* [PATCH v2] staging: octeon: remove multiple blank lines
@ 2016-09-13 21:20 Gargi Sharma
2016-09-14 5:36 ` [Outreachy kernel] " Julia Lawall
2016-09-14 5:39 ` Julia Lawall
0 siblings, 2 replies; 3+ messages in thread
From: Gargi Sharma @ 2016-09-13 21:20 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Gargi Sharma
Correcting the commit message. Fixes the checkpatch issue Please don't use multiple blank lines.
Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
drivers/staging/octeon/ethernet.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index 0bd5c18..ec8e424 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -686,7 +686,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
return -EINVAL;
}
-
cvm_oct_configure_common_hw();
cvmx_helper_initialize_packet_io_global();
@@ -929,7 +928,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
}
}
-
cvmx_pko_shutdown();
cvmx_ipd_free_ptr();
--
2.9.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: octeon: remove multiple blank lines
2016-09-13 21:20 [PATCH v2] staging: octeon: remove multiple blank lines Gargi Sharma
@ 2016-09-14 5:36 ` Julia Lawall
2016-09-14 5:39 ` Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2016-09-14 5:36 UTC (permalink / raw)
To: Gargi Sharma; +Cc: outreachy-kernel, gregkh
On Wed, 14 Sep 2016, Gargi Sharma wrote:
> Correcting the commit message. Fixes the checkpatch issue Please don't use multiple blank lines.
You made the wrong choice here. In the v2, there should be a commit
message as though no one ever saw the previous version. Then under the
--- you should say what has changed. It doesn't need to be very detailed.
It could just be "v2: fixed the commit message". Then one can check that
the current commit message is ok, and one knows that the patch code has
not changed.
julia
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
> drivers/staging/octeon/ethernet.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index 0bd5c18..ec8e424 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -686,7 +686,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> -
> cvm_oct_configure_common_hw();
>
> cvmx_helper_initialize_packet_io_global();
> @@ -929,7 +928,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
> }
> }
>
> -
> cvmx_pko_shutdown();
>
> cvmx_ipd_free_ptr();
> --
> 2.9.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160913212001.3945-1-gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: octeon: remove multiple blank lines
2016-09-13 21:20 [PATCH v2] staging: octeon: remove multiple blank lines Gargi Sharma
2016-09-14 5:36 ` [Outreachy kernel] " Julia Lawall
@ 2016-09-14 5:39 ` Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2016-09-14 5:39 UTC (permalink / raw)
To: Gargi Sharma; +Cc: outreachy-kernel, gregkh
On Wed, 14 Sep 2016, Gargi Sharma wrote:
> Correcting the commit message. Fixes the checkpatch issue Please don't use multiple blank lines.
The part above the --- and after the first diff is what will end up in
git, to be studied by other developers in the future. So that part should
always be put in a way that is most helpful for those people. Between the
--- and the first diff disappears. There you can put information that the
future doesn't need to know about.
julia
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
> drivers/staging/octeon/ethernet.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index 0bd5c18..ec8e424 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -686,7 +686,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> -
> cvm_oct_configure_common_hw();
>
> cvmx_helper_initialize_packet_io_global();
> @@ -929,7 +928,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
> }
> }
>
> -
> cvmx_pko_shutdown();
>
> cvmx_ipd_free_ptr();
> --
> 2.9.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160913212001.3945-1-gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-14 5:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-13 21:20 [PATCH v2] staging: octeon: remove multiple blank lines Gargi Sharma
2016-09-14 5:36 ` [Outreachy kernel] " Julia Lawall
2016-09-14 5:39 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.