* [PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings
@ 2016-09-14 14:34 Ronald Rojas
2016-09-14 14:36 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Ronald Rojas @ 2016-09-14 14:34 UTC (permalink / raw)
To: outreachy-kernel
This patch fixes several of the checkpatch.pl warnings
in the driver/staging/octeon/ethernet.c file:
CHECK: Please don't use multiple blank lines
89: FILE: drivers/staging/octeon/ethernet.c:89:
CHECK: Please don't use multiple blank lines
668: FILE: drivers/staging/octeon/ethernet.c:668:
CHECK: Please don't use multiple blank lines
881: FILE: drivers/staging/octeon/ethernet.c:881:
Signed-off-by: Ronald Rojas <ronladred@gmail.com>
---
drivers/staging/octeon/ethernet.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index e9cd5f2..79571d6 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -86,7 +86,6 @@ int rx_napi_weight = 32;
module_param(rx_napi_weight, int, 0444);
MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
-
/*
* cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
*
@@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
return -EINVAL;
}
-
cvm_oct_configure_common_hw();
cvmx_helper_initialize_packet_io_global();
@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
}
}
-
cvmx_pko_shutdown();
cvmx_ipd_free_ptr();
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings
2016-09-14 14:34 [PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings Ronald Rojas
@ 2016-09-14 14:36 ` Julia Lawall
2016-09-14 16:55 ` Ronald Rojas
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2016-09-14 14:36 UTC (permalink / raw)
To: Ronald Rojas; +Cc: outreachy-kernel
I guess there are some maintainers who should also receive this? Look for
the information about the get_maintainer command in the Submit a patch
section of the tutorial.
On Wed, 14 Sep 2016, Ronald Rojas wrote:
> This patch fixes several of the checkpatch.pl warnings
> in the driver/staging/octeon/ethernet.c file:
>
> CHECK: Please don't use multiple blank lines
> 89: FILE: drivers/staging/octeon/ethernet.c:89:
>
> CHECK: Please don't use multiple blank lines
> 668: FILE: drivers/staging/octeon/ethernet.c:668:
>
> CHECK: Please don't use multiple blank lines
> 881: FILE: drivers/staging/octeon/ethernet.c:881:
You don't need to list all of the errors explicitly. The important part
is just that checkpatch suggested removing the blank lines.
thanks,
julia
> Signed-off-by: Ronald Rojas <ronladred@gmail.com>
> ---
> drivers/staging/octeon/ethernet.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index e9cd5f2..79571d6 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -86,7 +86,6 @@ int rx_napi_weight = 32;
> module_param(rx_napi_weight, int, 0444);
> MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
>
> -
> /*
> * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
> *
> @@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> -
> cvm_oct_configure_common_hw();
>
> cvmx_helper_initialize_packet_io_global();
> @@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
> }
> }
>
> -
> cvmx_pko_shutdown();
>
> cvmx_ipd_free_ptr();
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914143430.GA22511%40fedora.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings
2016-09-14 14:36 ` [Outreachy kernel] " Julia Lawall
@ 2016-09-14 16:55 ` Ronald Rojas
2016-09-14 19:10 ` Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Ronald Rojas @ 2016-09-14 16:55 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel
Sorry for the mistake. When I resubmit the patch with the appropriate
maintainers CC'd should I append a v2 to the subject? Or use the same
name?
Ronald
Ronald Rojas
On Wed, Sep 14, 2016 at 10:36 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> I guess there are some maintainers who should also receive this? Look for
> the information about the get_maintainer command in the Submit a patch
> section of the tutorial.
>
> On Wed, 14 Sep 2016, Ronald Rojas wrote:
>
>> This patch fixes several of the checkpatch.pl warnings
>> in the driver/staging/octeon/ethernet.c file:
>>
>> CHECK: Please don't use multiple blank lines
>> 89: FILE: drivers/staging/octeon/ethernet.c:89:
>>
>> CHECK: Please don't use multiple blank lines
>> 668: FILE: drivers/staging/octeon/ethernet.c:668:
>>
>> CHECK: Please don't use multiple blank lines
>> 881: FILE: drivers/staging/octeon/ethernet.c:881:
>
> You don't need to list all of the errors explicitly. The important part
> is just that checkpatch suggested removing the blank lines.
>
> thanks,
> julia
>
>> Signed-off-by: Ronald Rojas <ronladred@gmail.com>
>> ---
>> drivers/staging/octeon/ethernet.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
>> index e9cd5f2..79571d6 100644
>> --- a/drivers/staging/octeon/ethernet.c
>> +++ b/drivers/staging/octeon/ethernet.c
>> @@ -86,7 +86,6 @@ int rx_napi_weight = 32;
>> module_param(rx_napi_weight, int, 0444);
>> MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
>>
>> -
>> /*
>> * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
>> *
>> @@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
>> return -EINVAL;
>> }
>>
>> -
>> cvm_oct_configure_common_hw();
>>
>> cvmx_helper_initialize_packet_io_global();
>> @@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
>> }
>> }
>>
>> -
>> cvmx_pko_shutdown();
>>
>> cvmx_ipd_free_ptr();
>> --
>> 2.7.4
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914143430.GA22511%40fedora.
>> For more options, visit https://groups.google.com/d/optout.
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings
2016-09-14 16:55 ` Ronald Rojas
@ 2016-09-14 19:10 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-09-14 19:10 UTC (permalink / raw)
To: Ronald Rojas; +Cc: outreachy-kernel
On Wed, 14 Sep 2016, Ronald Rojas wrote:
> Sorry for the mistake. When I resubmit the patch with the appropriate
> maintainers CC'd should I append a v2 to the subject? Or use the same
> name?
[PATCH v2]
It is always safe to up the version. Greg will only apply the highest
version number.
julia
>
> Ronald
> Ronald Rojas
>
>
> On Wed, Sep 14, 2016 at 10:36 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> > I guess there are some maintainers who should also receive this? Look for
> > the information about the get_maintainer command in the Submit a patch
> > section of the tutorial.
> >
> > On Wed, 14 Sep 2016, Ronald Rojas wrote:
> >
> >> This patch fixes several of the checkpatch.pl warnings
> >> in the driver/staging/octeon/ethernet.c file:
> >>
> >> CHECK: Please don't use multiple blank lines
> >> 89: FILE: drivers/staging/octeon/ethernet.c:89:
> >>
> >> CHECK: Please don't use multiple blank lines
> >> 668: FILE: drivers/staging/octeon/ethernet.c:668:
> >>
> >> CHECK: Please don't use multiple blank lines
> >> 881: FILE: drivers/staging/octeon/ethernet.c:881:
> >
> > You don't need to list all of the errors explicitly. The important part
> > is just that checkpatch suggested removing the blank lines.
> >
> > thanks,
> > julia
> >
> >> Signed-off-by: Ronald Rojas <ronladred@gmail.com>
> >> ---
> >> drivers/staging/octeon/ethernet.c | 3 ---
> >> 1 file changed, 3 deletions(-)
> >>
> >> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> >> index e9cd5f2..79571d6 100644
> >> --- a/drivers/staging/octeon/ethernet.c
> >> +++ b/drivers/staging/octeon/ethernet.c
> >> @@ -86,7 +86,6 @@ int rx_napi_weight = 32;
> >> module_param(rx_napi_weight, int, 0444);
> >> MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
> >>
> >> -
> >> /*
> >> * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
> >> *
> >> @@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
> >> return -EINVAL;
> >> }
> >>
> >> -
> >> cvm_oct_configure_common_hw();
> >>
> >> cvmx_helper_initialize_packet_io_global();
> >> @@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
> >> }
> >> }
> >>
> >> -
> >> cvmx_pko_shutdown();
> >>
> >> cvmx_ipd_free_ptr();
> >> --
> >> 2.7.4
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914143430.GA22511%40fedora.
> >> For more options, visit https://groups.google.com/d/optout.
> >>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAM_P2LKQuGM0D52ezJQdTovMFbWSzuJVnaFYmgQ7-jQ1HMf%2BCw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings
2016-09-15 12:29 ` [Outreachy kernel] " Arnd Bergmann
@ 2016-09-15 12:37 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-09-15 12:37 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: outreachy-kernel, Ronald Rojas
On Thu, 15 Sep 2016, Arnd Bergmann wrote:
> On Thursday, September 15, 2016 8:24:26 AM CEST Ronald Rojas wrote:
> > Fixes several of the checkpatch.pl warning
> > CHECK: Please don't use multiple blank lines
> >
> > Signed-off-by: Ronald Rojas <ronladred@gmail.com>
>
> In the subject line, please use "octeon" instead of "ethernet".
In general, you can't make up your own formula for creating the subject
line. You have to see what others have done, because different subsystems
use different strategies. To see what others have done, do:
git log --oneline filename.c
julia
>
> Did you build test this driver using a MIPS cross-compiler?
> I realize that it's just a whitespace change and it clearly
> won't break anything, but in general you should do some
> build testing before sending it out, and properly building
> this driver is a bit tricky.
>
> Arnd
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/15778561.A1ImvO0lIj%40wuerfel.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings
2016-09-15 12:24 Ronald Rojas
@ 2016-09-15 12:29 ` Arnd Bergmann
2016-09-15 12:37 ` Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2016-09-15 12:29 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Ronald Rojas
On Thursday, September 15, 2016 8:24:26 AM CEST Ronald Rojas wrote:
> Fixes several of the checkpatch.pl warning
> CHECK: Please don't use multiple blank lines
>
> Signed-off-by: Ronald Rojas <ronladred@gmail.com>
In the subject line, please use "octeon" instead of "ethernet".
Did you build test this driver using a MIPS cross-compiler?
I realize that it's just a whitespace change and it clearly
won't break anything, but in general you should do some
build testing before sending it out, and properly building
this driver is a bit tricky.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-15 12:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14 14:34 [PATCH] Staging: ethernet: Fixes checkpatch blank lines warnings Ronald Rojas
2016-09-14 14:36 ` [Outreachy kernel] " Julia Lawall
2016-09-14 16:55 ` Ronald Rojas
2016-09-14 19:10 ` Julia Lawall
2016-09-15 12:24 Ronald Rojas
2016-09-15 12:29 ` [Outreachy kernel] " Arnd Bergmann
2016-09-15 12:37 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.