All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
	Jiri Kosina <jikos@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: FRV-setup: Clarification for "source code clean-up"?
Date: Fri, 21 Oct 2016 13:03:20 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1610211300540.3212@hadrien> (raw)
In-Reply-To: <20161021102237.GK4418@mwanda>

Markus,

If you want to do something that might be useful, you could look into the
problem of missing checks for dma mapping failure.  There is  nice slide
presenatation about the issue:

http://www.slideshare.net/SamsungOSG/shuah-khan-dmamaperror

The slides are from a few years ago, but I did a small test recently, and
the problem seems to persist.  This needs to be done slowly and carefully,
because when there is a failure, you need to figure out what to do to
clean up and what value to return.  There is no point to clean up all of
the other checkpatch errors in the file at the same time.  Just stay on
the problem at hand.

julia

WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
	Jiri Kosina <jikos@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: FRV-setup: Clarification for "source code clean-up"?
Date: Fri, 21 Oct 2016 11:03:20 +0000	[thread overview]
Message-ID: <alpine.DEB.2.10.1610211300540.3212@hadrien> (raw)
In-Reply-To: <20161021102237.GK4418@mwanda>

Markus,

If you want to do something that might be useful, you could look into the
problem of missing checks for dma mapping failure.  There is  nice slide
presenatation about the issue:

http://www.slideshare.net/SamsungOSG/shuah-khan-dmamaperror

The slides are from a few years ago, but I did a small test recently, and
the problem seems to persist.  This needs to be done slowly and carefully,
because when there is a failure, you need to figure out what to do to
clean up and what value to return.  There is no point to clean up all of
the other checkpatch errors in the file at the same time.  Just stay on
the problem at hand.

julia

  parent reply	other threads:[~2016-10-21 11:03 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  5:03 [PATCH 0/6] FRV-setup: Fine-tuning for six function implementations SF Markus Elfring
2016-10-21  5:03 ` SF Markus Elfring
2016-10-21  5:05 ` [PATCH 1/6] FRV-setup: Use seq_puts() in show_cpuinfo() SF Markus Elfring
2016-10-21  5:05   ` SF Markus Elfring
2016-10-21  5:07 ` [PATCH 2/6] FRV-setup: Use seq_putc() " SF Markus Elfring
2016-10-21  5:07   ` SF Markus Elfring
2016-10-21  5:08 ` [PATCH 3/6] FRV-setup: Add some spaces for better code readability SF Markus Elfring
2016-10-21  5:08   ` SF Markus Elfring
2016-10-21  5:09 ` [PATCH 4/6] FRV-setup: Move "else" closer to a brace SF Markus Elfring
2016-10-21  5:09   ` SF Markus Elfring
2016-10-21  5:10 ` [PATCH 5/6] FRV-setup: Fix indentation in two lines SF Markus Elfring
2016-10-21  5:10   ` SF Markus Elfring
2016-10-21  7:24   ` Jiri Kosina
2016-10-21  7:24     ` Jiri Kosina
2016-10-21  7:51     ` Dan Carpenter
2016-10-21  7:51       ` Dan Carpenter
2016-10-21  9:11       ` FRV-setup: Clarification for "source code clean-up"? SF Markus Elfring
2016-10-21  9:11         ` SF Markus Elfring
2016-10-21  9:27         ` Dan Carpenter
2016-10-21  9:27           ` Dan Carpenter
2016-10-21  9:50           ` SF Markus Elfring
2016-10-21  9:50             ` SF Markus Elfring
2016-10-21 10:22             ` Dan Carpenter
2016-10-21 10:22               ` Dan Carpenter
2016-10-21 10:28               ` Geert Uytterhoeven
2016-10-21 10:28                 ` Geert Uytterhoeven
2016-10-21 11:03               ` Julia Lawall [this message]
2016-10-21 11:03                 ` Julia Lawall
2016-10-21 11:38                 ` Improving software around DMA API usage? SF Markus Elfring
2016-10-21 11:38                   ` SF Markus Elfring
2016-10-21  5:11 ` [PATCH 6/6] FRV-setup: Move statements for "case" to separate lines SF Markus Elfring
2016-10-21  5:11   ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1610211300540.3212@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=dan.carpenter@oracle.com \
    --cc=elfring@users.sourceforge.net \
    --cc=geert+renesas@glider.be \
    --cc=jikos@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.