* [PATCH] staging: wilc1000: Blank lines aren't necessary before a close brace '}' @ 2017-09-23 17:21 Keerthi Reddy 2017-09-23 17:28 ` [Outreachy kernel] " Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: Keerthi Reddy @ 2017-09-23 17:21 UTC (permalink / raw) To: outreachy-kernel Before closing the brace, the blank line is not needed. That blank line has not meaning here. so remove it. Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index 36dc2a0..e7882b2 100644 --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c @@ -1111,7 +1111,6 @@ static int del_key(struct wiphy *wiphy, struct net_device *netdev, g_key_gtk_params.key = NULL; kfree(g_key_gtk_params.seq); g_key_gtk_params.seq = NULL; - } if (key_index >= 0 && key_index <= 3) { -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: wilc1000: Blank lines aren't necessary before a close brace '}' 2017-09-23 17:21 [PATCH] staging: wilc1000: Blank lines aren't necessary before a close brace '}' Keerthi Reddy @ 2017-09-23 17:28 ` Julia Lawall 2017-09-23 17:49 ` Keerthi Reddy 0 siblings, 1 reply; 4+ messages in thread From: Julia Lawall @ 2017-09-23 17:28 UTC (permalink / raw) To: Keerthi Reddy; +Cc: outreachy-kernel On Sat, 23 Sep 2017, Keerthi Reddy wrote: > Before closing the brace, the blank line is not needed. That blank > line has not meaning here. so remove it. This is on the same file as your previous patch, so they have to be put in a series. julia > > Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com> > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > index 36dc2a0..e7882b2 100644 > --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > @@ -1111,7 +1111,6 @@ static int del_key(struct wiphy *wiphy, struct net_device *netdev, > g_key_gtk_params.key = NULL; > kfree(g_key_gtk_params.seq); > g_key_gtk_params.seq = NULL; > - > } > > if (key_index >= 0 && key_index <= 3) { > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170923172108.GA8880%40manoharreddy. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: wilc1000: Blank lines aren't necessary before a close brace '}' 2017-09-23 17:28 ` [Outreachy kernel] " Julia Lawall @ 2017-09-23 17:49 ` Keerthi Reddy 2017-09-23 18:10 ` Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: Keerthi Reddy @ 2017-09-23 17:49 UTC (permalink / raw) To: Julia Lawall; +Cc: outreachy-kernel Sat, Sep 23, 2017 at 07:28:36PM +0200, Julia Lawall wrote: > This is on the same file as your previous patch, so they have to be put in > a series. Can I update the patch previous patch into a patch set by combining this one the previous one? > > On Sat, 23 Sep 2017, Keerthi Reddy wrote: > > > Before closing the brace, the blank line is not needed. That blank > > line has not meaning here. so remove it. > > This is on the same file as your previous patch, so they have to be put in > a series. > > julia > > > > > Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com> > > --- > > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > > index 36dc2a0..e7882b2 100644 > > --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > > +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > > @@ -1111,7 +1111,6 @@ static int del_key(struct wiphy *wiphy, struct net_device *netdev, > > g_key_gtk_params.key = NULL; > > kfree(g_key_gtk_params.seq); > > g_key_gtk_params.seq = NULL; > > - > > } > > > > if (key_index >= 0 && key_index <= 3) { > > -- > > 2.7.4 > > > > -- > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170923172108.GA8880%40manoharreddy. > > For more options, visit https://groups.google.com/d/optout. > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: wilc1000: Blank lines aren't necessary before a close brace '}' 2017-09-23 17:49 ` Keerthi Reddy @ 2017-09-23 18:10 ` Julia Lawall 0 siblings, 0 replies; 4+ messages in thread From: Julia Lawall @ 2017-09-23 18:10 UTC (permalink / raw) To: Keerthi Reddy; +Cc: outreachy-kernel On Sat, 23 Sep 2017, Keerthi Reddy wrote: > Sat, Sep 23, 2017 at 07:28:36PM +0200, Julia Lawall wrote: > > > This is on the same file as your previous patch, so they have to be put in > > a series. > Can I update the patch previous patch into a patch set by combining this > one the previous one? I'm not sure to completely understand the question. Each patch should do only one thing. These are doing two different things, so they should not be in the same patch. You need to make a series, with one being 1/2 and the next being 2/2. How to do this is described in the tutorial. julia > > > > On Sat, 23 Sep 2017, Keerthi Reddy wrote: > > > > > Before closing the brace, the blank line is not needed. That blank > > > line has not meaning here. so remove it. > > > > This is on the same file as your previous patch, so they have to be put in > > a series. > > > > julia > > > > > > > > Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com> > > > --- > > > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > > > index 36dc2a0..e7882b2 100644 > > > --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > > > +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > > > @@ -1111,7 +1111,6 @@ static int del_key(struct wiphy *wiphy, struct net_device *netdev, > > > g_key_gtk_params.key = NULL; > > > kfree(g_key_gtk_params.seq); > > > g_key_gtk_params.seq = NULL; > > > - > > > } > > > > > > if (key_index >= 0 && key_index <= 3) { > > > -- > > > 2.7.4 > > > > > > -- > > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170923172108.GA8880%40manoharreddy. > > > For more options, visit https://groups.google.com/d/optout. > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-23 18:10 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-09-23 17:21 [PATCH] staging: wilc1000: Blank lines aren't necessary before a close brace '}' Keerthi Reddy 2017-09-23 17:28 ` [Outreachy kernel] " Julia Lawall 2017-09-23 17:49 ` Keerthi Reddy 2017-09-23 18:10 ` Julia Lawall
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.