* [PATCH] Coccinelle: make DEBUG_FILE option more useful
@ 2017-10-15 9:55 ` Julia Lawall
0 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2017-10-15 9:55 UTC (permalink / raw)
To: Luis R . Rodriguez, Masahiro Yamada
Cc: kernel-janitors, Gilles Muller, Nicolas Palix, Michal Marek,
cocci, linux-kernel
Make coccicheck checked for the existence of DEBUG_FILE on each semantic
patch, and bailed if it already existed. This meant that DEBUG_FILE was
useless for checking more than one semantic patch at a time. Now the check
is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
append to the file on each semantic patch. Furthermore, the spatch command
that is run for each semantic patch is also added to the DEBUG_FILE, to
make clear what each stdout trace corresponds to.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
scripts/coccicheck | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index ec487b8..3e21a1b 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -122,15 +122,8 @@ run_cmd_parmap() {
if [ $VERBOSE -ne 0 ] ; then
echo "Running ($NPROC in parallel): $@"
fi
- if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
- if [ -f $DEBUG_FILE ]; then
- echo "Debug file $DEBUG_FILE exists, bailing"
- exit
- fi
- else
- DEBUG_FILE="/dev/null"
- fi
- $@ 2>$DEBUG_FILE
+ echo $@ >>$DEBUG_FILE
+ $@ 2>>$DEBUG_FILE
if [[ $? -ne 0 ]]; then
echo "coccicheck failed"
exit $?
@@ -246,6 +239,16 @@ coccinelle () {
}
+if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
+ if [ -f $DEBUG_FILE ]; then
+ echo "Debug file $DEBUG_FILE exists, bailing"
+ exit
+ fi
+ touch $DEBUG_FILE
+else
+ DEBUG_FILE="/dev/null"
+fi
+
if [ "$COCCI" = "" ] ; then
for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
coccinelle $f
^ permalink raw reply related [flat|nested] 15+ messages in thread* [Cocci] [PATCH] Coccinelle: make DEBUG_FILE option more useful
@ 2017-10-15 9:55 ` Julia Lawall
0 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2017-10-15 9:55 UTC (permalink / raw)
To: cocci
Make coccicheck checked for the existence of DEBUG_FILE on each semantic
patch, and bailed if it already existed. This meant that DEBUG_FILE was
useless for checking more than one semantic patch at a time. Now the check
is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
append to the file on each semantic patch. Furthermore, the spatch command
that is run for each semantic patch is also added to the DEBUG_FILE, to
make clear what each stdout trace corresponds to.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
scripts/coccicheck | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index ec487b8..3e21a1b 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -122,15 +122,8 @@ run_cmd_parmap() {
if [ $VERBOSE -ne 0 ] ; then
echo "Running ($NPROC in parallel): $@"
fi
- if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
- if [ -f $DEBUG_FILE ]; then
- echo "Debug file $DEBUG_FILE exists, bailing"
- exit
- fi
- else
- DEBUG_FILE="/dev/null"
- fi
- $@ 2>$DEBUG_FILE
+ echo $@ >>$DEBUG_FILE
+ $@ 2>>$DEBUG_FILE
if [[ $? -ne 0 ]]; then
echo "coccicheck failed"
exit $?
@@ -246,6 +239,16 @@ coccinelle () {
}
+if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
+ if [ -f $DEBUG_FILE ]; then
+ echo "Debug file $DEBUG_FILE exists, bailing"
+ exit
+ fi
+ touch $DEBUG_FILE
+else
+ DEBUG_FILE="/dev/null"
+fi
+
if [ "$COCCI" = "" ] ; then
for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
coccinelle $f
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH] Coccinelle: make DEBUG_FILE option more useful
@ 2017-10-15 9:55 ` Julia Lawall
0 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2017-10-15 9:55 UTC (permalink / raw)
To: cocci
Make coccicheck checked for the existence of DEBUG_FILE on each semantic
patch, and bailed if it already existed. This meant that DEBUG_FILE was
useless for checking more than one semantic patch at a time. Now the check
is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
append to the file on each semantic patch. Furthermore, the spatch command
that is run for each semantic patch is also added to the DEBUG_FILE, to
make clear what each stdout trace corresponds to.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
scripts/coccicheck | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index ec487b8..3e21a1b 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -122,15 +122,8 @@ run_cmd_parmap() {
if [ $VERBOSE -ne 0 ] ; then
echo "Running ($NPROC in parallel): $@"
fi
- if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
- if [ -f $DEBUG_FILE ]; then
- echo "Debug file $DEBUG_FILE exists, bailing"
- exit
- fi
- else
- DEBUG_FILE="/dev/null"
- fi
- $@ 2>$DEBUG_FILE
+ echo $@ >>$DEBUG_FILE
+ $@ 2>>$DEBUG_FILE
if [[ $? -ne 0 ]]; then
echo "coccicheck failed"
exit $?
@@ -246,6 +239,16 @@ coccinelle () {
}
+if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
+ if [ -f $DEBUG_FILE ]; then
+ echo "Debug file $DEBUG_FILE exists, bailing"
+ exit
+ fi
+ touch $DEBUG_FILE
+else
+ DEBUG_FILE="/dev/null"
+fi
+
if [ "$COCCI" = "" ] ; then
for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
coccinelle $f
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH] Coccinelle: make DEBUG_FILE option more useful
2017-10-15 9:55 ` Julia Lawall
(?)
@ 2017-10-26 1:49 ` Masahiro Yamada
-1 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2017-10-26 1:49 UTC (permalink / raw)
To: Julia Lawall
Cc: Luis R . Rodriguez, kernel-janitors, Gilles Muller,
Nicolas Palix, Michal Marek, cocci, Linux Kernel Mailing List
Hi Julia,
2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
> Make coccicheck checked for the existence of DEBUG_FILE on each semantic
> patch, and bailed if it already existed. This meant that DEBUG_FILE was
> useless for checking more than one semantic patch at a time. Now the check
> is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
> append to the file on each semantic patch. Furthermore, the spatch command
> that is run for each semantic patch is also added to the DEBUG_FILE, to
> make clear what each stdout trace corresponds to.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
I think this is a good improvement,
and looks almost good to me.
Just one nit.
>
> }
>
> +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> + if [ -f $DEBUG_FILE ]; then
> + echo "Debug file $DEBUG_FILE exists, bailing"
> + exit
> + fi
> + touch $DEBUG_FILE
I think this "touch" is redundant.
If the DEBUG_FILE does not exist, 2>> will automatically create it.
> +else
> + DEBUG_FILE="/dev/null"
> +fi
> +
> if [ "$COCCI" = "" ] ; then
> for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> coccinelle $f
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Cocci] [PATCH] Coccinelle: make DEBUG_FILE option more useful
@ 2017-10-26 1:49 ` Masahiro Yamada
0 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2017-10-26 1:49 UTC (permalink / raw)
To: cocci
Hi Julia,
2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
> Make coccicheck checked for the existence of DEBUG_FILE on each semantic
> patch, and bailed if it already existed. This meant that DEBUG_FILE was
> useless for checking more than one semantic patch at a time. Now the check
> is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
> append to the file on each semantic patch. Furthermore, the spatch command
> that is run for each semantic patch is also added to the DEBUG_FILE, to
> make clear what each stdout trace corresponds to.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
I think this is a good improvement,
and looks almost good to me.
Just one nit.
>
> }
>
> +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> + if [ -f $DEBUG_FILE ]; then
> + echo "Debug file $DEBUG_FILE exists, bailing"
> + exit
> + fi
> + touch $DEBUG_FILE
I think this "touch" is redundant.
If the DEBUG_FILE does not exist, 2>> will automatically create it.
> +else
> + DEBUG_FILE="/dev/null"
> +fi
> +
> if [ "$COCCI" = "" ] ; then
> for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> coccinelle $f
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Coccinelle: make DEBUG_FILE option more useful
@ 2017-10-26 1:49 ` Masahiro Yamada
0 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2017-10-26 1:49 UTC (permalink / raw)
To: cocci
Hi Julia,
2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
> Make coccicheck checked for the existence of DEBUG_FILE on each semantic
> patch, and bailed if it already existed. This meant that DEBUG_FILE was
> useless for checking more than one semantic patch at a time. Now the check
> is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
> append to the file on each semantic patch. Furthermore, the spatch command
> that is run for each semantic patch is also added to the DEBUG_FILE, to
> make clear what each stdout trace corresponds to.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
I think this is a good improvement,
and looks almost good to me.
Just one nit.
>
> }
>
> +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> + if [ -f $DEBUG_FILE ]; then
> + echo "Debug file $DEBUG_FILE exists, bailing"
> + exit
> + fi
> + touch $DEBUG_FILE
I think this "touch" is redundant.
If the DEBUG_FILE does not exist, 2>> will automatically create it.
> +else
> + DEBUG_FILE="/dev/null"
> +fi
> +
> if [ "$COCCI" = "" ] ; then
> for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> coccinelle $f
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Coccinelle: make DEBUG_FILE option more useful
2017-10-26 1:49 ` Masahiro Yamada
(?)
@ 2017-10-26 4:02 ` Julia Lawall
-1 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2017-10-26 4:02 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Luis R . Rodriguez, kernel-janitors, Gilles Muller,
Nicolas Palix, Michal Marek, cocci, Linux Kernel Mailing List
On Thu, 26 Oct 2017, Masahiro Yamada wrote:
> Hi Julia,
>
>
> 2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
> > Make coccicheck checked for the existence of DEBUG_FILE on each semantic
> > patch, and bailed if it already existed. This meant that DEBUG_FILE was
> > useless for checking more than one semantic patch at a time. Now the check
> > is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
> > append to the file on each semantic patch. Furthermore, the spatch command
> > that is run for each semantic patch is also added to the DEBUG_FILE, to
> > make clear what each stdout trace corresponds to.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
>
> I think this is a good improvement,
> and looks almost good to me.
>
> Just one nit.
>
>
> >
> > }
> >
> > +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> > + if [ -f $DEBUG_FILE ]; then
> > + echo "Debug file $DEBUG_FILE exists, bailing"
> > + exit
> > + fi
> > + touch $DEBUG_FILE
>
> I think this "touch" is redundant.
>
> If the DEBUG_FILE does not exist, 2>> will automatically create it.
Thanks very much for the feedback. I will resubmit.
julia
>
>
>
>
> > +else
> > + DEBUG_FILE="/dev/null"
> > +fi
> > +
> > if [ "$COCCI" = "" ] ; then
> > for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> > coccinelle $f
> >
>
>
>
> --
> Best Regards
> Masahiro Yamada
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Cocci] [PATCH] Coccinelle: make DEBUG_FILE option more useful
@ 2017-10-26 4:02 ` Julia Lawall
0 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2017-10-26 4:02 UTC (permalink / raw)
To: cocci
On Thu, 26 Oct 2017, Masahiro Yamada wrote:
> Hi Julia,
>
>
> 2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
> > Make coccicheck checked for the existence of DEBUG_FILE on each semantic
> > patch, and bailed if it already existed. This meant that DEBUG_FILE was
> > useless for checking more than one semantic patch at a time. Now the check
> > is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
> > append to the file on each semantic patch. Furthermore, the spatch command
> > that is run for each semantic patch is also added to the DEBUG_FILE, to
> > make clear what each stdout trace corresponds to.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
>
> I think this is a good improvement,
> and looks almost good to me.
>
> Just one nit.
>
>
> >
> > }
> >
> > +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> > + if [ -f $DEBUG_FILE ]; then
> > + echo "Debug file $DEBUG_FILE exists, bailing"
> > + exit
> > + fi
> > + touch $DEBUG_FILE
>
> I think this "touch" is redundant.
>
> If the DEBUG_FILE does not exist, 2>> will automatically create it.
Thanks very much for the feedback. I will resubmit.
julia
>
>
>
>
> > +else
> > + DEBUG_FILE="/dev/null"
> > +fi
> > +
> > if [ "$COCCI" = "" ] ; then
> > for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> > coccinelle $f
> >
>
>
>
> --
> Best Regards
> Masahiro Yamada
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Coccinelle: make DEBUG_FILE option more useful
@ 2017-10-26 4:02 ` Julia Lawall
0 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2017-10-26 4:02 UTC (permalink / raw)
To: cocci
On Thu, 26 Oct 2017, Masahiro Yamada wrote:
> Hi Julia,
>
>
> 2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
> > Make coccicheck checked for the existence of DEBUG_FILE on each semantic
> > patch, and bailed if it already existed. This meant that DEBUG_FILE was
> > useless for checking more than one semantic patch at a time. Now the check
> > is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
> > append to the file on each semantic patch. Furthermore, the spatch command
> > that is run for each semantic patch is also added to the DEBUG_FILE, to
> > make clear what each stdout trace corresponds to.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
>
> I think this is a good improvement,
> and looks almost good to me.
>
> Just one nit.
>
>
> >
> > }
> >
> > +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> > + if [ -f $DEBUG_FILE ]; then
> > + echo "Debug file $DEBUG_FILE exists, bailing"
> > + exit
> > + fi
> > + touch $DEBUG_FILE
>
> I think this "touch" is redundant.
>
> If the DEBUG_FILE does not exist, 2>> will automatically create it.
Thanks very much for the feedback. I will resubmit.
julia
>
>
>
>
> > +else
> > + DEBUG_FILE="/dev/null"
> > +fi
> > +
> > if [ "$COCCI" = "" ] ; then
> > for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> > coccinelle $f
> >
>
>
>
> --
> Best Regards
> Masahiro Yamada
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Coccinelle: make DEBUG_FILE option more useful
2017-10-26 4:02 ` Julia Lawall
(?)
@ 2017-11-07 0:24 ` Masahiro Yamada
-1 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2017-11-07 0:24 UTC (permalink / raw)
To: Julia Lawall
Cc: Luis R . Rodriguez, kernel-janitors, Gilles Muller,
Nicolas Palix, Michal Marek, cocci, Linux Kernel Mailing List
2017-10-26 13:02 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>:
>
>
> On Thu, 26 Oct 2017, Masahiro Yamada wrote:
>
>> Hi Julia,
>>
>>
>> 2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
>> > Make coccicheck checked for the existence of DEBUG_FILE on each semantic
>> > patch, and bailed if it already existed. This meant that DEBUG_FILE was
>> > useless for checking more than one semantic patch at a time. Now the check
>> > is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
>> > append to the file on each semantic patch. Furthermore, the spatch command
>> > that is run for each semantic patch is also added to the DEBUG_FILE, to
>> > make clear what each stdout trace corresponds to.
>> >
>> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>> >
>>
>> I think this is a good improvement,
>> and looks almost good to me.
>>
>> Just one nit.
>>
>>
>> >
>> > }
>> >
>> > +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
>> > + if [ -f $DEBUG_FILE ]; then
>> > + echo "Debug file $DEBUG_FILE exists, bailing"
>> > + exit
>> > + fi
>> > + touch $DEBUG_FILE
>>
>> I think this "touch" is redundant.
>>
>> If the DEBUG_FILE does not exist, 2>> will automatically create it.
>
> Thanks very much for the feedback. I will resubmit.
>
> julia
>
>
Remove the redundant "touch"
and applied to linux-kbuild/misc.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Cocci] [PATCH] Coccinelle: make DEBUG_FILE option more useful
@ 2017-11-07 0:24 ` Masahiro Yamada
0 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2017-11-07 0:24 UTC (permalink / raw)
To: cocci
2017-10-26 13:02 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>:
>
>
> On Thu, 26 Oct 2017, Masahiro Yamada wrote:
>
>> Hi Julia,
>>
>>
>> 2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
>> > Make coccicheck checked for the existence of DEBUG_FILE on each semantic
>> > patch, and bailed if it already existed. This meant that DEBUG_FILE was
>> > useless for checking more than one semantic patch at a time. Now the check
>> > is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
>> > append to the file on each semantic patch. Furthermore, the spatch command
>> > that is run for each semantic patch is also added to the DEBUG_FILE, to
>> > make clear what each stdout trace corresponds to.
>> >
>> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>> >
>>
>> I think this is a good improvement,
>> and looks almost good to me.
>>
>> Just one nit.
>>
>>
>> >
>> > }
>> >
>> > +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
>> > + if [ -f $DEBUG_FILE ]; then
>> > + echo "Debug file $DEBUG_FILE exists, bailing"
>> > + exit
>> > + fi
>> > + touch $DEBUG_FILE
>>
>> I think this "touch" is redundant.
>>
>> If the DEBUG_FILE does not exist, 2>> will automatically create it.
>
> Thanks very much for the feedback. I will resubmit.
>
> julia
>
>
Remove the redundant "touch"
and applied to linux-kbuild/misc.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Coccinelle: make DEBUG_FILE option more useful
@ 2017-11-07 0:24 ` Masahiro Yamada
0 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2017-11-07 0:24 UTC (permalink / raw)
To: cocci
2017-10-26 13:02 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>:
>
>
> On Thu, 26 Oct 2017, Masahiro Yamada wrote:
>
>> Hi Julia,
>>
>>
>> 2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
>> > Make coccicheck checked for the existence of DEBUG_FILE on each semantic
>> > patch, and bailed if it already existed. This meant that DEBUG_FILE was
>> > useless for checking more than one semantic patch at a time. Now the check
>> > is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
>> > append to the file on each semantic patch. Furthermore, the spatch command
>> > that is run for each semantic patch is also added to the DEBUG_FILE, to
>> > make clear what each stdout trace corresponds to.
>> >
>> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>> >
>>
>> I think this is a good improvement,
>> and looks almost good to me.
>>
>> Just one nit.
>>
>>
>> >
>> > }
>> >
>> > +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
>> > + if [ -f $DEBUG_FILE ]; then
>> > + echo "Debug file $DEBUG_FILE exists, bailing"
>> > + exit
>> > + fi
>> > + touch $DEBUG_FILE
>>
>> I think this "touch" is redundant.
>>
>> If the DEBUG_FILE does not exist, 2>> will automatically create it.
>
> Thanks very much for the feedback. I will resubmit.
>
> julia
>
>
Remove the redundant "touch"
and applied to linux-kbuild/misc.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Coccinelle: make DEBUG_FILE option more useful
2017-11-07 0:24 ` Masahiro Yamada
(?)
@ 2017-11-08 13:02 ` Julia Lawall
-1 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2017-11-08 13:02 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Julia Lawall, Luis R . Rodriguez, kernel-janitors, Gilles Muller,
Nicolas Palix, Michal Marek, cocci, Linux Kernel Mailing List
On Tue, 7 Nov 2017, Masahiro Yamada wrote:
> 2017-10-26 13:02 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>:
> >
> >
> > On Thu, 26 Oct 2017, Masahiro Yamada wrote:
> >
> >> Hi Julia,
> >>
> >>
> >> 2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
> >> > Make coccicheck checked for the existence of DEBUG_FILE on each semantic
> >> > patch, and bailed if it already existed. This meant that DEBUG_FILE was
> >> > useless for checking more than one semantic patch at a time. Now the check
> >> > is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
> >> > append to the file on each semantic patch. Furthermore, the spatch command
> >> > that is run for each semantic patch is also added to the DEBUG_FILE, to
> >> > make clear what each stdout trace corresponds to.
> >> >
> >> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >> >
> >>
> >> I think this is a good improvement,
> >> and looks almost good to me.
> >>
> >> Just one nit.
> >>
> >>
> >> >
> >> > }
> >> >
> >> > +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> >> > + if [ -f $DEBUG_FILE ]; then
> >> > + echo "Debug file $DEBUG_FILE exists, bailing"
> >> > + exit
> >> > + fi
> >> > + touch $DEBUG_FILE
> >>
> >> I think this "touch" is redundant.
> >>
> >> If the DEBUG_FILE does not exist, 2>> will automatically create it.
> >
> > Thanks very much for the feedback. I will resubmit.
> >
> > julia
> >
> >
>
> Remove the redundant "touch"
> and applied to linux-kbuild/misc.
Thanks!
julia
>
>
>
> --
> Best Regards
> Masahiro Yamada
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Cocci] [PATCH] Coccinelle: make DEBUG_FILE option more useful
@ 2017-11-08 13:02 ` Julia Lawall
0 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2017-11-08 13:02 UTC (permalink / raw)
To: cocci
On Tue, 7 Nov 2017, Masahiro Yamada wrote:
> 2017-10-26 13:02 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>:
> >
> >
> > On Thu, 26 Oct 2017, Masahiro Yamada wrote:
> >
> >> Hi Julia,
> >>
> >>
> >> 2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
> >> > Make coccicheck checked for the existence of DEBUG_FILE on each semantic
> >> > patch, and bailed if it already existed. This meant that DEBUG_FILE was
> >> > useless for checking more than one semantic patch at a time. Now the check
> >> > is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
> >> > append to the file on each semantic patch. Furthermore, the spatch command
> >> > that is run for each semantic patch is also added to the DEBUG_FILE, to
> >> > make clear what each stdout trace corresponds to.
> >> >
> >> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >> >
> >>
> >> I think this is a good improvement,
> >> and looks almost good to me.
> >>
> >> Just one nit.
> >>
> >>
> >> >
> >> > }
> >> >
> >> > +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> >> > + if [ -f $DEBUG_FILE ]; then
> >> > + echo "Debug file $DEBUG_FILE exists, bailing"
> >> > + exit
> >> > + fi
> >> > + touch $DEBUG_FILE
> >>
> >> I think this "touch" is redundant.
> >>
> >> If the DEBUG_FILE does not exist, 2>> will automatically create it.
> >
> > Thanks very much for the feedback. I will resubmit.
> >
> > julia
> >
> >
>
> Remove the redundant "touch"
> and applied to linux-kbuild/misc.
Thanks!
julia
>
>
>
> --
> Best Regards
> Masahiro Yamada
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Coccinelle: make DEBUG_FILE option more useful
@ 2017-11-08 13:02 ` Julia Lawall
0 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2017-11-08 13:02 UTC (permalink / raw)
To: cocci
On Tue, 7 Nov 2017, Masahiro Yamada wrote:
> 2017-10-26 13:02 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>:
> >
> >
> > On Thu, 26 Oct 2017, Masahiro Yamada wrote:
> >
> >> Hi Julia,
> >>
> >>
> >> 2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
> >> > Make coccicheck checked for the existence of DEBUG_FILE on each semantic
> >> > patch, and bailed if it already existed. This meant that DEBUG_FILE was
> >> > useless for checking more than one semantic patch at a time. Now the check
> >> > is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
> >> > append to the file on each semantic patch. Furthermore, the spatch command
> >> > that is run for each semantic patch is also added to the DEBUG_FILE, to
> >> > make clear what each stdout trace corresponds to.
> >> >
> >> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >> >
> >>
> >> I think this is a good improvement,
> >> and looks almost good to me.
> >>
> >> Just one nit.
> >>
> >>
> >> >
> >> > }
> >> >
> >> > +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> >> > + if [ -f $DEBUG_FILE ]; then
> >> > + echo "Debug file $DEBUG_FILE exists, bailing"
> >> > + exit
> >> > + fi
> >> > + touch $DEBUG_FILE
> >>
> >> I think this "touch" is redundant.
> >>
> >> If the DEBUG_FILE does not exist, 2>> will automatically create it.
> >
> > Thanks very much for the feedback. I will resubmit.
> >
> > julia
> >
> >
>
> Remove the redundant "touch"
> and applied to linux-kbuild/misc.
Thanks!
julia
>
>
>
> --
> Best Regards
> Masahiro Yamada
>
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2017-11-08 13:02 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-15 9:55 [PATCH] Coccinelle: make DEBUG_FILE option more useful Julia Lawall
2017-10-15 9:55 ` [Cocci] " Julia Lawall
2017-10-15 9:55 ` Julia Lawall
2017-10-26 1:49 ` Masahiro Yamada
2017-10-26 1:49 ` [Cocci] " Masahiro Yamada
2017-10-26 1:49 ` Masahiro Yamada
2017-10-26 4:02 ` Julia Lawall
2017-10-26 4:02 ` [Cocci] " Julia Lawall
2017-10-26 4:02 ` Julia Lawall
2017-11-07 0:24 ` Masahiro Yamada
2017-11-07 0:24 ` [Cocci] " Masahiro Yamada
2017-11-07 0:24 ` Masahiro Yamada
2017-11-08 13:02 ` Julia Lawall
2017-11-08 13:02 ` [Cocci] " Julia Lawall
2017-11-08 13:02 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.