All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kurz <akurz@blala.de>
To: David Miller <davem@davemloft.net>
Cc: marc.zyngier@arm.com, afd@ti.com, linux-usb@vger.kernel.org,
	netdev@vger.kernel.org, freddy@asix.com.tw
Subject: Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code
Date: Mon, 2 Apr 2018 15:21:08 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.20.1804021513340.14675@blala.de> (raw)
In-Reply-To: <20180402.101410.2105582698262762699.davem@davemloft.net>

Hi Marc, David,
with the v2 patch ("net: usb: asix88179_178a: de-duplicate code")
I made an embarrasly stupid mistake of removing the wrong function.
The v2 patch accidentially changed ax88179_link_reset() instead of 
ax88179_reset(). Hunk 6 of v2 ("net: usb: asix88179_178a: de-duplicate 
code") is just utterly wrong.

ax88179_bind() and ax88179_reset() were the correct targets to be 
de-duplicated, as done in the v3 patch.

Sorry for this, Alexander

On Mon, 2 Apr 2018, David Miller wrote:

> From: Marc Zyngier <marc.zyngier@arm.com>
> Date: Mon, 02 Apr 2018 10:45:40 +0100
> 
> > What has changed between this patch and the previous one? Having a bit
> > of a change-log would certainly help. Also, I would have appreciated a
> > reply to the questions I had on v2 before you posted a third version.
> 
> Agreed, and I'm not applying these patches until this is sorted out
> and explained properly.
> 

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Kurz <akurz@blala.de>
To: David Miller <davem@davemloft.net>
Cc: marc.zyngier@arm.com, afd@ti.com, linux-usb@vger.kernel.org,
	netdev@vger.kernel.org, freddy@asix.com.tw
Subject: [v3,2/2] net: usb: asix88179_178a: de-duplicate code
Date: Mon, 2 Apr 2018 15:21:08 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.20.1804021513340.14675@blala.de> (raw)

Hi Marc, David,
with the v2 patch ("net: usb: asix88179_178a: de-duplicate code")
I made an embarrasly stupid mistake of removing the wrong function.
The v2 patch accidentially changed ax88179_link_reset() instead of 
ax88179_reset(). Hunk 6 of v2 ("net: usb: asix88179_178a: de-duplicate 
code") is just utterly wrong.

ax88179_bind() and ax88179_reset() were the correct targets to be 
de-duplicated, as done in the v3 patch.

Sorry for this, Alexander

On Mon, 2 Apr 2018, David Miller wrote:

> From: Marc Zyngier <marc.zyngier@arm.com>
> Date: Mon, 02 Apr 2018 10:45:40 +0100
> 
> > What has changed between this patch and the previous one? Having a bit
> > of a change-log would certainly help. Also, I would have appreciated a
> > reply to the questions I had on v2 before you posted a third version.
> 
> Agreed, and I'm not applying these patches until this is sorted out
> and explained properly.
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-04-02 15:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-02  7:43 [PATCH v3 1/2] net: usb: asix88179_178a: set permanent address once only Alexander Kurz
2018-04-02  7:43 ` [v3,1/2] " Alexander Kurz
2018-04-02  7:43 ` [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code Alexander Kurz
2018-04-02  7:43   ` [v3,2/2] " Alexander Kurz
2018-04-02  9:45   ` [PATCH v3 2/2] " Marc Zyngier
2018-04-02  9:45     ` [v3,2/2] " Marc Zyngier
2018-04-02 14:14     ` [PATCH v3 2/2] " David Miller
2018-04-02 14:14       ` [v3,2/2] " David Miller
2018-04-02 15:21       ` Alexander Kurz [this message]
2018-04-02 15:21         ` Alexander Kurz
2018-04-02 19:06         ` [PATCH v3 2/2] " Marc Zyngier
2018-04-02 19:06           ` [v3,2/2] " Marc Zyngier
2018-04-02 20:25   ` [PATCH v3 2/2] " Marc Zyngier
2018-04-02 20:25     ` [v3,2/2] " Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1804021513340.14675@blala.de \
    --to=akurz@blala.de \
    --cc=afd@ti.com \
    --cc=davem@davemloft.net \
    --cc=freddy@asix.com.tw \
    --cc=linux-usb@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.