Re: [PATCH 3/3] add--interactive: use add-interactive--helper for status_cmd

From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Daniel Ferreira <bnmvco@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 3/3] add--interactive: use add-interactive--helper for status_cmd
Date: Sat, 6 May 2017 00:32:00 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1.1705060031450.146734@virtualbox> (raw)
In-Reply-To: <1494009820-2090-4-git-send-email-bnmvco@gmail.com>

Hi Daniel,

On Fri, 5 May 2017, Daniel Ferreira wrote:

> Call the newly introduced git-add-interactive--helper builtin on
> status_cmd() instead of relying on git-add--interactive's Perl
> functions to build print the numstat.
> 
> Signed-off-by: Daniel Ferreira <bnmvco@gmail.com>
> ---
>  git-add--interactive.perl | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/git-add--interactive.perl b/git-add--interactive.perl
> index 709a5f6..8617462 100755
> --- a/git-add--interactive.perl
> +++ b/git-add--interactive.perl
> @@ -632,9 +632,7 @@ EOF
>  }
>  
>  sub status_cmd {
> -	list_and_choose({ LIST_ONLY => 1, HEADER => $status_head },
> -			list_modified());
> -	print "\n";
> +	system(qw(git add-interactive--helper --status));
>  }
>  
>  sub say_n_paths {

Obviously good!

Thanks,
Johannes