[Outreachy Kernel][PATCH v5] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Outreachy Kernel][PATCH v5] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Bhanusree Pola]

Adjust all lines exceeding 75 chars per line to fix checkpatch warning. 

Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---

changes in v5:
-Fixed Change log
-Change in subject line.Do not send as 'Re:'

changes in v4:
-Remove Whitespace in comment section of module_comedi_pci_driver()
 to fix checkpatch Error.

changes in v3:
-Comment section of module_pci_driver() exceeds 75 characters.
 Adjust the chars to 75 per line
-Modified log message.
-Added change log.

changes in v2:
-comedi_pci_auto_config() function prototype is exceeds
 75 characters per line. Adjust to 75 chars to improve
 readability and also adjust the arguments to match open
 parantheses.
-Comment section of module_comedi_pci_driver() exceeds 75
 characters. Modified contents to adjust 75 chars per line.

 drivers/staging/comedi/comedi_pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
index 1cc5436cb415..7291d3c0b7dc 100644
--- a/drivers/staging/comedi/comedi_pci.h
+++ b/drivers/staging/comedi/comedi_pci.h
@@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
 				  struct pci_driver *pci_driver);
 
 /**
- * module_comedi_pci_driver()-Helper macro for registering a comedi PCI 
+ * module_comedi_pci_driver()-Helper macro for registering a comedi PCI
  * driver
  * @__comedi_driver: comedi_driver struct
  * @__pci_driver: pci_driver struct
-- 
2.17.1

Re: [Outreachy kernel] [Outreachy Kernel][PATCH v5] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Julia Lawall]

On Sun, 7 Oct 2018, Bhanusree Pola wrote:

> Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
>
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
>
> changes in v5:
> -Fixed Change log
> -Change in subject line.Do not send as 'Re:'

It doesn't matter here, because this text will go away, but please get in
the habit of putting at least one space after punctuation.  That is:

Change in subject line. Do not send as 'Re:'

Then things don't run together, and it is easier to read.

julia

>
> changes in v4:
> -Remove Whitespace in comment section of module_comedi_pci_driver()
>  to fix checkpatch Error.
>
> changes in v3:
> -Comment section of module_pci_driver() exceeds 75 characters.
>  Adjust the chars to 75 per line
> -Modified log message.
> -Added change log.
>
> changes in v2:
> -comedi_pci_auto_config() function prototype is exceeds
>  75 characters per line. Adjust to 75 chars to improve
>  readability and also adjust the arguments to match open
>  parantheses.
> -Comment section of module_comedi_pci_driver() exceeds 75
>  characters. Modified contents to adjust 75 chars per line.
>
>  drivers/staging/comedi/comedi_pci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
> index 1cc5436cb415..7291d3c0b7dc 100644
> --- a/drivers/staging/comedi/comedi_pci.h
> +++ b/drivers/staging/comedi/comedi_pci.h
> @@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
>  				  struct pci_driver *pci_driver);
>
>  /**
> - * module_comedi_pci_driver()-Helper macro for registering a comedi PCI
> + * module_comedi_pci_driver()-Helper macro for registering a comedi PCI
>   * driver
>   * @__comedi_driver: comedi_driver struct
>   * @__pci_driver: pci_driver struct
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181006190246.GA14037%40veda-VGN-CS3AGH-R.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [Outreachy Kernel][PATCH v5] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Bhanusree]

On Sunday 07 October 2018 12:36 AM, Julia Lawall wrote:
>
> On Sun, 7 Oct 2018, Bhanusree Pola wrote:
>
>> Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
>>
>> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
>> ---
>>
>> changes in v5:
>> -Fixed Change log
>> -Change in subject line.Do not send as 'Re:'
> It doesn't matter here, because this text will go away, but please get in
> the habit of putting at least one space after punctuation.  That is:
>
> Change in subject line. Do not send as 'Re:'
>
> Then things don't run together, and it is easier to read.
It is taking time for me to understand. Sometimes I'm doing it in haste. 
Thank you for making me understand.

Re: [Outreachy kernel] [Outreachy Kernel][PATCH v5] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Himanshu Jha]

On Sun, Oct 07, 2018 at 12:32:47AM +0530, Bhanusree Pola wrote:
> Adjust all lines exceeding 75 chars per line to fix checkpatch warning. 
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
> 
> changes in v5:
> -Fixed Change log
> -Change in subject line.Do not send as 'Re:'
> 
> changes in v4:
> -Remove Whitespace in comment section of module_comedi_pci_driver()
>  to fix checkpatch Error.
> 
> changes in v3:
> -Comment section of module_pci_driver() exceeds 75 characters.
>  Adjust the chars to 75 per line
> -Modified log message.
> -Added change log.
> 
> changes in v2:
> -comedi_pci_auto_config() function prototype is exceeds
>  75 characters per line. Adjust to 75 chars to improve
>  readability and also adjust the arguments to match open
>  parantheses.
> -Comment section of module_comedi_pci_driver() exceeds 75
>  characters. Modified contents to adjust 75 chars per line.
> 
>  drivers/staging/comedi/comedi_pci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
> index 1cc5436cb415..7291d3c0b7dc 100644
> --- a/drivers/staging/comedi/comedi_pci.h
> +++ b/drivers/staging/comedi/comedi_pci.h
> @@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
>  				  struct pci_driver *pci_driver);
>  
>  /**
> - * module_comedi_pci_driver()-Helper macro for registering a comedi PCI 
> + * module_comedi_pci_driver()-Helper macro for registering a comedi PCI

The original line is:

* module_comedi_pci_driver() - Helper macro for registering a comedi PCI driver

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/comedi/comedi_pci.h#n44

The patch looks dubious to me.

Always base your work on latest -next tree.
https://www.kernel.org/doc/man-pages/linux-next.html

-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology

Re: [Outreachy kernel] [Outreachy Kernel][PATCH v5] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Julia Lawall]

On Sun, 7 Oct 2018, Himanshu Jha wrote:

> On Sun, Oct 07, 2018 at 12:32:47AM +0530, Bhanusree Pola wrote:
> > Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
> >
> > Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> > ---
> >
> > changes in v5:
> > -Fixed Change log
> > -Change in subject line.Do not send as 'Re:'
> >
> > changes in v4:
> > -Remove Whitespace in comment section of module_comedi_pci_driver()
> >  to fix checkpatch Error.
> >
> > changes in v3:
> > -Comment section of module_pci_driver() exceeds 75 characters.
> >  Adjust the chars to 75 per line
> > -Modified log message.
> > -Added change log.
> >
> > changes in v2:
> > -comedi_pci_auto_config() function prototype is exceeds
> >  75 characters per line. Adjust to 75 chars to improve
> >  readability and also adjust the arguments to match open
> >  parantheses.
> > -Comment section of module_comedi_pci_driver() exceeds 75
> >  characters. Modified contents to adjust 75 chars per line.
> >
> >  drivers/staging/comedi/comedi_pci.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
> > index 1cc5436cb415..7291d3c0b7dc 100644
> > --- a/drivers/staging/comedi/comedi_pci.h
> > +++ b/drivers/staging/comedi/comedi_pci.h
> > @@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
> >  				  struct pci_driver *pci_driver);
> >
> >  /**
> > - * module_comedi_pci_driver()-Helper macro for registering a comedi PCI
> > + * module_comedi_pci_driver()-Helper macro for registering a comedi PCI
>
> The original line is:
>
> * module_comedi_pci_driver() - Helper macro for registering a comedi PCI driver
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/comedi/comedi_pci.h#n44
>
> The patch looks dubious to me.
>
> Always base your work on latest -next tree.
> https://www.kernel.org/doc/man-pages/linux-next.html

Bhanusree,

I think you made your new patch on top of your old one.

julia

>
> --
> Himanshu Jha
> Undergraduate Student
> Department of Electronics & Communication
> Guru Tegh Bahadur Institute of Technology
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181006193150.GA8922%40himanshu-Vostro-3559.
> For more options, visit https://groups.google.com/d/optout.
>