All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bp@suse.de" <bp@suse.de>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"rafal@milecki.pl" <rafal@milecki.pl>,
	"clemej@gmail.com" <clemej@gmail.com>
Subject: Re: [PATCH v4 2/2] x86/MCE/AMD: Don't report L1 BTB MCA errors on some Family 17h models
Date: Wed, 27 Mar 2019 20:19:57 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1903272019190.1789@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190325163410.171021-2-Yazen.Ghannam@amd.com>



On Mon, 25 Mar 2019, Ghannam, Yazen wrote:

> From: Yazen Ghannam <yazen.ghannam@amd.com>
> 
> AMD Family 17h Models 10h-2Fh may report a high number of L1 BTB MCA
> errors under certain conditions. The errors are benign and can safely be
> ignored. However, the high error rate may cause the MCA threshold
> counter to overflow causing a high rate of thresholding interrupts. In
> addition, users may see the errors reported through the AMD MCE decoder
> module, even with the interrupt disabled, due to MCA polling.
> 
> This error is reported through the Instruction Fetch bank.
> 
> Clear the "Counter Present" bit in the Instruction Fetch bank's
> MCA_MISC0 register. This will prevent enabling MCA thresholding on this
> bank which will prevent the high interrupt rate due to this error.
> 
> Define an AMD-specific function to filter these errors from the MCE
> event pool.
> 
> Rename filter function in EDAC/mce_amd to avoid a naming conflict.
> 
> Cc: <stable@vger.kernel.org> # 5.0.x: c95b323dcd35: x86/MCE/AMD: Turn off MC4_MISC thresholding on all family 0x15 models

What is this supposed to tell us?

> Cc: <stable@vger.kernel.org> # 5.0.x: 30aa3d26edb0: x86/MCE/AMD: Carve out the MC4_MISC thresholding quirk
> Cc: <stable@vger.kernel.org> # 5.0.x: 9308fd407455: x86/MCE: Group AMD function prototypes in <asm/mce.h>
> Cc: <stable@vger.kernel.org> # 5.0.x

Confused.

Thanks,

	tglx

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bp@suse.de" <bp@suse.de>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"rafal@milecki.pl" <rafal@milecki.pl>,
	"clemej@gmail.com" <clemej@gmail.com>
Subject: [v4,2/2] x86/MCE/AMD: Don't report L1 BTB MCA errors on some Family 17h models
Date: Wed, 27 Mar 2019 20:19:57 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1903272019190.1789@nanos.tec.linutronix.de> (raw)

On Mon, 25 Mar 2019, Ghannam, Yazen wrote:

> From: Yazen Ghannam <yazen.ghannam@amd.com>
> 
> AMD Family 17h Models 10h-2Fh may report a high number of L1 BTB MCA
> errors under certain conditions. The errors are benign and can safely be
> ignored. However, the high error rate may cause the MCA threshold
> counter to overflow causing a high rate of thresholding interrupts. In
> addition, users may see the errors reported through the AMD MCE decoder
> module, even with the interrupt disabled, due to MCA polling.
> 
> This error is reported through the Instruction Fetch bank.
> 
> Clear the "Counter Present" bit in the Instruction Fetch bank's
> MCA_MISC0 register. This will prevent enabling MCA thresholding on this
> bank which will prevent the high interrupt rate due to this error.
> 
> Define an AMD-specific function to filter these errors from the MCE
> event pool.
> 
> Rename filter function in EDAC/mce_amd to avoid a naming conflict.
> 
> Cc: <stable@vger.kernel.org> # 5.0.x: c95b323dcd35: x86/MCE/AMD: Turn off MC4_MISC thresholding on all family 0x15 models

What is this supposed to tell us?

> Cc: <stable@vger.kernel.org> # 5.0.x: 30aa3d26edb0: x86/MCE/AMD: Carve out the MC4_MISC thresholding quirk
> Cc: <stable@vger.kernel.org> # 5.0.x: 9308fd407455: x86/MCE: Group AMD function prototypes in <asm/mce.h>
> Cc: <stable@vger.kernel.org> # 5.0.x

Confused.

Thanks,

	tglx

  reply	other threads:[~2019-03-27 19:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 16:34 [PATCH v4 1/2] x86/MCE: Add function to allow filtering of MCA errors Ghannam, Yazen
2019-03-25 16:34 ` [v4,1/2] " Yazen Ghannam
2019-03-25 16:34 ` [PATCH v4 2/2] x86/MCE/AMD: Don't report L1 BTB MCA errors on some Family 17h models Ghannam, Yazen
2019-03-25 16:34   ` [v4,2/2] " Yazen Ghannam
2019-03-27 19:19   ` Thomas Gleixner [this message]
2019-03-27 19:19     ` Thomas Gleixner
2019-03-27 19:29     ` [PATCH v4 2/2] " Borislav Petkov
2019-03-27 19:29       ` [v4,2/2] " Borislav Petkov
2019-03-27 19:37       ` [PATCH v4 2/2] " Thomas Gleixner
2019-03-27 19:37         ` [v4,2/2] " Thomas Gleixner
2019-04-23 18:19   ` [tip:ras/core] x86/MCE/AMD: Don't report L1 BTB MCA errors on some family " tip-bot for Yazen Ghannam
2019-04-23 18:19     ` tip-bot for Borislav Petkov
2019-03-26  7:56 ` [PATCH v4 1/2] x86/MCE: Add function to allow filtering of MCA errors Borislav Petkov
2019-03-26  7:56   ` [v4,1/2] " Borislav Petkov
2019-03-26 11:41   ` [PATCH v4 1/2] " Ghannam, Yazen
2019-03-26 11:41     ` [v4,1/2] " Yazen Ghannam
2019-03-26 15:47     ` [PATCH v4 1/2] " Borislav Petkov
2019-03-26 15:47       ` [v4,1/2] " Borislav Petkov
2019-03-26  9:28 ` [PATCH v4 1/2] " Borislav Petkov
2019-03-26  9:28   ` [v4,1/2] " Borislav Petkov
2019-04-23 18:19 ` [tip:ras/core] x86/MCE: Add an MCE-record filtering function tip-bot for Yazen Ghannam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1903272019190.1789@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=Yazen.Ghannam@amd.com \
    --cc=bp@suse.de \
    --cc=clemej@gmail.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafal@milecki.pl \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.