From: Stefano Stabellini <sstabellini@kernel.org> To: Julien Grall <julien@xen.org> Cc: Stefano Stabellini <sstabellini@kernel.org>, jgross@suse.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Stefano Stabellini <stefano.stabellini@xilinx.com> Subject: Re: [PATCH 01/10] swiotlb-xen: use vmalloc_to_page on vmalloc virt addresses Date: Thu, 21 May 2020 20:54:47 -0700 (PDT) [thread overview] Message-ID: <alpine.DEB.2.21.2005211235590.27502@sstabellini-ThinkPad-T480s> (raw) In-Reply-To: <23e5b6d8-c5d9-b43f-41cd-9d02d8ec0a7f@xen.org> On Thu, 21 May 2020, Julien Grall wrote: > Hi, > > On 21/05/2020 00:45, Stefano Stabellini wrote: > > From: Boris Ostrovsky <boris.ostrovsky@oracle.com> > > > > Don't just assume that virt_to_page works on all virtual addresses. > > Instead add a is_vmalloc_addr check and use vmalloc_to_page on vmalloc > > virt addresses. > > Can you provide an example where swiotlb is used with vmalloc()? The issue was reported here happening on the Rasperry Pi 4: https://marc.info/?l=xen-devel&m=158862573216800 If you are asking where in the Linux codebase the vmalloc is happening specifically, I don't know for sure, my information is limited to the stack trace that you see in the link (I don't have a Rasperry Pi 4 yet but I shall have one soon.) > > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com> > > --- > > drivers/xen/swiotlb-xen.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c > > index b6d27762c6f8..a42129cba36e 100644 > > --- a/drivers/xen/swiotlb-xen.c > > +++ b/drivers/xen/swiotlb-xen.c > > @@ -335,6 +335,7 @@ xen_swiotlb_free_coherent(struct device *hwdev, size_t > > size, void *vaddr, > > int order = get_order(size); > > phys_addr_t phys; > > u64 dma_mask = DMA_BIT_MASK(32); > > + struct page *pg; > > if (hwdev && hwdev->coherent_dma_mask) > > dma_mask = hwdev->coherent_dma_mask; > > @@ -346,9 +347,11 @@ xen_swiotlb_free_coherent(struct device *hwdev, size_t > > size, void *vaddr, > > /* Convert the size to actually allocated. */ > > size = 1UL << (order + XEN_PAGE_SHIFT); > > + pg = is_vmalloc_addr(vaddr) ? vmalloc_to_page(vaddr) : > > + virt_to_page(vaddr); > > Common DMA code seems to protect this check with CONFIG_DMA_REMAP. Is it > something we want to do it here as well? Or is there any other condition where > vmalloc can happen? I can see it in dma_direct_free_pages: if (IS_ENABLED(CONFIG_DMA_REMAP) && is_vmalloc_addr(cpu_addr)) vunmap(cpu_addr); I wonder why the common DMA code does that. is_vmalloc_addr should work regardless of CONFIG_DMA_REMAP. Maybe just for efficiency?
WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <sstabellini@kernel.org> To: Julien Grall <julien@xen.org> Cc: jgross@suse.com, Stefano Stabellini <sstabellini@kernel.org>, konrad.wilk@oracle.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, Stefano Stabellini <stefano.stabellini@xilinx.com> Subject: Re: [PATCH 01/10] swiotlb-xen: use vmalloc_to_page on vmalloc virt addresses Date: Thu, 21 May 2020 20:54:47 -0700 (PDT) [thread overview] Message-ID: <alpine.DEB.2.21.2005211235590.27502@sstabellini-ThinkPad-T480s> (raw) In-Reply-To: <23e5b6d8-c5d9-b43f-41cd-9d02d8ec0a7f@xen.org> On Thu, 21 May 2020, Julien Grall wrote: > Hi, > > On 21/05/2020 00:45, Stefano Stabellini wrote: > > From: Boris Ostrovsky <boris.ostrovsky@oracle.com> > > > > Don't just assume that virt_to_page works on all virtual addresses. > > Instead add a is_vmalloc_addr check and use vmalloc_to_page on vmalloc > > virt addresses. > > Can you provide an example where swiotlb is used with vmalloc()? The issue was reported here happening on the Rasperry Pi 4: https://marc.info/?l=xen-devel&m=158862573216800 If you are asking where in the Linux codebase the vmalloc is happening specifically, I don't know for sure, my information is limited to the stack trace that you see in the link (I don't have a Rasperry Pi 4 yet but I shall have one soon.) > > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com> > > --- > > drivers/xen/swiotlb-xen.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c > > index b6d27762c6f8..a42129cba36e 100644 > > --- a/drivers/xen/swiotlb-xen.c > > +++ b/drivers/xen/swiotlb-xen.c > > @@ -335,6 +335,7 @@ xen_swiotlb_free_coherent(struct device *hwdev, size_t > > size, void *vaddr, > > int order = get_order(size); > > phys_addr_t phys; > > u64 dma_mask = DMA_BIT_MASK(32); > > + struct page *pg; > > if (hwdev && hwdev->coherent_dma_mask) > > dma_mask = hwdev->coherent_dma_mask; > > @@ -346,9 +347,11 @@ xen_swiotlb_free_coherent(struct device *hwdev, size_t > > size, void *vaddr, > > /* Convert the size to actually allocated. */ > > size = 1UL << (order + XEN_PAGE_SHIFT); > > + pg = is_vmalloc_addr(vaddr) ? vmalloc_to_page(vaddr) : > > + virt_to_page(vaddr); > > Common DMA code seems to protect this check with CONFIG_DMA_REMAP. Is it > something we want to do it here as well? Or is there any other condition where > vmalloc can happen? I can see it in dma_direct_free_pages: if (IS_ENABLED(CONFIG_DMA_REMAP) && is_vmalloc_addr(cpu_addr)) vunmap(cpu_addr); I wonder why the common DMA code does that. is_vmalloc_addr should work regardless of CONFIG_DMA_REMAP. Maybe just for efficiency?
next prev parent reply other threads:[~2020-05-22 3:54 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-20 23:45 [PATCH 00/10] fix swiotlb-xen for RPi4 Stefano Stabellini 2020-05-20 23:45 ` Stefano Stabellini 2020-05-20 23:45 ` [PATCH 01/10] swiotlb-xen: use vmalloc_to_page on vmalloc virt addresses Stefano Stabellini 2020-05-20 23:45 ` Stefano Stabellini 2020-05-21 8:01 ` Julien Grall 2020-05-21 8:01 ` Julien Grall 2020-05-22 3:54 ` Stefano Stabellini [this message] 2020-05-22 3:54 ` Stefano Stabellini 2020-05-22 18:11 ` Julien Grall 2020-05-22 18:11 ` Julien Grall 2020-05-22 20:36 ` Stefano Stabellini 2020-05-22 20:36 ` Stefano Stabellini 2020-05-20 23:45 ` [PATCH 02/10] swiotlb-xen: remove start_dma_addr Stefano Stabellini 2020-05-20 23:45 ` Stefano Stabellini 2020-05-21 8:05 ` Julien Grall 2020-05-21 8:05 ` Julien Grall 2020-05-22 3:55 ` Stefano Stabellini 2020-05-22 3:55 ` Stefano Stabellini 2020-05-22 18:16 ` Julien Grall 2020-05-22 18:16 ` Julien Grall 2020-05-22 20:47 ` Stefano Stabellini 2020-05-22 20:47 ` Stefano Stabellini 2020-05-20 23:45 ` [PATCH 03/10] swiotlb-xen: add struct device* parameter to xen_phys_to_bus Stefano Stabellini 2020-05-20 23:45 ` Stefano Stabellini 2020-05-20 23:45 ` [PATCH 04/10] swiotlb-xen: add struct device* parameter to xen_bus_to_phys Stefano Stabellini 2020-05-20 23:45 ` Stefano Stabellini 2020-05-20 23:45 ` [PATCH 05/10] swiotlb-xen: add struct device* parameter to xen_dma_sync_for_cpu Stefano Stabellini 2020-05-20 23:45 ` Stefano Stabellini 2020-05-20 23:45 ` [PATCH 06/10] swiotlb-xen: add struct device* parameter to xen_dma_sync_for_device Stefano Stabellini 2020-05-20 23:45 ` Stefano Stabellini 2020-05-20 23:45 ` [PATCH 07/10] swiotlb-xen: add struct device* parameter to is_xen_swiotlb_buffer Stefano Stabellini 2020-05-20 23:45 ` Stefano Stabellini 2020-05-20 23:45 ` [PATCH 08/10] swiotlb-xen: introduce phys_to_dma/dma_to_phys translations Stefano Stabellini 2020-05-20 23:45 ` Stefano Stabellini 2020-05-21 8:07 ` Julien Grall 2020-05-21 8:07 ` Julien Grall 2020-05-21 22:59 ` Boris Ostrovsky 2020-05-21 22:59 ` Boris Ostrovsky 2020-05-22 17:34 ` Stefano Stabellini 2020-05-22 17:34 ` Stefano Stabellini 2020-05-22 18:29 ` Boris Ostrovsky 2020-05-22 18:29 ` Boris Ostrovsky 2020-05-20 23:45 ` [PATCH 09/10] xen/arm: introduce phys/dma translations in xen_dma_sync_for_* Stefano Stabellini 2020-05-20 23:45 ` Stefano Stabellini 2020-05-21 8:18 ` Julien Grall 2020-05-21 8:18 ` Julien Grall 2020-05-21 20:08 ` Stefano Stabellini 2020-05-21 20:08 ` Stefano Stabellini 2020-05-21 20:17 ` Julien Grall 2020-05-21 20:17 ` Julien Grall 2020-05-20 23:45 ` [PATCH 10/10] xen/arm: call dma_to_phys on the dma_addr_t parameter of dma_cache_maint Stefano Stabellini 2020-05-20 23:45 ` Stefano Stabellini 2020-05-21 8:25 ` Julien Grall 2020-05-21 8:25 ` Julien Grall 2020-05-20 23:51 ` [PATCH 00/10] fix swiotlb-xen for RPi4 Roman Shaposhnik 2020-05-20 23:51 ` Roman Shaposhnik 2020-05-20 23:56 ` Stefano Stabellini 2020-05-20 23:56 ` Stefano Stabellini 2020-06-02 21:51 ` Stefano Stabellini 2020-06-02 21:51 ` Stefano Stabellini 2020-06-03 0:15 ` Boris Ostrovsky 2020-06-03 0:15 ` Boris Ostrovsky
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.21.2005211235590.27502@sstabellini-ThinkPad-T480s \ --to=sstabellini@kernel.org \ --cc=boris.ostrovsky@oracle.com \ --cc=jgross@suse.com \ --cc=julien@xen.org \ --cc=konrad.wilk@oracle.com \ --cc=linux-kernel@vger.kernel.org \ --cc=stefano.stabellini@xilinx.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.