* [PATCH] Correct indentation in Hal8723BReg.h
@ 2021-04-06 2:08 Fabio M. De Francesco
2021-04-06 5:12 ` Greg KH
0 siblings, 1 reply; 13+ messages in thread
From: Fabio M. De Francesco @ 2021-04-06 2:08 UTC (permalink / raw)
To: gregkh, outreachy-kernel; +Cc: Fabio M. De Francesco
Correct indentation issues of many #define and comments in Hal8723BReg.h
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 604 ++++++++++----------
1 file changed, 302 insertions(+), 302 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/Hal8723BReg.h b/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
index b9aca99478db..2b51d93de658 100644
--- a/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
+++ b/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
@@ -27,103 +27,103 @@
/* */
/* */
-/* 0x0000h ~ 0x00FFh System Configuration */
+/* 0x0000h ~ 0x00FFh System Configuration */
/* */
/* */
#define REG_SYS_ISO_CTRL_8723B 0x0000 /* 2 Byte */
#define REG_SYS_FUNC_EN_8723B 0x0002 /* 2 Byte */
#define REG_APS_FSMCO_8723B 0x0004 /* 4 Byte */
-#define REG_SYS_CLKR_8723B 0x0008 /* 2 Byte */
-#define REG_9346CR_8723B 0x000A /* 2 Byte */
-#define REG_EE_VPD_8723B 0x000C /* 2 Byte */
-#define REG_AFE_MISC_8723B 0x0010 /* 1 Byte */
-#define REG_SPS0_CTRL_8723B 0x0011 /* 7 Byte */
+#define REG_SYS_CLKR_8723B 0x0008 /* 2 Byte */
+#define REG_9346CR_8723B 0x000A /* 2 Byte */
+#define REG_EE_VPD_8723B 0x000C /* 2 Byte */
+#define REG_AFE_MISC_8723B 0x0010 /* 1 Byte */
+#define REG_SPS0_CTRL_8723B 0x0011 /* 7 Byte */
#define REG_SPS_OCP_CFG_8723B 0x0018 /* 4 Byte */
-#define REG_RSV_CTRL_8723B 0x001C /* 3 Byte */
-#define REG_RF_CTRL_8723B 0x001F /* 1 Byte */
+#define REG_RSV_CTRL_8723B 0x001C /* 3 Byte */
+#define REG_RF_CTRL_8723B 0x001F /* 1 Byte */
#define REG_LPLDO_CTRL_8723B 0x0023 /* 1 Byte */
-#define REG_AFE_XTAL_CTRL_8723B 0x0024 /* 4 Byte */
+#define REG_AFE_XTAL_CTRL_8723B 0x0024 /* 4 Byte */
#define REG_AFE_PLL_CTRL_8723B 0x0028 /* 4 Byte */
#define REG_MAC_PLL_CTRL_EXT_8723B 0x002c /* 4 Byte */
#define REG_EFUSE_CTRL_8723B 0x0030
#define REG_EFUSE_TEST_8723B 0x0034
-#define REG_PWR_DATA_8723B 0x0038
-#define REG_CAL_TIMER_8723B 0x003C
-#define REG_ACLK_MON_8723B 0x003E
+#define REG_PWR_DATA_8723B 0x0038
+#define REG_CAL_TIMER_8723B 0x003C
+#define REG_ACLK_MON_8723B 0x003E
#define REG_GPIO_MUXCFG_8723B 0x0040
#define REG_GPIO_IO_SEL_8723B 0x0042
#define REG_MAC_PINMUX_CFG_8723B 0x0043
#define REG_GPIO_PIN_CTRL_8723B 0x0044
-#define REG_GPIO_INTM_8723B 0x0048
-#define REG_LEDCFG0_8723B 0x004C
-#define REG_LEDCFG1_8723B 0x004D
-#define REG_LEDCFG2_8723B 0x004E
-#define REG_LEDCFG3_8723B 0x004F
-#define REG_FSIMR_8723B 0x0050
-#define REG_FSISR_8723B 0x0054
-#define REG_HSIMR_8723B 0x0058
-#define REG_HSISR_8723B 0x005c
-#define REG_GPIO_EXT_CTRL 0x0060
+#define REG_GPIO_INTM_8723B 0x0048
+#define REG_LEDCFG0_8723B 0x004C
+#define REG_LEDCFG1_8723B 0x004D
+#define REG_LEDCFG2_8723B 0x004E
+#define REG_LEDCFG3_8723B 0x004F
+#define REG_FSIMR_8723B 0x0050
+#define REG_FSISR_8723B 0x0054
+#define REG_HSIMR_8723B 0x0058
+#define REG_HSISR_8723B 0x005c
+#define REG_GPIO_EXT_CTRL 0x0060
#define REG_MULTI_FUNC_CTRL_8723B 0x0068
#define REG_GPIO_STATUS_8723B 0x006C
-#define REG_SDIO_CTRL_8723B 0x0070
-#define REG_OPT_CTRL_8723B 0x0074
-#define REG_AFE_XTAL_CTRL_EXT_8723B 0x0078
-#define REG_MCUFWDL_8723B 0x0080
+#define REG_SDIO_CTRL_8723B 0x0070
+#define REG_OPT_CTRL_8723B 0x0074
+#define REG_AFE_XTAL_CTRL_EXT_8723B 0x0078
+#define REG_MCUFWDL_8723B 0x0080
#define REG_BT_PATCH_STATUS_8723B 0x0088
-#define REG_HIMR0_8723B 0x00B0
-#define REG_HISR0_8723B 0x00B4
-#define REG_HIMR1_8723B 0x00B8
-#define REG_HISR1_8723B 0x00BC
+#define REG_HIMR0_8723B 0x00B0
+#define REG_HISR0_8723B 0x00B4
+#define REG_HIMR1_8723B 0x00B8
+#define REG_HISR1_8723B 0x00BC
#define REG_PMC_DBG_CTRL2_8723B 0x00CC
#define REG_EFUSE_BURN_GNT_8723B 0x00CF
-#define REG_HPON_FSM_8723B 0x00EC
-#define REG_SYS_CFG_8723B 0x00F0
-#define REG_SYS_CFG1_8723B 0x00FC
-#define REG_ROM_VERSION 0x00FD
+#define REG_HPON_FSM_8723B 0x00EC
+#define REG_SYS_CFG_8723B 0x00F0
+#define REG_SYS_CFG1_8723B 0x00FC
+#define REG_ROM_VERSION 0x00FD
/* */
/* */
-/* 0x0100h ~ 0x01FFh MACTOP General Configuration */
+/* 0x0100h ~ 0x01FFh MACTOP General Configuration */
/* */
/* */
-#define REG_CR_8723B 0x0100
-#define REG_PBP_8723B 0x0104
-#define REG_PKT_BUFF_ACCESS_CTRL_8723B 0x0106
+#define REG_CR_8723B 0x0100
+#define REG_PBP_8723B 0x0104
+#define REG_PKT_BUFF_ACCESS_CTRL_8723B 0x0106
#define REG_TRXDMA_CTRL_8723B 0x010C
#define REG_TRXFF_BNDY_8723B 0x0114
#define REG_TRXFF_STATUS_8723B 0x0118
-#define REG_RXFF_PTR_8723B 0x011C
-#define REG_CPWM_8723B 0x012F
-#define REG_FWIMR_8723B 0x0130
-#define REG_FWISR_8723B 0x0134
-#define REG_FTIMR_8723B 0x0138
+#define REG_RXFF_PTR_8723B 0x011C
+#define REG_CPWM_8723B 0x012F
+#define REG_FWIMR_8723B 0x0130
+#define REG_FWISR_8723B 0x0134
+#define REG_FTIMR_8723B 0x0138
#define REG_PKTBUF_DBG_CTRL_8723B 0x0140
-#define REG_RXPKTBUF_CTRL_8723B 0x0142
-#define REG_PKTBUF_DBG_DATA_L_8723B 0x0144
-#define REG_PKTBUF_DBG_DATA_H_8723B 0x0148
-
-#define REG_TC0_CTRL_8723B 0x0150
-#define REG_TC1_CTRL_8723B 0x0154
-#define REG_TC2_CTRL_8723B 0x0158
-#define REG_TC3_CTRL_8723B 0x015C
-#define REG_TC4_CTRL_8723B 0x0160
+#define REG_RXPKTBUF_CTRL_8723B 0x0142
+#define REG_PKTBUF_DBG_DATA_L_8723B 0x0144
+#define REG_PKTBUF_DBG_DATA_H_8723B 0x0148
+
+#define REG_TC0_CTRL_8723B 0x0150
+#define REG_TC1_CTRL_8723B 0x0154
+#define REG_TC2_CTRL_8723B 0x0158
+#define REG_TC3_CTRL_8723B 0x015C
+#define REG_TC4_CTRL_8723B 0x0160
#define REG_TCUNIT_BASE_8723B 0x0164
-#define REG_RSVD3_8723B 0x0168
-#define REG_C2HEVT_MSG_NORMAL_8723B 0x01A0
-#define REG_C2HEVT_CMD_SEQ_88XX 0x01A1
-#define REG_C2hEVT_CMD_CONTENT_88XX 0x01A2
-#define REG_C2HEVT_CMD_LEN_88XX 0x01AE
+#define REG_RSVD3_8723B 0x0168
+#define REG_C2HEVT_MSG_NORMAL_8723B 0x01A0
+#define REG_C2HEVT_CMD_SEQ_88XX 0x01A1
+#define REG_C2hEVT_CMD_CONTENT_88XX 0x01A2
+#define REG_C2HEVT_CMD_LEN_88XX 0x01AE
#define REG_C2HEVT_CLEAR_8723B 0x01AF
-#define REG_MCUTST_1_8723B 0x01C0
-#define REG_MCUTST_WOWLAN_8723B 0x01C7
-#define REG_FMETHR_8723B 0x01C8
-#define REG_HMETFR_8723B 0x01CC
-#define REG_HMEBOX_0_8723B 0x01D0
-#define REG_HMEBOX_1_8723B 0x01D4
-#define REG_HMEBOX_2_8723B 0x01D8
-#define REG_HMEBOX_3_8723B 0x01DC
-#define REG_LLT_INIT_8723B 0x01E0
+#define REG_MCUTST_1_8723B 0x01C0
+#define REG_MCUTST_WOWLAN_8723B 0x01C7
+#define REG_FMETHR_8723B 0x01C8
+#define REG_HMETFR_8723B 0x01CC
+#define REG_HMEBOX_0_8723B 0x01D0
+#define REG_HMEBOX_1_8723B 0x01D4
+#define REG_HMEBOX_2_8723B 0x01D8
+#define REG_HMEBOX_3_8723B 0x01DC
+#define REG_LLT_INIT_8723B 0x01E0
#define REG_HMEBOX_EXT0_8723B 0x01F0
#define REG_HMEBOX_EXT1_8723B 0x01F4
#define REG_HMEBOX_EXT2_8723B 0x01F8
@@ -131,65 +131,65 @@
/* */
/* */
-/* 0x0200h ~ 0x027Fh TXDMA Configuration */
+/* 0x0200h ~ 0x027Fh TXDMA Configuration */
/* */
/* */
-#define REG_RQPN_8723B 0x0200
-#define REG_FIFOPAGE_8723B 0x0204
+#define REG_RQPN_8723B 0x0200
+#define REG_FIFOPAGE_8723B 0x0204
#define REG_DWBCN0_CTRL_8723B REG_TDECTRL
-#define REG_TXDMA_OFFSET_CHK_8723B 0x020C
-#define REG_TXDMA_STATUS_8723B 0x0210
+#define REG_TXDMA_OFFSET_CHK_8723B 0x020C
+#define REG_TXDMA_STATUS_8723B 0x0210
#define REG_RQPN_NPQ_8723B 0x0214
#define REG_DWBCN1_CTRL_8723B 0x0228
/* */
/* */
-/* 0x0280h ~ 0x02FFh RXDMA Configuration */
+/* 0x0280h ~ 0x02FFh RXDMA Configuration */
/* */
/* */
#define REG_RXDMA_AGG_PG_TH_8723B 0x0280
-#define REG_FW_UPD_RDPTR_8723B 0x0284 /* FW shall update this register before FW write RXPKT_RELEASE_POLL to 1 */
-#define REG_RXDMA_CONTROL_8723B 0x0286 /* Control the RX DMA. */
-#define REG_RXPKT_NUM_8723B 0x0287 /* The number of packets in RXPKTBUF. */
+#define REG_FW_UPD_RDPTR_8723B 0x0284 /* FW shall update this register before FW write RXPKT_RELEASE_POLL to 1 */
+#define REG_RXDMA_CONTROL_8723B 0x0286 /* Control the RX DMA. */
+#define REG_RXPKT_NUM_8723B 0x0287 /* The number of packets in RXPKTBUF. */
#define REG_RXDMA_STATUS_8723B 0x0288
#define REG_RXDMA_PRO_8723B 0x0290
-#define REG_EARLY_MODE_CONTROL_8723B 0x02BC
-#define REG_RSVD5_8723B 0x02F0
-#define REG_RSVD6_8723B 0x02F4
-
-
-/* */
-/* */
-/* 0x0300h ~ 0x03FFh PCIe */
-/* */
-/* */
-#define REG_PCIE_CTRL_REG_8723B 0x0300
-#define REG_INT_MIG_8723B 0x0304 /* Interrupt Migration */
-#define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor Address */
-#define REG_HQ_DESA_8723B 0x0310 /* TX High Queue Descriptor Address */
-#define REG_MGQ_DESA_8723B 0x0318 /* TX Manage Queue Descriptor Address */
-#define REG_VOQ_DESA_8723B 0x0320 /* TX VO Queue Descriptor Address */
-#define REG_VIQ_DESA_8723B 0x0328 /* TX VI Queue Descriptor Address */
-#define REG_BEQ_DESA_8723B 0x0330 /* TX BE Queue Descriptor Address */
-#define REG_BKQ_DESA_8723B 0x0338 /* TX BK Queue Descriptor Address */
-#define REG_RX_DESA_8723B 0x0340 /* RX Queue Descriptor Address */
-#define REG_DBI_WDATA_8723B 0x0348 /* DBI Write Data */
-#define REG_DBI_RDATA_8723B 0x034C /* DBI Read Data */
-#define REG_DBI_ADDR_8723B 0x0350 /* DBI Address */
-#define REG_DBI_FLAG_8723B 0x0352 /* DBI Read/Write Flag */
-#define REG_MDIO_WDATA_8723B 0x0354 /* MDIO for Write PCIE PHY */
-#define REG_MDIO_RDATA_8723B 0x0356 /* MDIO for Reads PCIE PHY */
-#define REG_MDIO_CTL_8723B 0x0358 /* MDIO for Control */
-#define REG_DBG_SEL_8723B 0x0360 /* Debug Selection Register */
+#define REG_EARLY_MODE_CONTROL_8723B 0x02BC
+#define REG_RSVD5_8723B 0x02F0
+#define REG_RSVD6_8723B 0x02F4
+
+
+/* */
+/* */
+/* 0x0300h ~ 0x03FFh PCIe */
+/* */
+/* */
+#define REG_PCIE_CTRL_REG_8723B 0x0300
+#define REG_INT_MIG_8723B 0x0304 /* Interrupt Migration */
+#define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor Address */
+#define REG_HQ_DESA_8723B 0x0310 /* TX High Queue Descriptor Address */
+#define REG_MGQ_DESA_8723B 0x0318 /* TX Manage Queue Descriptor Address */
+#define REG_VOQ_DESA_8723B 0x0320 /* TX VO Queue Descriptor Address */
+#define REG_VIQ_DESA_8723B 0x0328 /* TX VI Queue Descriptor Address */
+#define REG_BEQ_DESA_8723B 0x0330 /* TX BE Queue Descriptor Address */
+#define REG_BKQ_DESA_8723B 0x0338 /* TX BK Queue Descriptor Address */
+#define REG_RX_DESA_8723B 0x0340 /* RX Queue Descriptor Address */
+#define REG_DBI_WDATA_8723B 0x0348 /* DBI Write Data */
+#define REG_DBI_RDATA_8723B 0x034C /* DBI Read Data */
+#define REG_DBI_ADDR_8723B 0x0350 /* DBI Address */
+#define REG_DBI_FLAG_8723B 0x0352 /* DBI Read/Write Flag */
+#define REG_MDIO_WDATA_8723B 0x0354 /* MDIO for Write PCIE PHY */
+#define REG_MDIO_RDATA_8723B 0x0356 /* MDIO for Reads PCIE PHY */
+#define REG_MDIO_CTL_8723B 0x0358 /* MDIO for Control */
+#define REG_DBG_SEL_8723B 0x0360 /* Debug Selection Register */
#define REG_PCIE_HRPWM_8723B 0x0361 /* PCIe RPWM */
#define REG_PCIE_HCPWM_8723B 0x0363 /* PCIe CPWM */
-#define REG_PCIE_MULTIFET_CTRL_8723B 0x036A /* PCIE Multi-Fethc Control */
+#define REG_PCIE_MULTIFET_CTRL_8723B 0x036A /* PCIE Multi-Fethc Control */
/* spec version 11 */
/* */
/* */
-/* 0x0400h ~ 0x047Fh Protocol Configuration */
+/* 0x0400h ~ 0x047Fh Protocol Configuration */
/* */
/* */
#define REG_VOQ_INFORMATION_8723B 0x0400
@@ -198,235 +198,235 @@
#define REG_BKQ_INFORMATION_8723B 0x040C
#define REG_MGQ_INFORMATION_8723B 0x0410
#define REG_HGQ_INFORMATION_8723B 0x0414
-#define REG_BCNQ_INFORMATION_8723B 0x0418
+#define REG_BCNQ_INFORMATION_8723B 0x0418
#define REG_TXPKT_EMPTY_8723B 0x041A
-#define REG_FWHW_TXQ_CTRL_8723B 0x0420
+#define REG_FWHW_TXQ_CTRL_8723B 0x0420
#define REG_HWSEQ_CTRL_8723B 0x0423
-#define REG_TXPKTBUF_BCNQ_BDNY_8723B 0x0424
-#define REG_TXPKTBUF_MGQ_BDNY_8723B 0x0425
+#define REG_TXPKTBUF_BCNQ_BDNY_8723B 0x0424
+#define REG_TXPKTBUF_MGQ_BDNY_8723B 0x0425
#define REG_LIFECTRL_CTRL_8723B 0x0426
-#define REG_MULTI_BCNQ_OFFSET_8723B 0x0427
-#define REG_SPEC_SIFS_8723B 0x0428
-#define REG_RL_8723B 0x042A
-#define REG_TXBF_CTRL_8723B 0x042C
-#define REG_DARFRC_8723B 0x0430
-#define REG_RARFRC_8723B 0x0438
-#define REG_RRSR_8723B 0x0440
-#define REG_ARFR0_8723B 0x0444
-#define REG_ARFR1_8723B 0x044C
-#define REG_CCK_CHECK_8723B 0x0454
+#define REG_MULTI_BCNQ_OFFSET_8723B 0x0427
+#define REG_SPEC_SIFS_8723B 0x0428
+#define REG_RL_8723B 0x042A
+#define REG_TXBF_CTRL_8723B 0x042C
+#define REG_DARFRC_8723B 0x0430
+#define REG_RARFRC_8723B 0x0438
+#define REG_RRSR_8723B 0x0440
+#define REG_ARFR0_8723B 0x0444
+#define REG_ARFR1_8723B 0x044C
+#define REG_CCK_CHECK_8723B 0x0454
#define REG_AMPDU_MAX_TIME_8723B 0x0456
-#define REG_TXPKTBUF_BCNQ_BDNY1_8723B 0x0457
+#define REG_TXPKTBUF_BCNQ_BDNY1_8723B 0x0457
-#define REG_AMPDU_MAX_LENGTH_8723B 0x0458
+#define REG_AMPDU_MAX_LENGTH_8723B 0x0458
#define REG_TXPKTBUF_WMAC_LBK_BF_HD_8723B 0x045D
-#define REG_NDPA_OPT_CTRL_8723B 0x045F
+#define REG_NDPA_OPT_CTRL_8723B 0x045F
#define REG_FAST_EDCA_CTRL_8723B 0x0460
#define REG_RD_RESP_PKT_TH_8723B 0x0463
-#define REG_DATA_SC_8723B 0x0483
-#define REG_TXRPT_START_OFFSET 0x04AC
-#define REG_POWER_STAGE1_8723B 0x04B4
-#define REG_POWER_STAGE2_8723B 0x04B8
-#define REG_AMPDU_BURST_MODE_8723B 0x04BC
-#define REG_PKT_VO_VI_LIFE_TIME_8723B 0x04C0
-#define REG_PKT_BE_BK_LIFE_TIME_8723B 0x04C2
+#define REG_DATA_SC_8723B 0x0483
+#define REG_TXRPT_START_OFFSET 0x04AC
+#define REG_POWER_STAGE1_8723B 0x04B4
+#define REG_POWER_STAGE2_8723B 0x04B8
+#define REG_AMPDU_BURST_MODE_8723B 0x04BC
+#define REG_PKT_VO_VI_LIFE_TIME_8723B 0x04C0
+#define REG_PKT_BE_BK_LIFE_TIME_8723B 0x04C2
#define REG_STBC_SETTING_8723B 0x04C4
#define REG_HT_SINGLE_AMPDU_8723B 0x04C7
#define REG_PROT_MODE_CTRL_8723B 0x04C8
-#define REG_MAX_AGGR_NUM_8723B 0x04CA
-#define REG_RTS_MAX_AGGR_NUM_8723B 0x04CB
-#define REG_BAR_MODE_CTRL_8723B 0x04CC
-#define REG_RA_TRY_RATE_AGG_LMT_8723B 0x04CF
+#define REG_MAX_AGGR_NUM_8723B 0x04CA
+#define REG_RTS_MAX_AGGR_NUM_8723B 0x04CB
+#define REG_BAR_MODE_CTRL_8723B 0x04CC
+#define REG_RA_TRY_RATE_AGG_LMT_8723B 0x04CF
#define REG_MACID_PKT_DROP0_8723B 0x04D0
#define REG_MACID_PKT_SLEEP_8723B 0x04D4
/* */
/* */
-/* 0x0500h ~ 0x05FFh EDCA Configuration */
+/* 0x0500h ~ 0x05FFh EDCA Configuration */
/* */
/* */
-#define REG_EDCA_VO_PARAM_8723B 0x0500
-#define REG_EDCA_VI_PARAM_8723B 0x0504
-#define REG_EDCA_BE_PARAM_8723B 0x0508
-#define REG_EDCA_BK_PARAM_8723B 0x050C
-#define REG_BCNTCFG_8723B 0x0510
-#define REG_PIFS_8723B 0x0512
-#define REG_RDG_PIFS_8723B 0x0513
-#define REG_SIFS_CTX_8723B 0x0514
-#define REG_SIFS_TRX_8723B 0x0516
+#define REG_EDCA_VO_PARAM_8723B 0x0500
+#define REG_EDCA_VI_PARAM_8723B 0x0504
+#define REG_EDCA_BE_PARAM_8723B 0x0508
+#define REG_EDCA_BK_PARAM_8723B 0x050C
+#define REG_BCNTCFG_8723B 0x0510
+#define REG_PIFS_8723B 0x0512
+#define REG_RDG_PIFS_8723B 0x0513
+#define REG_SIFS_CTX_8723B 0x0514
+#define REG_SIFS_TRX_8723B 0x0516
#define REG_AGGR_BREAK_TIME_8723B 0x051A
-#define REG_SLOT_8723B 0x051B
+#define REG_SLOT_8723B 0x051B
#define REG_TX_PTCL_CTRL_8723B 0x0520
-#define REG_TXPAUSE_8723B 0x0522
-#define REG_DIS_TXREQ_CLR_8723B 0x0523
-#define REG_RD_CTRL_8723B 0x0524
-/* */
-/* Format for offset 540h-542h: */
-/* [3:0]: TBTT prohibit setup in unit of 32us. The time for HW getting beacon content before TBTT. */
-/* [7:4]: Reserved. */
-/* [19:8]: TBTT prohibit hold in unit of 32us. The time for HW holding to send the beacon packet. */
-/* [23:20]: Reserved */
-/* Description: */
-/* | */
-/* |<--Setup--|--Hold------------>| */
-/* --------------|---------------------- */
-/* | */
+#define REG_TXPAUSE_8723B 0x0522
+#define REG_DIS_TXREQ_CLR_8723B 0x0523
+#define REG_RD_CTRL_8723B 0x0524
+/* */
+/* Format for offset 540h-542h: */
+/* [3:0]: TBTT prohibit setup in unit of 32us. The time for HW getting beacon content before TBTT. */
+/* [7:4]: Reserved. */
+/* [19:8]: TBTT prohibit hold in unit of 32us. The time for HW holding to send the beacon packet. */
+/* [23:20]: Reserved */
+/* Description: */
+/* | */
+/* |<--Setup--|--Hold------------>| */
+/* --------------|---------------------- */
+/* | */
/* TBTT */
/* Note: We cannot update beacon content to HW or send any AC packets during the time between Setup and Hold. */
/* Described by Designer Tim and Bruce, 2011-01-14. */
/* */
-#define REG_TBTT_PROHIBIT_8723B 0x0540
-#define REG_RD_NAV_NXT_8723B 0x0544
-#define REG_NAV_PROT_LEN_8723B 0x0546
-#define REG_BCN_CTRL_8723B 0x0550
-#define REG_BCN_CTRL_1_8723B 0x0551
-#define REG_MBID_NUM_8723B 0x0552
-#define REG_DUAL_TSF_RST_8723B 0x0553
-#define REG_BCN_INTERVAL_8723B 0x0554
-#define REG_DRVERLYINT_8723B 0x0558
-#define REG_BCNDMATIM_8723B 0x0559
-#define REG_ATIMWND_8723B 0x055A
-#define REG_USTIME_TSF_8723B 0x055C
-#define REG_BCN_MAX_ERR_8723B 0x055D
-#define REG_RXTSF_OFFSET_CCK_8723B 0x055E
-#define REG_RXTSF_OFFSET_OFDM_8723B 0x055F
-#define REG_TSFTR_8723B 0x0560
-#define REG_CTWND_8723B 0x0572
-#define REG_SECONDARY_CCA_CTRL_8723B 0x0577
-#define REG_PSTIMER_8723B 0x0580
-#define REG_TIMER0_8723B 0x0584
-#define REG_TIMER1_8723B 0x0588
-#define REG_ACMHWCTRL_8723B 0x05C0
-#define REG_SCH_TXCMD_8723B 0x05F8
-
-/* 0x0600h ~ 0x07FFh WMAC Configuration */
-#define REG_MAC_CR_8723B 0x0600
-#define REG_TCR_8723B 0x0604
-#define REG_RCR_8723B 0x0608
-#define REG_RX_PKT_LIMIT_8723B 0x060C
-#define REG_RX_DLK_TIME_8723B 0x060D
-#define REG_RX_DRVINFO_SZ_8723B 0x060F
-
-#define REG_MACID_8723B 0x0610
-#define REG_BSSID_8723B 0x0618
-#define REG_MAR_8723B 0x0620
-#define REG_MBIDCAMCFG_8723B 0x0628
-
-#define REG_USTIME_EDCA_8723B 0x0638
-#define REG_MAC_SPEC_SIFS_8723B 0x063A
-#define REG_RESP_SIFP_CCK_8723B 0x063C
-#define REG_RESP_SIFS_OFDM_8723B 0x063E
-#define REG_ACKTO_8723B 0x0640
-#define REG_CTS2TO_8723B 0x0641
-#define REG_EIFS_8723B 0x0642
-
-#define REG_NAV_UPPER_8723B 0x0652 /* unit of 128 */
-#define REG_TRXPTCL_CTL_8723B 0x0668
-
-/* Security */
-#define REG_CAMCMD_8723B 0x0670
-#define REG_CAMWRITE_8723B 0x0674
-#define REG_CAMREAD_8723B 0x0678
-#define REG_CAMDBG_8723B 0x067C
-#define REG_SECCFG_8723B 0x0680
-
-/* Power */
-#define REG_WOW_CTRL_8723B 0x0690
-#define REG_PS_RX_INFO_8723B 0x0692
-#define REG_UAPSD_TID_8723B 0x0693
-#define REG_WKFMCAM_CMD_8723B 0x0698
-#define REG_WKFMCAM_NUM_8723B 0x0698
-#define REG_WKFMCAM_RWD_8723B 0x069C
-#define REG_RXFLTMAP0_8723B 0x06A0
-#define REG_RXFLTMAP1_8723B 0x06A2
-#define REG_RXFLTMAP2_8723B 0x06A4
-#define REG_BCN_PSR_RPT_8723B 0x06A8
-#define REG_BT_COEX_TABLE_8723B 0x06C0
-#define REG_BFMER0_INFO_8723B 0x06E4
-#define REG_BFMER1_INFO_8723B 0x06EC
-#define REG_CSI_RPT_PARAM_BW20_8723B 0x06F4
-#define REG_CSI_RPT_PARAM_BW40_8723B 0x06F8
-#define REG_CSI_RPT_PARAM_BW80_8723B 0x06FC
-
-/* Hardware Port 2 */
-#define REG_MACID1_8723B 0x0700
-#define REG_BSSID1_8723B 0x0708
-#define REG_BFMEE_SEL_8723B 0x0714
-#define REG_SND_PTCL_CTRL_8723B 0x0718
-
-
-/* Redifine 8192C register definition for compatibility */
-
-/* TODO: use these definition when using REG_xxx naming rule. */
-/* NOTE: DO NOT Remove these definition. Use later. */
-#define EFUSE_CTRL_8723B REG_EFUSE_CTRL_8723B /* E-Fuse Control. */
-#define EFUSE_TEST_8723B REG_EFUSE_TEST_8723B /* E-Fuse Test. */
-#define MSR_8723B (REG_CR_8723B + 2) /* Media Status register */
+#define REG_TBTT_PROHIBIT_8723B 0x0540
+#define REG_RD_NAV_NXT_8723B 0x0544
+#define REG_NAV_PROT_LEN_8723B 0x0546
+#define REG_BCN_CTRL_8723B 0x0550
+#define REG_BCN_CTRL_1_8723B 0x0551
+#define REG_MBID_NUM_8723B 0x0552
+#define REG_DUAL_TSF_RST_8723B 0x0553
+#define REG_BCN_INTERVAL_8723B 0x0554
+#define REG_DRVERLYINT_8723B 0x0558
+#define REG_BCNDMATIM_8723B 0x0559
+#define REG_ATIMWND_8723B 0x055A
+#define REG_USTIME_TSF_8723B 0x055C
+#define REG_BCN_MAX_ERR_8723B 0x055D
+#define REG_RXTSF_OFFSET_CCK_8723B 0x055E
+#define REG_RXTSF_OFFSET_OFDM_8723B 0x055F
+#define REG_TSFTR_8723B 0x0560
+#define REG_CTWND_8723B 0x0572
+#define REG_SECONDARY_CCA_CTRL_8723B 0x0577
+#define REG_PSTIMER_8723B 0x0580
+#define REG_TIMER0_8723B 0x0584
+#define REG_TIMER1_8723B 0x0588
+#define REG_ACMHWCTRL_8723B 0x05C0
+#define REG_SCH_TXCMD_8723B 0x05F8
+
+/* 0x0600h ~ 0x07FFh WMAC Configuration */
+#define REG_MAC_CR_8723B 0x0600
+#define REG_TCR_8723B 0x0604
+#define REG_RCR_8723B 0x0608
+#define REG_RX_PKT_LIMIT_8723B 0x060C
+#define REG_RX_DLK_TIME_8723B 0x060D
+#define REG_RX_DRVINFO_SZ_8723B 0x060F
+
+#define REG_MACID_8723B 0x0610
+#define REG_BSSID_8723B 0x0618
+#define REG_MAR_8723B 0x0620
+#define REG_MBIDCAMCFG_8723B 0x0628
+
+#define REG_USTIME_EDCA_8723B 0x0638
+#define REG_MAC_SPEC_SIFS_8723B 0x063A
+#define REG_RESP_SIFP_CCK_8723B 0x063C
+#define REG_RESP_SIFS_OFDM_8723B 0x063E
+#define REG_ACKTO_8723B 0x0640
+#define REG_CTS2TO_8723B 0x0641
+#define REG_EIFS_8723B 0x0642
+
+#define REG_NAV_UPPER_8723B 0x0652 /* unit of 128 */
+#define REG_TRXPTCL_CTL_8723B 0x0668
+
+/* Security */
+#define REG_CAMCMD_8723B 0x0670
+#define REG_CAMWRITE_8723B 0x0674
+#define REG_CAMREAD_8723B 0x0678
+#define REG_CAMDBG_8723B 0x067C
+#define REG_SECCFG_8723B 0x0680
+
+/* Power */
+#define REG_WOW_CTRL_8723B 0x0690
+#define REG_PS_RX_INFO_8723B 0x0692
+#define REG_UAPSD_TID_8723B 0x0693
+#define REG_WKFMCAM_CMD_8723B 0x0698
+#define REG_WKFMCAM_NUM_8723B 0x0698
+#define REG_WKFMCAM_RWD_8723B 0x069C
+#define REG_RXFLTMAP0_8723B 0x06A0
+#define REG_RXFLTMAP1_8723B 0x06A2
+#define REG_RXFLTMAP2_8723B 0x06A4
+#define REG_BCN_PSR_RPT_8723B 0x06A8
+#define REG_BT_COEX_TABLE_8723B 0x06C0
+#define REG_BFMER0_INFO_8723B 0x06E4
+#define REG_BFMER1_INFO_8723B 0x06EC
+#define REG_CSI_RPT_PARAM_BW20_8723B 0x06F4
+#define REG_CSI_RPT_PARAM_BW40_8723B 0x06F8
+#define REG_CSI_RPT_PARAM_BW80_8723B 0x06FC
+
+/* Hardware Port 2 */
+#define REG_MACID1_8723B 0x0700
+#define REG_BSSID1_8723B 0x0708
+#define REG_BFMEE_SEL_8723B 0x0714
+#define REG_SND_PTCL_CTRL_8723B 0x0718
+
+
+/* Redifine 8192C register definition for compatibility */
+
+/* TODO: use these definition when using REG_xxx naming rule. */
+/* NOTE: DO NOT Remove these definition. Use later. */
+#define EFUSE_CTRL_8723B REG_EFUSE_CTRL_8723B /* E-Fuse Control. */
+#define EFUSE_TEST_8723B REG_EFUSE_TEST_8723B /* E-Fuse Test. */
+#define MSR_8723B (REG_CR_8723B + 2) /* Media Status register */
#define ISR_8723B REG_HISR0_8723B
-#define TSFR_8723B REG_TSFTR_8723B /* Timing Sync Function Timer Register. */
+#define TSFR_8723B REG_TSFTR_8723B /* Timing Sync Function Timer Register. */
#define PBP_8723B REG_PBP_8723B
-/* Redifine MACID register, to compatible prior ICs. */
-#define IDR0_8723B REG_MACID_8723B /* MAC ID Register, Offset 0x0050-0x0053 */
-#define IDR4_8723B (REG_MACID_8723B + 4) /* MAC ID Register, Offset 0x0054-0x0055 */
+/* Redifine MACID register, to compatible prior ICs. */
+#define IDR0_8723B REG_MACID_8723B /* MAC ID Register, Offset 0x0050-0x0053 */
+#define IDR4_8723B (REG_MACID_8723B + 4) /* MAC ID Register, Offset 0x0054-0x0055 */
/* 9. Security Control Registers (Offset:) */
#define RWCAM_8723B REG_CAMCMD_8723B /* IN 8190 Data Sheet is called CAMcmd */
-#define WCAMI_8723B REG_CAMWRITE_8723B /* Software write CAM input content */
-#define RCAMO_8723B REG_CAMREAD_8723B /* Software read/write CAM config */
+#define WCAMI_8723B REG_CAMWRITE_8723B /* Software write CAM input content */
+#define RCAMO_8723B REG_CAMREAD_8723B /* Software read/write CAM config */
#define CAMDBG_8723B REG_CAMDBG_8723B
#define SECR_8723B REG_SECCFG_8723B /* Security Configuration Register */
-/* 8195 IMR/ISR bits (offset 0xB0, 8bits) */
-#define IMR_DISABLED_8723B 0
-/* IMR DW0(0x00B0-00B3) Bit 0-31 */
-#define IMR_TIMER2_8723B BIT31 /* Timeout interrupt 2 */
-#define IMR_TIMER1_8723B BIT30 /* Timeout interrupt 1 */
-#define IMR_PSTIMEOUT_8723B BIT29 /* Power Save Time Out Interrupt */
-#define IMR_GTINT4_8723B BIT28 /* When GTIMER4 expires, this bit is set to 1 */
-#define IMR_GTINT3_8723B BIT27 /* When GTIMER3 expires, this bit is set to 1 */
-#define IMR_TXBCN0ERR_8723B BIT26 /* Transmit Beacon0 Error */
-#define IMR_TXBCN0OK_8723B BIT25 /* Transmit Beacon0 OK */
-#define IMR_TSF_BIT32_TOGGLE_8723B BIT24 /* TSF Timer BIT32 toggle indication interrupt */
-#define IMR_BCNDMAINT0_8723B BIT20 /* Beacon DMA Interrupt 0 */
-#define IMR_BCNDERR0_8723B BIT16 /* Beacon Queue DMA OK0 */
-#define IMR_HSISR_IND_ON_INT_8723B BIT15 /* HSISR Indicator (HSIMR & HSISR is true, this bit is set to 1) */
-#define IMR_BCNDMAINT_E_8723B BIT14 /* Beacon DMA Interrupt Extension for Win7 */
-#define IMR_ATIMEND_8723B BIT12 /* CTWidnow End or ATIM Window End */
-#define IMR_C2HCMD_8723B BIT10 /* CPU to Host Command INT Status, Write 1 clear */
-#define IMR_CPWM2_8723B BIT9 /* CPU power Mode exchange INT Status, Write 1 clear */
-#define IMR_CPWM_8723B BIT8 /* CPU power Mode exchange INT Status, Write 1 clear */
-#define IMR_HIGHDOK_8723B BIT7 /* High Queue DMA OK */
-#define IMR_MGNTDOK_8723B BIT6 /* Management Queue DMA OK */
-#define IMR_BKDOK_8723B BIT5 /* AC_BK DMA OK */
-#define IMR_BEDOK_8723B BIT4 /* AC_BE DMA OK */
-#define IMR_VIDOK_8723B BIT3 /* AC_VI DMA OK */
-#define IMR_VODOK_8723B BIT2 /* AC_VO DMA OK */
-#define IMR_RDU_8723B BIT1 /* Rx Descriptor Unavailable */
-#define IMR_ROK_8723B BIT0 /* Receive DMA OK */
-
-/* IMR DW1(0x00B4-00B7) Bit 0-31 */
-#define IMR_BCNDMAINT7_8723B BIT27 /* Beacon DMA Interrupt 7 */
-#define IMR_BCNDMAINT6_8723B BIT26 /* Beacon DMA Interrupt 6 */
-#define IMR_BCNDMAINT5_8723B BIT25 /* Beacon DMA Interrupt 5 */
-#define IMR_BCNDMAINT4_8723B BIT24 /* Beacon DMA Interrupt 4 */
-#define IMR_BCNDMAINT3_8723B BIT23 /* Beacon DMA Interrupt 3 */
-#define IMR_BCNDMAINT2_8723B BIT22 /* Beacon DMA Interrupt 2 */
-#define IMR_BCNDMAINT1_8723B BIT21 /* Beacon DMA Interrupt 1 */
-#define IMR_BCNDOK7_8723B BIT20 /* Beacon Queue DMA OK Interrupt 7 */
-#define IMR_BCNDOK6_8723B BIT19 /* Beacon Queue DMA OK Interrupt 6 */
-#define IMR_BCNDOK5_8723B BIT18 /* Beacon Queue DMA OK Interrupt 5 */
-#define IMR_BCNDOK4_8723B BIT17 /* Beacon Queue DMA OK Interrupt 4 */
-#define IMR_BCNDOK3_8723B BIT16 /* Beacon Queue DMA OK Interrupt 3 */
-#define IMR_BCNDOK2_8723B BIT15 /* Beacon Queue DMA OK Interrupt 2 */
-#define IMR_BCNDOK1_8723B BIT14 /* Beacon Queue DMA OK Interrupt 1 */
-#define IMR_ATIMEND_E_8723B BIT13 /* ATIM Window End Extension for Win7 */
-#define IMR_TXERR_8723B BIT11 /* Tx Error Flag Interrupt Status, write 1 clear. */
-#define IMR_RXERR_8723B BIT10 /* Rx Error Flag INT Status, Write 1 clear */
-#define IMR_TXFOVW_8723B BIT9 /* Transmit FIFO Overflow */
-#define IMR_RXFOVW_8723B BIT8 /* Receive FIFO Overflow */
+/* 8195 IMR/ISR bits (offset 0xB0, 8bits) */
+#define IMR_DISABLED_8723B 0
+/* IMR DW0(0x00B0-00B3) Bit 0-31 */
+#define IMR_TIMER2_8723B BIT31 /* Timeout interrupt 2 */
+#define IMR_TIMER1_8723B BIT30 /* Timeout interrupt 1 */
+#define IMR_PSTIMEOUT_8723B BIT29 /* Power Save Time Out Interrupt */
+#define IMR_GTINT4_8723B BIT28 /* When GTIMER4 expires, this bit is set to 1 */
+#define IMR_GTINT3_8723B BIT27 /* When GTIMER3 expires, this bit is set to 1 */
+#define IMR_TXBCN0ERR_8723B BIT26 /* Transmit Beacon0 Error */
+#define IMR_TXBCN0OK_8723B BIT25 /* Transmit Beacon0 OK */
+#define IMR_TSF_BIT32_TOGGLE_8723B BIT24 /* TSF Timer BIT32 toggle indication interrupt */
+#define IMR_BCNDMAINT0_8723B BIT20 /* Beacon DMA Interrupt 0 */
+#define IMR_BCNDERR0_8723B BIT16 /* Beacon Queue DMA OK0 */
+#define IMR_HSISR_IND_ON_INT_8723B BIT15 /* HSISR Indicator (HSIMR & HSISR is true, this bit is set to 1) */
+#define IMR_BCNDMAINT_E_8723B BIT14 /* Beacon DMA Interrupt Extension for Win7 */
+#define IMR_ATIMEND_8723B BIT12 /* CTWidnow End or ATIM Window End */
+#define IMR_C2HCMD_8723B BIT10 /* CPU to Host Command INT Status, Write 1 clear */
+#define IMR_CPWM2_8723B BIT9 /* CPU power Mode exchange INT Status, Write 1 clear */
+#define IMR_CPWM_8723B BIT8 /* CPU power Mode exchange INT Status, Write 1 clear */
+#define IMR_HIGHDOK_8723B BIT7 /* High Queue DMA OK */
+#define IMR_MGNTDOK_8723B BIT6 /* Management Queue DMA OK */
+#define IMR_BKDOK_8723B BIT5 /* AC_BK DMA OK */
+#define IMR_BEDOK_8723B BIT4 /* AC_BE DMA OK */
+#define IMR_VIDOK_8723B BIT3 /* AC_VI DMA OK */
+#define IMR_VODOK_8723B BIT2 /* AC_VO DMA OK */
+#define IMR_RDU_8723B BIT1 /* Rx Descriptor Unavailable */
+#define IMR_ROK_8723B BIT0 /* Receive DMA OK */
+
+/* IMR DW1(0x00B4-00B7) Bit 0-31 */
+#define IMR_BCNDMAINT7_8723B BIT27 /* Beacon DMA Interrupt 7 */
+#define IMR_BCNDMAINT6_8723B BIT26 /* Beacon DMA Interrupt 6 */
+#define IMR_BCNDMAINT5_8723B BIT25 /* Beacon DMA Interrupt 5 */
+#define IMR_BCNDMAINT4_8723B BIT24 /* Beacon DMA Interrupt 4 */
+#define IMR_BCNDMAINT3_8723B BIT23 /* Beacon DMA Interrupt 3 */
+#define IMR_BCNDMAINT2_8723B BIT22 /* Beacon DMA Interrupt 2 */
+#define IMR_BCNDMAINT1_8723B BIT21 /* Beacon DMA Interrupt 1 */
+#define IMR_BCNDOK7_8723B BIT20 /* Beacon Queue DMA OK Interrupt 7 */
+#define IMR_BCNDOK6_8723B BIT19 /* Beacon Queue DMA OK Interrupt 6 */
+#define IMR_BCNDOK5_8723B BIT18 /* Beacon Queue DMA OK Interrupt 5 */
+#define IMR_BCNDOK4_8723B BIT17 /* Beacon Queue DMA OK Interrupt 4 */
+#define IMR_BCNDOK3_8723B BIT16 /* Beacon Queue DMA OK Interrupt 3 */
+#define IMR_BCNDOK2_8723B BIT15 /* Beacon Queue DMA OK Interrupt 2 */
+#define IMR_BCNDOK1_8723B BIT14 /* Beacon Queue DMA OK Interrupt 1 */
+#define IMR_ATIMEND_E_8723B BIT13 /* ATIM Window End Extension for Win7 */
+#define IMR_TXERR_8723B BIT11 /* Tx Error Flag Interrupt Status, write 1 clear. */
+#define IMR_RXERR_8723B BIT10 /* Rx Error Flag INT Status, Write 1 clear */
+#define IMR_TXFOVW_8723B BIT9 /* Transmit FIFO Overflow */
+#define IMR_RXFOVW_8723B BIT8 /* Receive FIFO Overflow */
/* 2 ACMHWCTRL 0x05C0 */
#define AcmHw_HwEn_8723B BIT(0)
@@ -437,7 +437,7 @@
#define AcmHw_ViqStatus_8723B BIT(6)
#define AcmHw_BeqStatus_8723B BIT(7)
-/* 8195 (RCR) Receive Configuration Register (Offset 0x608, 32 bits) */
-#define RCR_TCPOFLD_EN BIT25 /* Enable TCP checksum offload */
+/* 8195 (RCR) Receive Configuration Register (Offset 0x608, 32 bits) */
+#define RCR_TCPOFLD_EN BIT25 /* Enable TCP checksum offload */
-#endif /* #ifndef __INC_HAL8723BREG_H */
+#endif /* #ifndef __INC_HAL8723BREG_H */
--
2.30.2
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] Correct indentation in Hal8723BReg.h
2021-04-06 2:08 [PATCH] Correct indentation in Hal8723BReg.h Fabio M. De Francesco
@ 2021-04-06 5:12 ` Greg KH
2021-04-06 5:52 ` Fabio M. De Francesco
0 siblings, 1 reply; 13+ messages in thread
From: Greg KH @ 2021-04-06 5:12 UTC (permalink / raw)
To: Fabio M. De Francesco; +Cc: outreachy-kernel
On Tue, Apr 06, 2021 at 04:08:15AM +0200, Fabio M. De Francesco wrote:
> Correct indentation issues of many #define and comments in Hal8723BReg.h
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 604 ++++++++++----------
> 1 file changed, 302 insertions(+), 302 deletions(-)
You forgot to cc: all of the needed mailing lists. And your subject
line needs some work. But the biggest issue is that I do not understand
what this patch does at all. What is wrong with the original code here
that required you to "correct" it?
confused,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] Correct indentation in Hal8723BReg.h
2021-04-06 5:12 ` Greg KH
@ 2021-04-06 5:52 ` Fabio M. De Francesco
2021-04-06 6:00 ` Fabio M. De Francesco
2021-04-06 6:43 ` Julia Lawall
0 siblings, 2 replies; 13+ messages in thread
From: Fabio M. De Francesco @ 2021-04-06 5:52 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
On Tuesday, April 6, 2021 7:12:20 AM CEST Greg KH wrote:
> On Tue, Apr 06, 2021 at 04:08:15AM +0200, Fabio M. De Francesco wrote:
> > Correct indentation issues of many #define and comments in Hal8723BReg.h
> >
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> > drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 604 ++++++++++----------
> > 1 file changed, 302 insertions(+), 302 deletions(-)
>
> You forgot to cc: all of the needed mailing lists. And your subject
> line needs some work. But the biggest issue is that I do not understand
> what this patch does at all. What is wrong with the original code here
> that required you to "correct" it?
>
> confused,
>
> greg k-h
>
I'm sorry that I forgot to cc linux-staging and linux-kernel mailing lists
and for the subject I had already sent a v2 patch that had
all the required tags (staging: rtl8723: hal:).
I think that what was wrong with the original code was that
the #define values were far from the symbols with random indentation.
For example, I changed something like:
#define SYMB1 0123
#define SYMB2 5678
#define SYMB3 9ABC
to:
#define SYMB1 0123
#define SYMB2 5678
#define SYMB3 9ABC
Notwithstanding checkpatch does not comply about that, I suppose that
my correction improves readibility. Isn't it?
Unfortunately, English is not my native language. I hope I have been able
to explain my point of view to you. If you agree, I'd prepare a v3 of the patch
for the purpose of explaining with higher detail what I've done and why.
I'm looking forward to reading from you.
Thanks for your time,
Fabio
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] Correct indentation in Hal8723BReg.h
2021-04-06 5:52 ` Fabio M. De Francesco
@ 2021-04-06 6:00 ` Fabio M. De Francesco
2021-04-06 6:40 ` [Outreachy kernel] " Julia Lawall
2021-04-06 6:43 ` Julia Lawall
1 sibling, 1 reply; 13+ messages in thread
From: Fabio M. De Francesco @ 2021-04-06 6:00 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
On Tuesday, April 6, 2021 7:52:52 AM CEST Fabio M. De Francesco wrote:
> On Tuesday, April 6, 2021 7:12:20 AM CEST Greg KH wrote:
> > On Tue, Apr 06, 2021 at 04:08:15AM +0200, Fabio M. De Francesco wrote:
> > > Correct indentation issues of many #define and comments in Hal8723BReg.h
> > >
> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > ---
> > > drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 604 ++++++++++----------
> > > 1 file changed, 302 insertions(+), 302 deletions(-)
> >
> > You forgot to cc: all of the needed mailing lists. And your subject
> > line needs some work. But the biggest issue is that I do not understand
> > what this patch does at all. What is wrong with the original code here
> > that required you to "correct" it?
> >
> > confused,
> >
> > greg k-h
> >
> I'm sorry that I forgot to cc linux-staging and linux-kernel mailing lists
> and for the subject I had already sent a v2 patch that had
> all the required tags (staging: rtl8723: hal:).
>
> I think that what was wrong with the original code was that
> the #define values were far from the symbols with random indentation.
>
> For example, I changed something like:
> #define SYMB1 0123
> #define SYMB2 5678
> #define SYMB3 9ABC
>
> to:
> #define SYMB1 0123
> #define SYMB2 5678
> #define SYMB3 9ABC
the preceding defined values are in a single column. I don't understand why KMail show them in different levels of indentation. However, I hope that my argument in support of the patch was still clear.
Thanks,
Fabio
>
> Notwithstanding checkpatch does not comply about that, I suppose that
> my correction improves readibility. Isn't it?
>
> Unfortunately, English is not my native language. I hope I have been able
> to explain my point of view to you. If you agree, I'd prepare a v3 of the patch
> for the purpose of explaining with higher detail what I've done and why.
>
> I'm looking forward to reading from you.
>
> Thanks for your time,
>
> Fabio
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Correct indentation in Hal8723BReg.h
2021-04-06 6:00 ` Fabio M. De Francesco
@ 2021-04-06 6:40 ` Julia Lawall
2021-04-06 7:08 ` Fabio M. De Francesco
0 siblings, 1 reply; 13+ messages in thread
From: Julia Lawall @ 2021-04-06 6:40 UTC (permalink / raw)
To: Fabio M. De Francesco; +Cc: Greg KH, outreachy-kernel
On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
> On Tuesday, April 6, 2021 7:52:52 AM CEST Fabio M. De Francesco wrote:
> > On Tuesday, April 6, 2021 7:12:20 AM CEST Greg KH wrote:
> > > On Tue, Apr 06, 2021 at 04:08:15AM +0200, Fabio M. De Francesco wrote:
> > > > Correct indentation issues of many #define and comments in Hal8723BReg.h
> > > >
> > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > > ---
> > > > drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 604 ++++++++++----------
> > > > 1 file changed, 302 insertions(+), 302 deletions(-)
> > >
> > > You forgot to cc: all of the needed mailing lists. And your subject
> > > line needs some work. But the biggest issue is that I do not understand
> > > what this patch does at all. What is wrong with the original code here
> > > that required you to "correct" it?
> > >
> > > confused,
> > >
> > > greg k-h
> > >
> > I'm sorry that I forgot to cc linux-staging and linux-kernel mailing lists
> > and for the subject I had already sent a v2 patch that had
> > all the required tags (staging: rtl8723: hal:).
> >
> > I think that what was wrong with the original code was that
> > the #define values were far from the symbols with random indentation.
> >
> > For example, I changed something like:
> > #define SYMB1 0123
> > #define SYMB2 5678
> > #define SYMB3 9ABC
> >
> > to:
> > #define SYMB1 0123
> > #define SYMB2 5678
> > #define SYMB3 9ABC
>
> the preceding defined values are in a single column. I don't understand why KMail show them in different levels of indentation. However, I hope that my argument in support of the patch was still clear.
There is surely a difference with the use of spaces and tabs. If you
change something about the defines and this problem shows up, you can make
another patch in the series to make the spacing more uniform.
julia
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Correct indentation in Hal8723BReg.h
2021-04-06 6:40 ` [Outreachy kernel] " Julia Lawall
@ 2021-04-06 7:08 ` Fabio M. De Francesco
2021-04-06 7:22 ` Greg KH
2021-04-06 7:27 ` Julia Lawall
0 siblings, 2 replies; 13+ messages in thread
From: Fabio M. De Francesco @ 2021-04-06 7:08 UTC (permalink / raw)
To: Julia Lawall; +Cc: Greg KH, outreachy-kernel
On Tuesday, April 6, 2021 8:40:37 AM CEST Julia Lawall wrote:
>
> On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
>
> > On Tuesday, April 6, 2021 7:52:52 AM CEST Fabio M. De Francesco wrote:
> > > On Tuesday, April 6, 2021 7:12:20 AM CEST Greg KH wrote:
> > > > On Tue, Apr 06, 2021 at 04:08:15AM +0200, Fabio M. De Francesco wrote:
> > > > > Correct indentation issues of many #define and comments in Hal8723BReg.h
> > > > >
> > > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > > > ---
> > > > > drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 604 ++++++++++----------
> > > > > 1 file changed, 302 insertions(+), 302 deletions(-)
> > > >
> > > > You forgot to cc: all of the needed mailing lists. And your subject
> > > > line needs some work. But the biggest issue is that I do not understand
> > > > what this patch does at all. What is wrong with the original code here
> > > > that required you to "correct" it?
> > > >
> > > > confused,
> > > >
> > > > greg k-h
> > > >
> > > I'm sorry that I forgot to cc linux-staging and linux-kernel mailing lists
> > > and for the subject I had already sent a v2 patch that had
> > > all the required tags (staging: rtl8723: hal:).
> > >
> > > I think that what was wrong with the original code was that
> > > the #define values were far from the symbols with random indentation.
> > >
> > > For example, I changed something like:
> > > #define SYMB1 0123
> > > #define SYMB2 5678
> > > #define SYMB3 9ABC
> > >
> > > to:
> > > #define SYMB1 0123
> > > #define SYMB2 5678
> > > #define SYMB3 9ABC
> >
> > the preceding defined values are in a single column. I don't understand why KMail show them in different levels of indentation. However, I hope that my argument in support of the patch was still clear.
>
> There is surely a difference with the use of spaces and tabs. If you
> change something about the defines and this problem shows up, you can make
> another patch in the series to make the spacing more uniform.
>
> julia
>
I have not this problem in the file in my git/kernels/staging directory, it just happen when I see that patch in KMail. When I open it with Vim, all the defines are correctly aligned in a single column (that is, the correction I made to the indentation levels of the defines is there). As a consequense, I suppose that the patch itself is correctly formatted. Doesn't it?
However, what is really important is what Greg K-H thinks of the patch. I'm not sure I was able to explain to him what I've made and why it improves the readibility of the whole file (may you please take a look at the original in Greg's tree? You would see that random levels of indentation I'm talking about). As you can read above, I asked him if I should make a v3 of that with a clearer explanation about the work I've made on those random levels of indentation but I haven't yet had his response.
What do you personally think about producing a v3 patch with a better explanation of the work I've made?
Thanks for your time and patience,
Fabio
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Correct indentation in Hal8723BReg.h
2021-04-06 7:08 ` Fabio M. De Francesco
@ 2021-04-06 7:22 ` Greg KH
2021-04-06 7:27 ` Julia Lawall
1 sibling, 0 replies; 13+ messages in thread
From: Greg KH @ 2021-04-06 7:22 UTC (permalink / raw)
To: Fabio M. De Francesco; +Cc: Julia Lawall, outreachy-kernel
On Tue, Apr 06, 2021 at 09:08:21AM +0200, Fabio M. De Francesco wrote:
> On Tuesday, April 6, 2021 8:40:37 AM CEST Julia Lawall wrote:
> >
> > On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
> >
> > > On Tuesday, April 6, 2021 7:52:52 AM CEST Fabio M. De Francesco wrote:
> > > > On Tuesday, April 6, 2021 7:12:20 AM CEST Greg KH wrote:
> > > > > On Tue, Apr 06, 2021 at 04:08:15AM +0200, Fabio M. De Francesco wrote:
> > > > > > Correct indentation issues of many #define and comments in Hal8723BReg.h
> > > > > >
> > > > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > > > > ---
> > > > > > drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 604 ++++++++++----------
> > > > > > 1 file changed, 302 insertions(+), 302 deletions(-)
> > > > >
> > > > > You forgot to cc: all of the needed mailing lists. And your subject
> > > > > line needs some work. But the biggest issue is that I do not understand
> > > > > what this patch does at all. What is wrong with the original code here
> > > > > that required you to "correct" it?
> > > > >
> > > > > confused,
> > > > >
> > > > > greg k-h
> > > > >
> > > > I'm sorry that I forgot to cc linux-staging and linux-kernel mailing lists
> > > > and for the subject I had already sent a v2 patch that had
> > > > all the required tags (staging: rtl8723: hal:).
> > > >
> > > > I think that what was wrong with the original code was that
> > > > the #define values were far from the symbols with random indentation.
> > > >
> > > > For example, I changed something like:
> > > > #define SYMB1 0123
> > > > #define SYMB2 5678
> > > > #define SYMB3 9ABC
> > > >
> > > > to:
> > > > #define SYMB1 0123
> > > > #define SYMB2 5678
> > > > #define SYMB3 9ABC
> > >
> > > the preceding defined values are in a single column. I don't understand why KMail show them in different levels of indentation. However, I hope that my argument in support of the patch was still clear.
> >
> > There is surely a difference with the use of spaces and tabs. If you
> > change something about the defines and this problem shows up, you can make
> > another patch in the series to make the spacing more uniform.
> >
> > julia
> >
> I have not this problem in the file in my git/kernels/staging directory, it just happen when I see that patch in KMail. When I open it with Vim, all the defines are correctly aligned in a single column (that is, the correction I made to the indentation levels of the defines is there). As a consequense, I suppose that the patch itself is correctly formatted. Doesn't it?
>
> However, what is really important is what Greg K-H thinks of the patch. I'm not sure I was able to explain to him what I've made and why it improves the readibility of the whole file (may you please take a look at the original in Greg's tree? You would see that random levels of indentation I'm talking about). As you can read above, I asked him if I should make a v3 of that with a clearer explanation about the work I've made on those random levels of indentation but I haven't yet had his response.
You need to explain what is wrong with the existing code and why your
change is needed to make it "better".
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Correct indentation in Hal8723BReg.h
2021-04-06 7:08 ` Fabio M. De Francesco
2021-04-06 7:22 ` Greg KH
@ 2021-04-06 7:27 ` Julia Lawall
2021-04-06 7:46 ` FMDF
1 sibling, 1 reply; 13+ messages in thread
From: Julia Lawall @ 2021-04-06 7:27 UTC (permalink / raw)
To: Fabio M. De Francesco; +Cc: Greg KH, outreachy-kernel
On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
> On Tuesday, April 6, 2021 8:40:37 AM CEST Julia Lawall wrote:
> >
> > On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
> >
> > > On Tuesday, April 6, 2021 7:52:52 AM CEST Fabio M. De Francesco wrote:
> > > > On Tuesday, April 6, 2021 7:12:20 AM CEST Greg KH wrote:
> > > > > On Tue, Apr 06, 2021 at 04:08:15AM +0200, Fabio M. De Francesco wrote:
> > > > > > Correct indentation issues of many #define and comments in Hal8723BReg.h
> > > > > >
> > > > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > > > > ---
> > > > > > drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 604 ++++++++++----------
> > > > > > 1 file changed, 302 insertions(+), 302 deletions(-)
> > > > >
> > > > > You forgot to cc: all of the needed mailing lists. And your subject
> > > > > line needs some work. But the biggest issue is that I do not understand
> > > > > what this patch does at all. What is wrong with the original code here
> > > > > that required you to "correct" it?
> > > > >
> > > > > confused,
> > > > >
> > > > > greg k-h
> > > > >
> > > > I'm sorry that I forgot to cc linux-staging and linux-kernel mailing lists
> > > > and for the subject I had already sent a v2 patch that had
> > > > all the required tags (staging: rtl8723: hal:).
> > > >
> > > > I think that what was wrong with the original code was that
> > > > the #define values were far from the symbols with random indentation.
> > > >
> > > > For example, I changed something like:
> > > > #define SYMB1 0123
> > > > #define SYMB2 5678
> > > > #define SYMB3 9ABC
> > > >
> > > > to:
> > > > #define SYMB1 0123
> > > > #define SYMB2 5678
> > > > #define SYMB3 9ABC
> > >
> > > the preceding defined values are in a single column. I don't understand why KMail show them in different levels of indentation. However, I hope that my argument in support of the patch was still clear.
> >
> > There is surely a difference with the use of spaces and tabs. If you
> > change something about the defines and this problem shows up, you can make
> > another patch in the series to make the spacing more uniform.
> >
> > julia
> >
> I have not this problem in the file in my git/kernels/staging directory,
Are you just looking at the file in your editor, or have you actually
counted the spaces and tabs?
julia
> it just happen when I see that patch in KMail. When I open it with Vim,
> all the defines are correctly aligned in a single column (that is, the
> correction I made to the indentation levels of the defines is there). As
> a consequense, I suppose that the patch itself is correctly formatted.
> Doesn't it?
>
> However, what is really important is what Greg K-H thinks of the patch. I'm not sure I was able to explain to him what I've made and why it improves the readibility of the whole file (may you please take a look at the original in Greg's tree? You would see that random levels of indentation I'm talking about). As you can read above, I asked him if I should make a v3 of that with a clearer explanation about the work I've made on those random levels of indentation but I haven't yet had his response.
>
> What do you personally think about producing a v3 patch with a better explanation of the work I've made?
>
> Thanks for your time and patience,
>
> Fabio
>
>
>
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Correct indentation in Hal8723BReg.h
2021-04-06 7:27 ` Julia Lawall
@ 2021-04-06 7:46 ` FMDF
2021-04-06 8:01 ` Julia Lawall
0 siblings, 1 reply; 13+ messages in thread
From: FMDF @ 2021-04-06 7:46 UTC (permalink / raw)
To: Julia Lawall; +Cc: Greg KH, outreachy-kernel
On Tue, Apr 6, 2021 at 9:27 AM Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
>
> On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
>
> > On Tuesday, April 6, 2021 8:40:37 AM CEST Julia Lawall wrote:
> > >
> > > On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
> > >
> > > > On Tuesday, April 6, 2021 7:52:52 AM CEST Fabio M. De Francesco wrote:
> > > > > On Tuesday, April 6, 2021 7:12:20 AM CEST Greg KH wrote:
> > > > > > On Tue, Apr 06, 2021 at 04:08:15AM +0200, Fabio M. De Francesco wrote:
> > > > > > > Correct indentation issues of many #define and comments in Hal8723BReg.h
> > > > > > >
> > > > > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > > > > > ---
> > > > > > > drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 604 ++++++++++----------
> > > > > > > 1 file changed, 302 insertions(+), 302 deletions(-)
> > > > > >
> > > > > > You forgot to cc: all of the needed mailing lists. And your subject
> > > > > > line needs some work. But the biggest issue is that I do not understand
> > > > > > what this patch does at all. What is wrong with the original code here
> > > > > > that required you to "correct" it?
> > > > > >
> > > > > > confused,
> > > > > >
> > > > > > greg k-h
> > > > > >
> > > > > I'm sorry that I forgot to cc linux-staging and linux-kernel mailing lists
> > > > > and for the subject I had already sent a v2 patch that had
> > > > > all the required tags (staging: rtl8723: hal:).
> > > > >
> > > > > I think that what was wrong with the original code was that
> > > > > the #define values were far from the symbols with random indentation.
> > > > >
> > > > > For example, I changed something like:
> > > > > #define SYMB1 0123
> > > > > #define SYMB2 5678
> > > > > #define SYMB3 9ABC
> > > > >
> > > > > to:
> > > > > #define SYMB1 0123
> > > > > #define SYMB2 5678
> > > > > #define SYMB3 9ABC
> > > >
> > > > the preceding defined values are in a single column. I don't understand why KMail show them in different levels of indentation. However, I hope that my argument in support of the patch was still clear.
> > >
> > > There is surely a difference with the use of spaces and tabs. If you
> > > change something about the defines and this problem shows up, you can make
> > > another patch in the series to make the spacing more uniform.
> > >
> > > julia
> > >
>
> > I have not this problem in the file in my git/kernels/staging directory,
>
> Are you just looking at the file in your editor, or have you actually
> counted the spaces and tabs?
>
> julia
I'm just looking at the file using Vim and all seems perfectly aligned, but now
I am not sure to understand what you mean about "counting the spaces and tabs".
However, what I did when I found lines with random indentation was:
1) to delete all the spaces and all the tabs that were placed between
the #define
directive and the defined value;
2) add a single space in order to separate
the value from the directive and two (8 character standard) tabs for align the
current value under the one of the previous line;
I'm preparing a v3 patch to explain what is wrong with the existing code
and why [I think] my change makes it better. Probably you've already seen
that Greg has responded asking just this.
Thanks a lot,
Fabio
>
> > it just happen when I see that patch in KMail. When I open it with Vim,
> > all the defines are correctly aligned in a single column (that is, the
> > correction I made to the indentation levels of the defines is there). As
> > a consequense, I suppose that the patch itself is correctly formatted.
> > Doesn't it?
> >
> > However, what is really important is what Greg K-H thinks of the patch. I'm not sure I was able to explain to him what I've made and why it improves the readibility of the whole file (may you please take a look at the original in Greg's tree? You would see that random levels of indentation I'm talking about). As you can read above, I asked him if I should make a v3 of that with a clearer explanation about the work I've made on those random levels of indentation but I haven't yet had his response.
> >
> > What do you personally think about producing a v3 patch with a better explanation of the work I've made?
> >
> > Thanks for your time and patience,
> >
> > Fabio
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Correct indentation in Hal8723BReg.h
2021-04-06 7:46 ` FMDF
@ 2021-04-06 8:01 ` Julia Lawall
2021-04-06 8:38 ` Fabio M. De Francesco
0 siblings, 1 reply; 13+ messages in thread
From: Julia Lawall @ 2021-04-06 8:01 UTC (permalink / raw)
To: FMDF; +Cc: Greg KH, outreachy-kernel
On Tue, 6 Apr 2021, FMDF wrote:
> On Tue, Apr 6, 2021 at 9:27 AM Julia Lawall <julia.lawall@inria.fr> wrote:
> >
> >
> >
> > On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
> >
> > > On Tuesday, April 6, 2021 8:40:37 AM CEST Julia Lawall wrote:
> > > >
> > > > On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
> > > >
> > > > > On Tuesday, April 6, 2021 7:52:52 AM CEST Fabio M. De Francesco wrote:
> > > > > > On Tuesday, April 6, 2021 7:12:20 AM CEST Greg KH wrote:
> > > > > > > On Tue, Apr 06, 2021 at 04:08:15AM +0200, Fabio M. De Francesco wrote:
> > > > > > > > Correct indentation issues of many #define and comments in Hal8723BReg.h
> > > > > > > >
> > > > > > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > > > > > > ---
> > > > > > > > drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 604 ++++++++++----------
> > > > > > > > 1 file changed, 302 insertions(+), 302 deletions(-)
> > > > > > >
> > > > > > > You forgot to cc: all of the needed mailing lists. And your subject
> > > > > > > line needs some work. But the biggest issue is that I do not understand
> > > > > > > what this patch does at all. What is wrong with the original code here
> > > > > > > that required you to "correct" it?
> > > > > > >
> > > > > > > confused,
> > > > > > >
> > > > > > > greg k-h
> > > > > > >
> > > > > > I'm sorry that I forgot to cc linux-staging and linux-kernel mailing lists
> > > > > > and for the subject I had already sent a v2 patch that had
> > > > > > all the required tags (staging: rtl8723: hal:).
> > > > > >
> > > > > > I think that what was wrong with the original code was that
> > > > > > the #define values were far from the symbols with random indentation.
> > > > > >
> > > > > > For example, I changed something like:
> > > > > > #define SYMB1 0123
> > > > > > #define SYMB2 5678
> > > > > > #define SYMB3 9ABC
> > > > > >
> > > > > > to:
> > > > > > #define SYMB1 0123
> > > > > > #define SYMB2 5678
> > > > > > #define SYMB3 9ABC
> > > > >
> > > > > the preceding defined values are in a single column. I don't understand why KMail show them in different levels of indentation. However, I hope that my argument in support of the patch was still clear.
> > > >
> > > > There is surely a difference with the use of spaces and tabs. If you
> > > > change something about the defines and this problem shows up, you can make
> > > > another patch in the series to make the spacing more uniform.
> > > >
> > > > julia
> > > >
> >
> > > I have not this problem in the file in my git/kernels/staging directory,
> >
> > Are you just looking at the file in your editor, or have you actually
> > counted the spaces and tabs?
> >
> > julia
>
> I'm just looking at the file using Vim and all seems perfectly aligned,
> but now
Some code may be
#define NAMEXXXXXXXX27
#define NAMET27
These may look the same in vim. That is 8 spaces = 1 tab (I realize that
this is a massive oversimplification :). If you start on the left and
move one space over at a time you will see the difference, because it will
move over the entire tab in one step.
When you turn the code into a patch, one space (or - or +) gets added to
the front of every line. If a tab is used in the middle of the line, this
will often have no effect on most of the line. If spaces are used, the
whole line will move over by one. Thus the code can look more unevenly
indented in the patch than in the original file.
But working with code is not about just looking at it, but also moving
from place to place in it to change things. One can move across tabs more
efficiently, so it could be nice that if the developer already started
using tabs sometime, then to use them all the time,.
julia
>
> I am not sure to understand what you mean about "counting the spaces and tabs".
>
> However, what I did when I found lines with random indentation was:
> 1) to delete all the spaces and all the tabs that were placed between
> the #define
> directive and the defined value;
> 2) add a single space in order to separate
> the value from the directive and two (8 character standard) tabs for align the
> current value under the one of the previous line;
>
> I'm preparing a v3 patch to explain what is wrong with the existing code
> and why [I think] my change makes it better. Probably you've already seen
> that Greg has responded asking just this.
>
> Thanks a lot,
>
> Fabio
>
> >
> > > it just happen when I see that patch in KMail. When I open it with Vim,
> > > all the defines are correctly aligned in a single column (that is, the
> > > correction I made to the indentation levels of the defines is there). As
> > > a consequense, I suppose that the patch itself is correctly formatted.
> > > Doesn't it?
> > >
> > > However, what is really important is what Greg K-H thinks of the patch. I'm not sure I was able to explain to him what I've made and why it improves the readibility of the whole file (may you please take a look at the original in Greg's tree? You would see that random levels of indentation I'm talking about). As you can read above, I asked him if I should make a v3 of that with a clearer explanation about the work I've made on those random levels of indentation but I haven't yet had his response.
> > >
> > > What do you personally think about producing a v3 patch with a better explanation of the work I've made?
> > >
> > > Thanks for your time and patience,
> > >
> > > Fabio
> > >
> > >
> > >
> > >
> > >
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAPj211vtzZDmwYomg9BBcZwPWxiiwD55%3DyEpcAXL2WgzGyvUDQ%40mail.gmail.com.
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Correct indentation in Hal8723BReg.h
2021-04-06 8:01 ` Julia Lawall
@ 2021-04-06 8:38 ` Fabio M. De Francesco
2021-04-06 8:44 ` Julia Lawall
0 siblings, 1 reply; 13+ messages in thread
From: Fabio M. De Francesco @ 2021-04-06 8:38 UTC (permalink / raw)
To: Julia Lawall; +Cc: Greg KH, outreachy-kernel
On Tuesday, April 6, 2021 10:01:55 AM CEST Julia Lawall wrote:
>
> On Tue, 6 Apr 2021, FMDF wrote:
>
> > On Tue, Apr 6, 2021 at 9:27 AM Julia Lawall <julia.lawall@inria.fr> wrote:
> > >
> > >
> > >
> > > On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
> > >
> > > > On Tuesday, April 6, 2021 8:40:37 AM CEST Julia Lawall wrote:
> > > > >
> > > > > On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
> > > > >
> > > > > > On Tuesday, April 6, 2021 7:52:52 AM CEST Fabio M. De Francesco wrote:
> > > > > > > On Tuesday, April 6, 2021 7:12:20 AM CEST Greg KH wrote:
> > > > > > > > On Tue, Apr 06, 2021 at 04:08:15AM +0200, Fabio M. De Francesco wrote:
> > > > > > > > > Correct indentation issues of many #define and comments in Hal8723BReg.h
> > > > > > > > >
> > > > > > > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > > > > > > > ---
> > > > > > > > > drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 604 ++++++++++----------
> > > > > > > > > 1 file changed, 302 insertions(+), 302 deletions(-)
> > > > > > > >
> > > > > > > > You forgot to cc: all of the needed mailing lists. And your subject
> > > > > > > > line needs some work. But the biggest issue is that I do not understand
> > > > > > > > what this patch does at all. What is wrong with the original code here
> > > > > > > > that required you to "correct" it?
> > > > > > > >
> > > > > > > > confused,
> > > > > > > >
> > > > > > > > greg k-h
> > > > > > > >
> > > > > > > I'm sorry that I forgot to cc linux-staging and linux-kernel mailing lists
> > > > > > > and for the subject I had already sent a v2 patch that had
> > > > > > > all the required tags (staging: rtl8723: hal:).
> > > > > > >
> > > > > > > I think that what was wrong with the original code was that
> > > > > > > the #define values were far from the symbols with random indentation.
> > > > > > >
> > > > > > > For example, I changed something like:
> > > > > > > #define SYMB1 0123
> > > > > > > #define SYMB2 5678
> > > > > > > #define SYMB3 9ABC
> > > > > > >
> > > > > > > to:
> > > > > > > #define SYMB1 0123
> > > > > > > #define SYMB2 5678
> > > > > > > #define SYMB3 9ABC
> > > > > >
> > > > > > the preceding defined values are in a single column. I don't understand why KMail show them in different levels of indentation. However, I hope that my argument in support of the patch was still clear.
> > > > >
> > > > > There is surely a difference with the use of spaces and tabs. If you
> > > > > change something about the defines and this problem shows up, you can make
> > > > > another patch in the series to make the spacing more uniform.
> > > > >
> > > > > julia
> > > > >
> > >
> > > > I have not this problem in the file in my git/kernels/staging directory,
> > >
> > > Are you just looking at the file in your editor, or have you actually
> > > counted the spaces and tabs?
> > >
> > > julia
> >
> > I'm just looking at the file using Vim and all seems perfectly aligned,
> > but now
>
> Some code may be
>
> #define NAMEXXXXXXXX27
> #define NAMET27
>
> These may look the same in vim. That is 8 spaces = 1 tab (I realize that
> this is a massive oversimplification :). If you start on the left and
> move one space over at a time you will see the difference, because it will
> move over the entire tab in one step.
>
> When you turn the code into a patch, one space (or - or +) gets added to
> the front of every line. If a tab is used in the middle of the line, this
> will often have no effect on most of the line. If spaces are used, the
> whole line will move over by one. Thus the code can look more unevenly
> indented in the patch than in the original file.
Ok, I understand that I have to be very careful when working with spaces and tabs because
they have different side effects on formatting patches, but...
How can developers check that the patches they are going to send with git are
properly indented? I mean, that the patches exactly represent what one sees in vim or in less?
Apart the patch we are talking about in this thread, there is more: checkpatch.pl emits
warnings when certain lines are not aligned with an open parenthesis of a previous
line. How to do proper alignment? Using +/- spaces to align can lead to strange results
(if I have understood what you wrote). How to make a good alignment without incurring
in undesired side effects that propagate in the resulting patch?
Thanks,
Fabio
>
> But working with code is not about just looking at it, but also moving
> from place to place in it to change things. One can move across tabs more
> efficiently, so it could be nice that if the developer already started
> using tabs sometime, then to use them all the time,.
>
> julia
>
> >
> > I am not sure to understand what you mean about "counting the spaces and tabs".
> >
> > However, what I did when I found lines with random indentation was:
> > 1) to delete all the spaces and all the tabs that were placed between
> > the #define
> > directive and the defined value;
> > 2) add a single space in order to separate
> > the value from the directive and two (8 character standard) tabs for align the
> > current value under the one of the previous line;
> >
> > I'm preparing a v3 patch to explain what is wrong with the existing code
> > and why [I think] my change makes it better. Probably you've already seen
> > that Greg has responded asking just this.
> >
> > Thanks a lot,
> >
> > Fabio
> >
> > >
> > > > it just happen when I see that patch in KMail. When I open it with Vim,
> > > > all the defines are correctly aligned in a single column (that is, the
> > > > correction I made to the indentation levels of the defines is there). As
> > > > a consequense, I suppose that the patch itself is correctly formatted.
> > > > Doesn't it?
> > > >
> > > > However, what is really important is what Greg K-H thinks of the patch. I'm not sure I was able to explain to him what I've made and why it improves the readibility of the whole file (may you please take a look at the original in Greg's tree? You would see that random levels of indentation I'm talking about). As you can read above, I asked him if I should make a v3 of that with a clearer explanation about the work I've made on those random levels of indentation but I haven't yet had his response.
> > > >
> > > > What do you personally think about producing a v3 patch with a better explanation of the work I've made?
> > > >
> > > > Thanks for your time and patience,
> > > >
> > > > Fabio
> > > >
> > > >
> > > >
> > > >
> > > >
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAPj211vtzZDmwYomg9BBcZwPWxiiwD55%3DyEpcAXL2WgzGyvUDQ%40mail.gmail.com.
> >
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Correct indentation in Hal8723BReg.h
2021-04-06 8:38 ` Fabio M. De Francesco
@ 2021-04-06 8:44 ` Julia Lawall
0 siblings, 0 replies; 13+ messages in thread
From: Julia Lawall @ 2021-04-06 8:44 UTC (permalink / raw)
To: Fabio M. De Francesco; +Cc: Greg KH, outreachy-kernel
> Ok, I understand that I have to be very careful when working with spaces and tabs because
> they have different side effects on formatting patches, but...
> How can developers check that the patches they are going to send with git are
> properly indented? I mean, that the patches exactly represent what one sees in vim or in less?
>
> Apart the patch we are talking about in this thread, there is more: checkpatch.pl emits
> warnings when certain lines are not aligned with an open parenthesis of a previous
> line. How to do proper alignment? Using +/- spaces to align can lead to strange results
> (if I have understood what you wrote). How to make a good alignment without incurring
> in undesired side effects that propagate in the resulting patch?
The patch doesn't really matter. What matters is the actual code. But
what matters is the actual characters in that code, not what you see on
the screen. Generally, if everything is done consistently, then
everything will be consistent after it has been pushed over by one space
to create the patch, even though it may look different than the original.
But what matters is the consistency.
julia
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Correct indentation in Hal8723BReg.h
2021-04-06 5:52 ` Fabio M. De Francesco
2021-04-06 6:00 ` Fabio M. De Francesco
@ 2021-04-06 6:43 ` Julia Lawall
1 sibling, 0 replies; 13+ messages in thread
From: Julia Lawall @ 2021-04-06 6:43 UTC (permalink / raw)
To: Fabio M. De Francesco; +Cc: Greg KH, outreachy-kernel
> Unfortunately, English is not my native language. I hope I have been able
> to explain my point of view to you. If you agree, I'd prepare a v3 of the patch
> for the purpose of explaining with higher detail what I've done and why.
Don't worry about your English ability. The point is to learn about what
kind of information the person reading the patch wants to see to
understand it efficiently, and that is someone that everyone has to learn.
julia
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-04-06 8:44 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 2:08 [PATCH] Correct indentation in Hal8723BReg.h Fabio M. De Francesco
2021-04-06 5:12 ` Greg KH
2021-04-06 5:52 ` Fabio M. De Francesco
2021-04-06 6:00 ` Fabio M. De Francesco
2021-04-06 6:40 ` [Outreachy kernel] " Julia Lawall
2021-04-06 7:08 ` Fabio M. De Francesco
2021-04-06 7:22 ` Greg KH
2021-04-06 7:27 ` Julia Lawall
2021-04-06 7:46 ` FMDF
2021-04-06 8:01 ` Julia Lawall
2021-04-06 8:38 ` Fabio M. De Francesco
2021-04-06 8:44 ` Julia Lawall
2021-04-06 6:43 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.