[PATCH] scsi: ufs: fix itnull.cocci warnings

[PATCH] scsi: ufs: fix itnull.cocci warnings

[Julia Lawall]

From: kernel test robot <lkp@intel.com>

list_for_each_entry binds rgn to an entry, which cannot be NULL.  So
remove the first test.

Generated by: scripts/coccinelle/iterators/itnull.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://github.com/bvanassche/linux ufs-for-next
head:   b93e987f91a0c037fc4357107f5144110cd84d08
commit: b93e987f91a0c037fc4357107f5144110cd84d08 [324/324] scsi: ufs: Split the drivers/scsi/ufs directory
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/scsi/ufs-core/ufshpb.c |    6 ------
 1 file changed, 6 deletions(-)

--- a/drivers/scsi/ufs-core/ufshpb.c
+++ b/drivers/scsi/ufs-core/ufshpb.c
@@ -875,12 +875,6 @@ static struct ufshpb_region *ufshpb_vict
 	struct ufshpb_region *rgn, *victim_rgn = NULL;

 	list_for_each_entry(rgn, &lru_info->lh_lru_rgn, list_lru_rgn) {
-		if (!rgn) {
-			dev_err(&hpb->sdev_ufs_lu->sdev_dev,
-				"%s: no region allocated\n",
-				__func__);
-			return NULL;
-		}
 		if (ufshpb_check_srgns_issue_state(hpb, rgn))
 			continue;

[PATCH] scsi: ufs: fix itnull.cocci warnings

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

From: kernel test robot <lkp@intel.com>

list_for_each_entry binds rgn to an entry, which cannot be NULL.  So
remove the first test.

Generated by: scripts/coccinelle/iterators/itnull.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://github.com/bvanassche/linux ufs-for-next
head:   b93e987f91a0c037fc4357107f5144110cd84d08
commit: b93e987f91a0c037fc4357107f5144110cd84d08 [324/324] scsi: ufs: Split the drivers/scsi/ufs directory
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/scsi/ufs-core/ufshpb.c |    6 ------
 1 file changed, 6 deletions(-)

--- a/drivers/scsi/ufs-core/ufshpb.c
+++ b/drivers/scsi/ufs-core/ufshpb.c
@@ -875,12 +875,6 @@ static struct ufshpb_region *ufshpb_vict
 	struct ufshpb_region *rgn, *victim_rgn = NULL;

 	list_for_each_entry(rgn, &lru_info->lh_lru_rgn, list_lru_rgn) {
-		if (!rgn) {
-			dev_err(&hpb->sdev_ufs_lu->sdev_dev,
-				"%s: no region allocated\n",
-				__func__);
-			return NULL;
-		}
 		if (ufshpb_check_srgns_issue_state(hpb, rgn))
 			continue;

[PATCH] scsi: ufs: fix itnull.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1718 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Bart Van Assche <bvanassche@acm.org>

From: kernel test robot <lkp@intel.com>

drivers/scsi/ufs-core/ufshpb.c:878:7-10: ERROR: iterator variable bound on line 877 cannot be NULL

 Many iterators have the property that the first argument is always bound
 to a real list element, never NULL.

Semantic patch information:
 False positives arise for some iterators that do not have this property,
 or in cases when the loop cursor is reassigned.  The latter should only
 happen when the matched code is on the way to a loop exit (break, goto,
 or return).

Generated by: scripts/coccinelle/iterators/itnull.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/bvanassche/linux ufs-for-next
head:   b93e987f91a0c037fc4357107f5144110cd84d08
commit: b93e987f91a0c037fc4357107f5144110cd84d08 [324/324] scsi: ufs: Split the drivers/scsi/ufs directory
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/scsi/ufs-core/ufshpb.c |    6 ------
 1 file changed, 6 deletions(-)

--- a/drivers/scsi/ufs-core/ufshpb.c
+++ b/drivers/scsi/ufs-core/ufshpb.c
@@ -875,12 +875,6 @@ static struct ufshpb_region *ufshpb_vict
 	struct ufshpb_region *rgn, *victim_rgn = NULL;
 
 	list_for_each_entry(rgn, &lru_info->lh_lru_rgn, list_lru_rgn) {
-		if (!rgn) {
-			dev_err(&hpb->sdev_ufs_lu->sdev_dev,
-				"%s: no region allocated\n",
-				__func__);
-			return NULL;
-		}
 		if (ufshpb_check_srgns_issue_state(hpb, rgn))
 			continue;
 

[PATCH] scsi: ufs: fix itnull.cocci warnings

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

From: kernel test robot <lkp@intel.com>

The entry should not be NULL, so drop the NULL test.

Generated by: scripts/coccinelle/iterators/itnull.cocci

CC: Daejun Park <daejun7.park@samsung.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

url:    https://github.com/0day-ci/linux/commits/Daejun-Park/scsi-ufs-Introduce-HPB-feature/20210428-155927
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
:::::: branch date: 18 hours ago
:::::: commit date: 18 hours ago

 ufshpb.c |    6 ------
 1 file changed, 6 deletions(-)

--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -403,12 +403,6 @@ static struct ufshpb_region *ufshpb_vict
 	struct ufshpb_region *rgn, *victim_rgn = NULL;

 	list_for_each_entry(rgn, &lru_info->lh_lru_rgn, list_lru_rgn) {
-		if (!rgn) {
-			dev_err(&hpb->sdev_ufs_lu->sdev_dev,
-				"%s: no region allocated\n",
-				__func__);
-			return NULL;
-		}
 		if (ufshpb_check_srgns_issue_state(hpb, rgn))
 			continue;

[PATCH] scsi: ufs: fix itnull.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2186 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210428075716epcms2p2b2f54411913a85d40735e061434ffaf5@epcms2p2>
References: <20210428075716epcms2p2b2f54411913a85d40735e061434ffaf5@epcms2p2>
TO: Daejun Park <daejun7.park@samsung.com>
TO: Daejun Park <daejun7.park@samsung.com>
TO: Greg KH <greg@kroah.com>
TO: "avri.altman" <avri.altman@wdc.com>
TO: jejb <jejb@linux.ibm.com>
TO: "martin.petersen" <martin.petersen@oracle.com>
TO: asutoshd <asutoshd@codeaurora.org>
TO: "stanley.chu" <stanley.chu@mediatek.com>
TO: cang <cang@codeaurora.org>
TO: bvanassche <bvanassche@acm.org>
TO: huobean <huobean@gmail.com>

From: kernel test robot <lkp@intel.com>

drivers/scsi/ufs/ufshpb.c:406:7-10: ERROR: iterator variable bound on line 405 cannot be NULL

 Many iterators have the property that the first argument is always bound
 to a real list element, never NULL.

Semantic patch information:
 False positives arise for some iterators that do not have this property,
 or in cases when the loop cursor is reassigned.  The latter should only
 happen when the matched code is on the way to a loop exit (break, goto,
 or return).

Generated by: scripts/coccinelle/iterators/itnull.cocci

CC: Daejun Park <daejun7.park@samsung.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Daejun-Park/scsi-ufs-Introduce-HPB-feature/20210428-155927
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
:::::: branch date: 18 hours ago
:::::: commit date: 18 hours ago

Please take the patch only if it's a positive warning. Thanks!

 ufshpb.c |    6 ------
 1 file changed, 6 deletions(-)

--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -403,12 +403,6 @@ static struct ufshpb_region *ufshpb_vict
 	struct ufshpb_region *rgn, *victim_rgn = NULL;
 
 	list_for_each_entry(rgn, &lru_info->lh_lru_rgn, list_lru_rgn) {
-		if (!rgn) {
-			dev_err(&hpb->sdev_ufs_lu->sdev_dev,
-				"%s: no region allocated\n",
-				__func__);
-			return NULL;
-		}
 		if (ufshpb_check_srgns_issue_state(hpb, rgn))
 			continue;