* [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel
@ 2022-07-25 17:44 Smith, Jackson
2022-07-27 0:17 ` Stefano Stabellini
0 siblings, 1 reply; 5+ messages in thread
From: Smith, Jackson @ 2022-07-25 17:44 UTC (permalink / raw)
To: Xen-devel; +Cc: Stefano Stabellini
Hi Stefano,
My colleague Jason Lei and I would like to submit a patch to imagebuilder.
It seems that generating a .fit with a true dom0less configuration fails because an extraneous comma is included in the its file.
We believe this change resolves the issue.
Thanks,
Jackson
-- >8 --
Remove extraneous comma in generated its file when no DOM0_KERNEL is specified.
diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
index 8f08cd6..6f94fce 100755
--- a/scripts/uboot-script-gen
+++ b/scripts/uboot-script-gen
@@ -676,7 +676,12 @@ create_its_file_xen()
i=$(( $i + 1 ))
continue
fi
- load_files+=", \"domU${i}_kernel\""
+ if test -z "$load_files"
+ then
+ load_files+="\"domU${i}_kernel\""
+ else
+ load_files+=", \"domU${i}_kernel\""
+ fi
cat >> "$its_file" <<- EOF
domU${i}_kernel {
description = "domU${i} kernel binary";
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel
2022-07-25 17:44 [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel Smith, Jackson
@ 2022-07-27 0:17 ` Stefano Stabellini
2022-07-27 14:54 ` Smith, Jackson
0 siblings, 1 reply; 5+ messages in thread
From: Stefano Stabellini @ 2022-07-27 0:17 UTC (permalink / raw)
To: Smith, Jackson; +Cc: Xen-devel, Stefano Stabellini
On Mon, 25 Jul 2022, Smith, Jackson wrote:
> Hi Stefano,
>
> My colleague Jason Lei and I would like to submit a patch to imagebuilder.
>
> It seems that generating a .fit with a true dom0less configuration fails because an extraneous comma is included in the its file.
>
> We believe this change resolves the issue.
Hi Jackson, thanks for your contribution!
Yes, I see the problem: the code assumes there is a dom0 kernel. If
there is no dom0 kernel then load_files will be wrongly starting with a
","
I would be happy to commit your patch. I assume I can add your
Signed-off-by to it, right?
Signed-off-by: Jackson Smith <rsmith@RiversideResearch.org>
Signed-off-by is the "Developer Certificate of Origin" which means:
https://developercertificate.org/
>
> Remove extraneous comma in generated its file when no DOM0_KERNEL is specified.
>
> diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
> index 8f08cd6..6f94fce 100755
> --- a/scripts/uboot-script-gen
> +++ b/scripts/uboot-script-gen
> @@ -676,7 +676,12 @@ create_its_file_xen()
> i=$(( $i + 1 ))
> continue
> fi
> - load_files+=", \"domU${i}_kernel\""
> + if test -z "$load_files"
> + then
> + load_files+="\"domU${i}_kernel\""
> + else
> + load_files+=", \"domU${i}_kernel\""
> + fi
> cat >> "$its_file" <<- EOF
> domU${i}_kernel {
> description = "domU${i} kernel binary";
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel
2022-07-27 0:17 ` Stefano Stabellini
@ 2022-07-27 14:54 ` Smith, Jackson
2022-07-27 15:21 ` Jason Shuhua Lei
0 siblings, 1 reply; 5+ messages in thread
From: Smith, Jackson @ 2022-07-27 14:54 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: Xen-devel, lei56
> -----Original Message-----
> From: Stefano Stabellini <sstabellini@kernel.org>
>
> On Mon, 25 Jul 2022, Smith, Jackson wrote:
> > Hi Stefano,
> >
> > My colleague Jason Lei and I would like to submit a patch to imagebuilder.
> >
> > It seems that generating a .fit with a true dom0less configuration fails
> because an extraneous comma is included in the its file.
> >
> > We believe this change resolves the issue.
>
> Hi Jackson, thanks for your contribution!
>
> Yes, I see the problem: the code assumes there is a dom0 kernel. If there is no
> dom0 kernel then load_files will be wrongly starting with a ","
>
> I would be happy to commit your patch. I assume I can add your Signed-off-by
> to it, right?
Yes, that is fine. Could you also add Jason, as he worked this out initially?
I've added him to the message so he can give his ok.
>
> Signed-off-by: Jackson Smith <rsmith@RiversideResearch.org>
>
> Signed-off-by is the "Developer Certificate of Origin" which means:
> https://developercertificate.org/
>
>
>
> >
> > Remove extraneous comma in generated its file when no DOM0_KERNEL is
> specified.
> >
> > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index
> > 8f08cd6..6f94fce 100755
> > --- a/scripts/uboot-script-gen
> > +++ b/scripts/uboot-script-gen
> > @@ -676,7 +676,12 @@ create_its_file_xen()
> > i=$(( $i + 1 ))
> > continue
> > fi
> > - load_files+=", \"domU${i}_kernel\""
> > + if test -z "$load_files"
> > + then
> > + load_files+="\"domU${i}_kernel\""
> > + else
> > + load_files+=", \"domU${i}_kernel\""
> > + fi
> > cat >> "$its_file" <<- EOF
> > domU${i}_kernel {
> > description = "domU${i} kernel binary";
> >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel
2022-07-27 14:54 ` Smith, Jackson
@ 2022-07-27 15:21 ` Jason Shuhua Lei
2022-07-27 20:01 ` Stefano Stabellini
0 siblings, 1 reply; 5+ messages in thread
From: Jason Shuhua Lei @ 2022-07-27 15:21 UTC (permalink / raw)
To: Smith, Jackson, Stefano Stabellini; +Cc: Xen-devel
Hello,
> -----Original Message-----
> From: Smith, Jackson <rsmith@RiversideResearch.org>
>
> > -----Original Message-----
> > From: Stefano Stabellini <sstabellini@kernel.org>
> >
> > On Mon, 25 Jul 2022, Smith, Jackson wrote:
> > > Hi Stefano,
> > >
> > > My colleague Jason Lei and I would like to submit a patch to imagebuilder.
> > >
> > > It seems that generating a .fit with a true dom0less configuration
> > > fails
> > because an extraneous comma is included in the its file.
> > >
> > > We believe this change resolves the issue.
> >
> > Hi Jackson, thanks for your contribution!
> >
> > Yes, I see the problem: the code assumes there is a dom0 kernel. If
> > there is no
> > dom0 kernel then load_files will be wrongly starting with a ","
> >
> > I would be happy to commit your patch. I assume I can add your
> > Signed-off-by to it, right?
>
> Yes, that is fine. Could you also add Jason, as he worked this out initially?
> I've added him to the message so he can give his ok.
>
Yes, I would like to be signed off on the patch as well using this email.
Thanks,
Jason Lei
> >
> > Signed-off-by: Jackson Smith <rsmith@RiversideResearch.org>
> >
> > Signed-off-by is the "Developer Certificate of Origin" which means:
> > https://developercertificate.org/
> >
> >
> >
> > >
> > > Remove extraneous comma in generated its file when no DOM0_KERNEL
> is
> > specified.
> > >
> > > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
> > > index 8f08cd6..6f94fce 100755
> > > --- a/scripts/uboot-script-gen
> > > +++ b/scripts/uboot-script-gen
> > > @@ -676,7 +676,12 @@ create_its_file_xen()
> > > i=$(( $i + 1 ))
> > > continue
> > > fi
> > > - load_files+=", \"domU${i}_kernel\""
> > > + if test -z "$load_files"
> > > + then
> > > + load_files+="\"domU${i}_kernel\""
> > > + else
> > > + load_files+=", \"domU${i}_kernel\""
> > > + fi
> > > cat >> "$its_file" <<- EOF
> > > domU${i}_kernel {
> > > description = "domU${i} kernel binary";
> > >
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel
2022-07-27 15:21 ` Jason Shuhua Lei
@ 2022-07-27 20:01 ` Stefano Stabellini
0 siblings, 0 replies; 5+ messages in thread
From: Stefano Stabellini @ 2022-07-27 20:01 UTC (permalink / raw)
To: Jason Shuhua Lei; +Cc: Smith, Jackson, Stefano Stabellini, Xen-devel
On Wed, 27 Jul 2022, Jason Shuhua Lei wrote:
> Hello,
> > -----Original Message-----
> > From: Smith, Jackson <rsmith@RiversideResearch.org>
> >
> > > -----Original Message-----
> > > From: Stefano Stabellini <sstabellini@kernel.org>
> > >
> > > On Mon, 25 Jul 2022, Smith, Jackson wrote:
> > > > Hi Stefano,
> > > >
> > > > My colleague Jason Lei and I would like to submit a patch to imagebuilder.
> > > >
> > > > It seems that generating a .fit with a true dom0less configuration
> > > > fails
> > > because an extraneous comma is included in the its file.
> > > >
> > > > We believe this change resolves the issue.
> > >
> > > Hi Jackson, thanks for your contribution!
> > >
> > > Yes, I see the problem: the code assumes there is a dom0 kernel. If
> > > there is no
> > > dom0 kernel then load_files will be wrongly starting with a ","
> > >
> > > I would be happy to commit your patch. I assume I can add your
> > > Signed-off-by to it, right?
> >
> > Yes, that is fine. Could you also add Jason, as he worked this out initially?
> > I've added him to the message so he can give his ok.
> >
> Yes, I would like to be signed off on the patch as well using this email.
Done, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-28 4:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-25 17:44 [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel Smith, Jackson
2022-07-27 0:17 ` Stefano Stabellini
2022-07-27 14:54 ` Smith, Jackson
2022-07-27 15:21 ` Jason Shuhua Lei
2022-07-27 20:01 ` Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.