From: Nicolas Pitre <nico@fluxnic.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH v2 03/20] ARM: LPAE: use u32 instead of unsigned long for 32-bit ptes
Date: Mon, 15 Nov 2010 17:07:14 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1011151706300.6448@xanadu.home> (raw)
In-Reply-To: <201011151047.37103.arnd@arndb.de>
On Mon, 15 Nov 2010, Arnd Bergmann wrote:
> On Monday 15 November 2010 10:39:30 Catalin Marinas wrote:
> > > There will be compiler warnings because u32 is unsigned int, and we
> > > print it as %08lx. Generic code cases pte values to (long long) and
> > > prints them using %08llx. We should do the same.
> >
> > We still need some kind of macro because with LPAE we need %016llx
> > since the phys address can go to 40-bit and there are some additional
> > bits in the top word. Unless you'd like to always print 16 characters
> > even for 32-bit ptes (or if there is some other printk magic I'm not
> > aware of).
>
> Why not just %010llx? That would just be two extra characters.
Not on non-LPAE build, please.
Nicolas
WARNING: multiple messages have this Message-ID (diff)
From: nico@fluxnic.net (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 03/20] ARM: LPAE: use u32 instead of unsigned long for 32-bit ptes
Date: Mon, 15 Nov 2010 17:07:14 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1011151706300.6448@xanadu.home> (raw)
In-Reply-To: <201011151047.37103.arnd@arndb.de>
On Mon, 15 Nov 2010, Arnd Bergmann wrote:
> On Monday 15 November 2010 10:39:30 Catalin Marinas wrote:
> > > There will be compiler warnings because u32 is unsigned int, and we
> > > print it as %08lx. Generic code cases pte values to (long long) and
> > > prints them using %08llx. We should do the same.
> >
> > We still need some kind of macro because with LPAE we need %016llx
> > since the phys address can go to 40-bit and there are some additional
> > bits in the top word. Unless you'd like to always print 16 characters
> > even for 32-bit ptes (or if there is some other printk magic I'm not
> > aware of).
>
> Why not just %010llx? That would just be two extra characters.
Not on non-LPAE build, please.
Nicolas
next prev parent reply other threads:[~2010-11-15 22:07 UTC|newest]
Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 18:00 [PATCH v2 00/20] ARM: Add support for the Large Physical Address Extensions Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 01/20] ARM: LPAE: Use PMD_(SHIFT|SIZE|MASK) instead of PGDIR_* Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-22 12:43 ` Russell King - ARM Linux
2010-11-22 12:43 ` Russell King - ARM Linux
2010-11-22 13:00 ` Catalin Marinas
2010-11-22 13:00 ` Catalin Marinas
2010-11-22 13:28 ` Russell King - ARM Linux
2010-11-22 13:28 ` Russell King - ARM Linux
2010-11-12 18:00 ` [PATCH v2 02/20] ARM: LPAE: Factor out 2-level page table definitions into separate files Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-15 23:31 ` Russell King - ARM Linux
2010-11-15 23:31 ` Russell King - ARM Linux
2010-11-16 9:14 ` Catalin Marinas
2010-11-16 9:14 ` Catalin Marinas
2010-11-16 9:59 ` Russell King - ARM Linux
2010-11-16 9:59 ` Russell King - ARM Linux
2010-11-16 10:02 ` Catalin Marinas
2010-11-16 10:02 ` Catalin Marinas
2010-11-16 10:04 ` Russell King - ARM Linux
2010-11-16 10:04 ` Russell King - ARM Linux
2010-11-16 10:11 ` Catalin Marinas
2010-11-16 10:11 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 03/20] ARM: LPAE: use u32 instead of unsigned long for 32-bit ptes Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-14 13:19 ` Russell King - ARM Linux
2010-11-14 13:19 ` Russell King - ARM Linux
2010-11-14 14:09 ` Catalin Marinas
2010-11-14 14:09 ` Catalin Marinas
2010-11-14 14:13 ` Catalin Marinas
2010-11-14 14:13 ` Catalin Marinas
2010-11-14 15:14 ` Russell King - ARM Linux
2010-11-14 15:14 ` Russell King - ARM Linux
2010-11-15 9:39 ` Catalin Marinas
2010-11-15 9:39 ` Catalin Marinas
2010-11-15 9:47 ` Arnd Bergmann
2010-11-15 9:47 ` Arnd Bergmann
2010-11-15 9:51 ` Catalin Marinas
2010-11-15 9:51 ` Catalin Marinas
2010-11-15 22:11 ` Nicolas Pitre
2010-11-15 22:11 ` Nicolas Pitre
2010-11-15 23:35 ` Russell King - ARM Linux
2010-11-15 23:35 ` Russell King - ARM Linux
2010-11-16 9:19 ` Catalin Marinas
2010-11-16 9:19 ` Catalin Marinas
2010-11-15 22:07 ` Nicolas Pitre [this message]
2010-11-15 22:07 ` Nicolas Pitre
2010-11-15 17:36 ` Russell King - ARM Linux
2010-11-15 17:36 ` Russell King - ARM Linux
2010-11-15 17:39 ` Catalin Marinas
2010-11-15 17:39 ` Catalin Marinas
2010-11-16 19:34 ` Catalin Marinas
2010-11-16 19:34 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 04/20] ARM: LPAE: Do not assume Linux PTEs are always at PTRS_PER_PTE offset Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-15 17:42 ` Russell King - ARM Linux
2010-11-15 17:42 ` Russell King - ARM Linux
2010-11-15 21:46 ` Catalin Marinas
2010-11-15 21:46 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 05/20] ARM: LPAE: Introduce L_PTE_NOEXEC and L_PTE_NOWRITE Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-15 18:30 ` Russell King - ARM Linux
2010-11-15 18:30 ` Russell King - ARM Linux
2010-11-16 10:07 ` Catalin Marinas
2010-11-16 10:07 ` Catalin Marinas
2010-11-16 15:18 ` Catalin Marinas
2010-11-16 15:18 ` Catalin Marinas
2010-11-16 15:32 ` Catalin Marinas
2010-11-16 15:32 ` Catalin Marinas
2010-11-16 18:19 ` Russell King - ARM Linux
2010-11-16 18:19 ` Russell King - ARM Linux
2010-11-17 17:02 ` Catalin Marinas
2010-11-17 17:02 ` Catalin Marinas
2010-11-17 17:16 ` Russell King - ARM Linux
2010-11-17 17:16 ` Russell King - ARM Linux
2010-11-17 17:22 ` Catalin Marinas
2010-11-17 17:22 ` Catalin Marinas
2010-11-17 17:24 ` Russell King - ARM Linux
2010-11-17 17:24 ` Russell King - ARM Linux
2010-11-17 17:30 ` Catalin Marinas
2010-11-17 17:30 ` Catalin Marinas
2010-11-17 17:32 ` Russell King - ARM Linux
2010-11-17 17:32 ` Russell King - ARM Linux
2010-11-17 17:34 ` Catalin Marinas
2010-11-17 17:34 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 06/20] ARM: LPAE: Introduce the 3-level page table format definitions Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-15 18:34 ` Russell King - ARM Linux
2010-11-15 18:34 ` Russell King - ARM Linux
2010-11-16 9:57 ` Catalin Marinas
2010-11-16 9:57 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 07/20] ARM: LPAE: Page table maintenance for the 3-level format Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-22 12:58 ` Russell King - ARM Linux
2010-11-22 12:58 ` Russell King - ARM Linux
2010-11-12 18:00 ` [PATCH v2 08/20] ARM: LPAE: MMU setup for the 3-level page table format Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-14 10:13 ` Catalin Marinas
2010-11-14 10:13 ` Catalin Marinas
2010-11-22 13:10 ` Russell King - ARM Linux
2010-11-22 13:10 ` Russell King - ARM Linux
2010-11-23 11:38 ` Catalin Marinas
2010-11-23 11:38 ` Catalin Marinas
2010-11-23 17:33 ` Russell King - ARM Linux
2010-11-23 17:33 ` Russell King - ARM Linux
2010-11-23 17:35 ` Catalin Marinas
2010-11-23 17:35 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 09/20] ARM: LPAE: Change setup_mm_for_reboot() to work with LPAE Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-22 13:11 ` Russell King - ARM Linux
2010-11-22 13:11 ` Russell King - ARM Linux
2010-11-12 18:00 ` [PATCH v2 10/20] ARM: LPAE: Remove the FIRST_USER_PGD_NR and USER_PTRS_PER_PGD definitions Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-22 13:11 ` Russell King - ARM Linux
2010-11-22 13:11 ` Russell King - ARM Linux
2010-11-12 18:00 ` [PATCH v2 11/20] ARM: LPAE: Add fault handling support Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-22 13:15 ` Russell King - ARM Linux
2010-11-22 13:15 ` Russell King - ARM Linux
2010-11-22 13:19 ` Catalin Marinas
2010-11-22 13:19 ` Catalin Marinas
2010-11-22 13:32 ` Russell King - ARM Linux
2010-11-22 13:32 ` Russell King - ARM Linux
2010-11-22 13:38 ` Catalin Marinas
2010-11-22 13:38 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 12/20] ARM: LPAE: Add context switching support Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 13/20] ARM: LPAE: Add SMP support for the 3-level page table format Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-22 13:37 ` Russell King - ARM Linux
2010-11-22 13:37 ` Russell King - ARM Linux
2010-11-12 18:00 ` [PATCH v2 14/20] ARM: LPAE: use phys_addr_t instead of unsigned long for physical addresses Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 15/20] ARM: LPAE: Use generic dma_addr_t type definition Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 16/20] ARM: LPAE: mark memory banks with start > ULONG_MAX as highmem Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 17/20] ARM: LPAE: use phys_addr_t for physical start address in early_mem Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 18/20] ARM: LPAE: add support for ATAG_MEM64 Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 19/20] ARM: LPAE: define printk format for physical addresses and page table entries Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-22 13:43 ` Russell King - ARM Linux
2010-11-22 13:43 ` Russell King - ARM Linux
2010-11-22 13:49 ` Catalin Marinas
2010-11-22 13:49 ` Catalin Marinas
2010-11-12 18:00 ` [PATCH v2 20/20] ARM: LPAE: Add the Kconfig entries Catalin Marinas
2010-11-12 18:00 ` Catalin Marinas
2010-11-13 12:38 ` Sergei Shtylyov
2010-11-13 12:38 ` Sergei Shtylyov
2010-11-14 10:11 ` Catalin Marinas
2010-11-14 10:11 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1011151706300.6448@xanadu.home \
--to=nico@fluxnic.net \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.