* any reason for include/uapi/sound header files not listed in Kbuild?
@ 2016-05-28 19:10 Robert P. J. Day
2016-05-31 12:29 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Robert P. J. Day @ 2016-05-28 19:10 UTC (permalink / raw)
To: alsa-devel
i just noticed that, in include/uapi/sound/, there are three header
files:
* asoc.h
* tlv.h
* usb_stream.h
that are not referenced by the corresponding Kbuild file. is there any
reason for this? or, in general, is there *any* reason for there to be
header files under include/uapi/ that are not listed in their Kbuild
files? thanks.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: any reason for include/uapi/sound header files not listed in Kbuild?
2016-05-28 19:10 any reason for include/uapi/sound header files not listed in Kbuild? Robert P. J. Day
@ 2016-05-31 12:29 ` Takashi Iwai
2016-05-31 12:54 ` Robert P. J. Day
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2016-05-31 12:29 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: alsa-devel
On Sat, 28 May 2016 21:10:32 +0200,
Robert P. J. Day wrote:
>
>
> i just noticed that, in include/uapi/sound/, there are three header
> files:
>
> * asoc.h
> * tlv.h
> * usb_stream.h
>
> that are not referenced by the corresponding Kbuild file. is there any
> reason for this?
There is no reason. I noticed this sometime ago but forgot after
that.
> or, in general, is there *any* reason for there to be
> header files under include/uapi/ that are not listed in their Kbuild
> files? thanks.
Yes, they should be included in Kbuild file. So far, all user-space
stuff is self-contained, keeping the copy of such files in it, thus
there was no complaint due to the missing files.
That said, feel free to send a fix patch ;)
thanks,
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: any reason for include/uapi/sound header files not listed in Kbuild?
2016-05-31 12:29 ` Takashi Iwai
@ 2016-05-31 12:54 ` Robert P. J. Day
2016-05-31 13:06 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Robert P. J. Day @ 2016-05-31 12:54 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
On Tue, 31 May 2016, Takashi Iwai wrote:
> On Sat, 28 May 2016 21:10:32 +0200,
> Robert P. J. Day wrote:
> >
> >
> > i just noticed that, in include/uapi/sound/, there are three header
> > files:
> >
> > * asoc.h
> > * tlv.h
> > * usb_stream.h
> >
> > that are not referenced by the corresponding Kbuild file. is there any
> > reason for this?
>
> There is no reason. I noticed this sometime ago but forgot after
> that.
>
> > or, in general, is there *any* reason for there to be
> > header files under include/uapi/ that are not listed in their Kbuild
> > files? thanks.
>
> Yes, they should be included in Kbuild file. So far, all user-space
> stuff is self-contained, keeping the copy of such files in it, thus
> there was no complaint due to the missing files.
>
> That said, feel free to send a fix patch ;)
so the patch would be to include the missing files in Kbuild, not to
delete them? :-)
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: any reason for include/uapi/sound header files not listed in Kbuild?
2016-05-31 12:54 ` Robert P. J. Day
@ 2016-05-31 13:06 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2016-05-31 13:06 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: alsa-devel
On Tue, 31 May 2016 14:54:29 +0200,
Robert P. J. Day wrote:
>
> On Tue, 31 May 2016, Takashi Iwai wrote:
>
> > On Sat, 28 May 2016 21:10:32 +0200,
> > Robert P. J. Day wrote:
> > >
> > >
> > > i just noticed that, in include/uapi/sound/, there are three header
> > > files:
> > >
> > > * asoc.h
> > > * tlv.h
> > > * usb_stream.h
> > >
> > > that are not referenced by the corresponding Kbuild file. is there any
> > > reason for this?
> >
> > There is no reason. I noticed this sometime ago but forgot after
> > that.
> >
> > > or, in general, is there *any* reason for there to be
> > > header files under include/uapi/ that are not listed in their Kbuild
> > > files? thanks.
> >
> > Yes, they should be included in Kbuild file. So far, all user-space
> > stuff is self-contained, keeping the copy of such files in it, thus
> > there was no complaint due to the missing files.
> >
> > That said, feel free to send a fix patch ;)
>
> so the patch would be to include the missing files in Kbuild, not to
> delete them? :-)
Yes.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-31 13:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-28 19:10 any reason for include/uapi/sound header files not listed in Kbuild? Robert P. J. Day
2016-05-31 12:29 ` Takashi Iwai
2016-05-31 12:54 ` Robert P. J. Day
2016-05-31 13:06 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.