* Re: [PATCH] X86, Acer, WMI: Do not double include linux/dmi.h in acer-wmi.c
@ 2011-01-25 1:34 ` Joey Lee
0 siblings, 0 replies; 4+ messages in thread
From: Joey Lee @ 2011-01-25 1:34 UTC (permalink / raw)
To: jj; +Cc: trivial, mjg, carlos, linux-kernel, platform-driver-x86
Hi Jesper,
於 一，2011-01-24 於 22:12 +0100，Jesper Juhl 提到：
> Including linux/dmi.h once in drivers/platform/x86/acer-wmi.c is enough.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> acer-wmi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index c5c4b8c..f21eb53 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -39,7 +39,6 @@
> #include <linux/slab.h>
> #include <linux/input.h>
> #include <linux/input/sparse-keymap.h>
> -#include <linux/dmi.h>
>
> #include <acpi/acpi_drivers.h>
>
>
Reviewed-by: Lee, Chun-Yi <jlee@novell.com>
Thank's for your patch to fix my fail.
Joey Lee
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] X86, Acer, WMI: Do not double include linux/dmi.h in acer-wmi.c
@ 2011-01-25 1:34 ` Joey Lee
0 siblings, 0 replies; 4+ messages in thread
From: Joey Lee @ 2011-01-25 1:34 UTC (permalink / raw)
To: jj; +Cc: trivial, mjg, carlos, linux-kernel, platform-driver-x86
Hi Jesper,
於 一，2011-01-24 於 22:12 +0100，Jesper Juhl 提到：
> Including linux/dmi.h once in drivers/platform/x86/acer-wmi.c is enough.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> acer-wmi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index c5c4b8c..f21eb53 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -39,7 +39,6 @@
> #include <linux/slab.h>
> #include <linux/input.h>
> #include <linux/input/sparse-keymap.h>
> -#include <linux/dmi.h>
>
> #include <acpi/acpi_drivers.h>
>
>
Reviewed-by: Lee, Chun-Yi <jlee@novell.com>
Thank's for your patch to fix my fail.
Joey Lee
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] X86, Acer, WMI: Do not double include linux/dmi.h in acer-wmi.c
2011-01-25 1:34 ` Joey Lee
(?)
@ 2011-01-25 11:03 ` Jiri Kosina
-1 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2011-01-25 11:03 UTC (permalink / raw)
To: Joey Lee; +Cc: jj, mjg, carlos, linux-kernel, platform-driver-x86
On Mon, 24 Jan 2011, Joey Lee wrote:
> Hi Jesper,
>
> 於 一，2011-01-24 於 22:12 +0100，Jesper Juhl 提到：
> > Including linux/dmi.h once in drivers/platform/x86/acer-wmi.c is enough.
> >
> > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> > ---
> > acer-wmi.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> > index c5c4b8c..f21eb53 100644
> > --- a/drivers/platform/x86/acer-wmi.c
> > +++ b/drivers/platform/x86/acer-wmi.c
> > @@ -39,7 +39,6 @@
> > #include <linux/slab.h>
> > #include <linux/input.h>
> > #include <linux/input/sparse-keymap.h>
> > -#include <linux/dmi.h>
> >
> > #include <acpi/acpi_drivers.h>
> >
> >
>
> Reviewed-by: Lee, Chun-Yi <jlee@novell.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] X86, Acer, WMI: Do not double include linux/dmi.h in acer-wmi.c
@ 2011-01-24 21:12 Jesper Juhl
0 siblings, 0 replies; 4+ messages in thread
From: Jesper Juhl @ 2011-01-24 21:12 UTC (permalink / raw)
To: linux-kernel
Cc: platform-driver-x86, Carlos Corbacho, Matthew Garrett, Lee,
Chun-Yi, trivial
Including linux/dmi.h once in drivers/platform/x86/acer-wmi.c is enough.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
acer-wmi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index c5c4b8c..f21eb53 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -39,7 +39,6 @@
#include <linux/slab.h>
#include <linux/input.h>
#include <linux/input/sparse-keymap.h>
-#include <linux/dmi.h>
#include <acpi/acpi_drivers.h>
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-25 11:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-25 1:34 [PATCH] X86, Acer, WMI: Do not double include linux/dmi.h in acer-wmi.c Joey Lee
2011-01-25 1:34 ` Joey Lee
2011-01-25 11:03 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2011-01-24 21:12 Jesper Juhl
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.