Re: [Qemu-devel] [RFC v3 31/56] ac97: convert to memory API

[malc <av1474@comtv.ru>]

On Mon, 11 Jul 2011, Avi Kivity wrote:

> On 07/11/2011 04:42 AM, Anthony Liguori wrote:
> > On 07/10/2011 03:33 PM, malc wrote:
> > > On Sun, 10 Jul 2011, Avi Kivity wrote:
> > > 
> > > > fixes BAR sizing as well.
> > > 
> > > I find this patch disgusting, the read and write handlers in particular.
> > 
> > Shouldn't it be possible to do something like:
> > 
> > typedef struct OldMemoryRegionOps {
> >     MemoryRegionOps parent_ops;
> >     CPUReadMemoryFunc *readfn[3];
> >     CPUWriteMemoryFunc *writefn[3];
> >     void *opaque;
> > } OldMemoryRegionOps;
> > 
> > That should allow old-style implementations to be converted without
> > introducing trampoline functions everywhere.
> 
> Here's a new version:

This one looks acceptable[1], original submission said:
"fixes BAR sizing as well." what was wrong with it?

[..snip..] 

P.S. Sans minor inconsistency with trailing commas.

-- 
mailto:av1474@comtv.ru