input question: ambient light sensor button

input question: ambient light sensor button

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 923 bytes --]

Hello,

I do not know where to ask this question, but I think that kernel 
developers could help me.

I have notebook with one special button on keyboard which is 
designed for turning ambient light sensor on and off. By default 
pressing button do nothing (I can turn ambient light sensor on/off 
via sysfs platform wmi module). Button press is reported by 
kernel input device AT Translated Set 2 keyboard and reports it 
as button "touchpad off".

Of course "touchpad off" is incorrect and I'd like to ask which 
kernel key or button from /usr/include/linux/input.h should be 
mapped for my ambient light sensor button? Is there already some? 
And what is strategy for allocating KEY_* and BTN_* numbers?

I'd like to know this, so udev could have correct DMI keymap 
hooks and other userspace programs can understand ambient light 
sensor button correctly.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: input question: ambient light sensor button

[Jiri Kosina]

On Sun, 15 Sep 2013, Pali Rohár wrote:

> I do not know where to ask this question, but I think that kernel 
> developers could help me.
> 
> I have notebook with one special button on keyboard which is 
> designed for turning ambient light sensor on and off. By default 
> pressing button do nothing (I can turn ambient light sensor on/off 
> via sysfs platform wmi module). Button press is reported by 
> kernel input device AT Translated Set 2 keyboard and reports it 
> as button "touchpad off".
> 
> Of course "touchpad off" is incorrect and I'd like to ask which 
> kernel key or button from /usr/include/linux/input.h should be 
> mapped for my ambient light sensor button? Is there already some? 
> And what is strategy for allocating KEY_* and BTN_* numbers?

This is maintained by Dmitry, so he's the one to answer this. I am adding 
him to CC.

> I'd like to know this, so udev could have correct DMI keymap 
> hooks and other userspace programs can understand ambient light 
> sensor button correctly.

-- 
Jiri Kosina
SUSE Labs

Re: input question: ambient light sensor button

[Jiri Kosina]

On Sun, 15 Sep 2013, Pali Rohár wrote:

> I do not know where to ask this question, but I think that kernel 
> developers could help me.
> 
> I have notebook with one special button on keyboard which is 
> designed for turning ambient light sensor on and off. By default 
> pressing button do nothing (I can turn ambient light sensor on/off 
> via sysfs platform wmi module). Button press is reported by 
> kernel input device AT Translated Set 2 keyboard and reports it 
> as button "touchpad off".
> 
> Of course "touchpad off" is incorrect and I'd like to ask which 
> kernel key or button from /usr/include/linux/input.h should be 
> mapped for my ambient light sensor button? Is there already some? 
> And what is strategy for allocating KEY_* and BTN_* numbers?

This is maintained by Dmitry, so he's the one to answer this. I am adding 
him to CC.

> I'd like to know this, so udev could have correct DMI keymap 
> hooks and other userspace programs can understand ambient light 
> sensor button correctly.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: input question: ambient light sensor button

[Dmitry Torokhov]

On Wed, Nov 13, 2013 at 11:47:18AM +0100, Jiri Kosina wrote:
> On Sun, 15 Sep 2013, Pali Rohár wrote:
> 
> > I do not know where to ask this question, but I think that kernel 
> > developers could help me.
> > 
> > I have notebook with one special button on keyboard which is 
> > designed for turning ambient light sensor on and off. By default 
> > pressing button do nothing (I can turn ambient light sensor on/off 
> > via sysfs platform wmi module). Button press is reported by 
> > kernel input device AT Translated Set 2 keyboard and reports it 
> > as button "touchpad off".
> > 
> > Of course "touchpad off" is incorrect and I'd like to ask which 
> > kernel key or button from /usr/include/linux/input.h should be 
> > mapped for my ambient light sensor button? Is there already some? 
> > And what is strategy for allocating KEY_* and BTN_* numbers?
> 
> This is maintained by Dmitry, so he's the one to answer this. I am adding 
> him to CC.

I guess we need patch adding

	#define KEY_ALS_TOGGLE	0x230

Thanks.

-- 
Dmitry

Re: input question: ambient light sensor button

[Dmitry Torokhov]

On Wed, Nov 13, 2013 at 11:47:18AM +0100, Jiri Kosina wrote:
> On Sun, 15 Sep 2013, Pali Rohár wrote:
> 
> > I do not know where to ask this question, but I think that kernel 
> > developers could help me.
> > 
> > I have notebook with one special button on keyboard which is 
> > designed for turning ambient light sensor on and off. By default 
> > pressing button do nothing (I can turn ambient light sensor on/off 
> > via sysfs platform wmi module). Button press is reported by 
> > kernel input device AT Translated Set 2 keyboard and reports it 
> > as button "touchpad off".
> > 
> > Of course "touchpad off" is incorrect and I'd like to ask which 
> > kernel key or button from /usr/include/linux/input.h should be 
> > mapped for my ambient light sensor button? Is there already some? 
> > And what is strategy for allocating KEY_* and BTN_* numbers?
> 
> This is maintained by Dmitry, so he's the one to answer this. I am adding 
> him to CC.

I guess we need patch adding

	#define KEY_ALS_TOGGLE	0x230

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: input question: ambient light sensor button

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 1246 bytes --]

On Wednesday 13 November 2013 17:28:40 Dmitry Torokhov wrote:
> On Wed, Nov 13, 2013 at 11:47:18AM +0100, Jiri Kosina wrote:
> > On Sun, 15 Sep 2013, Pali Rohár wrote:
> > > I do not know where to ask this question, but I think that
> > > kernel developers could help me.
> > > 
> > > I have notebook with one special button on keyboard which
> > > is designed for turning ambient light sensor on and off.
> > > By default pressing button do nothing (I can turn ambient
> > > light sensor on/off via sysfs platform wmi module).
> > > Button press is reported by kernel input device AT
> > > Translated Set 2 keyboard and reports it as button
> > > "touchpad off".
> > > 
> > > Of course "touchpad off" is incorrect and I'd like to ask
> > > which kernel key or button from
> > > /usr/include/linux/input.h should be mapped for my
> > > ambient light sensor button? Is there already some? And
> > > what is strategy for allocating KEY_* and BTN_* numbers?
> > 
> > This is maintained by Dmitry, so he's the one to answer
> > this. I am adding him to CC.
> 
> I guess we need patch adding
> 
> 	#define KEY_ALS_TOGGLE	0x230
> 
> Thanks.

So there is no good key for als yet?

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: input question: ambient light sensor button

[Dmitry Torokhov]

On Thu, Nov 14, 2013 at 01:02:31PM +0100, Pali Rohár wrote:
> On Wednesday 13 November 2013 17:28:40 Dmitry Torokhov wrote:
> > On Wed, Nov 13, 2013 at 11:47:18AM +0100, Jiri Kosina wrote:
> > > On Sun, 15 Sep 2013, Pali Rohár wrote:
> > > > I do not know where to ask this question, but I think that
> > > > kernel developers could help me.
> > > > 
> > > > I have notebook with one special button on keyboard which
> > > > is designed for turning ambient light sensor on and off.
> > > > By default pressing button do nothing (I can turn ambient
> > > > light sensor on/off via sysfs platform wmi module).
> > > > Button press is reported by kernel input device AT
> > > > Translated Set 2 keyboard and reports it as button
> > > > "touchpad off".
> > > > 
> > > > Of course "touchpad off" is incorrect and I'd like to ask
> > > > which kernel key or button from
> > > > /usr/include/linux/input.h should be mapped for my
> > > > ambient light sensor button? Is there already some? And
> > > > what is strategy for allocating KEY_* and BTN_* numbers?
> > > 
> > > This is maintained by Dmitry, so he's the one to answer
> > > this. I am adding him to CC.
> > 
> > I guess we need patch adding
> > 
> > 	#define KEY_ALS_TOGGLE	0x230
> > 
> > Thanks.
> 
> So there is no good key for als yet?

No, but if you send me a patch adding it I will gladly apply it.

Thanks.

-- 
Dmitry

Re: input question: ambient light sensor button

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 2284 bytes --]

On Tuesday 19 November 2013 22:27:36 Dmitry Torokhov wrote:
> On Thu, Nov 14, 2013 at 01:02:31PM +0100, Pali Rohár wrote:
> > On Wednesday 13 November 2013 17:28:40 Dmitry Torokhov wrote:
> > > On Wed, Nov 13, 2013 at 11:47:18AM +0100, Jiri Kosina wrote:
> > > > On Sun, 15 Sep 2013, Pali Rohár wrote:
> > > > > I do not know where to ask this question, but I think
> > > > > that kernel developers could help me.
> > > > > 
> > > > > I have notebook with one special button on keyboard
> > > > > which is designed for turning ambient light sensor on
> > > > > and off. By default pressing button do nothing (I can
> > > > > turn ambient light sensor on/off via sysfs platform
> > > > > wmi module). Button press is reported by kernel input
> > > > > device AT Translated Set 2 keyboard and reports it as
> > > > > button "touchpad off".
> > > > > 
> > > > > Of course "touchpad off" is incorrect and I'd like to
> > > > > ask which kernel key or button from
> > > > > /usr/include/linux/input.h should be mapped for my
> > > > > ambient light sensor button? Is there already some?
> > > > > And what is strategy for allocating KEY_* and BTN_*
> > > > > numbers?
> > > > 
> > > > This is maintained by Dmitry, so he's the one to answer
> > > > this. I am adding him to CC.
> > > 
> > > I guess we need patch adding
> > > 
> > > 	#define KEY_ALS_TOGGLE	0x230
> > > 
> > > Thanks.
> > 
> > So there is no good key for als yet?
> 
> No, but if you send me a patch adding it I will gladly apply
> it.
> 
> Thanks.

Ok, here is patch:

Add key code for ambient light sensor button

More notebooks have special button for enabling/disabling ambient
light sensor. This patch adding new als code to input.h header file.

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>

diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
index a372627..1562f10 100644
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -719,6 +719,8 @@ struct input_keymap_entry {
 #define BTN_DPAD_LEFT		0x222
 #define BTN_DPAD_RIGHT		0x223
 
+#define KEY_ALS_TOGGLE		0x230
+
 #define BTN_TRIGGER_HAPPY		0x2c0
 #define BTN_TRIGGER_HAPPY1		0x2c0
 #define BTN_TRIGGER_HAPPY2		0x2c1


-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: input question: ambient light sensor button

[Benjamin Tissoires]

Hi,

On Wed, Nov 20, 2013 at 9:50 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
>> > > I guess we need patch adding
>> > >
>> > >   #define KEY_ALS_TOGGLE  0x230
>> > >
>> > > Thanks.
>> >
>> > So there is no good key for als yet?
>>
>> No, but if you send me a patch adding it I will gladly apply
>> it.
>>
>> Thanks.
>
> Ok, here is patch:
>
> Add key code for ambient light sensor button
>
> More notebooks have special button for enabling/disabling ambient
> light sensor. This patch adding new als code to input.h header file.
>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
>
> diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> index a372627..1562f10 100644
> --- a/include/uapi/linux/input.h
> +++ b/include/uapi/linux/input.h
> @@ -719,6 +719,8 @@ struct input_keymap_entry {
>  #define BTN_DPAD_LEFT          0x222
>  #define BTN_DPAD_RIGHT         0x223
>
> +#define KEY_ALS_TOGGLE         0x230

Could you just add a comment explaining that ALS is ambiant light
sensor? Otherwise, I'm sure someone else will use this event code for
an other thing... :)

Cheers,
Benjamin

Re: input question: ambient light sensor button

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 1857 bytes --]

On Wednesday 20 November 2013 16:59:42 Benjamin Tissoires wrote:
> Hi,
> 
> On Wed, Nov 20, 2013 at 9:50 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
> >> > > I guess we need patch adding
> >> > > 
> >> > >   #define KEY_ALS_TOGGLE  0x230
> >> > > 
> >> > > Thanks.
> >> > 
> >> > So there is no good key for als yet?
> >> 
> >> No, but if you send me a patch adding it I will gladly
> >> apply it.
> >> 
> >> Thanks.
> > 
> > Ok, here is patch:
> > 
> > Add key code for ambient light sensor button
> > 
> > More notebooks have special button for enabling/disabling
> > ambient light sensor. This patch adding new als code to
> > input.h header file.
> > 
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > 
> > diff --git a/include/uapi/linux/input.h
> > b/include/uapi/linux/input.h index a372627..1562f10 100644
> > --- a/include/uapi/linux/input.h
> > +++ b/include/uapi/linux/input.h
> > @@ -719,6 +719,8 @@ struct input_keymap_entry {
> > 
> >  #define BTN_DPAD_LEFT          0x222
> >  #define BTN_DPAD_RIGHT         0x223
> > 
> > +#define KEY_ALS_TOGGLE         0x230
> 
> Could you just add a comment explaining that ALS is ambiant
> light sensor? Otherwise, I'm sure someone else will use this
> event code for an other thing... :)
> 
> Cheers,
> Benjamin

Ok, here is new diff with comment:

diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
index a372627..7bacdb5 100644
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -719,6 +719,8 @@ struct input_keymap_entry {
 #define BTN_DPAD_LEFT		0x222
 #define BTN_DPAD_RIGHT		0x223
 
+#define KEY_ALS_TOGGLE		0x230	/* Ambient light sensor */
+
 #define BTN_TRIGGER_HAPPY		0x2c0
 #define BTN_TRIGGER_HAPPY1		0x2c0
 #define BTN_TRIGGER_HAPPY2		0x2c1


-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: input question: ambient light sensor button

[Dmitry Torokhov]

On Fri, Nov 22, 2013 at 12:13:49PM +0100, Pali Rohár wrote:
> On Wednesday 20 November 2013 16:59:42 Benjamin Tissoires wrote:
> > Hi,
> > 
> > On Wed, Nov 20, 2013 at 9:50 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
> > >> > > I guess we need patch adding
> > >> > > 
> > >> > >   #define KEY_ALS_TOGGLE  0x230
> > >> > > 
> > >> > > Thanks.
> > >> > 
> > >> > So there is no good key for als yet?
> > >> 
> > >> No, but if you send me a patch adding it I will gladly
> > >> apply it.
> > >> 
> > >> Thanks.
> > > 
> > > Ok, here is patch:
> > > 
> > > Add key code for ambient light sensor button
> > > 
> > > More notebooks have special button for enabling/disabling
> > > ambient light sensor. This patch adding new als code to
> > > input.h header file.
> > > 
> > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > 
> > > diff --git a/include/uapi/linux/input.h
> > > b/include/uapi/linux/input.h index a372627..1562f10 100644
> > > --- a/include/uapi/linux/input.h
> > > +++ b/include/uapi/linux/input.h
> > > @@ -719,6 +719,8 @@ struct input_keymap_entry {
> > > 
> > >  #define BTN_DPAD_LEFT          0x222
> > >  #define BTN_DPAD_RIGHT         0x223
> > > 
> > > +#define KEY_ALS_TOGGLE         0x230
> > 
> > Could you just add a comment explaining that ALS is ambiant
> > light sensor? Otherwise, I'm sure someone else will use this
> > event code for an other thing... :)
> > 
> > Cheers,
> > Benjamin
> 
> Ok, here is new diff with comment:

Applied, thank you.

> 
> diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> index a372627..7bacdb5 100644
> --- a/include/uapi/linux/input.h
> +++ b/include/uapi/linux/input.h
> @@ -719,6 +719,8 @@ struct input_keymap_entry {
>  #define BTN_DPAD_LEFT		0x222
>  #define BTN_DPAD_RIGHT		0x223
>  
> +#define KEY_ALS_TOGGLE		0x230	/* Ambient light sensor */
> +
>  #define BTN_TRIGGER_HAPPY		0x2c0
>  #define BTN_TRIGGER_HAPPY1		0x2c0
>  #define BTN_TRIGGER_HAPPY2		0x2c1
> 
> 
> -- 
> Pali Rohár
> pali.rohar@gmail.com



-- 
Dmitry

Re: input question: ambient light sensor button

[Dmitry Torokhov]

On Fri, Nov 22, 2013 at 12:13:49PM +0100, Pali Rohár wrote:
> On Wednesday 20 November 2013 16:59:42 Benjamin Tissoires wrote:
> > Hi,
> > 
> > On Wed, Nov 20, 2013 at 9:50 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
> > >> > > I guess we need patch adding
> > >> > > 
> > >> > >   #define KEY_ALS_TOGGLE  0x230
> > >> > > 
> > >> > > Thanks.
> > >> > 
> > >> > So there is no good key for als yet?
> > >> 
> > >> No, but if you send me a patch adding it I will gladly
> > >> apply it.
> > >> 
> > >> Thanks.
> > > 
> > > Ok, here is patch:
> > > 
> > > Add key code for ambient light sensor button
> > > 
> > > More notebooks have special button for enabling/disabling
> > > ambient light sensor. This patch adding new als code to
> > > input.h header file.
> > > 
> > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > 
> > > diff --git a/include/uapi/linux/input.h
> > > b/include/uapi/linux/input.h index a372627..1562f10 100644
> > > --- a/include/uapi/linux/input.h
> > > +++ b/include/uapi/linux/input.h
> > > @@ -719,6 +719,8 @@ struct input_keymap_entry {
> > > 
> > >  #define BTN_DPAD_LEFT          0x222
> > >  #define BTN_DPAD_RIGHT         0x223
> > > 
> > > +#define KEY_ALS_TOGGLE         0x230
> > 
> > Could you just add a comment explaining that ALS is ambiant
> > light sensor? Otherwise, I'm sure someone else will use this
> > event code for an other thing... :)
> > 
> > Cheers,
> > Benjamin
> 
> Ok, here is new diff with comment:

Applied, thank you.

> 
> diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> index a372627..7bacdb5 100644
> --- a/include/uapi/linux/input.h
> +++ b/include/uapi/linux/input.h
> @@ -719,6 +719,8 @@ struct input_keymap_entry {
>  #define BTN_DPAD_LEFT		0x222
>  #define BTN_DPAD_RIGHT		0x223
>  
> +#define KEY_ALS_TOGGLE		0x230	/* Ambient light sensor */
> +
>  #define BTN_TRIGGER_HAPPY		0x2c0
>  #define BTN_TRIGGER_HAPPY1		0x2c0
>  #define BTN_TRIGGER_HAPPY2		0x2c1
> 
> 
> -- 
> Pali Rohár
> pali.rohar@gmail.com



-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html