Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

From: Jiri Kosina <jkosina@suse.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Vlastimil Babka" <vbabka@suse.cz>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	rpurdie@rpsys.net,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs
Date: Wed, 22 Jul 2015 23:50:35 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.2.00.1507222348580.1141@pobox.suse.cz> (raw)
In-Reply-To: <20150722214739.GA15790@amd>

On Wed, 22 Jul 2015, Pavel Machek wrote:

> > I am however not sure whether input_leds_connect() is not too unkind to 
> > unnamed LEDs and shouldn't be more tolerant to those in the long term.
> 
> Maybe.
> 
> > From: Jiri Kosina <jkosina@suse.com>
> > Subject: [PATCH] Input: leds: don't attempt to deregister unnamed LEDs
> > 
> > input_leds_connect() is skipping registration of LEDs for which
> > there is no symbolic name in input_led_info[].
> 
> Yes, and rather than testing for "no name" special case at two places,
> what about simply giving up when we see such error?

Well, that's quite the oposite of the "be more tolerant" aproach proposed 
above :)

I don't see a reason why the sole fact that the device has at least one 
LED that kernel can't handle properly should mean that neither of the 
other LEDs will work.

-- 
Jiri Kosina
SUSE Labs