From: Finn Thain <fthain@telegraphics.com.au>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
"David S. Miller" <davem@davemloft.net>,
linux-m68k <linux-m68k@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH net] macmace: Set platform device coherent_dma_mask
Date: Fri, 11 May 2018 13:28:57 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.21.1805111221180.8@nippy.intranet> (raw)
In-Reply-To: <CAOmrzkLL0ZNzAh7rwiDy=BkNqqXgbqfv3vkN6K8CTF8VGbT8zA@mail.gmail.com>
On Fri, 11 May 2018, Michael Schmitz wrote:
> > > Which begs the question: why can' you set up all Nubus bus devices'
> > > DMA masks in nubus_device_register(), or nubus_add_board()?
> >
> > I am expecting to see the same WARNING from the nubus sonic driver but
> > it hasn't happened yet, so I don't have a patch for it yet. In
> > anycase, the nubus fix would be a lot like the zorro bus fix, so I
> > don't see a problem.
>
> That's odd. But what I meant to say is that by setting up
> dma_coherent_mask in nubus_add_board(), and pointing dma_mask to that,
> ypu won't need any patches to Nubus device drivers.
Right. I think I've already acknowledged that. But it's off-topic, because
the patches under review are for platform drivers. Those patches fix an
actual bug that I've observed. Whereas, the nubus driver dma mask issue
that you raised is purely theoretical at this stage.
--
WARNING: multiple messages have this Message-ID (diff)
From: Finn Thain <fthain@telegraphics.com.au>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
"David S. Miller" <davem@davemloft.net>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH net] macmace: Set platform device coherent_dma_mask
Date: Fri, 11 May 2018 13:28:57 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.21.1805111221180.8@nippy.intranet> (raw)
In-Reply-To: <CAOmrzkLL0ZNzAh7rwiDy=BkNqqXgbqfv3vkN6K8CTF8VGbT8zA@mail.gmail.com>
On Fri, 11 May 2018, Michael Schmitz wrote:
> > > Which begs the question: why can' you set up all Nubus bus devices'
> > > DMA masks in nubus_device_register(), or nubus_add_board()?
> >
> > I am expecting to see the same WARNING from the nubus sonic driver but
> > it hasn't happened yet, so I don't have a patch for it yet. In
> > anycase, the nubus fix would be a lot like the zorro bus fix, so I
> > don't see a problem.
>
> That's odd. But what I meant to say is that by setting up
> dma_coherent_mask in nubus_add_board(), and pointing dma_mask to that,
> ypu won't need any patches to Nubus device drivers.
Right. I think I've already acknowledged that. But it's off-topic, because
the patches under review are for platform drivers. Those patches fix an
actual bug that I've observed. Whereas, the nubus driver dma mask issue
that you raised is purely theoretical at this stage.
--
next prev parent reply other threads:[~2018-05-11 3:29 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <S1751632AbeECEYA/20180503042400Z+254@vger.kernel.org>
2018-05-03 7:25 ` [PATCH net] macmace: Set platform device coherent_dma_mask Geert Uytterhoeven
2018-05-03 7:25 ` Geert Uytterhoeven
2018-05-03 8:38 ` Finn Thain
2018-05-03 8:38 ` Finn Thain
2018-05-03 8:46 ` Geert Uytterhoeven
2018-05-03 8:46 ` Geert Uytterhoeven
2018-05-03 8:51 ` Christoph Hellwig
2018-05-03 8:51 ` Christoph Hellwig
2018-05-03 20:24 ` Michael Schmitz
2018-05-03 20:24 ` Michael Schmitz
2018-05-04 7:24 ` Geert Uytterhoeven
2018-05-04 7:24 ` Geert Uytterhoeven
2018-05-04 8:16 ` Michael Schmitz
2018-05-04 8:16 ` Michael Schmitz
2018-05-10 1:25 ` Finn Thain
2018-05-10 1:25 ` Finn Thain
2018-05-10 1:25 ` Finn Thain
2018-05-10 1:25 ` Finn Thain
2018-05-10 20:27 ` Michael Schmitz
2018-05-10 20:27 ` Michael Schmitz
2018-05-10 23:55 ` Finn Thain
2018-05-10 23:55 ` Finn Thain
2018-05-11 2:11 ` Michael Schmitz
2018-05-11 2:11 ` Michael Schmitz
2018-05-11 3:28 ` Finn Thain [this message]
2018-05-11 3:28 ` Finn Thain
2018-05-11 4:18 ` Michael Schmitz
2018-05-11 4:18 ` Michael Schmitz
2018-05-11 5:28 ` Finn Thain
2018-05-11 5:28 ` Finn Thain
2018-05-11 9:30 ` Michael Schmitz
2018-05-11 9:30 ` Michael Schmitz
2018-05-11 10:06 ` Finn Thain
2018-05-11 10:06 ` Finn Thain
2018-05-11 22:02 ` Michael Schmitz
2018-05-11 22:02 ` Michael Schmitz
2018-05-03 4:23 Finn Thain
-- strict thread matches above, loose matches on Subject: below --
2018-05-03 4:23 Finn Thain
2018-05-03 4:23 Finn Thain
2018-05-03 4:23 Finn Thain
2018-05-03 4:23 Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.1805111221180.8@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.