All of lore.kernel.org
 help / color / mirror / Atom feed
From: Finn Thain <fthain@telegraphics.com.au>
To: Chris Boot <bootc@bootc.net>
Cc: linuxppc-dev@lists.ozlabs.org, target-devel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	Bart Van Assche <bvanassche@acm.org>,
	Chuhong Yuan <hslester96@gmail.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Nicholas Bellinger <nab@linux-iscsi.org>,
	Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: Re: [PATCH] scsi: target/sbp: remove firewire SBP target driver
Date: Sun, 14 Jun 2020 10:03:31 +1000 (AEST)	[thread overview]
Message-ID: <alpine.LNX.2.22.394.2006140934520.15@nippy.intranet> (raw)
In-Reply-To: <01020172acd3d10f-3964f076-a820-43fc-9494-3f3946e9b7b5-000000@eu-west-1.amazonses.com>

On Sat, 13 Jun 2020, Chris Boot wrote:

> I no longer have the time to maintain this subsystem nor the hardware to
> test patches with. 

Then why not patch MAINTAINERS, and orphan it, as per usual practice?

$ git log --oneline MAINTAINERS | grep -i orphan

> It also doesn't appear to have any active users so I doubt anyone will 
> miss it.
> 

It's not unusual that any Linux driver written more than 5 years ago 
"doesn't appear to have any active users".

If a driver has been orphaned and broken in the past, and no-one stepped 
up to fix it within a reasonable period, removal would make sense. But 
that's not the case here.

I haven't used this driver for a long time, but I still own PowerMacs with 
firewire, and I know I'm not the only one.

> Signed-off-by: Chris Boot <bootc@bootc.net>
> ---
>  MAINTAINERS                     |    9 -
>  drivers/target/Kconfig          |    1 -
>  drivers/target/Makefile         |    1 -
>  drivers/target/sbp/Kconfig      |   12 -
>  drivers/target/sbp/Makefile     |    2 -
>  drivers/target/sbp/sbp_target.c | 2350 -------------------------------
>  drivers/target/sbp/sbp_target.h |  243 ----
>  7 files changed, 2618 deletions(-)
>  delete mode 100644 drivers/target/sbp/Kconfig
>  delete mode 100644 drivers/target/sbp/Makefile
>  delete mode 100644 drivers/target/sbp/sbp_target.c
>  delete mode 100644 drivers/target/sbp/sbp_target.h
> 

WARNING: multiple messages have this Message-ID (diff)
From: Finn Thain <fthain@telegraphics.com.au>
To: Chris Boot <bootc@bootc.net>
Cc: linuxppc-dev@lists.ozlabs.org, target-devel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	Bart Van Assche <bvanassche@acm.org>,
	Chuhong Yuan <hslester96@gmail.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Nicholas Bellinger <nab@linux-iscsi.org>,
	Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: Re: [PATCH] scsi: target/sbp: remove firewire SBP target driver
Date: Sun, 14 Jun 2020 00:03:31 +0000	[thread overview]
Message-ID: <alpine.LNX.2.22.394.2006140934520.15@nippy.intranet> (raw)
In-Reply-To: <01020172acd3d10f-3964f076-a820-43fc-9494-3f3946e9b7b5-000000@eu-west-1.amazonses.com>

On Sat, 13 Jun 2020, Chris Boot wrote:

> I no longer have the time to maintain this subsystem nor the hardware to
> test patches with. 

Then why not patch MAINTAINERS, and orphan it, as per usual practice?

$ git log --oneline MAINTAINERS | grep -i orphan

> It also doesn't appear to have any active users so I doubt anyone will 
> miss it.
> 

It's not unusual that any Linux driver written more than 5 years ago 
"doesn't appear to have any active users".

If a driver has been orphaned and broken in the past, and no-one stepped 
up to fix it within a reasonable period, removal would make sense. But 
that's not the case here.

I haven't used this driver for a long time, but I still own PowerMacs with 
firewire, and I know I'm not the only one.

> Signed-off-by: Chris Boot <bootc@bootc.net>
> ---
>  MAINTAINERS                     |    9 -
>  drivers/target/Kconfig          |    1 -
>  drivers/target/Makefile         |    1 -
>  drivers/target/sbp/Kconfig      |   12 -
>  drivers/target/sbp/Makefile     |    2 -
>  drivers/target/sbp/sbp_target.c | 2350 -------------------------------
>  drivers/target/sbp/sbp_target.h |  243 ----
>  7 files changed, 2618 deletions(-)
>  delete mode 100644 drivers/target/sbp/Kconfig
>  delete mode 100644 drivers/target/sbp/Makefile
>  delete mode 100644 drivers/target/sbp/sbp_target.c
>  delete mode 100644 drivers/target/sbp/sbp_target.h
> 

WARNING: multiple messages have this Message-ID (diff)
From: Finn Thain <fthain@telegraphics.com.au>
To: Chris Boot <bootc@bootc.net>
Cc: Bart Van Assche <bvanassche@acm.org>,
	linux-scsi@vger.kernel.org, Chuhong Yuan <hslester96@gmail.com>,
	linux-kernel@vger.kernel.org,
	Nicholas Bellinger <nab@linux-iscsi.org>,
	target-devel@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux1394-devel@lists.sourceforge.net,
	linuxppc-dev@lists.ozlabs.org,
	Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: Re: [PATCH] scsi: target/sbp: remove firewire SBP target driver
Date: Sun, 14 Jun 2020 10:03:31 +1000 (AEST)	[thread overview]
Message-ID: <alpine.LNX.2.22.394.2006140934520.15@nippy.intranet> (raw)
In-Reply-To: <01020172acd3d10f-3964f076-a820-43fc-9494-3f3946e9b7b5-000000@eu-west-1.amazonses.com>

On Sat, 13 Jun 2020, Chris Boot wrote:

> I no longer have the time to maintain this subsystem nor the hardware to
> test patches with. 

Then why not patch MAINTAINERS, and orphan it, as per usual practice?

$ git log --oneline MAINTAINERS | grep -i orphan

> It also doesn't appear to have any active users so I doubt anyone will 
> miss it.
> 

It's not unusual that any Linux driver written more than 5 years ago 
"doesn't appear to have any active users".

If a driver has been orphaned and broken in the past, and no-one stepped 
up to fix it within a reasonable period, removal would make sense. But 
that's not the case here.

I haven't used this driver for a long time, but I still own PowerMacs with 
firewire, and I know I'm not the only one.

> Signed-off-by: Chris Boot <bootc@bootc.net>
> ---
>  MAINTAINERS                     |    9 -
>  drivers/target/Kconfig          |    1 -
>  drivers/target/Makefile         |    1 -
>  drivers/target/sbp/Kconfig      |   12 -
>  drivers/target/sbp/Makefile     |    2 -
>  drivers/target/sbp/sbp_target.c | 2350 -------------------------------
>  drivers/target/sbp/sbp_target.h |  243 ----
>  7 files changed, 2618 deletions(-)
>  delete mode 100644 drivers/target/sbp/Kconfig
>  delete mode 100644 drivers/target/sbp/Makefile
>  delete mode 100644 drivers/target/sbp/sbp_target.c
>  delete mode 100644 drivers/target/sbp/sbp_target.h
> 

  reply	other threads:[~2020-06-14  0:03 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-13  8:37 [PATCH] scsi: target/sbp: remove SBP target driver Chris Boot
2020-06-13  8:37 ` Chris Boot
2020-06-14  0:03 ` Finn Thain [this message]
2020-06-14  0:03   ` [PATCH] scsi: target/sbp: remove firewire " Finn Thain
2020-06-14  0:03   ` Finn Thain
2020-06-14 10:34   ` Chris Boot
2020-06-14 10:34     ` Chris Boot
2020-06-14 10:34     ` Chris Boot
2020-06-14 23:28     ` Finn Thain
2020-06-14 23:28       ` Finn Thain
2020-06-14 23:28       ` Finn Thain
2020-06-15 15:00       ` Chris Boot
2020-06-15 15:00         ` Chris Boot
2020-06-15 15:00         ` Chris Boot
2020-06-16  9:42         ` Finn Thain
2020-06-16  9:42           ` Finn Thain
2020-06-16  9:42           ` Finn Thain
2020-06-16 14:08           ` Bart Van Assche
2020-06-16 14:08             ` Bart Van Assche
2020-06-16 14:08             ` Bart Van Assche
2020-06-16 14:13             ` Johannes Thumshirn
2020-06-16 14:13               ` Johannes Thumshirn
2020-06-16 14:13               ` Johannes Thumshirn
2020-06-16 15:34               ` James Bottomley
2020-06-16 15:34                 ` James Bottomley
2020-06-16 15:34                 ` James Bottomley
2020-06-16 17:59                 ` Chris Boot
2020-06-16 17:59                   ` Chris Boot
2020-06-16 17:59                   ` Chris Boot
2020-06-17  3:09                   ` Martin K. Petersen
2020-06-17  3:09                     ` Martin K. Petersen
2020-06-17  3:09                     ` Martin K. Petersen
2020-06-18  0:40                     ` Finn Thain
2020-06-18  0:40                       ` Finn Thain
2020-06-18  0:40                       ` Finn Thain
2020-06-17  2:07             ` Finn Thain
2020-06-17  2:07               ` Finn Thain
2020-06-17  2:07               ` Finn Thain
2021-01-04 17:43               ` Bart Van Assche
2021-01-04 17:43                 ` Bart Van Assche
2021-01-04 22:50                 ` Finn Thain
2021-01-04 22:50                   ` Finn Thain
2021-01-05  1:48                   ` Bart Van Assche
2021-01-05  1:48                     ` Bart Van Assche
2020-06-17  2:35   ` Martin K. Petersen
2020-06-17  2:35     ` Martin K. Petersen
2020-06-17  2:35     ` Martin K. Petersen
2020-06-17  4:21     ` Finn Thain
2020-06-17  4:21       ` Finn Thain
2020-06-17  4:21       ` Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.22.394.2006140934520.15@nippy.intranet \
    --to=fthain@telegraphics.com.au \
    --cc=bootc@bootc.net \
    --cc=bvanassche@acm.org \
    --cc=hslester96@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=martin.petersen@oracle.com \
    --cc=nab@linux-iscsi.org \
    --cc=stefanr@s5r6.in-berlin.de \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.