All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-networking][PATCH] openl2tp: update systemd service file
@ 2019-12-19  3:16 kai.kang
  2019-12-19  3:23 ` Khem Raj
  0 siblings, 1 reply; 3+ messages in thread
From: kai.kang @ 2019-12-19  3:16 UTC (permalink / raw)
  To: openembedded-devel

From: Kai Kang <kai.kang@windriver.com>

It shows an warning of openl2tp in systemd log:

| /lib/systemd/system/openl2tpd.service:8: PIDFile= references a path
| below legacy directory /var/run/, updating /var/run/openl2tpd.pid →
| /run/openl2tpd.pid; please update the unit file accordingly.

Update the systemd service file to fix the warning.

Update SRC_URI as well that the homepage openl2tp.org has been closed.
Use archived file on sourceforge instead.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 .../recipes-protocols/openl2tp/openl2tp/openl2tpd.service       | 2 +-
 meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service b/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service
index 7b3faf672..d02d0ff7e 100644
--- a/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service
+++ b/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service
@@ -5,7 +5,7 @@ Requires=rpcbind.service
 
 [Service]
 Type=forking
-PIDFile=@STATEDIR@/run/openl2tpd.pid
+PIDFile=/run/openl2tpd.pid
 EnvironmentFile=@SYSCONFDIR@/default/openl2tpd
 ExecStartPre=@BASE_BINDIR@/sh -c "@BASE_SBINDIR@/modprobe -sq l2tp_ppp || @BASE_SBINDIR@/modprobe -sq pppol2tp"
 ExecStart=@SBINDIR@/openl2tpd $OPENL2TPDARGS
diff --git a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
index 90e8b111d..38d0554e1 100644
--- a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
+++ b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
@@ -18,7 +18,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=e9d9259cbbf00945adc25a470c1d3585 \
 
 DEPENDS = "popt flex readline rpcsvc-proto-native bison-native"
 
-SRC_URI = "ftp://ftp.openl2tp.org/releases/${BP}/${BP}.tar.gz \
+SRC_URI = "https://sourceforge.net/projects/openl2tp/files/openl2tp/${PV}/${BP}.tar.gz \
            file://Makefile-modify-CFLAGS-to-aviod-build-error.patch \
            file://openl2tp-simplify-gcc-warning-hack.patch \
            file://Makefile-obey-LDFLAGS.patch \
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [meta-networking][PATCH] openl2tp: update systemd service file
  2019-12-19  3:23 ` Khem Raj
@ 2019-12-19  3:23   ` Kang Kai
  0 siblings, 0 replies; 3+ messages in thread
From: Kang Kai @ 2019-12-19  3:23 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembeded-devel

On 2019/12/19 上午11:23, Khem Raj wrote:
> On Wed, Dec 18, 2019 at 7:16 PM <kai.kang@windriver.com> wrote:
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> It shows an warning of openl2tp in systemd log:
>>
>> | /lib/systemd/system/openl2tpd.service:8: PIDFile= references a path
>> | below legacy directory /var/run/, updating /var/run/openl2tpd.pid →
>> | /run/openl2tpd.pid; please update the unit file accordingly.
>>
>> Update the systemd service file to fix the warning.
>>
>> Update SRC_URI as well that the homepage openl2tp.org has been closed.
>> Use archived file on sourceforge instead.
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>>   .../recipes-protocols/openl2tp/openl2tp/openl2tpd.service       | 2 +-
>>   meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb      | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service b/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service
>> index 7b3faf672..d02d0ff7e 100644
>> --- a/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service
>> +++ b/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service
>> @@ -5,7 +5,7 @@ Requires=rpcbind.service
>>
>>   [Service]
>>   Type=forking
>> -PIDFile=@STATEDIR@/run/openl2tpd.pid
>> +PIDFile=/run/openl2tpd.pid
>>   EnvironmentFile=@SYSCONFDIR@/default/openl2tpd
>>   ExecStartPre=@BASE_BINDIR@/sh -c "@BASE_SBINDIR@/modprobe -sq l2tp_ppp || @BASE_SBINDIR@/modprobe -sq pppol2tp"
>>   ExecStart=@SBINDIR@/openl2tpd $OPENL2TPDARGS
>> diff --git a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
>> index 90e8b111d..38d0554e1 100644
>> --- a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
>> +++ b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
>> @@ -18,7 +18,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=e9d9259cbbf00945adc25a470c1d3585 \
>>
>>   DEPENDS = "popt flex readline rpcsvc-proto-native bison-native"
>>
>> -SRC_URI = "ftp://ftp.openl2tp.org/releases/${BP}/${BP}.tar.gz \
>> +SRC_URI = "https://sourceforge.net/projects/openl2tp/files/openl2tp/${PV}/${BP}.tar.gz \
> Can we use SOURCEFORGE_MIRROR

I'll try it.

Regards,
Kai


>
>>              file://Makefile-modify-CFLAGS-to-aviod-build-error.patch \
>>              file://openl2tp-simplify-gcc-warning-hack.patch \
>>              file://Makefile-obey-LDFLAGS.patch \
>> --
>> 2.17.1
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


-- 
Kai Kang



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [meta-networking][PATCH] openl2tp: update systemd service file
  2019-12-19  3:16 [meta-networking][PATCH] openl2tp: update systemd service file kai.kang
@ 2019-12-19  3:23 ` Khem Raj
  2019-12-19  3:23   ` Kang Kai
  0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2019-12-19  3:23 UTC (permalink / raw)
  To: Kang Kai; +Cc: openembeded-devel

On Wed, Dec 18, 2019 at 7:16 PM <kai.kang@windriver.com> wrote:
>
> From: Kai Kang <kai.kang@windriver.com>
>
> It shows an warning of openl2tp in systemd log:
>
> | /lib/systemd/system/openl2tpd.service:8: PIDFile= references a path
> | below legacy directory /var/run/, updating /var/run/openl2tpd.pid →
> | /run/openl2tpd.pid; please update the unit file accordingly.
>
> Update the systemd service file to fix the warning.
>
> Update SRC_URI as well that the homepage openl2tp.org has been closed.
> Use archived file on sourceforge instead.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  .../recipes-protocols/openl2tp/openl2tp/openl2tpd.service       | 2 +-
>  meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service b/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service
> index 7b3faf672..d02d0ff7e 100644
> --- a/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service
> +++ b/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service
> @@ -5,7 +5,7 @@ Requires=rpcbind.service
>
>  [Service]
>  Type=forking
> -PIDFile=@STATEDIR@/run/openl2tpd.pid
> +PIDFile=/run/openl2tpd.pid
>  EnvironmentFile=@SYSCONFDIR@/default/openl2tpd
>  ExecStartPre=@BASE_BINDIR@/sh -c "@BASE_SBINDIR@/modprobe -sq l2tp_ppp || @BASE_SBINDIR@/modprobe -sq pppol2tp"
>  ExecStart=@SBINDIR@/openl2tpd $OPENL2TPDARGS
> diff --git a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
> index 90e8b111d..38d0554e1 100644
> --- a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
> +++ b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
> @@ -18,7 +18,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=e9d9259cbbf00945adc25a470c1d3585 \
>
>  DEPENDS = "popt flex readline rpcsvc-proto-native bison-native"
>
> -SRC_URI = "ftp://ftp.openl2tp.org/releases/${BP}/${BP}.tar.gz \
> +SRC_URI = "https://sourceforge.net/projects/openl2tp/files/openl2tp/${PV}/${BP}.tar.gz \

Can we use SOURCEFORGE_MIRROR

>             file://Makefile-modify-CFLAGS-to-aviod-build-error.patch \
>             file://openl2tp-simplify-gcc-warning-hack.patch \
>             file://Makefile-obey-LDFLAGS.patch \
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-19  3:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19  3:16 [meta-networking][PATCH] openl2tp: update systemd service file kai.kang
2019-12-19  3:23 ` Khem Raj
2019-12-19  3:23   ` Kang Kai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.