* [linux-next:master 3272/11956] undefined reference to `ioread64_hi_lo'
@ 2020-09-30 1:44 kernel test robot
2020-09-30 14:38 ` Helge Deller
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-09-30 1:44 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]
Hi Helge,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 49e7e3e905e437a02782019570f70997e2da9101
commit: ad697ae387f9f707c4065ab26d583c007bec76e4 [3272/11956] parisc: Add qemu fw_cfg interface
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ad697ae387f9f707c4065ab26d583c007bec76e4
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout ad697ae387f9f707c4065ab26d583c007bec76e4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
hppa-linux-ld: drivers/firmware/arm_scmi/perf.o: in function `scmi_perf_fc_ring_db':
>> (.text+0x610): undefined reference to `ioread64_hi_lo'
>> hppa-linux-ld: (.text+0x63c): undefined reference to `iowrite64_hi_lo'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65657 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [linux-next:master 3272/11956] undefined reference to `ioread64_hi_lo'
2020-09-30 1:44 [linux-next:master 3272/11956] undefined reference to `ioread64_hi_lo' kernel test robot
@ 2020-09-30 14:38 ` Helge Deller
2020-09-30 15:29 ` Helge Deller
0 siblings, 1 reply; 3+ messages in thread
From: Helge Deller @ 2020-09-30 14:38 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2671 bytes --]
On 9/30/20 3:44 AM, kernel test robot wrote:
> Hi Helge,
>
> FYI, the error/warning still remains.
I answered on 8/29/20, 10:47 PM and didn't got any reply....
Here is what I wrote:
In drivers/firmware/arm_scmi/perf.c iowrite64_hi_lo() is called directly.
So, I could add this function to arch/parisc/lib/iomap.c to prevent the linker error.
But this file is compiled on parisc just because CONFIG_COMPILE_TEST is set, while
in production builds it would never be compiled.
So, what's the usual take in such a scenario?
Shall I ignore this linker error and 0-day warning, or shall I add a workaround?
In general I'd prefer this patch:
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -8,7 +8,7 @@ menu "Firmware Drivers"
config ARM_SCMI_PROTOCOL
bool "ARM System Control and Management Interface (SCMI) Message Protocol"
- depends on ARM || ARM64 || COMPILE_TEST
+ depends on ARM || ARM64 || (COMPILE_TEST && OF)
depends on MAILBOX
help
ARM System Control and Management Interface (SCMI) protocol is a
Would that be Ok?
Helge
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 49e7e3e905e437a02782019570f70997e2da9101
> commit: ad697ae387f9f707c4065ab26d583c007bec76e4 [3272/11956] parisc: Add qemu fw_cfg interface
> config: parisc-allyesconfig (attached as .config)
> compiler: hppa-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ad697ae387f9f707c4065ab26d583c007bec76e4
> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git fetch --no-tags linux-next master
> git checkout ad697ae387f9f707c4065ab26d583c007bec76e4
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> hppa-linux-ld: drivers/firmware/arm_scmi/perf.o: in function `scmi_perf_fc_ring_db':
>>> (.text+0x610): undefined reference to `ioread64_hi_lo'
>>> hppa-linux-ld: (.text+0x63c): undefined reference to `iowrite64_hi_lo'
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [linux-next:master 3272/11956] undefined reference to `ioread64_hi_lo'
2020-09-30 14:38 ` Helge Deller
@ 2020-09-30 15:29 ` Helge Deller
0 siblings, 0 replies; 3+ messages in thread
From: Helge Deller @ 2020-09-30 15:29 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2426 bytes --]
On 9/30/20 4:38 PM, Helge Deller wrote:
> On 9/30/20 3:44 AM, kernel test robot wrote:
>> Hi Helge,
>>
>> FYI, the error/warning still remains.
>
> I answered on 8/29/20, 10:47 PM and didn't got any reply....
> Here is what I wrote:
>
> In drivers/firmware/arm_scmi/perf.c iowrite64_hi_lo() is called directly.
> So, I could add this function to arch/parisc/lib/iomap.c to prevent the linker error.
> But this file is compiled on parisc just because CONFIG_COMPILE_TEST is set, while
> in production builds it would never be compiled.
>
> So, what's the usual take in such a scenario?
> Shall I ignore this linker error and 0-day warning, or shall I add a workaround?
I fixed it by adding the functions in my for-next tree:
https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/commit/?h=for-next
Thanks!
Helge
>>
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head: 49e7e3e905e437a02782019570f70997e2da9101
>> commit: ad697ae387f9f707c4065ab26d583c007bec76e4 [3272/11956] parisc: Add qemu fw_cfg interface
>> config: parisc-allyesconfig (attached as .config)
>> compiler: hppa-linux-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ad697ae387f9f707c4065ab26d583c007bec76e4
>> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>> git fetch --no-tags linux-next master
>> git checkout ad697ae387f9f707c4065ab26d583c007bec76e4
>> # save the attached .config to linux build tree
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>> hppa-linux-ld: drivers/firmware/arm_scmi/perf.o: in function `scmi_perf_fc_ring_db':
>>>> (.text+0x610): undefined reference to `ioread64_hi_lo'
>>>> hppa-linux-ld: (.text+0x63c): undefined reference to `iowrite64_hi_lo'
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-30 15:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-30 1:44 [linux-next:master 3272/11956] undefined reference to `ioread64_hi_lo' kernel test robot
2020-09-30 14:38 ` Helge Deller
2020-09-30 15:29 ` Helge Deller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.