All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Simon Fong <simon.fongnt@gmail.com>, abbotti@mev.co.uk
Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
	colin.king@canonical.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it
Date: Sat, 18 Jan 2020 21:32:06 -0800	[thread overview]
Message-ID: <b1437d2f1543e73a20250342a764185772167658.camel@perches.com> (raw)
In-Reply-To: <20200119035243.7819-1-simon.fongnt@gmail.com>

On Sun, 2020-01-19 at 11:52 +0800, Simon Fong wrote:
> Clean up long line and align it
[]
> diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
[]
> @@ -204,7 +204,8 @@ struct usbdux_private {
>  	struct mutex mut;
>  };
>  
> -static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)

Why do you believe this to be a long line?
It's only 63 characters.

         1         2         3         4         5         6         7
1234567890123456789012345678901234567890123456789012345678901234567890

static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)

> +static void usbdux_unlink_urbs(struct urb **urbs,
> +			       int num_urbs)
>  {
>  	int i;
>   


WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Simon Fong <simon.fongnt@gmail.com>, abbotti@mev.co.uk
Cc: devel@driverdev.osuosl.org, colin.king@canonical.com,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it
Date: Sat, 18 Jan 2020 21:32:06 -0800	[thread overview]
Message-ID: <b1437d2f1543e73a20250342a764185772167658.camel@perches.com> (raw)
In-Reply-To: <20200119035243.7819-1-simon.fongnt@gmail.com>

On Sun, 2020-01-19 at 11:52 +0800, Simon Fong wrote:
> Clean up long line and align it
[]
> diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
[]
> @@ -204,7 +204,8 @@ struct usbdux_private {
>  	struct mutex mut;
>  };
>  
> -static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)

Why do you believe this to be a long line?
It's only 63 characters.

         1         2         3         4         5         6         7
1234567890123456789012345678901234567890123456789012345678901234567890

static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)

> +static void usbdux_unlink_urbs(struct urb **urbs,
> +			       int num_urbs)
>  {
>  	int i;
>   

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2020-01-19  5:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-19  3:52 [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it Simon Fong
2020-01-19  3:52 ` Simon Fong
2020-01-19  5:32 ` Joe Perches [this message]
2020-01-19  5:32   ` Joe Perches
2020-01-19 12:50 ` Greg KH
2020-01-19 12:50   ` Greg KH
2020-01-19 12:52   ` Greg KH
2020-01-19 12:52     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1437d2f1543e73a20250342a764185772167658.camel@perches.com \
    --to=joe@perches.com \
    --cc=abbotti@mev.co.uk \
    --cc=colin.king@canonical.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon.fongnt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.