[Qemu-devel] [PATCH] maintainers: Add myself as a NetBSD reviewer

[Qemu-devel] [PATCH] maintainers: Add myself as a NetBSD reviewer

[Kamil Rytarowski]

I volunteer to review NetBSD patches.
Adding myself will help to not miss some of them.

Restore NetBSD as a maintained host.

All patches to make qemu/pkgsrc building have been emitted to review.

Signed-off-by: Kamil Rytarowski <n54@gmx.com>
---
 MAINTAINERS | 6 ++++++
 configure   | 1 +
 2 files changed, 7 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 0e8d731ebf..c4eff13ce2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -354,6 +354,12 @@ L: qemu-devel@nongnu.org
 S: Maintained
 F: *posix*
 
+NETBSD
+L: qemu-devel@nongnu.org
+M: Kamil Rytarowski <kamil@netbsd.org>
+S: Maintained
+K: (?i)NetBSD
+
 W32, W64
 L: qemu-devel@nongnu.org
 M: Stefan Weil <sw@weilnetz.de>
diff --git a/configure b/configure
index 7c020c076b..0b3e014c93 100755
--- a/configure
+++ b/configure
@@ -611,6 +611,7 @@ NetBSD)
   audio_possible_drivers="oss sdl"
   oss_lib="-lossaudio"
   HOST_VARIANT_DIR="netbsd"
+  supported_os="yes"
 ;;
 OpenBSD)
   bsd="yes"
-- 
2.12.2

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a NetBSD reviewer

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

On Sat, May 13, 2017 at 04:21:43AM +0200, Kamil Rytarowski wrote:
> I volunteer to review NetBSD patches.
> Adding myself will help to not miss some of them.
> 
> Restore NetBSD as a maintained host.
> 
> All patches to make qemu/pkgsrc building have been emitted to review.
> 
> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
> ---
>  MAINTAINERS | 6 ++++++
>  configure   | 1 +
>  2 files changed, 7 insertions(+)

Will you maintain a patch queue (git repo) so you can send pull
requests?  If yes, please add a T: field.

Thanks,
Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a NetBSD reviewer

[Kamil Rytarowski]

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

On 15.05.2017 16:13, Stefan Hajnoczi wrote:
> On Sat, May 13, 2017 at 04:21:43AM +0200, Kamil Rytarowski wrote:
>> I volunteer to review NetBSD patches.
>> Adding myself will help to not miss some of them.
>>
>> Restore NetBSD as a maintained host.
>>
>> All patches to make qemu/pkgsrc building have been emitted to review.
>>
>> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
>> ---
>>  MAINTAINERS | 6 ++++++
>>  configure   | 1 +
>>  2 files changed, 7 insertions(+)
> 
> Will you maintain a patch queue (git repo) so you can send pull
> requests?  If yes, please add a T: field.
> 

I don't think that there is a need for an additional patch queue, at
least in the maintained mode as a volunteer in spare time.

If there would be more BSD people, we could share a dedicated queue of
patches.

> Thanks,
> Stefan
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a NetBSD reviewer

[Paolo Bonzini]

On 15/05/2017 16:22, Kamil Rytarowski wrote:
> On 15.05.2017 16:13, Stefan Hajnoczi wrote:
>> On Sat, May 13, 2017 at 04:21:43AM +0200, Kamil Rytarowski wrote:
>>> I volunteer to review NetBSD patches.
>>> Adding myself will help to not miss some of them.
>>>
>>> Restore NetBSD as a maintained host.
>>>
>>> All patches to make qemu/pkgsrc building have been emitted to review.
>>>
>>> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
>>> ---
>>>  MAINTAINERS | 6 ++++++
>>>  configure   | 1 +
>>>  2 files changed, 7 insertions(+)
>>
>> Will you maintain a patch queue (git repo) so you can send pull
>> requests?  If yes, please add a T: field.
>>
> 
> I don't think that there is a need for an additional patch queue, at
> least in the maintained mode as a volunteer in spare time.
> 
> If there would be more BSD people, we could share a dedicated queue of
> patches.

How would patches be sent to the committer then?

Thanks,

Paolo

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a NetBSD reviewer

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

On Mon, May 15, 2017 at 04:43:41PM +0200, Paolo Bonzini wrote:
> 
> 
> On 15/05/2017 16:22, Kamil Rytarowski wrote:
> > On 15.05.2017 16:13, Stefan Hajnoczi wrote:
> >> On Sat, May 13, 2017 at 04:21:43AM +0200, Kamil Rytarowski wrote:
> >>> I volunteer to review NetBSD patches.
> >>> Adding myself will help to not miss some of them.
> >>>
> >>> Restore NetBSD as a maintained host.
> >>>
> >>> All patches to make qemu/pkgsrc building have been emitted to review.
> >>>
> >>> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
> >>> ---
> >>>  MAINTAINERS | 6 ++++++
> >>>  configure   | 1 +
> >>>  2 files changed, 7 insertions(+)
> >>
> >> Will you maintain a patch queue (git repo) so you can send pull
> >> requests?  If yes, please add a T: field.
> >>
> > 
> > I don't think that there is a need for an additional patch queue, at
> > least in the maintained mode as a volunteer in spare time.
> > 
> > If there would be more BSD people, we could share a dedicated queue of
> > patches.
> 
> How would patches be sent to the committer then?

After discussing on IRC it seems likely that NetBSD patches will go via
subsystem maintainers.  Therefore Kamil does not plan to send pull
requests directly.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a NetBSD reviewer

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

On Sat, May 13, 2017 at 04:21:43AM +0200, Kamil Rytarowski wrote:
> I volunteer to review NetBSD patches.
> Adding myself will help to not miss some of them.
> 
> Restore NetBSD as a maintained host.
> 
> All patches to make qemu/pkgsrc building have been emitted to review.
> 
> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
> ---
>  MAINTAINERS | 6 ++++++
>  configure   | 1 +
>  2 files changed, 7 insertions(+)

Thanks, applied to my staging tree:
https://github.com/stefanha/qemu/commits/staging

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]