* [PATCH 0/4] arm64: dts: meson-axg: enable SCPI
@ 2018-11-08 13:53 ` Jerome Brunet
0 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: Kevin Hilman, Carlo Caione
Cc: Jerome Brunet, devicetree, linux-amlogic, linux-kernel, linux-arm-kernel
The goal of this patchset is to enable SCPI (dvfs and hwmon) the axg
platform. The first patches in this series fix a few issues to acheive
this.
Jerome Brunet (4):
arm64: dts: meson-axg: fix mailbox address
arm64: dts: meson-axg: correct sram shared mem unit-address
Documentation: bindings: Add missing Amlogic SCPI sensor bindings
arm64: dts: meson-axg: enable SCPI
.../devicetree/bindings/arm/amlogic,scpi.txt | 7 ++++
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 34 ++++++++++++++++---
2 files changed, 37 insertions(+), 4 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 0/4] arm64: dts: meson-axg: enable SCPI
@ 2018-11-08 13:53 ` Jerome Brunet
0 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: linux-arm-kernel
The goal of this patchset is to enable SCPI (dvfs and hwmon) the axg
platform. The first patches in this series fix a few issues to acheive
this.
Jerome Brunet (4):
arm64: dts: meson-axg: fix mailbox address
arm64: dts: meson-axg: correct sram shared mem unit-address
Documentation: bindings: Add missing Amlogic SCPI sensor bindings
arm64: dts: meson-axg: enable SCPI
.../devicetree/bindings/arm/amlogic,scpi.txt | 7 ++++
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 34 ++++++++++++++++---
2 files changed, 37 insertions(+), 4 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 0/4] arm64: dts: meson-axg: enable SCPI
@ 2018-11-08 13:53 ` Jerome Brunet
0 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: linus-amlogic
The goal of this patchset is to enable SCPI (dvfs and hwmon) the axg
platform. The first patches in this series fix a few issues to acheive
this.
Jerome Brunet (4):
arm64: dts: meson-axg: fix mailbox address
arm64: dts: meson-axg: correct sram shared mem unit-address
Documentation: bindings: Add missing Amlogic SCPI sensor bindings
arm64: dts: meson-axg: enable SCPI
.../devicetree/bindings/arm/amlogic,scpi.txt | 7 ++++
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 34 ++++++++++++++++---
2 files changed, 37 insertions(+), 4 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 1/4] arm64: dts: meson-axg: fix mailbox address
2018-11-08 13:53 ` Jerome Brunet
(?)
@ 2018-11-08 13:53 ` Jerome Brunet
-1 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: Kevin Hilman, Carlo Caione
Cc: Jerome Brunet, devicetree, linux-amlogic, linux-kernel, linux-arm-kernel
MHU mailbox address is wrong. Fixing it enables the mailboxes on the A113.
These mailboxes are needed for SCPI
Fixes: 9d59b708500f ("arm64: dts: meson-axg: add initial A113D SoC DT support")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 3cc0044d3468..ff8b3406aff6 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -1067,9 +1067,9 @@
};
};
- mailbox: mailbox@ff63dc00 {
+ mailbox: mailbox@ff63c404 {
compatible = "amlogic,meson-gx-mhu", "amlogic,meson-gxbb-mhu";
- reg = <0 0xff63dc00 0 0x400>;
+ reg = <0 0xff63c404 0 0x4c>;
interrupts = <GIC_SPI 208 IRQ_TYPE_EDGE_RISING>,
<GIC_SPI 209 IRQ_TYPE_EDGE_RISING>,
<GIC_SPI 210 IRQ_TYPE_EDGE_RISING>;
--
2.19.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 1/4] arm64: dts: meson-axg: fix mailbox address
@ 2018-11-08 13:53 ` Jerome Brunet
0 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: linux-arm-kernel
MHU mailbox address is wrong. Fixing it enables the mailboxes on the A113.
These mailboxes are needed for SCPI
Fixes: 9d59b708500f ("arm64: dts: meson-axg: add initial A113D SoC DT support")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 3cc0044d3468..ff8b3406aff6 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -1067,9 +1067,9 @@
};
};
- mailbox: mailbox at ff63dc00 {
+ mailbox: mailbox at ff63c404 {
compatible = "amlogic,meson-gx-mhu", "amlogic,meson-gxbb-mhu";
- reg = <0 0xff63dc00 0 0x400>;
+ reg = <0 0xff63c404 0 0x4c>;
interrupts = <GIC_SPI 208 IRQ_TYPE_EDGE_RISING>,
<GIC_SPI 209 IRQ_TYPE_EDGE_RISING>,
<GIC_SPI 210 IRQ_TYPE_EDGE_RISING>;
--
2.19.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 1/4] arm64: dts: meson-axg: fix mailbox address
@ 2018-11-08 13:53 ` Jerome Brunet
0 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: linus-amlogic
MHU mailbox address is wrong. Fixing it enables the mailboxes on the A113.
These mailboxes are needed for SCPI
Fixes: 9d59b708500f ("arm64: dts: meson-axg: add initial A113D SoC DT support")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 3cc0044d3468..ff8b3406aff6 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -1067,9 +1067,9 @@
};
};
- mailbox: mailbox at ff63dc00 {
+ mailbox: mailbox at ff63c404 {
compatible = "amlogic,meson-gx-mhu", "amlogic,meson-gxbb-mhu";
- reg = <0 0xff63dc00 0 0x400>;
+ reg = <0 0xff63c404 0 0x4c>;
interrupts = <GIC_SPI 208 IRQ_TYPE_EDGE_RISING>,
<GIC_SPI 209 IRQ_TYPE_EDGE_RISING>,
<GIC_SPI 210 IRQ_TYPE_EDGE_RISING>;
--
2.19.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 2/4] arm64: dts: meson-axg: correct sram shared mem unit-address
2018-11-08 13:53 ` Jerome Brunet
(?)
@ 2018-11-08 13:53 ` Jerome Brunet
-1 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: Kevin Hilman, Carlo Caione
Cc: Jerome Brunet, devicetree, linux-amlogic, linux-kernel, linux-arm-kernel
Correct the unit-address in the node name of the SRAM shared memory
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index ff8b3406aff6..b8893675e39c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -1659,12 +1659,12 @@
#size-cells = <1>;
ranges = <0 0x0 0xfffc0000 0x20000>;
- cpu_scp_lpri: scp-shmem@0 {
+ cpu_scp_lpri: scp-shmem@13000 {
compatible = "amlogic,meson-axg-scp-shmem";
reg = <0x13000 0x400>;
};
- cpu_scp_hpri: scp-shmem@200 {
+ cpu_scp_hpri: scp-shmem@13400 {
compatible = "amlogic,meson-axg-scp-shmem";
reg = <0x13400 0x400>;
};
--
2.19.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 2/4] arm64: dts: meson-axg: correct sram shared mem unit-address
@ 2018-11-08 13:53 ` Jerome Brunet
0 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: linux-arm-kernel
Correct the unit-address in the node name of the SRAM shared memory
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index ff8b3406aff6..b8893675e39c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -1659,12 +1659,12 @@
#size-cells = <1>;
ranges = <0 0x0 0xfffc0000 0x20000>;
- cpu_scp_lpri: scp-shmem at 0 {
+ cpu_scp_lpri: scp-shmem at 13000 {
compatible = "amlogic,meson-axg-scp-shmem";
reg = <0x13000 0x400>;
};
- cpu_scp_hpri: scp-shmem at 200 {
+ cpu_scp_hpri: scp-shmem at 13400 {
compatible = "amlogic,meson-axg-scp-shmem";
reg = <0x13400 0x400>;
};
--
2.19.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 2/4] arm64: dts: meson-axg: correct sram shared mem unit-address
@ 2018-11-08 13:53 ` Jerome Brunet
0 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: linus-amlogic
Correct the unit-address in the node name of the SRAM shared memory
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index ff8b3406aff6..b8893675e39c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -1659,12 +1659,12 @@
#size-cells = <1>;
ranges = <0 0x0 0xfffc0000 0x20000>;
- cpu_scp_lpri: scp-shmem at 0 {
+ cpu_scp_lpri: scp-shmem at 13000 {
compatible = "amlogic,meson-axg-scp-shmem";
reg = <0x13000 0x400>;
};
- cpu_scp_hpri: scp-shmem at 200 {
+ cpu_scp_hpri: scp-shmem at 13400 {
compatible = "amlogic,meson-axg-scp-shmem";
reg = <0x13400 0x400>;
};
--
2.19.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings
2018-11-08 13:53 ` Jerome Brunet
(?)
@ 2018-11-08 13:53 ` Jerome Brunet
-1 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: Kevin Hilman, Carlo Caione
Cc: Jerome Brunet, devicetree, linux-amlogic, linux-kernel, linux-arm-kernel
amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not
documented. Just add it to amlogic's scpi documentation
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
Documentation/devicetree/bindings/arm/amlogic,scpi.txt | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
index 7b9a861e9306..5ab59da052df 100644
--- a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
+++ b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
@@ -17,4 +17,11 @@ Required sub-node properties:
- compatible : should be "amlogic,meson-gxbb-scp-shmem" for SRAM based shared
memory on Amlogic GXBB SoC.
+Sensor bindings for the sensors based on SCPI Message Protocol
+--------------------------------------------------------------
+SCPI provides an API to access the various sensors on the SoC.
+
+Required properties:
+- compatible : should be "amlogic,meson-gxbb-scpi-sensors".
+
[0] Documentation/devicetree/bindings/arm/arm,scpi.txt
--
2.19.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings
@ 2018-11-08 13:53 ` Jerome Brunet
0 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: linux-arm-kernel
amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not
documented. Just add it to amlogic's scpi documentation
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
Documentation/devicetree/bindings/arm/amlogic,scpi.txt | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
index 7b9a861e9306..5ab59da052df 100644
--- a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
+++ b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
@@ -17,4 +17,11 @@ Required sub-node properties:
- compatible : should be "amlogic,meson-gxbb-scp-shmem" for SRAM based shared
memory on Amlogic GXBB SoC.
+Sensor bindings for the sensors based on SCPI Message Protocol
+--------------------------------------------------------------
+SCPI provides an API to access the various sensors on the SoC.
+
+Required properties:
+- compatible : should be "amlogic,meson-gxbb-scpi-sensors".
+
[0] Documentation/devicetree/bindings/arm/arm,scpi.txt
--
2.19.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings
@ 2018-11-08 13:53 ` Jerome Brunet
0 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: linus-amlogic
amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not
documented. Just add it to amlogic's scpi documentation
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
Documentation/devicetree/bindings/arm/amlogic,scpi.txt | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
index 7b9a861e9306..5ab59da052df 100644
--- a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
+++ b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
@@ -17,4 +17,11 @@ Required sub-node properties:
- compatible : should be "amlogic,meson-gxbb-scp-shmem" for SRAM based shared
memory on Amlogic GXBB SoC.
+Sensor bindings for the sensors based on SCPI Message Protocol
+--------------------------------------------------------------
+SCPI provides an API to access the various sensors on the SoC.
+
+Required properties:
+- compatible : should be "amlogic,meson-gxbb-scpi-sensors".
+
[0] Documentation/devicetree/bindings/arm/arm,scpi.txt
--
2.19.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 4/4] arm64: dts: meson-axg: enable SCPI
2018-11-08 13:53 ` Jerome Brunet
(?)
@ 2018-11-08 13:53 ` Jerome Brunet
-1 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: Kevin Hilman, Carlo Caione
Cc: Jerome Brunet, devicetree, linux-amlogic, linux-kernel, linux-arm-kernel
Enable SCPI on the axg platform, with cpu clock and hwmon
(core temperature) support
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 26 ++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index b8893675e39c..5f512c91471e 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -79,6 +79,7 @@
reg = <0x0 0x0>;
enable-method = "psci";
next-level-cache = <&l2>;
+ clocks = <&scpi_dvfs 0>;
};
cpu1: cpu@1 {
@@ -87,6 +88,7 @@
reg = <0x0 0x1>;
enable-method = "psci";
next-level-cache = <&l2>;
+ clocks = <&scpi_dvfs 0>;
};
cpu2: cpu@2 {
@@ -95,6 +97,7 @@
reg = <0x0 0x2>;
enable-method = "psci";
next-level-cache = <&l2>;
+ clocks = <&scpi_dvfs 0>;
};
cpu3: cpu@3 {
@@ -103,6 +106,7 @@
reg = <0x0 0x3>;
enable-method = "psci";
next-level-cache = <&l2>;
+ clocks = <&scpi_dvfs 0>;
};
l2: l2-cache0 {
@@ -137,6 +141,28 @@
};
};
+ scpi {
+ compatible = "arm,scpi-pre-1.0";
+ mboxes = <&mailbox 1 &mailbox 2>;
+ shmem = <&cpu_scp_lpri &cpu_scp_hpri>;
+
+ scpi_clocks: clocks {
+ compatible = "arm,scpi-clocks";
+
+ scpi_dvfs: clock-controller {
+ compatible = "arm,scpi-dvfs-clocks";
+ #clock-cells = <1>;
+ clock-indices = <0>;
+ clock-output-names = "vcpu";
+ };
+ };
+
+ scpi_sensors: sensors {
+ compatible = "amlogic,meson-gxbb-scpi-sensors";
+ #thermal-sensor-cells = <1>;
+ };
+ };
+
soc {
compatible = "simple-bus";
#address-cells = <2>;
--
2.19.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 4/4] arm64: dts: meson-axg: enable SCPI
@ 2018-11-08 13:53 ` Jerome Brunet
0 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: linux-arm-kernel
Enable SCPI on the axg platform, with cpu clock and hwmon
(core temperature) support
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 26 ++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index b8893675e39c..5f512c91471e 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -79,6 +79,7 @@
reg = <0x0 0x0>;
enable-method = "psci";
next-level-cache = <&l2>;
+ clocks = <&scpi_dvfs 0>;
};
cpu1: cpu at 1 {
@@ -87,6 +88,7 @@
reg = <0x0 0x1>;
enable-method = "psci";
next-level-cache = <&l2>;
+ clocks = <&scpi_dvfs 0>;
};
cpu2: cpu at 2 {
@@ -95,6 +97,7 @@
reg = <0x0 0x2>;
enable-method = "psci";
next-level-cache = <&l2>;
+ clocks = <&scpi_dvfs 0>;
};
cpu3: cpu at 3 {
@@ -103,6 +106,7 @@
reg = <0x0 0x3>;
enable-method = "psci";
next-level-cache = <&l2>;
+ clocks = <&scpi_dvfs 0>;
};
l2: l2-cache0 {
@@ -137,6 +141,28 @@
};
};
+ scpi {
+ compatible = "arm,scpi-pre-1.0";
+ mboxes = <&mailbox 1 &mailbox 2>;
+ shmem = <&cpu_scp_lpri &cpu_scp_hpri>;
+
+ scpi_clocks: clocks {
+ compatible = "arm,scpi-clocks";
+
+ scpi_dvfs: clock-controller {
+ compatible = "arm,scpi-dvfs-clocks";
+ #clock-cells = <1>;
+ clock-indices = <0>;
+ clock-output-names = "vcpu";
+ };
+ };
+
+ scpi_sensors: sensors {
+ compatible = "amlogic,meson-gxbb-scpi-sensors";
+ #thermal-sensor-cells = <1>;
+ };
+ };
+
soc {
compatible = "simple-bus";
#address-cells = <2>;
--
2.19.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 4/4] arm64: dts: meson-axg: enable SCPI
@ 2018-11-08 13:53 ` Jerome Brunet
0 siblings, 0 replies; 38+ messages in thread
From: Jerome Brunet @ 2018-11-08 13:53 UTC (permalink / raw)
To: linus-amlogic
Enable SCPI on the axg platform, with cpu clock and hwmon
(core temperature) support
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 26 ++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index b8893675e39c..5f512c91471e 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -79,6 +79,7 @@
reg = <0x0 0x0>;
enable-method = "psci";
next-level-cache = <&l2>;
+ clocks = <&scpi_dvfs 0>;
};
cpu1: cpu at 1 {
@@ -87,6 +88,7 @@
reg = <0x0 0x1>;
enable-method = "psci";
next-level-cache = <&l2>;
+ clocks = <&scpi_dvfs 0>;
};
cpu2: cpu at 2 {
@@ -95,6 +97,7 @@
reg = <0x0 0x2>;
enable-method = "psci";
next-level-cache = <&l2>;
+ clocks = <&scpi_dvfs 0>;
};
cpu3: cpu at 3 {
@@ -103,6 +106,7 @@
reg = <0x0 0x3>;
enable-method = "psci";
next-level-cache = <&l2>;
+ clocks = <&scpi_dvfs 0>;
};
l2: l2-cache0 {
@@ -137,6 +141,28 @@
};
};
+ scpi {
+ compatible = "arm,scpi-pre-1.0";
+ mboxes = <&mailbox 1 &mailbox 2>;
+ shmem = <&cpu_scp_lpri &cpu_scp_hpri>;
+
+ scpi_clocks: clocks {
+ compatible = "arm,scpi-clocks";
+
+ scpi_dvfs: clock-controller {
+ compatible = "arm,scpi-dvfs-clocks";
+ #clock-cells = <1>;
+ clock-indices = <0>;
+ clock-output-names = "vcpu";
+ };
+ };
+
+ scpi_sensors: sensors {
+ compatible = "amlogic,meson-gxbb-scpi-sensors";
+ #thermal-sensor-cells = <1>;
+ };
+ };
+
soc {
compatible = "simple-bus";
#address-cells = <2>;
--
2.19.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* Re: [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings
2018-11-08 13:53 ` Jerome Brunet
(?)
@ 2018-11-08 16:04 ` Sudeep Holla
-1 siblings, 0 replies; 38+ messages in thread
From: Sudeep Holla @ 2018-11-08 16:04 UTC (permalink / raw)
To: Jerome Brunet
Cc: Kevin Hilman, Carlo Caione, devicetree, linux-amlogic,
linux-kernel, linux-arm-kernel, Sudeep Holla
On Thu, Nov 08, 2018 at 02:53:51PM +0100, Jerome Brunet wrote:
> amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not
> documented. Just add it to amlogic's scpi documentation
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Documentation/devicetree/bindings/arm/amlogic,scpi.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> index 7b9a861e9306..5ab59da052df 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> +++ b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> @@ -17,4 +17,11 @@ Required sub-node properties:
> - compatible : should be "amlogic,meson-gxbb-scp-shmem" for SRAM based shared
> memory on Amlogic GXBB SoC.
>
> +Sensor bindings for the sensors based on SCPI Message Protocol
> +--------------------------------------------------------------
> +SCPI provides an API to access the various sensors on the SoC.
> +
> +Required properties:
> +- compatible : should be "amlogic,meson-gxbb-scpi-sensors".
> +
Not sure if it's worth mentioning the reason for being able to identify
amlogic,meson-gxbb sensors from generic scpi ones. IIRC it was for the
unit values of these sensors are different ? But I will leave that to
DT or platform maintainers' taste.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings
@ 2018-11-08 16:04 ` Sudeep Holla
0 siblings, 0 replies; 38+ messages in thread
From: Sudeep Holla @ 2018-11-08 16:04 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 08, 2018 at 02:53:51PM +0100, Jerome Brunet wrote:
> amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not
> documented. Just add it to amlogic's scpi documentation
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Documentation/devicetree/bindings/arm/amlogic,scpi.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> index 7b9a861e9306..5ab59da052df 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> +++ b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> @@ -17,4 +17,11 @@ Required sub-node properties:
> - compatible : should be "amlogic,meson-gxbb-scp-shmem" for SRAM based shared
> memory on Amlogic GXBB SoC.
>
> +Sensor bindings for the sensors based on SCPI Message Protocol
> +--------------------------------------------------------------
> +SCPI provides an API to access the various sensors on the SoC.
> +
> +Required properties:
> +- compatible : should be "amlogic,meson-gxbb-scpi-sensors".
> +
Not sure if it's worth mentioning the reason for being able to identify
amlogic,meson-gxbb sensors from generic scpi ones. IIRC it was for the
unit values of these sensors are different ? But I will leave that to
DT or platform maintainers' taste.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings
@ 2018-11-08 16:04 ` Sudeep Holla
0 siblings, 0 replies; 38+ messages in thread
From: Sudeep Holla @ 2018-11-08 16:04 UTC (permalink / raw)
To: linus-amlogic
On Thu, Nov 08, 2018 at 02:53:51PM +0100, Jerome Brunet wrote:
> amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not
> documented. Just add it to amlogic's scpi documentation
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Documentation/devicetree/bindings/arm/amlogic,scpi.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> index 7b9a861e9306..5ab59da052df 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> +++ b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> @@ -17,4 +17,11 @@ Required sub-node properties:
> - compatible : should be "amlogic,meson-gxbb-scp-shmem" for SRAM based shared
> memory on Amlogic GXBB SoC.
>
> +Sensor bindings for the sensors based on SCPI Message Protocol
> +--------------------------------------------------------------
> +SCPI provides an API to access the various sensors on the SoC.
> +
> +Required properties:
> +- compatible : should be "amlogic,meson-gxbb-scpi-sensors".
> +
Not sure if it's worth mentioning the reason for being able to identify
amlogic,meson-gxbb sensors from generic scpi ones. IIRC it was for the
unit values of these sensors are different ? But I will leave that to
DT or platform maintainers' taste.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings
2018-11-08 16:04 ` Sudeep Holla
(?)
@ 2018-11-08 16:29 ` jbrunet at baylibre.com
-1 siblings, 0 replies; 38+ messages in thread
From: jbrunet @ 2018-11-08 16:29 UTC (permalink / raw)
To: Sudeep Holla
Cc: Kevin Hilman, Carlo Caione, devicetree, linux-amlogic,
linux-kernel, linux-arm-kernel
On Thu, 2018-11-08 at 16:04 +0000, Sudeep Holla wrote:
> On Thu, Nov 08, 2018 at 02:53:51PM +0100, Jerome Brunet wrote:
> > amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not
> > documented. Just add it to amlogic's scpi documentation
> >
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> > ---
> > Documentation/devicetree/bindings/arm/amlogic,scpi.txt | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> > b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> > index 7b9a861e9306..5ab59da052df 100644
> > --- a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> > +++ b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> > @@ -17,4 +17,11 @@ Required sub-node properties:
> > - compatible : should be "amlogic,meson-gxbb-scp-shmem" for SRAM based
> > shared
> > memory on Amlogic GXBB SoC.
> >
> > +Sensor bindings for the sensors based on SCPI Message Protocol
> > +--------------------------------------------------------------
> > +SCPI provides an API to access the various sensors on the SoC.
> > +
> > +Required properties:
> > +- compatible : should be "amlogic,meson-gxbb-scpi-sensors".
> > +
>
> Not sure if it's worth mentioning the reason for being able to identify
> amlogic,meson-gxbb sensors from generic scpi ones. IIRC it was for the
> unit values of these sensors are different ? But I will leave that to
> DT or platform maintainers' taste.
Yes Sudeep, the unit are different.
If we probe on the generic one, it will "work" but the result is just not
good.
BTW, the point of this patch is merely to remove an existing issue.
The scpi driver and meson-gx.dtsi are both refering to an undocumented
compatible.
>
> --
> Regards,
> Sudeep
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings
@ 2018-11-08 16:29 ` jbrunet at baylibre.com
0 siblings, 0 replies; 38+ messages in thread
From: jbrunet at baylibre.com @ 2018-11-08 16:29 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 2018-11-08 at 16:04 +0000, Sudeep Holla wrote:
> On Thu, Nov 08, 2018 at 02:53:51PM +0100, Jerome Brunet wrote:
> > amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not
> > documented. Just add it to amlogic's scpi documentation
> >
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> > ---
> > Documentation/devicetree/bindings/arm/amlogic,scpi.txt | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> > b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> > index 7b9a861e9306..5ab59da052df 100644
> > --- a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> > +++ b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> > @@ -17,4 +17,11 @@ Required sub-node properties:
> > - compatible : should be "amlogic,meson-gxbb-scp-shmem" for SRAM based
> > shared
> > memory on Amlogic GXBB SoC.
> >
> > +Sensor bindings for the sensors based on SCPI Message Protocol
> > +--------------------------------------------------------------
> > +SCPI provides an API to access the various sensors on the SoC.
> > +
> > +Required properties:
> > +- compatible : should be "amlogic,meson-gxbb-scpi-sensors".
> > +
>
> Not sure if it's worth mentioning the reason for being able to identify
> amlogic,meson-gxbb sensors from generic scpi ones. IIRC it was for the
> unit values of these sensors are different ? But I will leave that to
> DT or platform maintainers' taste.
Yes Sudeep, the unit are different.
If we probe on the generic one, it will "work" but the result is just not
good.
BTW, the point of this patch is merely to remove an existing issue.
The scpi driver and meson-gx.dtsi are both refering to an undocumented
compatible.
>
> --
> Regards,
> Sudeep
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings
@ 2018-11-08 16:29 ` jbrunet at baylibre.com
0 siblings, 0 replies; 38+ messages in thread
From: jbrunet at baylibre.com @ 2018-11-08 16:29 UTC (permalink / raw)
To: linus-amlogic
On Thu, 2018-11-08 at 16:04 +0000, Sudeep Holla wrote:
> On Thu, Nov 08, 2018 at 02:53:51PM +0100, Jerome Brunet wrote:
> > amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not
> > documented. Just add it to amlogic's scpi documentation
> >
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> > ---
> > Documentation/devicetree/bindings/arm/amlogic,scpi.txt | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> > b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> > index 7b9a861e9306..5ab59da052df 100644
> > --- a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> > +++ b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> > @@ -17,4 +17,11 @@ Required sub-node properties:
> > - compatible : should be "amlogic,meson-gxbb-scp-shmem" for SRAM based
> > shared
> > memory on Amlogic GXBB SoC.
> >
> > +Sensor bindings for the sensors based on SCPI Message Protocol
> > +--------------------------------------------------------------
> > +SCPI provides an API to access the various sensors on the SoC.
> > +
> > +Required properties:
> > +- compatible : should be "amlogic,meson-gxbb-scpi-sensors".
> > +
>
> Not sure if it's worth mentioning the reason for being able to identify
> amlogic,meson-gxbb sensors from generic scpi ones. IIRC it was for the
> unit values of these sensors are different ? But I will leave that to
> DT or platform maintainers' taste.
Yes Sudeep, the unit are different.
If we probe on the generic one, it will "work" but the result is just not
good.
BTW, the point of this patch is merely to remove an existing issue.
The scpi driver and meson-gx.dtsi are both refering to an undocumented
compatible.
>
> --
> Regards,
> Sudeep
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 1/4] arm64: dts: meson-axg: fix mailbox address
2018-11-08 13:53 ` Jerome Brunet
(?)
@ 2018-11-09 9:37 ` Neil Armstrong
-1 siblings, 0 replies; 38+ messages in thread
From: Neil Armstrong @ 2018-11-09 9:37 UTC (permalink / raw)
To: Jerome Brunet, Kevin Hilman, Carlo Caione
Cc: devicetree, linux-amlogic, linux-kernel, linux-arm-kernel
On 08/11/2018 14:53, Jerome Brunet wrote:
> MHU mailbox address is wrong. Fixing it enables the mailboxes on the A113.
> These mailboxes are needed for SCPI
>
> Fixes: 9d59b708500f ("arm64: dts: meson-axg: add initial A113D SoC DT support")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 3cc0044d3468..ff8b3406aff6 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -1067,9 +1067,9 @@
> };
> };
>
> - mailbox: mailbox@ff63dc00 {
> + mailbox: mailbox@ff63c404 {
> compatible = "amlogic,meson-gx-mhu", "amlogic,meson-gxbb-mhu";
> - reg = <0 0xff63dc00 0 0x400>;
> + reg = <0 0xff63c404 0 0x4c>;
> interrupts = <GIC_SPI 208 IRQ_TYPE_EDGE_RISING>,
> <GIC_SPI 209 IRQ_TYPE_EDGE_RISING>,
> <GIC_SPI 210 IRQ_TYPE_EDGE_RISING>;
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 1/4] arm64: dts: meson-axg: fix mailbox address
@ 2018-11-09 9:37 ` Neil Armstrong
0 siblings, 0 replies; 38+ messages in thread
From: Neil Armstrong @ 2018-11-09 9:37 UTC (permalink / raw)
To: linux-arm-kernel
On 08/11/2018 14:53, Jerome Brunet wrote:
> MHU mailbox address is wrong. Fixing it enables the mailboxes on the A113.
> These mailboxes are needed for SCPI
>
> Fixes: 9d59b708500f ("arm64: dts: meson-axg: add initial A113D SoC DT support")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 3cc0044d3468..ff8b3406aff6 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -1067,9 +1067,9 @@
> };
> };
>
> - mailbox: mailbox at ff63dc00 {
> + mailbox: mailbox at ff63c404 {
> compatible = "amlogic,meson-gx-mhu", "amlogic,meson-gxbb-mhu";
> - reg = <0 0xff63dc00 0 0x400>;
> + reg = <0 0xff63c404 0 0x4c>;
> interrupts = <GIC_SPI 208 IRQ_TYPE_EDGE_RISING>,
> <GIC_SPI 209 IRQ_TYPE_EDGE_RISING>,
> <GIC_SPI 210 IRQ_TYPE_EDGE_RISING>;
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 1/4] arm64: dts: meson-axg: fix mailbox address
@ 2018-11-09 9:37 ` Neil Armstrong
0 siblings, 0 replies; 38+ messages in thread
From: Neil Armstrong @ 2018-11-09 9:37 UTC (permalink / raw)
To: linus-amlogic
On 08/11/2018 14:53, Jerome Brunet wrote:
> MHU mailbox address is wrong. Fixing it enables the mailboxes on the A113.
> These mailboxes are needed for SCPI
>
> Fixes: 9d59b708500f ("arm64: dts: meson-axg: add initial A113D SoC DT support")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 3cc0044d3468..ff8b3406aff6 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -1067,9 +1067,9 @@
> };
> };
>
> - mailbox: mailbox at ff63dc00 {
> + mailbox: mailbox at ff63c404 {
> compatible = "amlogic,meson-gx-mhu", "amlogic,meson-gxbb-mhu";
> - reg = <0 0xff63dc00 0 0x400>;
> + reg = <0 0xff63c404 0 0x4c>;
> interrupts = <GIC_SPI 208 IRQ_TYPE_EDGE_RISING>,
> <GIC_SPI 209 IRQ_TYPE_EDGE_RISING>,
> <GIC_SPI 210 IRQ_TYPE_EDGE_RISING>;
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 2/4] arm64: dts: meson-axg: correct sram shared mem unit-address
2018-11-08 13:53 ` Jerome Brunet
(?)
@ 2018-11-09 9:38 ` Neil Armstrong
-1 siblings, 0 replies; 38+ messages in thread
From: Neil Armstrong @ 2018-11-09 9:38 UTC (permalink / raw)
To: Jerome Brunet, Kevin Hilman, Carlo Caione
Cc: devicetree, linux-amlogic, linux-kernel, linux-arm-kernel
On 08/11/2018 14:53, Jerome Brunet wrote:
> Correct the unit-address in the node name of the SRAM shared memory
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index ff8b3406aff6..b8893675e39c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -1659,12 +1659,12 @@
> #size-cells = <1>;
> ranges = <0 0x0 0xfffc0000 0x20000>;
>
> - cpu_scp_lpri: scp-shmem@0 {
> + cpu_scp_lpri: scp-shmem@13000 {
> compatible = "amlogic,meson-axg-scp-shmem";
> reg = <0x13000 0x400>;
> };
>
> - cpu_scp_hpri: scp-shmem@200 {
> + cpu_scp_hpri: scp-shmem@13400 {
> compatible = "amlogic,meson-axg-scp-shmem";
> reg = <0x13400 0x400>;
> };
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 2/4] arm64: dts: meson-axg: correct sram shared mem unit-address
@ 2018-11-09 9:38 ` Neil Armstrong
0 siblings, 0 replies; 38+ messages in thread
From: Neil Armstrong @ 2018-11-09 9:38 UTC (permalink / raw)
To: linux-arm-kernel
On 08/11/2018 14:53, Jerome Brunet wrote:
> Correct the unit-address in the node name of the SRAM shared memory
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index ff8b3406aff6..b8893675e39c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -1659,12 +1659,12 @@
> #size-cells = <1>;
> ranges = <0 0x0 0xfffc0000 0x20000>;
>
> - cpu_scp_lpri: scp-shmem at 0 {
> + cpu_scp_lpri: scp-shmem at 13000 {
> compatible = "amlogic,meson-axg-scp-shmem";
> reg = <0x13000 0x400>;
> };
>
> - cpu_scp_hpri: scp-shmem at 200 {
> + cpu_scp_hpri: scp-shmem at 13400 {
> compatible = "amlogic,meson-axg-scp-shmem";
> reg = <0x13400 0x400>;
> };
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 2/4] arm64: dts: meson-axg: correct sram shared mem unit-address
@ 2018-11-09 9:38 ` Neil Armstrong
0 siblings, 0 replies; 38+ messages in thread
From: Neil Armstrong @ 2018-11-09 9:38 UTC (permalink / raw)
To: linus-amlogic
On 08/11/2018 14:53, Jerome Brunet wrote:
> Correct the unit-address in the node name of the SRAM shared memory
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index ff8b3406aff6..b8893675e39c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -1659,12 +1659,12 @@
> #size-cells = <1>;
> ranges = <0 0x0 0xfffc0000 0x20000>;
>
> - cpu_scp_lpri: scp-shmem at 0 {
> + cpu_scp_lpri: scp-shmem at 13000 {
> compatible = "amlogic,meson-axg-scp-shmem";
> reg = <0x13000 0x400>;
> };
>
> - cpu_scp_hpri: scp-shmem at 200 {
> + cpu_scp_hpri: scp-shmem at 13400 {
> compatible = "amlogic,meson-axg-scp-shmem";
> reg = <0x13400 0x400>;
> };
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 4/4] arm64: dts: meson-axg: enable SCPI
2018-11-08 13:53 ` Jerome Brunet
(?)
@ 2018-11-09 9:39 ` Neil Armstrong
-1 siblings, 0 replies; 38+ messages in thread
From: Neil Armstrong @ 2018-11-09 9:39 UTC (permalink / raw)
To: Jerome Brunet, Kevin Hilman, Carlo Caione
Cc: devicetree, linux-amlogic, linux-kernel, linux-arm-kernel
On 08/11/2018 14:53, Jerome Brunet wrote:
> Enable SCPI on the axg platform, with cpu clock and hwmon
> (core temperature) support
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 26 ++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index b8893675e39c..5f512c91471e 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -79,6 +79,7 @@
> reg = <0x0 0x0>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> cpu1: cpu@1 {
> @@ -87,6 +88,7 @@
> reg = <0x0 0x1>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> cpu2: cpu@2 {
> @@ -95,6 +97,7 @@
> reg = <0x0 0x2>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> cpu3: cpu@3 {
> @@ -103,6 +106,7 @@
> reg = <0x0 0x3>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> l2: l2-cache0 {
> @@ -137,6 +141,28 @@
> };
> };
>
> + scpi {
> + compatible = "arm,scpi-pre-1.0";
> + mboxes = <&mailbox 1 &mailbox 2>;
> + shmem = <&cpu_scp_lpri &cpu_scp_hpri>;
> +
> + scpi_clocks: clocks {
> + compatible = "arm,scpi-clocks";
> +
> + scpi_dvfs: clock-controller {
> + compatible = "arm,scpi-dvfs-clocks";
> + #clock-cells = <1>;
> + clock-indices = <0>;
> + clock-output-names = "vcpu";
> + };
> + };
> +
> + scpi_sensors: sensors {
> + compatible = "amlogic,meson-gxbb-scpi-sensors";
> + #thermal-sensor-cells = <1>;
> + };
> + };
> +
> soc {
> compatible = "simple-bus";
> #address-cells = <2>;
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 4/4] arm64: dts: meson-axg: enable SCPI
@ 2018-11-09 9:39 ` Neil Armstrong
0 siblings, 0 replies; 38+ messages in thread
From: Neil Armstrong @ 2018-11-09 9:39 UTC (permalink / raw)
To: linux-arm-kernel
On 08/11/2018 14:53, Jerome Brunet wrote:
> Enable SCPI on the axg platform, with cpu clock and hwmon
> (core temperature) support
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 26 ++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index b8893675e39c..5f512c91471e 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -79,6 +79,7 @@
> reg = <0x0 0x0>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> cpu1: cpu at 1 {
> @@ -87,6 +88,7 @@
> reg = <0x0 0x1>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> cpu2: cpu at 2 {
> @@ -95,6 +97,7 @@
> reg = <0x0 0x2>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> cpu3: cpu at 3 {
> @@ -103,6 +106,7 @@
> reg = <0x0 0x3>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> l2: l2-cache0 {
> @@ -137,6 +141,28 @@
> };
> };
>
> + scpi {
> + compatible = "arm,scpi-pre-1.0";
> + mboxes = <&mailbox 1 &mailbox 2>;
> + shmem = <&cpu_scp_lpri &cpu_scp_hpri>;
> +
> + scpi_clocks: clocks {
> + compatible = "arm,scpi-clocks";
> +
> + scpi_dvfs: clock-controller {
> + compatible = "arm,scpi-dvfs-clocks";
> + #clock-cells = <1>;
> + clock-indices = <0>;
> + clock-output-names = "vcpu";
> + };
> + };
> +
> + scpi_sensors: sensors {
> + compatible = "amlogic,meson-gxbb-scpi-sensors";
> + #thermal-sensor-cells = <1>;
> + };
> + };
> +
> soc {
> compatible = "simple-bus";
> #address-cells = <2>;
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 4/4] arm64: dts: meson-axg: enable SCPI
@ 2018-11-09 9:39 ` Neil Armstrong
0 siblings, 0 replies; 38+ messages in thread
From: Neil Armstrong @ 2018-11-09 9:39 UTC (permalink / raw)
To: linus-amlogic
On 08/11/2018 14:53, Jerome Brunet wrote:
> Enable SCPI on the axg platform, with cpu clock and hwmon
> (core temperature) support
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 26 ++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index b8893675e39c..5f512c91471e 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -79,6 +79,7 @@
> reg = <0x0 0x0>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> cpu1: cpu at 1 {
> @@ -87,6 +88,7 @@
> reg = <0x0 0x1>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> cpu2: cpu at 2 {
> @@ -95,6 +97,7 @@
> reg = <0x0 0x2>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> cpu3: cpu at 3 {
> @@ -103,6 +106,7 @@
> reg = <0x0 0x3>;
> enable-method = "psci";
> next-level-cache = <&l2>;
> + clocks = <&scpi_dvfs 0>;
> };
>
> l2: l2-cache0 {
> @@ -137,6 +141,28 @@
> };
> };
>
> + scpi {
> + compatible = "arm,scpi-pre-1.0";
> + mboxes = <&mailbox 1 &mailbox 2>;
> + shmem = <&cpu_scp_lpri &cpu_scp_hpri>;
> +
> + scpi_clocks: clocks {
> + compatible = "arm,scpi-clocks";
> +
> + scpi_dvfs: clock-controller {
> + compatible = "arm,scpi-dvfs-clocks";
> + #clock-cells = <1>;
> + clock-indices = <0>;
> + clock-output-names = "vcpu";
> + };
> + };
> +
> + scpi_sensors: sensors {
> + compatible = "amlogic,meson-gxbb-scpi-sensors";
> + #thermal-sensor-cells = <1>;
> + };
> + };
> +
> soc {
> compatible = "simple-bus";
> #address-cells = <2>;
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 0/4] arm64: dts: meson-axg: enable SCPI
2018-11-08 13:53 ` Jerome Brunet
(?)
(?)
@ 2018-11-15 20:07 ` Kevin Hilman
-1 siblings, 0 replies; 38+ messages in thread
From: Kevin Hilman @ 2018-11-15 20:07 UTC (permalink / raw)
To: Jerome Brunet, Carlo Caione
Cc: Jerome Brunet, devicetree, linux-amlogic, linux-kernel, linux-arm-kernel
Jerome Brunet <jbrunet@baylibre.com> writes:
> The goal of this patchset is to enable SCPI (dvfs and hwmon) the axg
> platform. The first patches in this series fix a few issues to acheive
> this.
Queued for v4.21 (branch: v4.21/dt64)
Kevin
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 0/4] arm64: dts: meson-axg: enable SCPI
@ 2018-11-15 20:07 ` Kevin Hilman
0 siblings, 0 replies; 38+ messages in thread
From: Kevin Hilman @ 2018-11-15 20:07 UTC (permalink / raw)
To: Carlo Caione
Cc: Jerome Brunet, devicetree, linux-amlogic, linux-kernel, linux-arm-kernel
Jerome Brunet <jbrunet@baylibre.com> writes:
> The goal of this patchset is to enable SCPI (dvfs and hwmon) the axg
> platform. The first patches in this series fix a few issues to acheive
> this.
Queued for v4.21 (branch: v4.21/dt64)
Kevin
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 0/4] arm64: dts: meson-axg: enable SCPI
@ 2018-11-15 20:07 ` Kevin Hilman
0 siblings, 0 replies; 38+ messages in thread
From: Kevin Hilman @ 2018-11-15 20:07 UTC (permalink / raw)
To: linux-arm-kernel
Jerome Brunet <jbrunet@baylibre.com> writes:
> The goal of this patchset is to enable SCPI (dvfs and hwmon) the axg
> platform. The first patches in this series fix a few issues to acheive
> this.
Queued for v4.21 (branch: v4.21/dt64)
Kevin
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 0/4] arm64: dts: meson-axg: enable SCPI
@ 2018-11-15 20:07 ` Kevin Hilman
0 siblings, 0 replies; 38+ messages in thread
From: Kevin Hilman @ 2018-11-15 20:07 UTC (permalink / raw)
To: linus-amlogic
Jerome Brunet <jbrunet@baylibre.com> writes:
> The goal of this patchset is to enable SCPI (dvfs and hwmon) the axg
> platform. The first patches in this series fix a few issues to acheive
> this.
Queued for v4.21 (branch: v4.21/dt64)
Kevin
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings
2018-11-08 13:53 ` Jerome Brunet
(?)
(?)
@ 2018-11-17 16:21 ` Rob Herring
-1 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2018-11-17 16:21 UTC (permalink / raw)
To: Jerome Brunet
Cc: Kevin Hilman, Carlo Caione, Jerome Brunet, devicetree,
linux-amlogic, linux-kernel, linux-arm-kernel
On Thu, 8 Nov 2018 14:53:51 +0100, Jerome Brunet wrote:
> amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not
> documented. Just add it to amlogic's scpi documentation
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Documentation/devicetree/bindings/arm/amlogic,scpi.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings
@ 2018-11-17 16:21 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2018-11-17 16:21 UTC (permalink / raw)
Cc: Kevin Hilman, Carlo Caione, Jerome Brunet, devicetree,
linux-amlogic, linux-kernel, linux-arm-kernel
On Thu, 8 Nov 2018 14:53:51 +0100, Jerome Brunet wrote:
> amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not
> documented. Just add it to amlogic's scpi documentation
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Documentation/devicetree/bindings/arm/amlogic,scpi.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings
@ 2018-11-17 16:21 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2018-11-17 16:21 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 8 Nov 2018 14:53:51 +0100, Jerome Brunet wrote:
> amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not
> documented. Just add it to amlogic's scpi documentation
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Documentation/devicetree/bindings/arm/amlogic,scpi.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings
@ 2018-11-17 16:21 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2018-11-17 16:21 UTC (permalink / raw)
To: linus-amlogic
On Thu, 8 Nov 2018 14:53:51 +0100, Jerome Brunet wrote:
> amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not
> documented. Just add it to amlogic's scpi documentation
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Documentation/devicetree/bindings/arm/amlogic,scpi.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 38+ messages in thread
end of thread, other threads:[~2018-11-17 16:21 UTC | newest]
Thread overview: 38+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-08 13:53 [PATCH 0/4] arm64: dts: meson-axg: enable SCPI Jerome Brunet
2018-11-08 13:53 ` Jerome Brunet
2018-11-08 13:53 ` Jerome Brunet
2018-11-08 13:53 ` [PATCH 1/4] arm64: dts: meson-axg: fix mailbox address Jerome Brunet
2018-11-08 13:53 ` Jerome Brunet
2018-11-08 13:53 ` Jerome Brunet
2018-11-09 9:37 ` Neil Armstrong
2018-11-09 9:37 ` Neil Armstrong
2018-11-09 9:37 ` Neil Armstrong
2018-11-08 13:53 ` [PATCH 2/4] arm64: dts: meson-axg: correct sram shared mem unit-address Jerome Brunet
2018-11-08 13:53 ` Jerome Brunet
2018-11-08 13:53 ` Jerome Brunet
2018-11-09 9:38 ` Neil Armstrong
2018-11-09 9:38 ` Neil Armstrong
2018-11-09 9:38 ` Neil Armstrong
2018-11-08 13:53 ` [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings Jerome Brunet
2018-11-08 13:53 ` Jerome Brunet
2018-11-08 13:53 ` Jerome Brunet
2018-11-08 16:04 ` Sudeep Holla
2018-11-08 16:04 ` Sudeep Holla
2018-11-08 16:04 ` Sudeep Holla
2018-11-08 16:29 ` jbrunet
2018-11-08 16:29 ` jbrunet at baylibre.com
2018-11-08 16:29 ` jbrunet at baylibre.com
2018-11-17 16:21 ` Rob Herring
2018-11-17 16:21 ` Rob Herring
2018-11-17 16:21 ` Rob Herring
2018-11-17 16:21 ` Rob Herring
2018-11-08 13:53 ` [PATCH 4/4] arm64: dts: meson-axg: enable SCPI Jerome Brunet
2018-11-08 13:53 ` Jerome Brunet
2018-11-08 13:53 ` Jerome Brunet
2018-11-09 9:39 ` Neil Armstrong
2018-11-09 9:39 ` Neil Armstrong
2018-11-09 9:39 ` Neil Armstrong
2018-11-15 20:07 ` [PATCH 0/4] " Kevin Hilman
2018-11-15 20:07 ` Kevin Hilman
2018-11-15 20:07 ` Kevin Hilman
2018-11-15 20:07 ` Kevin Hilman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.