* [PATCH for-6.1 1/1] selftests/net: don't tests batched TCP io_uring zc
@ 2022-10-26 23:11 Pavel Begunkov
2022-11-02 10:42 ` Pavel Begunkov
2022-11-02 14:27 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Pavel Begunkov @ 2022-10-26 23:11 UTC (permalink / raw)
To: io-uring; +Cc: Jens Axboe, asml.silence
It doesn't make sense batch submitting io_uring requests to a single TCP
socket without linking or some other kind of ordering. Moreover, it
causes spurious -EINTR fails due to interaction with task_work. Disable
it for now and keep queue depth=1.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
tools/testing/selftests/net/io_uring_zerocopy_tx.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/io_uring_zerocopy_tx.sh b/tools/testing/selftests/net/io_uring_zerocopy_tx.sh
index 32aa6e9dacc2..9ac4456d48fc 100755
--- a/tools/testing/selftests/net/io_uring_zerocopy_tx.sh
+++ b/tools/testing/selftests/net/io_uring_zerocopy_tx.sh
@@ -29,7 +29,7 @@ if [[ "$#" -eq "0" ]]; then
for IP in "${IPs[@]}"; do
for mode in $(seq 1 3); do
$0 "$IP" udp -m "$mode" -t 1 -n 32
- $0 "$IP" tcp -m "$mode" -t 1 -n 32
+ $0 "$IP" tcp -m "$mode" -t 1 -n 1
done
done
--
2.38.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH for-6.1 1/1] selftests/net: don't tests batched TCP io_uring zc
2022-10-26 23:11 [PATCH for-6.1 1/1] selftests/net: don't tests batched TCP io_uring zc Pavel Begunkov
@ 2022-11-02 10:42 ` Pavel Begunkov
2022-11-02 14:27 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Begunkov @ 2022-11-02 10:42 UTC (permalink / raw)
To: io-uring; +Cc: Jens Axboe
On 10/27/22 00:11, Pavel Begunkov wrote:
> It doesn't make sense batch submitting io_uring requests to a single TCP
> socket without linking or some other kind of ordering. Moreover, it
> causes spurious -EINTR fails due to interaction with task_work. Disable
> it for now and keep queue depth=1.
Jens, let's pick it up unless you have objections
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
> tools/testing/selftests/net/io_uring_zerocopy_tx.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/io_uring_zerocopy_tx.sh b/tools/testing/selftests/net/io_uring_zerocopy_tx.sh
> index 32aa6e9dacc2..9ac4456d48fc 100755
> --- a/tools/testing/selftests/net/io_uring_zerocopy_tx.sh
> +++ b/tools/testing/selftests/net/io_uring_zerocopy_tx.sh
> @@ -29,7 +29,7 @@ if [[ "$#" -eq "0" ]]; then
> for IP in "${IPs[@]}"; do
> for mode in $(seq 1 3); do
> $0 "$IP" udp -m "$mode" -t 1 -n 32
> - $0 "$IP" tcp -m "$mode" -t 1 -n 32
> + $0 "$IP" tcp -m "$mode" -t 1 -n 1
> done
> done
>
--
Pavel Begunkov
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-6.1 1/1] selftests/net: don't tests batched TCP io_uring zc
2022-10-26 23:11 [PATCH for-6.1 1/1] selftests/net: don't tests batched TCP io_uring zc Pavel Begunkov
2022-11-02 10:42 ` Pavel Begunkov
@ 2022-11-02 14:27 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-11-02 14:27 UTC (permalink / raw)
To: io-uring, Pavel Begunkov
On Thu, 27 Oct 2022 00:11:53 +0100, Pavel Begunkov wrote:
> It doesn't make sense batch submitting io_uring requests to a single TCP
> socket without linking or some other kind of ordering. Moreover, it
> causes spurious -EINTR fails due to interaction with task_work. Disable
> it for now and keep queue depth=1.
>
>
Applied, thanks!
[1/1] selftests/net: don't tests batched TCP io_uring zc
commit: 9921d5013a6e51892623bf2f1c5b49eaecda55ac
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-02 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-26 23:11 [PATCH for-6.1 1/1] selftests/net: don't tests batched TCP io_uring zc Pavel Begunkov
2022-11-02 10:42 ` Pavel Begunkov
2022-11-02 14:27 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.