From: Lucas Stach <l.stach@pengutronix.de> To: Adam Ford <aford173@gmail.com>, linux-arm-kernel@lists.infradead.org Cc: aford@beaconembedded.com, Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] dt-bindings: soc: add binding for i.MX8MN DISP blk-ctrl Date: Wed, 06 Oct 2021 09:39:08 +0200 [thread overview] Message-ID: <b5b80a0fafe6b774fe9d8bb9e1431960cf2e7330.camel@pengutronix.de> (raw) In-Reply-To: <20211006000505.627334-2-aford173@gmail.com> Am Dienstag, dem 05.10.2021 um 19:04 -0500 schrieb Adam Ford: > This adds the DT binding for the i.MX8MN DISP blk-ctrl. > > Signed-off-by: Adam Ford <aford173@gmail.com> > --- > .../soc/imx/fsl,imx8mn-disp-blk-ctrl.yaml | 97 +++++++++++++++++++ > 1 file changed, 97 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx8mn-disp-blk-ctrl.yaml > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mn-disp-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mn-disp-blk-ctrl.yaml > new file mode 100644 > index 000000000000..92d30aff446e > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mn-disp-blk-ctrl.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml# mm -> mn in the file name. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8MN DISP blk-ctrl > + > +maintainers: > + - Lucas Stach <l.stach@pengutronix.de> I'm not opposed to being maintainer for this file, just making sure that this is what you intended. Other than that I think this looks okay. Regards, Lucas > + > +description: > + The i.MX8MN DISP blk-ctrl is a top-level peripheral providing access to > + the NoC and ensuring proper power sequencing of the display and MIPI CSI > + peripherals located in the DISP domain of the SoC. > + > +properties: > + compatible: > + items: > + - const: fsl,imx8mn-disp-blk-ctrl > + - const: syscon > + > + reg: > + maxItems: 1 > + > + '#power-domain-cells': > + const: 1 > + > + power-domains: > + minItems: 5 > + maxItems: 5 > + > + power-domain-names: > + items: > + - const: bus > + - const: isi > + - const: lcdif > + - const: mipi-dsi > + - const: mipi-csi > + > + clocks: > + minItems: 11 > + maxItems: 11 > + > + clock-names: > + items: > + - const: disp_axi > + - const: disp_apb > + - const: disp_axi_root > + - const: disp_apb_root > + - const: lcdif-axi > + - const: lcdif-apb > + - const: lcdif-pix > + - const: dsi-pclk > + - const: dsi-ref > + - const: csi-aclk > + - const: csi-pclk > + > +required: > + - compatible > + - reg > + - power-domains > + - power-domain-names > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/imx8mn-clock.h> > + #include <dt-bindings/power/imx8mn-power.h> > + > + disp_blk_ctl: blk_ctrl@32e28000 { > + compatible = "fsl,imx8mn-disp-blk-ctrl", "syscon"; > + reg = <0x32e28000 0x100>; > + power-domains = <&pgc_dispmix>, <&pgc_dispmix>, > + <&pgc_dispmix>, <&pgc_mipi>, > + <&pgc_mipi>; > + power-domain-names = "bus", "isi", "lcdif", "mipi-dsi", > + "mipi-csi"; > + clocks = <&clk IMX8MN_CLK_DISP_AXI>, > + <&clk IMX8MN_CLK_DISP_APB>, > + <&clk IMX8MN_CLK_DISP_AXI_ROOT>, > + <&clk IMX8MN_CLK_DISP_APB_ROOT>, > + <&clk IMX8MN_CLK_DISP_AXI_ROOT>, > + <&clk IMX8MN_CLK_DISP_APB_ROOT>, > + <&clk IMX8MN_CLK_DISP_PIXEL_ROOT>, > + <&clk IMX8MN_CLK_DSI_CORE>, > + <&clk IMX8MN_CLK_DSI_PHY_REF>, > + <&clk IMX8MN_CLK_CSI1_PHY_REF>, > + <&clk IMX8MN_CLK_CAMERA_PIXEL_ROOT>; > + clock-names = "disp_axi", "disp_apb", "disp_axi_root", "disp_apb_root", > + "lcdif-axi", "lcdif-apb", "lcdif-pix", "dsi-pclk", > + "dsi-ref", "csi-aclk", "csi-pclk"; > + #power-domain-cells = <1>; > + };
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de> To: Adam Ford <aford173@gmail.com>, linux-arm-kernel@lists.infradead.org Cc: aford@beaconembedded.com, Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] dt-bindings: soc: add binding for i.MX8MN DISP blk-ctrl Date: Wed, 06 Oct 2021 09:39:08 +0200 [thread overview] Message-ID: <b5b80a0fafe6b774fe9d8bb9e1431960cf2e7330.camel@pengutronix.de> (raw) In-Reply-To: <20211006000505.627334-2-aford173@gmail.com> Am Dienstag, dem 05.10.2021 um 19:04 -0500 schrieb Adam Ford: > This adds the DT binding for the i.MX8MN DISP blk-ctrl. > > Signed-off-by: Adam Ford <aford173@gmail.com> > --- > .../soc/imx/fsl,imx8mn-disp-blk-ctrl.yaml | 97 +++++++++++++++++++ > 1 file changed, 97 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx8mn-disp-blk-ctrl.yaml > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mn-disp-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mn-disp-blk-ctrl.yaml > new file mode 100644 > index 000000000000..92d30aff446e > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mn-disp-blk-ctrl.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml# mm -> mn in the file name. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8MN DISP blk-ctrl > + > +maintainers: > + - Lucas Stach <l.stach@pengutronix.de> I'm not opposed to being maintainer for this file, just making sure that this is what you intended. Other than that I think this looks okay. Regards, Lucas > + > +description: > + The i.MX8MN DISP blk-ctrl is a top-level peripheral providing access to > + the NoC and ensuring proper power sequencing of the display and MIPI CSI > + peripherals located in the DISP domain of the SoC. > + > +properties: > + compatible: > + items: > + - const: fsl,imx8mn-disp-blk-ctrl > + - const: syscon > + > + reg: > + maxItems: 1 > + > + '#power-domain-cells': > + const: 1 > + > + power-domains: > + minItems: 5 > + maxItems: 5 > + > + power-domain-names: > + items: > + - const: bus > + - const: isi > + - const: lcdif > + - const: mipi-dsi > + - const: mipi-csi > + > + clocks: > + minItems: 11 > + maxItems: 11 > + > + clock-names: > + items: > + - const: disp_axi > + - const: disp_apb > + - const: disp_axi_root > + - const: disp_apb_root > + - const: lcdif-axi > + - const: lcdif-apb > + - const: lcdif-pix > + - const: dsi-pclk > + - const: dsi-ref > + - const: csi-aclk > + - const: csi-pclk > + > +required: > + - compatible > + - reg > + - power-domains > + - power-domain-names > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/imx8mn-clock.h> > + #include <dt-bindings/power/imx8mn-power.h> > + > + disp_blk_ctl: blk_ctrl@32e28000 { > + compatible = "fsl,imx8mn-disp-blk-ctrl", "syscon"; > + reg = <0x32e28000 0x100>; > + power-domains = <&pgc_dispmix>, <&pgc_dispmix>, > + <&pgc_dispmix>, <&pgc_mipi>, > + <&pgc_mipi>; > + power-domain-names = "bus", "isi", "lcdif", "mipi-dsi", > + "mipi-csi"; > + clocks = <&clk IMX8MN_CLK_DISP_AXI>, > + <&clk IMX8MN_CLK_DISP_APB>, > + <&clk IMX8MN_CLK_DISP_AXI_ROOT>, > + <&clk IMX8MN_CLK_DISP_APB_ROOT>, > + <&clk IMX8MN_CLK_DISP_AXI_ROOT>, > + <&clk IMX8MN_CLK_DISP_APB_ROOT>, > + <&clk IMX8MN_CLK_DISP_PIXEL_ROOT>, > + <&clk IMX8MN_CLK_DSI_CORE>, > + <&clk IMX8MN_CLK_DSI_PHY_REF>, > + <&clk IMX8MN_CLK_CSI1_PHY_REF>, > + <&clk IMX8MN_CLK_CAMERA_PIXEL_ROOT>; > + clock-names = "disp_axi", "disp_apb", "disp_axi_root", "disp_apb_root", > + "lcdif-axi", "lcdif-apb", "lcdif-pix", "dsi-pclk", > + "dsi-ref", "csi-aclk", "csi-pclk"; > + #power-domain-cells = <1>; > + }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-06 7:39 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-06 0:04 [PATCH 1/7] dt-bindings: power: imx8mn: add defines for DISP blk-ctrl domains Adam Ford 2021-10-06 0:04 ` Adam Ford 2021-10-06 0:04 ` [PATCH 2/7] dt-bindings: soc: add binding for i.MX8MN DISP blk-ctrl Adam Ford 2021-10-06 0:04 ` Adam Ford 2021-10-06 7:39 ` Lucas Stach [this message] 2021-10-06 7:39 ` Lucas Stach 2021-10-06 12:30 ` Adam Ford 2021-10-06 12:30 ` Adam Ford 2021-10-06 13:16 ` Rob Herring 2021-10-06 13:16 ` Rob Herring 2021-10-06 0:05 ` [PATCH 3/7] soc: imx: imx8m-blk-ctrl: add " Adam Ford 2021-10-06 0:05 ` Adam Ford 2021-10-06 7:45 ` Lucas Stach 2021-10-06 7:45 ` Lucas Stach 2021-10-09 14:46 ` Adam Ford 2021-10-09 14:46 ` Adam Ford 2021-10-06 0:05 ` [PATCH 4/7] arm64: dts: imx8mn: add GPC node Adam Ford 2021-10-06 0:05 ` Adam Ford 2021-10-06 7:48 ` Lucas Stach 2021-10-06 7:48 ` Lucas Stach 2021-10-06 0:05 ` [PATCH 5/7] arm64: dts: imx8mn: put USB controller into power-domains Adam Ford 2021-10-06 0:05 ` Adam Ford 2021-10-06 7:49 ` Lucas Stach 2021-10-06 7:49 ` Lucas Stach 2021-10-06 0:05 ` [PATCH 6/7] arm64: dts: imx8mn: add DISP blk-ctrl Adam Ford 2021-10-06 0:05 ` Adam Ford 2021-10-06 0:05 ` [PATCH 7/7] arm64: dts: imx8mn: Enable GPU Adam Ford 2021-10-06 0:05 ` Adam Ford 2021-10-06 7:53 ` Lucas Stach 2021-10-06 7:53 ` Lucas Stach
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b5b80a0fafe6b774fe9d8bb9e1431960cf2e7330.camel@pengutronix.de \ --to=l.stach@pengutronix.de \ --cc=aford173@gmail.com \ --cc=aford@beaconembedded.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.