Re: [cocci] Need some help with spatch

[Vlastimil Babka <vbabka@suse.cz>]

On 11/5/21 22:13, Julia Lawall wrote:
>> for example the cocci patch is supposed to change all "page" to "slab", but
>> some lines are patched like this:
>>
>> -       __free_slab(page->slab_cache, page);
>> +       __free_slab(page->slab_cache, slab);
> 
> I assume that here you are using the semantic patch in 184d9494c1a4.  I

Yes, that's the slub.cocci one from that commit.

> get that both occurrences of page are changed.  What version of Coccinelle
> do you have?

It's 1.1.0 in openSUSE Tumbleweed, so it should be the latest?

But that reminds me, yesterday I adjusted just that rule in the semantic
patch a bit and suddenly it converted almost everything. Today I re-ran
spatch for some rebasing reason and it again needed the fixup. I assumed
there was some git snafu on my part and the fixup was already applied.
But if it works differently for you, I'm not sure now. Is it possible
for the result to be non-deterministic? E.g. some internal state of
coccinelle is based on, say, hash table and in some cases the
non-deterministic order matters?

And just to be sure, does .config matter for coccinelle (through effects
on #ifdefs etc)? I assume it doesn't, if I don't use that switch to
perform preprocessing?

Thanks,
Vlastimil

> julia
>