[U-Boot] [EXT] [PATCH 2/2] spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and n25q256*

From: Vignesh Raghavendra <vigneshr@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [EXT] [PATCH 2/2] spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and n25q256*
Date: Mon, 23 Sep 2019 16:07:12 +0530	[thread overview]
Message-ID: <b86a2669-d0df-7454-5170-b7525f1b36ed@ti.com> (raw)
In-Reply-To: <VI1PR04MB401531592E28D6491DDF287195850@VI1PR04MB4015.eurprd04.prod.outlook.com>

Hi Ashish,

On 23/09/19 2:37 PM, Ashish Kumar wrote:
> 
[...]
>> Lets see if something stands out.
> Hi Vignesh, Eugeniy,
> 
> Could you please provide me dump for n25q512a which consists of all 6 JEDEC id bytes.
> I had initiated mail chain with MICRON FAE, and they suggest that extended id may be different for
> n25q512a  from mt25qu512a.
> 
> I have dumped JEDEC ID from mt25qu512a "20, bb, 20, 10, 44, 00" , the second last byte is supposed to be different as per FAE.
> 
> Bit 6 
> device
> Generation
> 1 = 2nd
> generation
> 

Thats great! Thanks for getting that information!

From Eugeniy's debug dumps in other mail chain, I see JEDEC ID of that flash is:
 " 20 ba 20 10 00 00" (does not support 4 byte addressing opcodes)

So these variants can be differentiated quite easily. I will send out a series fixing those entries.

Regards
Vignesh

> Regards
> Ashish 
>>
>> Regards
>> Vignesh
>>
>>> Still, so we have such an op-in possibility to enable 4 byte opcodes
>>> on these chips?
>>>
>>> Regards,
>>> Simon
>>>
>>>
>>>     Regards
>>>     Ashish
>>>     >
>>>     > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com
>>>     <mailto:vigneshr@ti.com>> For n25q512ax3:
>>>     > Tested-by: Eugeniy Paltsev <paltsev@synopsys.com
>>>     <mailto:paltsev@synopsys.com>>
>>>     > ---
>>>     >  drivers/mtd/spi/spi-nor-ids.c | 6 +++---
>>>     >  1 file changed, 3 insertions(+), 3 deletions(-)
>>>     >
>>>     > diff --git a/drivers/mtd/spi/spi-nor-ids.c
>>>     b/drivers/mtd/spi/spi-nor-ids.c
>>>     > index f32a6c7d464b..5a7fe07c8309 100644
>>>     > --- a/drivers/mtd/spi/spi-nor-ids.c
>>>     > +++ b/drivers/mtd/spi/spi-nor-ids.c
>>>     > @@ -161,10 +161,10 @@ const struct flash_info spi_nor_ids[] = {
>>>     >         { INFO("n25q064a",    0x20bb17, 0, 64 * 1024,  128, SECT_4K |
>>>     > SPI_NOR_QUAD_READ) },
>>>     >         { INFO("n25q128a11",  0x20bb18, 0, 64 * 1024,  256, SECT_4K |
>>>     > SPI_NOR_QUAD_READ) },
>>>     >         { INFO("n25q128a13",  0x20ba18, 0, 64 * 1024,  256, SECT_4K |
>>>     > SPI_NOR_QUAD_READ) },
>>>     > -       { INFO("n25q256a",    0x20ba19, 0, 64 * 1024,  512, SECT_4K |
>>>     > SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>> SPI_NOR_4B_OPCODES) },
>>>     > +       { INFO("n25q256a",    0x20ba19, 0, 64 * 1024,  512, SECT_4K |
>>>     > SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>>>     >         { INFO("n25q256ax1",  0x20bb19, 0, 64 * 1024,  512, SECT_4K |
>>>     > SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
>>>     > -       { INFO("mt25qu512a (n25q512a)",    0x20bb20, 0, 64 * 1024,
>>>     1024,
>>>     > SECT_4K | USE_FSR | SPI_NOR_QUAD_READ |
>> SPI_NOR_4B_OPCODES) },
>>>     > -       { INFO("n25q512ax3",  0x20ba20, 0, 64 * 1024, 1024,
>>>     SECT_4K | USE_FSR |
>>>     > SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
>>>     > +       { INFO("mt25qu512a (n25q512a)",    0x20bb20, 0, 64 * 1024,
>>>     1024,
>>>     > SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
>>>     > +       { INFO("n25q512ax3",  0x20ba20, 0, 64 * 1024, 1024, SECT_4K |
>>>     > + USE_FSR | SPI_NOR_QUAD_READ) },
>>>     >         { INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048,
>>>     SECT_4K | USE_FSR |
>>>     > SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>>>     >         { INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048,
>>>     SECT_4K | USE_FSR |
>>>     > SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>>>     >         { INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096,
>>>     SECT_4K | USE_FSR |
>>>     > SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>>>     > --
>>>     > 2.23.0
>>>
>>>     _______________________________________________
>>>     U-Boot mailing list
>>>     U-Boot at lists.denx.de <mailto:U-Boot@lists.denx.de>
>>>
>>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
>>> s.denx.de%2Flistinfo%2Fu-
>> boot&amp;data=02%7C01%7Cashish.kumar%40nxp.co
>>>
>> m%7C5531cc6a339141ded6cc08d7369fbe9d%7C686ea1d3bc2b4c6fa92cd99c5c
>> 30163
>>>
>> 5%7C0%7C0%7C637037932040085697&amp;sdata=1%2BbqG6OBWOLedplM1
>> 19W7E%2Bgp
>>> XlN1wasXZR3AJgzYaM%3D&amp;reserved=0
>>>
>>
>> --
>> Regards
>> Vignesh

-- 
Regards
Vignesh