* [U-Boot] [PATCH v2] cmd: efidebug: fix a build error in show_efi_boot_opt()
@ 2019-11-26 1:11 AKASHI Takahiro
2019-11-26 1:17 ` Heinrich Schuchardt
0 siblings, 1 reply; 2+ messages in thread
From: AKASHI Takahiro @ 2019-11-26 1:11 UTC (permalink / raw)
To: u-boot
I detected the following error in sandbox with Clang on Travis CI:
+cmd/efidebug.c:703:15: error: result of comparison of constant
9223372036854775822 with expression of type 'int' is always false
[-Werror,-Wtautological-constant-out-of-range-compare]
+ else if (ret == EFI_NOT_FOUND)
+ ~~~ ^ ~~~~~~~~~~~~~
Simply changing a type of 'ret' to efi_status_t will fix this error.
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
cmd/efidebug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cmd/efidebug.c b/cmd/efidebug.c
index ef97e19d0735..1fff4390deae 100644
--- a/cmd/efidebug.c
+++ b/cmd/efidebug.c
@@ -684,7 +684,7 @@ static void show_efi_boot_opt(int id)
efi_guid_t guid;
void *data = NULL;
efi_uintn_t size;
- int ret;
+ efi_status_t ret;
sprintf(var_name, "Boot%04X", id);
p = var_name16;
@@ -693,7 +693,7 @@ static void show_efi_boot_opt(int id)
size = 0;
ret = EFI_CALL(RT->get_variable(var_name16, &guid, NULL, &size, NULL));
- if (ret == (int)EFI_BUFFER_TOO_SMALL) {
+ if (ret == EFI_BUFFER_TOO_SMALL) {
data = malloc(size);
ret = EFI_CALL(RT->get_variable(var_name16, &guid, NULL, &size,
data));
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH v2] cmd: efidebug: fix a build error in show_efi_boot_opt()
2019-11-26 1:11 [U-Boot] [PATCH v2] cmd: efidebug: fix a build error in show_efi_boot_opt() AKASHI Takahiro
@ 2019-11-26 1:17 ` Heinrich Schuchardt
0 siblings, 0 replies; 2+ messages in thread
From: Heinrich Schuchardt @ 2019-11-26 1:17 UTC (permalink / raw)
To: u-boot
On 11/26/19 2:11 AM, AKASHI Takahiro wrote:
> I detected the following error in sandbox with Clang on Travis CI:
> +cmd/efidebug.c:703:15: error: result of comparison of constant
> 9223372036854775822 with expression of type 'int' is always false
> [-Werror,-Wtautological-constant-out-of-range-compare]
> + else if (ret == EFI_NOT_FOUND)
> + ~~~ ^ ~~~~~~~~~~~~~
>
> Simply changing a type of 'ret' to efi_status_t will fix this error.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> cmd/efidebug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cmd/efidebug.c b/cmd/efidebug.c
> index ef97e19d0735..1fff4390deae 100644
> --- a/cmd/efidebug.c
> +++ b/cmd/efidebug.c
> @@ -684,7 +684,7 @@ static void show_efi_boot_opt(int id)
> efi_guid_t guid;
> void *data = NULL;
> efi_uintn_t size;
> - int ret;
> + efi_status_t ret;
>
> sprintf(var_name, "Boot%04X", id);
> p = var_name16;
> @@ -693,7 +693,7 @@ static void show_efi_boot_opt(int id)
>
> size = 0;
> ret = EFI_CALL(RT->get_variable(var_name16, &guid, NULL, &size, NULL));
> - if (ret == (int)EFI_BUFFER_TOO_SMALL) {
> + if (ret == EFI_BUFFER_TOO_SMALL) {
> data = malloc(size);
> ret = EFI_CALL(RT->get_variable(var_name16, &guid, NULL, &size,
> data));
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-26 1:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26 1:11 [U-Boot] [PATCH v2] cmd: efidebug: fix a build error in show_efi_boot_opt() AKASHI Takahiro
2019-11-26 1:17 ` Heinrich Schuchardt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.