From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
To: "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"chris.packham@alliedtelesis.co.nz"
<chris.packham@alliedtelesis.co.nz>,
"wsa@kernel.org" <wsa@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/4] P2040/P2041 i2c recovery erratum
Date: Tue, 11 May 2021 22:10:21 +0000 [thread overview]
Message-ID: <b90f48cfdc31af08190e7a8eaa71b7bd488fcbaa.camel@infinera.com> (raw)
In-Reply-To: <20210511212052.27242-1-chris.packham@alliedtelesis.co.nz>
On Wed, 2021-05-12 at 09:20 +1200, Chris Packham wrote:
> The P2040/P2041 has an erratum where the i2c recovery scheme
> documented in the reference manual (and currently implemented
> in the i2c-mpc.c driver) does not work. The errata document
> provides an alternative that does work. This series implements
> that alternative and uses a property in the devicetree to
> decide when the alternative mechanism is needed.
>
> Chris Packham (4):
> dt-bindings: i2c: mpc: Add fsl,i2c-erratum-a004447 flag
> powerpc/fsl: set fsl,i2c-erratum-a004447 flag for P2041 i2c
> controllers
> powerpc/fsl: set fsl,i2c-erratum-a004447 flag for P1010 i2c
> controllers
> i2c: mpc: implement erratum A-004447 workaround
>
> .../devicetree/bindings/i2c/i2c-mpc.yaml | 7 ++
> arch/powerpc/boot/dts/fsl/p1010si-post.dtsi | 8 ++
> arch/powerpc/boot/dts/fsl/p2041si-post.dtsi | 16 ++++
> drivers/i2c/busses/i2c-mpc.c | 81 ++++++++++++++++++-
> 4 files changed, 110 insertions(+), 2 deletions(-)
>
This now reminds me about the current I2C reset procedure, it didn't work for us and I came up with this one:
https://www.spinics.net/lists/linux-i2c/msg29490.html
it never got in but we are still using it.
Jocke
WARNING: multiple messages have this Message-ID (diff)
From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
To: "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"chris.packham@alliedtelesis.co.nz"
<chris.packham@alliedtelesis.co.nz>,
"wsa@kernel.org" <wsa@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/4] P2040/P2041 i2c recovery erratum
Date: Tue, 11 May 2021 22:10:21 +0000 [thread overview]
Message-ID: <b90f48cfdc31af08190e7a8eaa71b7bd488fcbaa.camel@infinera.com> (raw)
In-Reply-To: <20210511212052.27242-1-chris.packham@alliedtelesis.co.nz>
On Wed, 2021-05-12 at 09:20 +1200, Chris Packham wrote:
> The P2040/P2041 has an erratum where the i2c recovery scheme
> documented in the reference manual (and currently implemented
> in the i2c-mpc.c driver) does not work. The errata document
> provides an alternative that does work. This series implements
> that alternative and uses a property in the devicetree to
> decide when the alternative mechanism is needed.
>
> Chris Packham (4):
> dt-bindings: i2c: mpc: Add fsl,i2c-erratum-a004447 flag
> powerpc/fsl: set fsl,i2c-erratum-a004447 flag for P2041 i2c
> controllers
> powerpc/fsl: set fsl,i2c-erratum-a004447 flag for P1010 i2c
> controllers
> i2c: mpc: implement erratum A-004447 workaround
>
> .../devicetree/bindings/i2c/i2c-mpc.yaml | 7 ++
> arch/powerpc/boot/dts/fsl/p1010si-post.dtsi | 8 ++
> arch/powerpc/boot/dts/fsl/p2041si-post.dtsi | 16 ++++
> drivers/i2c/busses/i2c-mpc.c | 81 ++++++++++++++++++-
> 4 files changed, 110 insertions(+), 2 deletions(-)
>
This now reminds me about the current I2C reset procedure, it didn't work for us and I came up with this one:
https://www.spinics.net/lists/linux-i2c/msg29490.html
it never got in but we are still using it.
Jocke
next prev parent reply other threads:[~2021-05-11 22:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 21:20 [PATCH v3 0/4] P2040/P2041 i2c recovery erratum Chris Packham
2021-05-11 21:20 ` Chris Packham
2021-05-11 21:20 ` [PATCH v3 1/4] dt-bindings: i2c: mpc: Add fsl,i2c-erratum-a004447 flag Chris Packham
2021-05-11 21:20 ` [PATCH v3 1/4] dt-bindings: i2c: mpc: Add fsl, i2c-erratum-a004447 flag Chris Packham
2021-05-11 21:20 ` [PATCH v3 2/4] powerpc/fsl: set fsl,i2c-erratum-a004447 flag for P2041 i2c controllers Chris Packham
2021-05-11 21:20 ` [PATCH v3 2/4] powerpc/fsl: set fsl, i2c-erratum-a004447 " Chris Packham
2021-05-26 1:02 ` [PATCH v3 2/4] powerpc/fsl: set fsl,i2c-erratum-a004447 " Michael Ellerman
2021-05-26 1:02 ` Michael Ellerman
2021-05-11 21:20 ` [PATCH v3 3/4] powerpc/fsl: set fsl,i2c-erratum-a004447 flag for P1010 " Chris Packham
2021-05-11 21:20 ` [PATCH v3 3/4] powerpc/fsl: set fsl, i2c-erratum-a004447 " Chris Packham
2021-05-26 1:02 ` [PATCH v3 3/4] powerpc/fsl: set fsl,i2c-erratum-a004447 " Michael Ellerman
2021-05-26 1:02 ` Michael Ellerman
2021-05-11 21:20 ` [PATCH v3 4/4] i2c: mpc: implement erratum A-004447 workaround Chris Packham
2021-05-11 21:20 ` Chris Packham
2021-05-11 22:10 ` Joakim Tjernlund [this message]
2021-05-11 22:10 ` [PATCH v3 0/4] P2040/P2041 i2c recovery erratum Joakim Tjernlund
2021-05-12 1:48 ` Chris Packham
2021-05-12 1:48 ` Chris Packham
2021-05-12 8:57 ` Joakim Tjernlund
2021-05-12 8:57 ` Joakim Tjernlund
2021-05-12 15:01 ` wsa
2021-05-12 15:01 ` wsa
2021-05-20 3:36 ` Chris Packham
2021-05-20 3:36 ` Chris Packham
2021-05-25 18:49 ` wsa
2021-05-25 18:49 ` wsa
2021-05-25 18:53 ` Wolfram Sang
2021-05-25 18:53 ` Wolfram Sang
2021-05-26 1:02 ` Michael Ellerman
2021-05-26 1:02 ` Michael Ellerman
2021-05-27 19:53 ` Wolfram Sang
2021-05-27 19:53 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b90f48cfdc31af08190e7a8eaa71b7bd488fcbaa.camel@infinera.com \
--to=joakim.tjernlund@infinera.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.