* [PATCH 0/2] misc: xilinx_sdfec: Adjustments for xsdfec_add_ldpc() @ 2019-11-05 18:52 ` Markus Elfring 0 siblings, 0 replies; 21+ messages in thread From: Markus Elfring @ 2019-11-05 18:52 UTC (permalink / raw) To: linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman, Michal Simek Cc: LKML, kernel-janitors From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 5 Nov 2019 19:45:05 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use memdup_user() rather than duplicating its implementation Combine three condition checks into one statement drivers/misc/xilinx_sdfec.c | 29 ++++++++--------------------- 1 file changed, 8 insertions(+), 21 deletions(-) -- 2.24.0 ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 0/2] misc: xilinx_sdfec: Adjustments for xsdfec_add_ldpc() @ 2019-11-05 18:52 ` Markus Elfring 0 siblings, 0 replies; 21+ messages in thread From: Markus Elfring @ 2019-11-05 18:52 UTC (permalink / raw) To: linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 5 Nov 2019 19:45:05 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use memdup_user() rather than duplicating its implementation Combine three condition checks into one statement drivers/misc/xilinx_sdfec.c | 29 ++++++++--------------------- 1 file changed, 8 insertions(+), 21 deletions(-) -- 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 0/2] misc: xilinx_sdfec: Adjustments for xsdfec_add_ldpc() @ 2019-11-05 18:52 ` Markus Elfring 0 siblings, 0 replies; 21+ messages in thread From: Markus Elfring @ 2019-11-05 18:52 UTC (permalink / raw) To: linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 5 Nov 2019 19:45:05 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use memdup_user() rather than duplicating its implementation Combine three condition checks into one statement drivers/misc/xilinx_sdfec.c | 29 ++++++++--------------------- 1 file changed, 8 insertions(+), 21 deletions(-) -- 2.24.0 ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation 2019-11-05 18:52 ` Markus Elfring (?) @ 2019-11-05 18:54 ` Markus Elfring -1 siblings, 0 replies; 21+ messages in thread From: Markus Elfring @ 2019-11-05 18:54 UTC (permalink / raw) To: linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman, Michal Simek Cc: LKML, kernel-janitors From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 5 Nov 2019 19:09:15 +0100 Reuse existing functionality from memdup_user() instead of keeping duplicate source code. Generated by: scripts/coccinelle/api/memdup_user.cocci Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/misc/xilinx_sdfec.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c index 11835969e982..a622fcf4954a 100644 --- a/drivers/misc/xilinx_sdfec.c +++ b/drivers/misc/xilinx_sdfec.c @@ -649,14 +649,9 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) struct xsdfec_ldpc_params *ldpc; int ret, n; - ldpc = kzalloc(sizeof(*ldpc), GFP_KERNEL); - if (!ldpc) - return -ENOMEM; - - if (copy_from_user(ldpc, arg, sizeof(*ldpc))) { - ret = -EFAULT; - goto err_out; - } + ldpc = memdup_user(arg, sizeof(*ldpc)); + if (IS_ERR(ldpc)) + return PTR_ERR(ldpc); if (xsdfec->config.code == XSDFEC_TURBO_CODE) { ret = -EIO; -- 2.24.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation @ 2019-11-05 18:54 ` Markus Elfring 0 siblings, 0 replies; 21+ messages in thread From: Markus Elfring @ 2019-11-05 18:54 UTC (permalink / raw) To: linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 5 Nov 2019 19:09:15 +0100 Reuse existing functionality from memdup_user() instead of keeping duplicate source code. Generated by: scripts/coccinelle/api/memdup_user.cocci Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/misc/xilinx_sdfec.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c index 11835969e982..a622fcf4954a 100644 --- a/drivers/misc/xilinx_sdfec.c +++ b/drivers/misc/xilinx_sdfec.c @@ -649,14 +649,9 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) struct xsdfec_ldpc_params *ldpc; int ret, n; - ldpc = kzalloc(sizeof(*ldpc), GFP_KERNEL); - if (!ldpc) - return -ENOMEM; - - if (copy_from_user(ldpc, arg, sizeof(*ldpc))) { - ret = -EFAULT; - goto err_out; - } + ldpc = memdup_user(arg, sizeof(*ldpc)); + if (IS_ERR(ldpc)) + return PTR_ERR(ldpc); if (xsdfec->config.code == XSDFEC_TURBO_CODE) { ret = -EIO; -- 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation @ 2019-11-05 18:54 ` Markus Elfring 0 siblings, 0 replies; 21+ messages in thread From: Markus Elfring @ 2019-11-05 18:54 UTC (permalink / raw) To: linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 5 Nov 2019 19:09:15 +0100 Reuse existing functionality from memdup_user() instead of keeping duplicate source code. Generated by: scripts/coccinelle/api/memdup_user.cocci Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/misc/xilinx_sdfec.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c index 11835969e982..a622fcf4954a 100644 --- a/drivers/misc/xilinx_sdfec.c +++ b/drivers/misc/xilinx_sdfec.c @@ -649,14 +649,9 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) struct xsdfec_ldpc_params *ldpc; int ret, n; - ldpc = kzalloc(sizeof(*ldpc), GFP_KERNEL); - if (!ldpc) - return -ENOMEM; - - if (copy_from_user(ldpc, arg, sizeof(*ldpc))) { - ret = -EFAULT; - goto err_out; - } + ldpc = memdup_user(arg, sizeof(*ldpc)); + if (IS_ERR(ldpc)) + return PTR_ERR(ldpc); if (xsdfec->config.code == XSDFEC_TURBO_CODE) { ret = -EIO; -- 2.24.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* RE: [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation 2019-11-05 18:54 ` Markus Elfring (?) @ 2019-11-07 15:40 ` Dragan Cvetic -1 siblings, 0 replies; 21+ messages in thread From: Dragan Cvetic @ 2019-11-07 15:40 UTC (permalink / raw) To: Markus Elfring, linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Greg Kroah-Hartman, Michal Simek Cc: LKML, kernel-janitors HI Markus, Thanks for the nice solution, we are going to test this change and let you know about the result. Regards Dragan > -----Original Message----- > From: Markus Elfring [mailto:Markus.Elfring@web.de] > Sent: Tuesday 5 November 2019 18:55 > To: linux-arm-kernel@lists.infradead.org; Arnd Bergmann <arnd@arndb.de>; Derek Kiernan <dkiernan@xilinx.com>; Dragan Cvetic > <draganc@xilinx.com>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Michal Simek <michals@xilinx.com> > Cc: LKML <linux-kernel@vger.kernel.org>; kernel-janitors@vger.kernel.org > Subject: [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 5 Nov 2019 19:09:15 +0100 > > Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > Generated by: scripts/coccinelle/api/memdup_user.cocci > > Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/misc/xilinx_sdfec.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c > index 11835969e982..a622fcf4954a 100644 > --- a/drivers/misc/xilinx_sdfec.c > +++ b/drivers/misc/xilinx_sdfec.c > @@ -649,14 +649,9 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) > struct xsdfec_ldpc_params *ldpc; > int ret, n; > > - ldpc = kzalloc(sizeof(*ldpc), GFP_KERNEL); > - if (!ldpc) > - return -ENOMEM; > - > - if (copy_from_user(ldpc, arg, sizeof(*ldpc))) { > - ret = -EFAULT; > - goto err_out; > - } > + ldpc = memdup_user(arg, sizeof(*ldpc)); > + if (IS_ERR(ldpc)) > + return PTR_ERR(ldpc); > > if (xsdfec->config.code == XSDFEC_TURBO_CODE) { > ret = -EIO; > -- > 2.24.0 ^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation @ 2019-11-07 15:40 ` Dragan Cvetic 0 siblings, 0 replies; 21+ messages in thread From: Dragan Cvetic @ 2019-11-07 15:40 UTC (permalink / raw) To: Markus Elfring, linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML HI Markus, Thanks for the nice solution, we are going to test this change and let you know about the result. Regards Dragan > -----Original Message----- > From: Markus Elfring [mailto:Markus.Elfring@web.de] > Sent: Tuesday 5 November 2019 18:55 > To: linux-arm-kernel@lists.infradead.org; Arnd Bergmann <arnd@arndb.de>; Derek Kiernan <dkiernan@xilinx.com>; Dragan Cvetic > <draganc@xilinx.com>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Michal Simek <michals@xilinx.com> > Cc: LKML <linux-kernel@vger.kernel.org>; kernel-janitors@vger.kernel.org > Subject: [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 5 Nov 2019 19:09:15 +0100 > > Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > Generated by: scripts/coccinelle/api/memdup_user.cocci > > Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/misc/xilinx_sdfec.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c > index 11835969e982..a622fcf4954a 100644 > --- a/drivers/misc/xilinx_sdfec.c > +++ b/drivers/misc/xilinx_sdfec.c > @@ -649,14 +649,9 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) > struct xsdfec_ldpc_params *ldpc; > int ret, n; > > - ldpc = kzalloc(sizeof(*ldpc), GFP_KERNEL); > - if (!ldpc) > - return -ENOMEM; > - > - if (copy_from_user(ldpc, arg, sizeof(*ldpc))) { > - ret = -EFAULT; > - goto err_out; > - } > + ldpc = memdup_user(arg, sizeof(*ldpc)); > + if (IS_ERR(ldpc)) > + return PTR_ERR(ldpc); > > if (xsdfec->config.code == XSDFEC_TURBO_CODE) { > ret = -EIO; > -- > 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation @ 2019-11-07 15:40 ` Dragan Cvetic 0 siblings, 0 replies; 21+ messages in thread From: Dragan Cvetic @ 2019-11-07 15:40 UTC (permalink / raw) To: Markus Elfring, linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML SEkgTWFya3VzLA0KDQpUaGFua3MgZm9yIHRoZSBuaWNlIHNvbHV0aW9uLA0Kd2UgYXJlIGdvaW5n IHRvIHRlc3QgdGhpcyBjaGFuZ2UgYW5kIGxldCB5b3Uga25vdyBhYm91dCB0aGUgcmVzdWx0Lg0K DQpSZWdhcmRzDQpEcmFnYW4NCg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZy b206IE1hcmt1cyBFbGZyaW5nIFttYWlsdG86TWFya3VzLkVsZnJpbmdAd2ViLmRlXQ0KPiBTZW50 OiBUdWVzZGF5IDUgTm92ZW1iZXIgMjAxOSAxODo1NQ0KPiBUbzogbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnOyBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPjsgRGVyZWsg S2llcm5hbiA8ZGtpZXJuYW5AeGlsaW54LmNvbT47IERyYWdhbiBDdmV0aWMNCj4gPGRyYWdhbmNA eGlsaW54LmNvbT47IEdyZWcgS3JvYWgtSGFydG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5v cmc+OyBNaWNoYWwgU2ltZWsgPG1pY2hhbHNAeGlsaW54LmNvbT4NCj4gQ2M6IExLTUwgPGxpbnV4 LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+OyBrZXJuZWwtamFuaXRvcnNAdmdlci5rZXJuZWwub3Jn DQo+IFN1YmplY3Q6IFtQQVRDSCAxLzJdIG1pc2M6IHhpbGlueF9zZGZlYzogVXNlIG1lbWR1cF91 c2VyKCkgcmF0aGVyIHRoYW4gZHVwbGljYXRpbmcgaXRzIGltcGxlbWVudGF0aW9uDQo+IA0KPiBG cm9tOiBNYXJrdXMgRWxmcmluZyA8ZWxmcmluZ0B1c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+DQo+IERh dGU6IFR1ZSwgNSBOb3YgMjAxOSAxOTowOToxNSArMDEwMA0KPiANCj4gUmV1c2UgZXhpc3Rpbmcg ZnVuY3Rpb25hbGl0eSBmcm9tIG1lbWR1cF91c2VyKCkgaW5zdGVhZCBvZiBrZWVwaW5nDQo+IGR1 cGxpY2F0ZSBzb3VyY2UgY29kZS4NCj4gDQo+IEdlbmVyYXRlZCBieTogc2NyaXB0cy9jb2NjaW5l bGxlL2FwaS9tZW1kdXBfdXNlci5jb2NjaQ0KPiANCj4gRml4ZXM6IDIwZWM2MjhlODAwN2VjNzVj MmY4ODRlMDAwMDRmMzllYWI2Mjg5YjUgKCJtaXNjOiB4aWxpbnhfc2RmZWM6IEFkZCBhYmlsaXR5 IHRvIGNvbmZpZ3VyZSBMRFBDIikNCj4gU2lnbmVkLW9mZi1ieTogTWFya3VzIEVsZnJpbmcgPGVs ZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0Pg0KPiAtLS0NCj4gIGRyaXZlcnMvbWlzYy94aWxp bnhfc2RmZWMuYyB8IDExICsrKy0tLS0tLS0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRp b25zKCspLCA4IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWlzYy94 aWxpbnhfc2RmZWMuYyBiL2RyaXZlcnMvbWlzYy94aWxpbnhfc2RmZWMuYw0KPiBpbmRleCAxMTgz NTk2OWU5ODIuLmE2MjJmY2Y0OTU0YSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9taXNjL3hpbGlu eF9zZGZlYy5jDQo+ICsrKyBiL2RyaXZlcnMvbWlzYy94aWxpbnhfc2RmZWMuYw0KPiBAQCAtNjQ5 LDE0ICs2NDksOSBAQCBzdGF0aWMgaW50IHhzZGZlY19hZGRfbGRwYyhzdHJ1Y3QgeHNkZmVjX2Rl diAqeHNkZmVjLCB2b2lkIF9fdXNlciAqYXJnKQ0KPiAgCXN0cnVjdCB4c2RmZWNfbGRwY19wYXJh bXMgKmxkcGM7DQo+ICAJaW50IHJldCwgbjsNCj4gDQo+IC0JbGRwYyA9IGt6YWxsb2Moc2l6ZW9m KCpsZHBjKSwgR0ZQX0tFUk5FTCk7DQo+IC0JaWYgKCFsZHBjKQ0KPiAtCQlyZXR1cm4gLUVOT01F TTsNCj4gLQ0KPiAtCWlmIChjb3B5X2Zyb21fdXNlcihsZHBjLCBhcmcsIHNpemVvZigqbGRwYykp KSB7DQo+IC0JCXJldCA9IC1FRkFVTFQ7DQo+IC0JCWdvdG8gZXJyX291dDsNCj4gLQl9DQo+ICsJ bGRwYyA9IG1lbWR1cF91c2VyKGFyZywgc2l6ZW9mKCpsZHBjKSk7DQo+ICsJaWYgKElTX0VSUihs ZHBjKSkNCj4gKwkJcmV0dXJuIFBUUl9FUlIobGRwYyk7DQo+IA0KPiAgCWlmICh4c2RmZWMtPmNv bmZpZy5jb2RlID09IFhTREZFQ19UVVJCT19DT0RFKSB7DQo+ICAJCXJldCA9IC1FSU87DQo+IC0t DQo+IDIuMjQuMA0KDQo ^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation 2019-11-05 18:54 ` Markus Elfring (?) @ 2019-11-10 22:18 ` Dragan Cvetic -1 siblings, 0 replies; 21+ messages in thread From: Dragan Cvetic @ 2019-11-10 22:18 UTC (permalink / raw) To: Markus Elfring, linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Greg Kroah-Hartman, Michal Simek Cc: LKML, kernel-janitors Hi Markus, > -----Original Message----- > From: Markus Elfring [mailto:Markus.Elfring@web.de] > Sent: Tuesday 5 November 2019 18:55 > To: linux-arm-kernel@lists.infradead.org; Arnd Bergmann <arnd@arndb.de>; Derek Kiernan <dkiernan@xilinx.com>; Dragan Cvetic > <draganc@xilinx.com>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Michal Simek <michals@xilinx.com> > Cc: LKML <linux-kernel@vger.kernel.org>; kernel-janitors@vger.kernel.org > Subject: [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 5 Nov 2019 19:09:15 +0100 > > Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > Generated by: scripts/coccinelle/api/memdup_user.cocci > > Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/misc/xilinx_sdfec.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c > index 11835969e982..a622fcf4954a 100644 > --- a/drivers/misc/xilinx_sdfec.c > +++ b/drivers/misc/xilinx_sdfec.c > @@ -649,14 +649,9 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) > struct xsdfec_ldpc_params *ldpc; > int ret, n; > > - ldpc = kzalloc(sizeof(*ldpc), GFP_KERNEL); > - if (!ldpc) > - return -ENOMEM; > - > - if (copy_from_user(ldpc, arg, sizeof(*ldpc))) { > - ret = -EFAULT; > - goto err_out; > - } > + ldpc = memdup_user(arg, sizeof(*ldpc)); > + if (IS_ERR(ldpc)) > + return PTR_ERR(ldpc); Acked-by: Dragan Cvetic <dragan.cvetic@xilinx.com> > > if (xsdfec->config.code == XSDFEC_TURBO_CODE) { > ret = -EIO; > -- > 2.24.0 ^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation @ 2019-11-10 22:18 ` Dragan Cvetic 0 siblings, 0 replies; 21+ messages in thread From: Dragan Cvetic @ 2019-11-10 22:18 UTC (permalink / raw) To: Markus Elfring, linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML Hi Markus, > -----Original Message----- > From: Markus Elfring [mailto:Markus.Elfring@web.de] > Sent: Tuesday 5 November 2019 18:55 > To: linux-arm-kernel@lists.infradead.org; Arnd Bergmann <arnd@arndb.de>; Derek Kiernan <dkiernan@xilinx.com>; Dragan Cvetic > <draganc@xilinx.com>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Michal Simek <michals@xilinx.com> > Cc: LKML <linux-kernel@vger.kernel.org>; kernel-janitors@vger.kernel.org > Subject: [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 5 Nov 2019 19:09:15 +0100 > > Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > Generated by: scripts/coccinelle/api/memdup_user.cocci > > Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/misc/xilinx_sdfec.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c > index 11835969e982..a622fcf4954a 100644 > --- a/drivers/misc/xilinx_sdfec.c > +++ b/drivers/misc/xilinx_sdfec.c > @@ -649,14 +649,9 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) > struct xsdfec_ldpc_params *ldpc; > int ret, n; > > - ldpc = kzalloc(sizeof(*ldpc), GFP_KERNEL); > - if (!ldpc) > - return -ENOMEM; > - > - if (copy_from_user(ldpc, arg, sizeof(*ldpc))) { > - ret = -EFAULT; > - goto err_out; > - } > + ldpc = memdup_user(arg, sizeof(*ldpc)); > + if (IS_ERR(ldpc)) > + return PTR_ERR(ldpc); Acked-by: Dragan Cvetic <dragan.cvetic@xilinx.com> > > if (xsdfec->config.code == XSDFEC_TURBO_CODE) { > ret = -EIO; > -- > 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation @ 2019-11-10 22:18 ` Dragan Cvetic 0 siblings, 0 replies; 21+ messages in thread From: Dragan Cvetic @ 2019-11-10 22:18 UTC (permalink / raw) To: Markus Elfring, linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML SGkgTWFya3VzLA0KDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogTWFy a3VzIEVsZnJpbmcgW21haWx0bzpNYXJrdXMuRWxmcmluZ0B3ZWIuZGVdDQo+IFNlbnQ6IFR1ZXNk YXkgNSBOb3ZlbWJlciAyMDE5IDE4OjU1DQo+IFRvOiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmc7IEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIuZGU+OyBEZXJlayBLaWVybmFu IDxka2llcm5hbkB4aWxpbnguY29tPjsgRHJhZ2FuIEN2ZXRpYw0KPiA8ZHJhZ2FuY0B4aWxpbngu Y29tPjsgR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz47IE1p Y2hhbCBTaW1layA8bWljaGFsc0B4aWxpbnguY29tPg0KPiBDYzogTEtNTCA8bGludXgta2VybmVs QHZnZXIua2VybmVsLm9yZz47IGtlcm5lbC1qYW5pdG9yc0B2Z2VyLmtlcm5lbC5vcmcNCj4gU3Vi amVjdDogW1BBVENIIDEvMl0gbWlzYzogeGlsaW54X3NkZmVjOiBVc2UgbWVtZHVwX3VzZXIoKSBy YXRoZXIgdGhhbiBkdXBsaWNhdGluZyBpdHMgaW1wbGVtZW50YXRpb24NCj4gDQo+IEZyb206IE1h cmt1cyBFbGZyaW5nIDxlbGZyaW5nQHVzZXJzLnNvdXJjZWZvcmdlLm5ldD4NCj4gRGF0ZTogVHVl LCA1IE5vdiAyMDE5IDE5OjA5OjE1ICswMTAwDQo+IA0KPiBSZXVzZSBleGlzdGluZyBmdW5jdGlv bmFsaXR5IGZyb20gbWVtZHVwX3VzZXIoKSBpbnN0ZWFkIG9mIGtlZXBpbmcNCj4gZHVwbGljYXRl IHNvdXJjZSBjb2RlLg0KPiANCj4gR2VuZXJhdGVkIGJ5OiBzY3JpcHRzL2NvY2NpbmVsbGUvYXBp L21lbWR1cF91c2VyLmNvY2NpDQo+IA0KPiBGaXhlczogMjBlYzYyOGU4MDA3ZWM3NWMyZjg4NGUw MDAwNGYzOWVhYjYyODliNSAoIm1pc2M6IHhpbGlueF9zZGZlYzogQWRkIGFiaWxpdHkgdG8gY29u ZmlndXJlIExEUEMiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBNYXJrdXMgRWxmcmluZyA8ZWxmcmluZ0B1 c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+DQo+IC0tLQ0KPiAgZHJpdmVycy9taXNjL3hpbGlueF9zZGZl Yy5jIHwgMTEgKysrLS0tLS0tLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyks IDggZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9taXNjL3hpbGlueF9z ZGZlYy5jIGIvZHJpdmVycy9taXNjL3hpbGlueF9zZGZlYy5jDQo+IGluZGV4IDExODM1OTY5ZTk4 Mi4uYTYyMmZjZjQ5NTRhIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL21pc2MveGlsaW54X3NkZmVj LmMNCj4gKysrIGIvZHJpdmVycy9taXNjL3hpbGlueF9zZGZlYy5jDQo+IEBAIC02NDksMTQgKzY0 OSw5IEBAIHN0YXRpYyBpbnQgeHNkZmVjX2FkZF9sZHBjKHN0cnVjdCB4c2RmZWNfZGV2ICp4c2Rm ZWMsIHZvaWQgX191c2VyICphcmcpDQo+ICAJc3RydWN0IHhzZGZlY19sZHBjX3BhcmFtcyAqbGRw YzsNCj4gIAlpbnQgcmV0LCBuOw0KPiANCj4gLQlsZHBjID0ga3phbGxvYyhzaXplb2YoKmxkcGMp LCBHRlBfS0VSTkVMKTsNCj4gLQlpZiAoIWxkcGMpDQo+IC0JCXJldHVybiAtRU5PTUVNOw0KPiAt DQo+IC0JaWYgKGNvcHlfZnJvbV91c2VyKGxkcGMsIGFyZywgc2l6ZW9mKCpsZHBjKSkpIHsNCj4g LQkJcmV0ID0gLUVGQVVMVDsNCj4gLQkJZ290byBlcnJfb3V0Ow0KPiAtCX0NCj4gKwlsZHBjID0g bWVtZHVwX3VzZXIoYXJnLCBzaXplb2YoKmxkcGMpKTsNCj4gKwlpZiAoSVNfRVJSKGxkcGMpKQ0K PiArCQlyZXR1cm4gUFRSX0VSUihsZHBjKTsNCg0KQWNrZWQtYnk6IERyYWdhbiBDdmV0aWMgPGRy YWdhbi5jdmV0aWNAeGlsaW54LmNvbT4NCg0KPiANCj4gIAlpZiAoeHNkZmVjLT5jb25maWcuY29k ZSA9PSBYU0RGRUNfVFVSQk9fQ09ERSkgew0KPiAgCQlyZXQgPSAtRUlPOw0KPiAtLQ0KPiAyLjI0 LjANCg0K ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() 2019-11-05 18:52 ` Markus Elfring (?) @ 2019-11-05 18:56 ` Markus Elfring -1 siblings, 0 replies; 21+ messages in thread From: Markus Elfring @ 2019-11-05 18:56 UTC (permalink / raw) To: linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman, Michal Simek Cc: LKML, kernel-janitors From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 5 Nov 2019 19:32:25 +0100 The same return code was set after three condition checks. Thus use a single statement instead. Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/misc/xilinx_sdfec.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c index a622fcf4954a..322d5c6e6d12 100644 --- a/drivers/misc/xilinx_sdfec.c +++ b/drivers/misc/xilinx_sdfec.c @@ -653,18 +653,10 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) if (IS_ERR(ldpc)) return PTR_ERR(ldpc); - if (xsdfec->config.code == XSDFEC_TURBO_CODE) { - ret = -EIO; - goto err_out; - } - - /* Verify Device has not started */ - if (xsdfec->state == XSDFEC_STARTED) { - ret = -EIO; - goto err_out; - } - - if (xsdfec->config.code_wr_protect) { + if (xsdfec->config.code == XSDFEC_TURBO_CODE || + /* Verify device has not started */ + xsdfec->state == XSDFEC_STARTED || + xsdfec->config.code_wr_protect) { ret = -EIO; goto err_out; } -- 2.24.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() @ 2019-11-05 18:56 ` Markus Elfring 0 siblings, 0 replies; 21+ messages in thread From: Markus Elfring @ 2019-11-05 18:56 UTC (permalink / raw) To: linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 5 Nov 2019 19:32:25 +0100 The same return code was set after three condition checks. Thus use a single statement instead. Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/misc/xilinx_sdfec.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c index a622fcf4954a..322d5c6e6d12 100644 --- a/drivers/misc/xilinx_sdfec.c +++ b/drivers/misc/xilinx_sdfec.c @@ -653,18 +653,10 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) if (IS_ERR(ldpc)) return PTR_ERR(ldpc); - if (xsdfec->config.code == XSDFEC_TURBO_CODE) { - ret = -EIO; - goto err_out; - } - - /* Verify Device has not started */ - if (xsdfec->state == XSDFEC_STARTED) { - ret = -EIO; - goto err_out; - } - - if (xsdfec->config.code_wr_protect) { + if (xsdfec->config.code == XSDFEC_TURBO_CODE || + /* Verify device has not started */ + xsdfec->state == XSDFEC_STARTED || + xsdfec->config.code_wr_protect) { ret = -EIO; goto err_out; } -- 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc @ 2019-11-05 18:56 ` Markus Elfring 0 siblings, 0 replies; 21+ messages in thread From: Markus Elfring @ 2019-11-05 18:56 UTC (permalink / raw) To: linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 5 Nov 2019 19:32:25 +0100 The same return code was set after three condition checks. Thus use a single statement instead. Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/misc/xilinx_sdfec.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c index a622fcf4954a..322d5c6e6d12 100644 --- a/drivers/misc/xilinx_sdfec.c +++ b/drivers/misc/xilinx_sdfec.c @@ -653,18 +653,10 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) if (IS_ERR(ldpc)) return PTR_ERR(ldpc); - if (xsdfec->config.code == XSDFEC_TURBO_CODE) { - ret = -EIO; - goto err_out; - } - - /* Verify Device has not started */ - if (xsdfec->state == XSDFEC_STARTED) { - ret = -EIO; - goto err_out; - } - - if (xsdfec->config.code_wr_protect) { + if (xsdfec->config.code == XSDFEC_TURBO_CODE || + /* Verify device has not started */ + xsdfec->state == XSDFEC_STARTED || + xsdfec->config.code_wr_protect) { ret = -EIO; goto err_out; } -- 2.24.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* RE: [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() 2019-11-05 18:56 ` [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc Markus Elfring (?) @ 2019-11-07 16:30 ` Dragan Cvetic -1 siblings, 0 replies; 21+ messages in thread From: Dragan Cvetic @ 2019-11-07 16:30 UTC (permalink / raw) To: Markus Elfring, linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Greg Kroah-Hartman, Michal Simek Cc: LKML, kernel-janitors Hi Markus, > -----Original Message----- > From: Markus Elfring [mailto:Markus.Elfring@web.de] > Sent: Tuesday 5 November 2019 18:56 > To: linux-arm-kernel@lists.infradead.org; Arnd Bergmann <arnd@arndb.de>; Derek Kiernan <dkiernan@xilinx.com>; Dragan Cvetic > <draganc@xilinx.com>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Michal Simek <michals@xilinx.com> > Cc: LKML <linux-kernel@vger.kernel.org>; kernel-janitors@vger.kernel.org > Subject: [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 5 Nov 2019 19:32:25 +0100 > > The same return code was set after three condition checks. > Thus use a single statement instead. > > Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/misc/xilinx_sdfec.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c > index a622fcf4954a..322d5c6e6d12 100644 > --- a/drivers/misc/xilinx_sdfec.c > +++ b/drivers/misc/xilinx_sdfec.c > @@ -653,18 +653,10 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) > if (IS_ERR(ldpc)) > return PTR_ERR(ldpc); > > - if (xsdfec->config.code == XSDFEC_TURBO_CODE) { > - ret = -EIO; > - goto err_out; > - } > - > - /* Verify Device has not started */ > - if (xsdfec->state == XSDFEC_STARTED) { > - ret = -EIO; > - goto err_out; > - } > - > - if (xsdfec->config.code_wr_protect) { > + if (xsdfec->config.code == XSDFEC_TURBO_CODE || > + /* Verify device has not started */ > + xsdfec->state == XSDFEC_STARTED || > + xsdfec->config.code_wr_protect) { > ret = -EIO; > goto err_out; > } approved > -- > 2.24.0 ^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() @ 2019-11-07 16:30 ` Dragan Cvetic 0 siblings, 0 replies; 21+ messages in thread From: Dragan Cvetic @ 2019-11-07 16:30 UTC (permalink / raw) To: Markus Elfring, linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML Hi Markus, > -----Original Message----- > From: Markus Elfring [mailto:Markus.Elfring@web.de] > Sent: Tuesday 5 November 2019 18:56 > To: linux-arm-kernel@lists.infradead.org; Arnd Bergmann <arnd@arndb.de>; Derek Kiernan <dkiernan@xilinx.com>; Dragan Cvetic > <draganc@xilinx.com>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Michal Simek <michals@xilinx.com> > Cc: LKML <linux-kernel@vger.kernel.org>; kernel-janitors@vger.kernel.org > Subject: [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 5 Nov 2019 19:32:25 +0100 > > The same return code was set after three condition checks. > Thus use a single statement instead. > > Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/misc/xilinx_sdfec.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c > index a622fcf4954a..322d5c6e6d12 100644 > --- a/drivers/misc/xilinx_sdfec.c > +++ b/drivers/misc/xilinx_sdfec.c > @@ -653,18 +653,10 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) > if (IS_ERR(ldpc)) > return PTR_ERR(ldpc); > > - if (xsdfec->config.code == XSDFEC_TURBO_CODE) { > - ret = -EIO; > - goto err_out; > - } > - > - /* Verify Device has not started */ > - if (xsdfec->state == XSDFEC_STARTED) { > - ret = -EIO; > - goto err_out; > - } > - > - if (xsdfec->config.code_wr_protect) { > + if (xsdfec->config.code == XSDFEC_TURBO_CODE || > + /* Verify device has not started */ > + xsdfec->state == XSDFEC_STARTED || > + xsdfec->config.code_wr_protect) { > ret = -EIO; > goto err_out; > } approved > -- > 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ @ 2019-11-07 16:30 ` Dragan Cvetic 0 siblings, 0 replies; 21+ messages in thread From: Dragan Cvetic @ 2019-11-07 16:30 UTC (permalink / raw) To: Markus Elfring, linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML DQpIaSBNYXJrdXMsDQoNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBN YXJrdXMgRWxmcmluZyBbbWFpbHRvOk1hcmt1cy5FbGZyaW5nQHdlYi5kZV0NCj4gU2VudDogVHVl c2RheSA1IE5vdmVtYmVyIDIwMTkgMTg6NTYNCj4gVG86IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZzsgQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT47IERlcmVrIEtpZXJu YW4gPGRraWVybmFuQHhpbGlueC5jb20+OyBEcmFnYW4gQ3ZldGljDQo+IDxkcmFnYW5jQHhpbGlu eC5jb20+OyBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPjsg TWljaGFsIFNpbWVrIDxtaWNoYWxzQHhpbGlueC5jb20+DQo+IENjOiBMS01MIDxsaW51eC1rZXJu ZWxAdmdlci5rZXJuZWwub3JnPjsga2VybmVsLWphbml0b3JzQHZnZXIua2VybmVsLm9yZw0KPiBT dWJqZWN0OiBbUEFUQ0ggMi8yXSBtaXNjOiB4aWxpbnhfc2RmZWM6IENvbWJpbmUgdGhyZWUgY29u ZGl0aW9uIGNoZWNrcyBpbnRvIG9uZSBzdGF0ZW1lbnQgaW4geHNkZmVjX2FkZF9sZHBjKCkNCj4g DQo+IEZyb206IE1hcmt1cyBFbGZyaW5nIDxlbGZyaW5nQHVzZXJzLnNvdXJjZWZvcmdlLm5ldD4N Cj4gRGF0ZTogVHVlLCA1IE5vdiAyMDE5IDE5OjMyOjI1ICswMTAwDQo+IA0KPiBUaGUgc2FtZSBy ZXR1cm4gY29kZSB3YXMgc2V0IGFmdGVyIHRocmVlIGNvbmRpdGlvbiBjaGVja3MuDQo+IFRodXMg dXNlIGEgc2luZ2xlIHN0YXRlbWVudCBpbnN0ZWFkLg0KPiANCj4gRml4ZXM6IDIwZWM2MjhlODAw N2VjNzVjMmY4ODRlMDAwMDRmMzllYWI2Mjg5YjUgKCJtaXNjOiB4aWxpbnhfc2RmZWM6IEFkZCBh YmlsaXR5IHRvIGNvbmZpZ3VyZSBMRFBDIikNCj4gU2lnbmVkLW9mZi1ieTogTWFya3VzIEVsZnJp bmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0Pg0KPiAtLS0NCj4gIGRyaXZlcnMvbWlz Yy94aWxpbnhfc2RmZWMuYyB8IDE2ICsrKystLS0tLS0tLS0tLS0NCj4gIDEgZmlsZSBjaGFuZ2Vk LCA0IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbWlzYy94aWxpbnhfc2RmZWMuYyBiL2RyaXZlcnMvbWlzYy94aWxpbnhfc2RmZWMuYw0K PiBpbmRleCBhNjIyZmNmNDk1NGEuLjMyMmQ1YzZlNmQxMiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVy cy9taXNjL3hpbGlueF9zZGZlYy5jDQo+ICsrKyBiL2RyaXZlcnMvbWlzYy94aWxpbnhfc2RmZWMu Yw0KPiBAQCAtNjUzLDE4ICs2NTMsMTAgQEAgc3RhdGljIGludCB4c2RmZWNfYWRkX2xkcGMoc3Ry dWN0IHhzZGZlY19kZXYgKnhzZGZlYywgdm9pZCBfX3VzZXIgKmFyZykNCj4gIAlpZiAoSVNfRVJS KGxkcGMpKQ0KPiAgCQlyZXR1cm4gUFRSX0VSUihsZHBjKTsNCj4gDQo+IC0JaWYgKHhzZGZlYy0+ Y29uZmlnLmNvZGUgPT0gWFNERkVDX1RVUkJPX0NPREUpIHsNCj4gLQkJcmV0ID0gLUVJTzsNCj4g LQkJZ290byBlcnJfb3V0Ow0KPiAtCX0NCj4gLQ0KPiAtCS8qIFZlcmlmeSBEZXZpY2UgaGFzIG5v dCBzdGFydGVkICovDQo+IC0JaWYgKHhzZGZlYy0+c3RhdGUgPT0gWFNERkVDX1NUQVJURUQpIHsN Cj4gLQkJcmV0ID0gLUVJTzsNCj4gLQkJZ290byBlcnJfb3V0Ow0KPiAtCX0NCj4gLQ0KPiAtCWlm ICh4c2RmZWMtPmNvbmZpZy5jb2RlX3dyX3Byb3RlY3QpIHsNCj4gKwlpZiAoeHNkZmVjLT5jb25m aWcuY29kZSA9PSBYU0RGRUNfVFVSQk9fQ09ERSB8fA0KPiArCSAgICAvKiBWZXJpZnkgZGV2aWNl IGhhcyBub3Qgc3RhcnRlZCAqLw0KPiArCSAgICB4c2RmZWMtPnN0YXRlID09IFhTREZFQ19TVEFS VEVEIHx8DQo+ICsJICAgIHhzZGZlYy0+Y29uZmlnLmNvZGVfd3JfcHJvdGVjdCkgew0KPiAgCQly ZXQgPSAtRUlPOw0KPiAgCQlnb3RvIGVycl9vdXQ7DQo+ICAJfQ0KDQphcHByb3ZlZA0KDQo+IC0t DQo+IDIuMjQuMA0KDQo ^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() 2019-11-05 18:56 ` [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc Markus Elfring (?) @ 2019-11-07 21:58 ` Dragan Cvetic -1 siblings, 0 replies; 21+ messages in thread From: Dragan Cvetic @ 2019-11-07 21:58 UTC (permalink / raw) To: Markus Elfring, linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Greg Kroah-Hartman, Michal Simek Cc: LKML, kernel-janitors > -----Original Message----- > From: Markus Elfring [mailto:Markus.Elfring@web.de] > Sent: Tuesday 5 November 2019 18:56 > To: linux-arm-kernel@lists.infradead.org; Arnd Bergmann <arnd@arndb.de>; Derek Kiernan <dkiernan@xilinx.com>; Dragan Cvetic > <draganc@xilinx.com>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Michal Simek <michals@xilinx.com> > Cc: LKML <linux-kernel@vger.kernel.org>; kernel-janitors@vger.kernel.org > Subject: [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 5 Nov 2019 19:32:25 +0100 > > The same return code was set after three condition checks. > Thus use a single statement instead. > > Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/misc/xilinx_sdfec.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c > index a622fcf4954a..322d5c6e6d12 100644 > --- a/drivers/misc/xilinx_sdfec.c > +++ b/drivers/misc/xilinx_sdfec.c > @@ -653,18 +653,10 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) > if (IS_ERR(ldpc)) > return PTR_ERR(ldpc); > > - if (xsdfec->config.code == XSDFEC_TURBO_CODE) { > - ret = -EIO; > - goto err_out; > - } > - > - /* Verify Device has not started */ > - if (xsdfec->state == XSDFEC_STARTED) { > - ret = -EIO; > - goto err_out; > - } > - > - if (xsdfec->config.code_wr_protect) { > + if (xsdfec->config.code == XSDFEC_TURBO_CODE || > + /* Verify device has not started */ > + xsdfec->state == XSDFEC_STARTED || > + xsdfec->config.code_wr_protect) { > ret = -EIO; > goto err_out; > } > -- > 2.24.0 Acked-by: Dragan Cvetic <dragan.cvetic@xilinx.com> ^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() @ 2019-11-07 21:58 ` Dragan Cvetic 0 siblings, 0 replies; 21+ messages in thread From: Dragan Cvetic @ 2019-11-07 21:58 UTC (permalink / raw) To: Markus Elfring, linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML > -----Original Message----- > From: Markus Elfring [mailto:Markus.Elfring@web.de] > Sent: Tuesday 5 November 2019 18:56 > To: linux-arm-kernel@lists.infradead.org; Arnd Bergmann <arnd@arndb.de>; Derek Kiernan <dkiernan@xilinx.com>; Dragan Cvetic > <draganc@xilinx.com>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Michal Simek <michals@xilinx.com> > Cc: LKML <linux-kernel@vger.kernel.org>; kernel-janitors@vger.kernel.org > Subject: [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 5 Nov 2019 19:32:25 +0100 > > The same return code was set after three condition checks. > Thus use a single statement instead. > > Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC") > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/misc/xilinx_sdfec.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c > index a622fcf4954a..322d5c6e6d12 100644 > --- a/drivers/misc/xilinx_sdfec.c > +++ b/drivers/misc/xilinx_sdfec.c > @@ -653,18 +653,10 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg) > if (IS_ERR(ldpc)) > return PTR_ERR(ldpc); > > - if (xsdfec->config.code == XSDFEC_TURBO_CODE) { > - ret = -EIO; > - goto err_out; > - } > - > - /* Verify Device has not started */ > - if (xsdfec->state == XSDFEC_STARTED) { > - ret = -EIO; > - goto err_out; > - } > - > - if (xsdfec->config.code_wr_protect) { > + if (xsdfec->config.code == XSDFEC_TURBO_CODE || > + /* Verify device has not started */ > + xsdfec->state == XSDFEC_STARTED || > + xsdfec->config.code_wr_protect) { > ret = -EIO; > goto err_out; > } > -- > 2.24.0 Acked-by: Dragan Cvetic <dragan.cvetic@xilinx.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ @ 2019-11-07 21:58 ` Dragan Cvetic 0 siblings, 0 replies; 21+ messages in thread From: Dragan Cvetic @ 2019-11-07 21:58 UTC (permalink / raw) To: Markus Elfring, linux-arm-kernel, Arnd Bergmann, Derek Kiernan, Greg Kroah-Hartman, Michal Simek Cc: kernel-janitors, LKML DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogTWFya3VzIEVsZnJpbmcg W21haWx0bzpNYXJrdXMuRWxmcmluZ0B3ZWIuZGVdDQo+IFNlbnQ6IFR1ZXNkYXkgNSBOb3ZlbWJl ciAyMDE5IDE4OjU2DQo+IFRvOiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7 IEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIuZGU+OyBEZXJlayBLaWVybmFuIDxka2llcm5hbkB4 aWxpbnguY29tPjsgRHJhZ2FuIEN2ZXRpYw0KPiA8ZHJhZ2FuY0B4aWxpbnguY29tPjsgR3JlZyBL cm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz47IE1pY2hhbCBTaW1layA8 bWljaGFsc0B4aWxpbnguY29tPg0KPiBDYzogTEtNTCA8bGludXgta2VybmVsQHZnZXIua2VybmVs Lm9yZz47IGtlcm5lbC1qYW5pdG9yc0B2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogW1BBVENI IDIvMl0gbWlzYzogeGlsaW54X3NkZmVjOiBDb21iaW5lIHRocmVlIGNvbmRpdGlvbiBjaGVja3Mg aW50byBvbmUgc3RhdGVtZW50IGluIHhzZGZlY19hZGRfbGRwYygpDQo+IA0KPiBGcm9tOiBNYXJr dXMgRWxmcmluZyA8ZWxmcmluZ0B1c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+DQo+IERhdGU6IFR1ZSwg NSBOb3YgMjAxOSAxOTozMjoyNSArMDEwMA0KPiANCj4gVGhlIHNhbWUgcmV0dXJuIGNvZGUgd2Fz IHNldCBhZnRlciB0aHJlZSBjb25kaXRpb24gY2hlY2tzLg0KPiBUaHVzIHVzZSBhIHNpbmdsZSBz dGF0ZW1lbnQgaW5zdGVhZC4NCj4gDQo+IEZpeGVzOiAyMGVjNjI4ZTgwMDdlYzc1YzJmODg0ZTAw MDA0ZjM5ZWFiNjI4OWI1ICgibWlzYzogeGlsaW54X3NkZmVjOiBBZGQgYWJpbGl0eSB0byBjb25m aWd1cmUgTERQQyIpDQo+IFNpZ25lZC1vZmYtYnk6IE1hcmt1cyBFbGZyaW5nIDxlbGZyaW5nQHVz ZXJzLnNvdXJjZWZvcmdlLm5ldD4NCj4gLS0tDQo+ICBkcml2ZXJzL21pc2MveGlsaW54X3NkZmVj LmMgfCAxNiArKysrLS0tLS0tLS0tLS0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25z KCspLCAxMiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21pc2MveGls aW54X3NkZmVjLmMgYi9kcml2ZXJzL21pc2MveGlsaW54X3NkZmVjLmMNCj4gaW5kZXggYTYyMmZj ZjQ5NTRhLi4zMjJkNWM2ZTZkMTIgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvbWlzYy94aWxpbnhf c2RmZWMuYw0KPiArKysgYi9kcml2ZXJzL21pc2MveGlsaW54X3NkZmVjLmMNCj4gQEAgLTY1Mywx OCArNjUzLDEwIEBAIHN0YXRpYyBpbnQgeHNkZmVjX2FkZF9sZHBjKHN0cnVjdCB4c2RmZWNfZGV2 ICp4c2RmZWMsIHZvaWQgX191c2VyICphcmcpDQo+ICAJaWYgKElTX0VSUihsZHBjKSkNCj4gIAkJ cmV0dXJuIFBUUl9FUlIobGRwYyk7DQo+IA0KPiAtCWlmICh4c2RmZWMtPmNvbmZpZy5jb2RlID09 IFhTREZFQ19UVVJCT19DT0RFKSB7DQo+IC0JCXJldCA9IC1FSU87DQo+IC0JCWdvdG8gZXJyX291 dDsNCj4gLQl9DQo+IC0NCj4gLQkvKiBWZXJpZnkgRGV2aWNlIGhhcyBub3Qgc3RhcnRlZCAqLw0K PiAtCWlmICh4c2RmZWMtPnN0YXRlID09IFhTREZFQ19TVEFSVEVEKSB7DQo+IC0JCXJldCA9IC1F SU87DQo+IC0JCWdvdG8gZXJyX291dDsNCj4gLQl9DQo+IC0NCj4gLQlpZiAoeHNkZmVjLT5jb25m aWcuY29kZV93cl9wcm90ZWN0KSB7DQo+ICsJaWYgKHhzZGZlYy0+Y29uZmlnLmNvZGUgPT0gWFNE RkVDX1RVUkJPX0NPREUgfHwNCj4gKwkgICAgLyogVmVyaWZ5IGRldmljZSBoYXMgbm90IHN0YXJ0 ZWQgKi8NCj4gKwkgICAgeHNkZmVjLT5zdGF0ZSA9PSBYU0RGRUNfU1RBUlRFRCB8fA0KPiArCSAg ICB4c2RmZWMtPmNvbmZpZy5jb2RlX3dyX3Byb3RlY3QpIHsNCj4gIAkJcmV0ID0gLUVJTzsNCj4g IAkJZ290byBlcnJfb3V0Ow0KPiAgCX0NCj4gLS0NCj4gMi4yNC4wDQoNCkFja2VkLWJ5OiBEcmFn YW4gQ3ZldGljIDxkcmFnYW4uY3ZldGljQHhpbGlueC5jb20+DQo ^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2019-11-10 22:18 UTC | newest] Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-05 18:52 [PATCH 0/2] misc: xilinx_sdfec: Adjustments for xsdfec_add_ldpc() Markus Elfring 2019-11-05 18:52 ` Markus Elfring 2019-11-05 18:52 ` Markus Elfring 2019-11-05 18:54 ` [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation Markus Elfring 2019-11-05 18:54 ` Markus Elfring 2019-11-05 18:54 ` Markus Elfring 2019-11-07 15:40 ` Dragan Cvetic 2019-11-07 15:40 ` Dragan Cvetic 2019-11-07 15:40 ` Dragan Cvetic 2019-11-10 22:18 ` Dragan Cvetic 2019-11-10 22:18 ` Dragan Cvetic 2019-11-10 22:18 ` Dragan Cvetic 2019-11-05 18:56 ` [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() Markus Elfring 2019-11-05 18:56 ` Markus Elfring 2019-11-05 18:56 ` [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc Markus Elfring 2019-11-07 16:30 ` [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() Dragan Cvetic 2019-11-07 16:30 ` Dragan Cvetic 2019-11-07 16:30 ` [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ Dragan Cvetic 2019-11-07 21:58 ` [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ldpc() Dragan Cvetic 2019-11-07 21:58 ` Dragan Cvetic 2019-11-07 21:58 ` [PATCH 2/2] misc: xilinx_sdfec: Combine three condition checks into one statement in xsdfec_add_ Dragan Cvetic
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.