From: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com> To: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "Souza, Jose" <jose.souza@intel.com> Subject: Re: [PATCH 4/4] drm/i915/display: Set TRANS_DDI_MODE_SELECT to default value when disabling TRANS_DDI Date: Tue, 11 Feb 2020 11:23:18 +0000 [thread overview] Message-ID: <bb5c6aee30df288ecf9f48de3382c62584c4493f.camel@intel.com> (raw) In-Reply-To: <20200117015837.402239-4-jose.souza@intel.com> On Thu, 2020-01-16 at 17:58 -0800, José Roberto de Souza wrote: > TGL timeouts when disabling MST transcoder and fifo underruns over > MST > transcoders are fixed when setting TRANS_DDI_MODE_SELECT to 0(HDMI > mode) during the disable sequence. > > Although BSpec disable sequence don't require this step it is a > harmless change and it is also done by Windows driver. > Anyhow HW team was notified about that but it can take some time to > documentation to be updated. > > A case that always lead to those issues is: > - do a modeset enabling pipe A and pipe B in the same MST stream > leaving A as master > - disable pipe A, promote B as master doing a full modeset in A > - enable pipe A, changing the master transcoder back to A(doing a > full modeset in B) > - Pow: underruns and timeouts > > The transcoders involved will only work again when complete disabled > and their power wells turned off causing a reset in their registers. > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Matt Roper <matthew.d.roper@intel.com> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 1 + > 1 file changed, 1 insertion(+) BAT/IGT are fine, so if this improves some MST behaviors don't see any point in holding this patch from being merged. For MST, we are anyway facing MST regressions almost on weekly basis. Until we have some meaningful tests in CI for MST, it anyway would be constantly in "bad" shape. Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c > b/drivers/gpu/drm/i915/display/intel_ddi.c > index 32ea3c7e8b62..82e90f271974 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -1997,6 +1997,7 @@ void intel_ddi_disable_transcoder_func(const > struct intel_crtc_state *crtc_state > > val = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder)); > val &= ~TRANS_DDI_FUNC_ENABLE; > + val &= ~TRANS_DDI_MODE_SELECT_MASK; > > if (INTEL_GEN(dev_priv) >= 12) { > if (!intel_dp_mst_is_master_trans(crtc_state)) _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com> To: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "Souza, Jose" <jose.souza@intel.com> Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915/display: Set TRANS_DDI_MODE_SELECT to default value when disabling TRANS_DDI Date: Tue, 11 Feb 2020 11:23:18 +0000 [thread overview] Message-ID: <bb5c6aee30df288ecf9f48de3382c62584c4493f.camel@intel.com> (raw) In-Reply-To: <20200117015837.402239-4-jose.souza@intel.com> On Thu, 2020-01-16 at 17:58 -0800, José Roberto de Souza wrote: > TGL timeouts when disabling MST transcoder and fifo underruns over > MST > transcoders are fixed when setting TRANS_DDI_MODE_SELECT to 0(HDMI > mode) during the disable sequence. > > Although BSpec disable sequence don't require this step it is a > harmless change and it is also done by Windows driver. > Anyhow HW team was notified about that but it can take some time to > documentation to be updated. > > A case that always lead to those issues is: > - do a modeset enabling pipe A and pipe B in the same MST stream > leaving A as master > - disable pipe A, promote B as master doing a full modeset in A > - enable pipe A, changing the master transcoder back to A(doing a > full modeset in B) > - Pow: underruns and timeouts > > The transcoders involved will only work again when complete disabled > and their power wells turned off causing a reset in their registers. > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Matt Roper <matthew.d.roper@intel.com> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 1 + > 1 file changed, 1 insertion(+) BAT/IGT are fine, so if this improves some MST behaviors don't see any point in holding this patch from being merged. For MST, we are anyway facing MST regressions almost on weekly basis. Until we have some meaningful tests in CI for MST, it anyway would be constantly in "bad" shape. Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c > b/drivers/gpu/drm/i915/display/intel_ddi.c > index 32ea3c7e8b62..82e90f271974 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -1997,6 +1997,7 @@ void intel_ddi_disable_transcoder_func(const > struct intel_crtc_state *crtc_state > > val = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder)); > val &= ~TRANS_DDI_FUNC_ENABLE; > + val &= ~TRANS_DDI_MODE_SELECT_MASK; > > if (INTEL_GEN(dev_priv) >= 12) { > if (!intel_dp_mst_is_master_trans(crtc_state)) _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-11 11:23 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-17 1:58 [PATCH 1/4] drm/mst: Don't do atomic checks over disabled managers José Roberto de Souza 2020-01-17 1:58 ` [Intel-gfx] " José Roberto de Souza 2020-01-17 1:58 ` [PATCH 2/4] drm/mst: Some style improvements in drm_dp_mst_topology_mgr_set_mst() José Roberto de Souza 2020-01-17 1:58 ` [Intel-gfx] " José Roberto de Souza 2020-01-17 20:22 ` Lyude Paul 2020-01-17 20:22 ` [Intel-gfx] " Lyude Paul 2020-01-17 21:20 ` Lyude Paul 2020-01-17 21:20 ` [Intel-gfx] " Lyude Paul 2020-01-17 1:58 ` [PATCH 3/4] drm/i915/display: Remove useless call intel_dp_mst_encoder_cleanup() José Roberto de Souza 2020-01-17 1:58 ` [Intel-gfx] " José Roberto de Souza 2020-01-30 17:16 ` Ville Syrjälä 2020-01-30 17:16 ` Ville Syrjälä 2020-01-31 0:14 ` Souza, Jose 2020-01-31 0:14 ` Souza, Jose 2020-02-11 10:53 ` Lisovskiy, Stanislav 2020-02-11 10:53 ` [Intel-gfx] " Lisovskiy, Stanislav 2020-01-17 1:58 ` [PATCH 4/4] drm/i915/display: Set TRANS_DDI_MODE_SELECT to default value when disabling TRANS_DDI José Roberto de Souza 2020-01-17 1:58 ` [Intel-gfx] " José Roberto de Souza 2020-01-30 17:25 ` Ville Syrjälä 2020-01-30 17:25 ` [Intel-gfx] " Ville Syrjälä 2020-01-30 20:07 ` Souza, Jose 2020-01-30 20:07 ` [Intel-gfx] " Souza, Jose 2020-01-31 11:20 ` Ville Syrjälä 2020-01-31 11:20 ` [Intel-gfx] " Ville Syrjälä 2020-05-13 8:28 ` Sharma, Swati2 2020-05-13 8:28 ` Sharma, Swati2 2020-05-13 12:09 ` Ville Syrjälä 2020-05-13 12:09 ` Ville Syrjälä 2020-05-13 12:14 ` Ville Syrjälä 2020-05-13 12:14 ` Ville Syrjälä 2020-02-11 11:23 ` Lisovskiy, Stanislav [this message] 2020-02-11 11:23 ` Lisovskiy, Stanislav 2020-01-17 3:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/mst: Don't do atomic checks over disabled managers Patchwork 2020-01-17 3:08 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork 2020-01-17 13:51 ` [PATCH 1/4] " Mikita Lipski 2020-01-17 13:51 ` [Intel-gfx] " Mikita Lipski 2020-01-17 20:21 ` Lyude Paul 2020-01-17 20:21 ` [Intel-gfx] " Lyude Paul 2020-01-17 21:24 ` Alex Deucher 2020-01-17 21:24 ` [Intel-gfx] " Alex Deucher 2020-01-20 10:42 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bb5c6aee30df288ecf9f48de3382c62584c4493f.camel@intel.com \ --to=stanislav.lisovskiy@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jose.souza@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.