Re: [PATCH 15/16] soc: imx: gpcv2: support reset defer probe

From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: marex@denx.de, devicetree@vger.kernel.org,
	Peng Fan <peng.fan@nxp.com>,
	kernel@pengutronix.de, abel.vesa@nxp.com,
	andrew.smirnov@gmail.com, aford173@gmail.com, agx@sigxcpu.org,
	linux-kernel@vger.kernel.org, krzk@kernel.org,
	frieder.schrempf@kontron.de, ping.bai@nxp.com, linux-imx@nxp.com,
	p.zabel@pengutronix.de, festevam@gmail.com,
	linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de
Subject: Re: [PATCH 15/16] soc: imx: gpcv2: support reset defer probe
Date: Thu, 29 Apr 2021 10:39:14 +0200	[thread overview]
Message-ID: <bc5793e4-5d43-1ca9-7a12-9b58806c1856@pengutronix.de> (raw)
In-Reply-To: <20210429073050.21039-16-peng.fan@oss.nxp.com>

Hi,

On 29.04.21 09:30, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> When gpcv2 probe, the reset controller might not be ready, so we need
> defer probe
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/soc/imx/gpcv2.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index 072f519462a5..49dd137f6b94 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -784,9 +784,12 @@ static int imx_pgc_domain_probe(struct platform_device *pdev)
>  				     "Failed to get domain's clocks\n");
>  
>  	domain->reset = devm_reset_control_array_get_optional_exclusive(domain->dev);
> -	if (IS_ERR(domain->reset))
> +	if (IS_ERR(domain->reset)) {
> +		if (PTR_ERR(domain->reset) == -EPROBE_DEFER)
> +			return -EPROBE_DEFER;
>  		return dev_err_probe(domain->dev, PTR_ERR(domain->reset),
>  				     "Failed to get domain's resets\n");

dev_err_probe already propagates the error code in its second argument.
Seems to me this patch's only effect is to disable deferred probe reason tracking?

> +	}
>  
>  	pm_runtime_enable(domain->dev);
>  
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |