* [PATCH v1 1/1] platform/x86/intel: int33fe: Use y instead of objs in Makefile
@ 2021-08-06 15:49 Andy Shevchenko
2021-08-09 9:00 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2021-08-06 15:49 UTC (permalink / raw)
To: Andy Shevchenko, platform-driver-x86, linux-kernel
Cc: Hans de Goede, Mark Gross
The 'objs' is for user space tools, for the kernel modules
we should use 'y'.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/x86/intel/int33fe/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel/int33fe/Makefile b/drivers/platform/x86/intel/int33fe/Makefile
index cc11183ce179..9456e3b37f6f 100644
--- a/drivers/platform/x86/intel/int33fe/Makefile
+++ b/drivers/platform/x86/intel/int33fe/Makefile
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: GPL-2.0-only
obj-$(CONFIG_INTEL_CHT_INT33FE) += intel_cht_int33fe.o
-intel_cht_int33fe-objs := intel_cht_int33fe_common.o \
+intel_cht_int33fe-y := intel_cht_int33fe_common.o \
intel_cht_int33fe_typec.o \
intel_cht_int33fe_microb.o
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] platform/x86/intel: int33fe: Use y instead of objs in Makefile
2021-08-06 15:49 [PATCH v1 1/1] platform/x86/intel: int33fe: Use y instead of objs in Makefile Andy Shevchenko
@ 2021-08-09 9:00 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-08-09 9:00 UTC (permalink / raw)
To: Andy Shevchenko, platform-driver-x86, linux-kernel; +Cc: Mark Gross
Hi,
On 8/6/21 5:49 PM, Andy Shevchenko wrote:
> The 'objs' is for user space tools, for the kernel modules
> we should use 'y'.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/intel/int33fe/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/int33fe/Makefile b/drivers/platform/x86/intel/int33fe/Makefile
> index cc11183ce179..9456e3b37f6f 100644
> --- a/drivers/platform/x86/intel/int33fe/Makefile
> +++ b/drivers/platform/x86/intel/int33fe/Makefile
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0-only
> obj-$(CONFIG_INTEL_CHT_INT33FE) += intel_cht_int33fe.o
> -intel_cht_int33fe-objs := intel_cht_int33fe_common.o \
> +intel_cht_int33fe-y := intel_cht_int33fe_common.o \
> intel_cht_int33fe_typec.o \
> intel_cht_int33fe_microb.o
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-09 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06 15:49 [PATCH v1 1/1] platform/x86/intel: int33fe: Use y instead of objs in Makefile Andy Shevchenko
2021-08-09 9:00 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.