[Buildroot] [Bug 10361] New: python3 python-config script generates invalid includes

[Buildroot] [Bug 10361] New: python3 python-config script generates invalid includes

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10361

            Bug ID: 10361
           Summary: python3 python-config script generates invalid
                    includes
           Product: buildroot
           Version: unspecified
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: unassigned at buildroot.uclibc.org
          Reporter: matthew.weber at rockwellcollins.com
                CC: buildroot at uclibc.org
  Target Milestone: ---

If building in a path that starts with /usr, the includedir=$(echo
"@includedir@" | sed "s#^$prefix_build#$prefix_real#") assignment in the
python-config.sh ends up having the path it processes ran through a path
substitution once before this line is executed because the @includedir@ in the
python-config.sh.in is set to the string '${prefix}/include'.  ${prefix} is
assigned just above includedir in python-config.sh to prefix=$(echo
"$prefix_build" | sed "s#^$prefix_build#$prefix_real#")

I believe we need to update the line ref below to 

includedir=$(echo "@includedir@")

https://git.busybox.net/buildroot/tree/package/python3/0010-Misc-python-config.sh.in-ensure-sed-invocations-only.patch#n43

Another option would be to rename the prefix variable in this file so that
there isn't a naming conflict......

Example build failure
http://autobuild.buildroot.net/results/dfd/dfdac93d25d5730f08aa747e615a1a1c3ac7f1c0/

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10361] New: python3 python-config script generates invalid includes

[Matthew Weber]

Peter,

On Wed, Oct 4, 2017 at 9:19 PM,  <bugzilla@busybox.net> wrote:
> https://bugs.busybox.net/show_bug.cgi?id=10361
>
>             Bug ID: 10361
>            Summary: python3 python-config script generates invalid
>                     includes
>            Product: buildroot
>            Version: unspecified
>           Hardware: All
>                 OS: Linux
>             Status: NEW
>           Severity: normal
>           Priority: P5
>          Component: Other
>           Assignee: unassigned at buildroot.uclibc.org
>           Reporter: matthew.weber at rockwellcollins.com
>                 CC: buildroot at uclibc.org
>   Target Milestone: ---
>
> If building in a path that starts with /usr, the includedir=$(echo
> "@includedir@" | sed "s#^$prefix_build#$prefix_real#") assignment in the
> python-config.sh ends up having the path it processes ran through a path
> substitution once before this line is executed because the @includedir@ in the
> python-config.sh.in is set to the string '${prefix}/include'.  ${prefix} is
> assigned just above includedir in python-config.sh to prefix=$(echo
> "$prefix_build" | sed "s#^$prefix_build#$prefix_real#")
>
> I believe we need to update the line ref below to
>
> includedir=$(echo "@includedir@")
>
> https://git.busybox.net/buildroot/tree/package/python3/0010-Misc-python-config.sh.in-ensure-sed-invocations-only.patch#n43
>
> Another option would be to rename the prefix variable in this file so that
> there isn't a naming conflict......
>
> Example build failure
> http://autobuild.buildroot.net/results/dfd/dfdac93d25d5730f08aa747e615a1a1c3ac7f1c0/

I see u authored the original patch (unsure how much you are invested
in it, but curious of your feedback)?  I assume the content of
@includedir@ is based on the user of python's value they pass in, so I
think changing the prefix variable name in that script might be the
preferred option?

Matt

[Buildroot] [Bug 10361] python3 python-config script generates invalid includes

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10361

--- Comment #1 from Matt Weber <matthew.weber@rockwellcollins.com> ---
Added a upstream bug.

https://bugs.python.org/issue31713

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10361] python3 python-config script generates invalid includes

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10361

--- Comment #2 from Matt Weber <matthew.weber@rockwellcollins.com> ---
Created attachment 7261
  --> https://bugs.busybox.net/attachment.cgi?id=7261&action=edit
updates use of prefix

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10361] python3 python-config script generates invalid includes

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10361

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
Fixed by
https://git.buildroot.org/buildroot/commit/?id=04d1699ba4cecaa77f688b4effbcac5e84419b15

-- 
You are receiving this mail because:
You are on the CC list for the bug.