* [Buildroot] [Bug 10361] New: python3 python-config script generates invalid includes
@ 2017-10-05 2:19 bugzilla at busybox.net
2017-10-05 12:46 ` Matthew Weber
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: bugzilla at busybox.net @ 2017-10-05 2:19 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=10361
Bug ID: 10361
Summary: python3 python-config script generates invalid
includes
Product: buildroot
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: matthew.weber at rockwellcollins.com
CC: buildroot at uclibc.org
Target Milestone: ---
If building in a path that starts with /usr, the includedir=$(echo
"@includedir@" | sed "s#^$prefix_build#$prefix_real#") assignment in the
python-config.sh ends up having the path it processes ran through a path
substitution once before this line is executed because the @includedir@ in the
python-config.sh.in is set to the string '${prefix}/include'. ${prefix} is
assigned just above includedir in python-config.sh to prefix=$(echo
"$prefix_build" | sed "s#^$prefix_build#$prefix_real#")
I believe we need to update the line ref below to
includedir=$(echo "@includedir@")
https://git.busybox.net/buildroot/tree/package/python3/0010-Misc-python-config.sh.in-ensure-sed-invocations-only.patch#n43
Another option would be to rename the prefix variable in this file so that
there isn't a naming conflict......
Example build failure
http://autobuild.buildroot.net/results/dfd/dfdac93d25d5730f08aa747e615a1a1c3ac7f1c0/
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [Bug 10361] New: python3 python-config script generates invalid includes
2017-10-05 2:19 [Buildroot] [Bug 10361] New: python3 python-config script generates invalid includes bugzilla at busybox.net
@ 2017-10-05 12:46 ` Matthew Weber
2017-10-06 13:38 ` [Buildroot] [Bug 10361] " bugzilla at busybox.net
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Matthew Weber @ 2017-10-05 12:46 UTC (permalink / raw)
To: buildroot
Peter,
On Wed, Oct 4, 2017 at 9:19 PM, <bugzilla@busybox.net> wrote:
> https://bugs.busybox.net/show_bug.cgi?id=10361
>
> Bug ID: 10361
> Summary: python3 python-config script generates invalid
> includes
> Product: buildroot
> Version: unspecified
> Hardware: All
> OS: Linux
> Status: NEW
> Severity: normal
> Priority: P5
> Component: Other
> Assignee: unassigned at buildroot.uclibc.org
> Reporter: matthew.weber at rockwellcollins.com
> CC: buildroot at uclibc.org
> Target Milestone: ---
>
> If building in a path that starts with /usr, the includedir=$(echo
> "@includedir@" | sed "s#^$prefix_build#$prefix_real#") assignment in the
> python-config.sh ends up having the path it processes ran through a path
> substitution once before this line is executed because the @includedir@ in the
> python-config.sh.in is set to the string '${prefix}/include'. ${prefix} is
> assigned just above includedir in python-config.sh to prefix=$(echo
> "$prefix_build" | sed "s#^$prefix_build#$prefix_real#")
>
> I believe we need to update the line ref below to
>
> includedir=$(echo "@includedir@")
>
> https://git.busybox.net/buildroot/tree/package/python3/0010-Misc-python-config.sh.in-ensure-sed-invocations-only.patch#n43
>
> Another option would be to rename the prefix variable in this file so that
> there isn't a naming conflict......
>
> Example build failure
> http://autobuild.buildroot.net/results/dfd/dfdac93d25d5730f08aa747e615a1a1c3ac7f1c0/
I see u authored the original patch (unsure how much you are invested
in it, but curious of your feedback)? I assume the content of
@includedir@ is based on the user of python's value they pass in, so I
think changing the prefix variable name in that script might be the
preferred option?
Matt
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [Bug 10361] python3 python-config script generates invalid includes
2017-10-05 2:19 [Buildroot] [Bug 10361] New: python3 python-config script generates invalid includes bugzilla at busybox.net
2017-10-05 12:46 ` Matthew Weber
@ 2017-10-06 13:38 ` bugzilla at busybox.net
2017-10-06 17:46 ` bugzilla at busybox.net
2017-11-06 9:45 ` bugzilla at busybox.net
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla at busybox.net @ 2017-10-06 13:38 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=10361
--- Comment #1 from Matt Weber <matthew.weber@rockwellcollins.com> ---
Added a upstream bug.
https://bugs.python.org/issue31713
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [Bug 10361] python3 python-config script generates invalid includes
2017-10-05 2:19 [Buildroot] [Bug 10361] New: python3 python-config script generates invalid includes bugzilla at busybox.net
2017-10-05 12:46 ` Matthew Weber
2017-10-06 13:38 ` [Buildroot] [Bug 10361] " bugzilla at busybox.net
@ 2017-10-06 17:46 ` bugzilla at busybox.net
2017-11-06 9:45 ` bugzilla at busybox.net
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla at busybox.net @ 2017-10-06 17:46 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=10361
--- Comment #2 from Matt Weber <matthew.weber@rockwellcollins.com> ---
Created attachment 7261
--> https://bugs.busybox.net/attachment.cgi?id=7261&action=edit
updates use of prefix
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [Bug 10361] python3 python-config script generates invalid includes
2017-10-05 2:19 [Buildroot] [Bug 10361] New: python3 python-config script generates invalid includes bugzilla at busybox.net
` (2 preceding siblings ...)
2017-10-06 17:46 ` bugzilla at busybox.net
@ 2017-11-06 9:45 ` bugzilla at busybox.net
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla at busybox.net @ 2017-11-06 9:45 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=10361
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #3 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
Fixed by
https://git.buildroot.org/buildroot/commit/?id=04d1699ba4cecaa77f688b4effbcac5e84419b15
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-06 9:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-05 2:19 [Buildroot] [Bug 10361] New: python3 python-config script generates invalid includes bugzilla at busybox.net
2017-10-05 12:46 ` Matthew Weber
2017-10-06 13:38 ` [Buildroot] [Bug 10361] " bugzilla at busybox.net
2017-10-06 17:46 ` bugzilla at busybox.net
2017-11-06 9:45 ` bugzilla at busybox.net
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.