* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
@ 2017-11-14 18:10 ` bugzilla-daemon
2017-11-14 18:10 ` bugzilla-daemon
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2017-11-14 18:10 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 332 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #1 from Philip Rebohle <philip.rebohle@tu-dortmund.de> ---
Created attachment 135458
--> https://bugs.freedesktop.org/attachment.cgi?id=135458&action=edit
Frame 2400 with artifacts
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1349 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
2017-11-14 18:10 ` bugzilla-daemon
@ 2017-11-14 18:10 ` bugzilla-daemon
2017-11-14 18:21 ` bugzilla-daemon
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2017-11-14 18:10 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 335 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #2 from Philip Rebohle <philip.rebohle@tu-dortmund.de> ---
Created attachment 135459
--> https://bugs.freedesktop.org/attachment.cgi?id=135459&action=edit
Frame 2400 without artifacts
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1358 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
2017-11-14 18:10 ` bugzilla-daemon
2017-11-14 18:10 ` bugzilla-daemon
@ 2017-11-14 18:21 ` bugzilla-daemon
2017-11-27 11:02 ` bugzilla-daemon
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2017-11-14 18:21 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 475 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #3 from Philip Rebohle <philip.rebohle@tu-dortmund.de> ---
PS: While bug 102218 is not directly related to this one, that's another case
where two shaders that *should* be functionally equivalent yield different
results. In the second screenshot, workarounds for both issues are applied in
order to obtain correct rendering.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1504 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
` (2 preceding siblings ...)
2017-11-14 18:21 ` bugzilla-daemon
@ 2017-11-27 11:02 ` bugzilla-daemon
2017-11-27 12:04 ` bugzilla-daemon
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2017-11-27 11:02 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 278 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #4 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Thanks for the very lucid bug report. I can reproduce this and am
investigating.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1143 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
` (3 preceding siblings ...)
2017-11-27 11:02 ` bugzilla-daemon
@ 2017-11-27 12:04 ` bugzilla-daemon
2017-11-27 20:42 ` bugzilla-daemon
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2017-11-27 12:04 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 474 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #5 from Philip Rebohle <philip.rebohle@tu-dortmund.de> ---
I found another pair of equivalent expressions that produce different results.
Working as expected:
if ((floatBitsToUint(R0).y >= 0x4u ? 0xffffffffu : 0u) == 0xffffffffu)
Showing artifacts:
if ((floatBitsToUint(R0).y >= 0x4u ? 0xffffffffu : 0u) != 0u)
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1355 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
` (4 preceding siblings ...)
2017-11-27 12:04 ` bugzilla-daemon
@ 2017-11-27 20:42 ` bugzilla-daemon
2017-11-28 12:27 ` bugzilla-daemon
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2017-11-27 20:42 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 631 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #6 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Thanks. To give you an update, this is a super subtle control flow handling bug
in LLVM -- and the difference between the original shader and your modification
at the LLVM input is merely that the sense of one branch is (correctly)
inverted, leading LLVM down a subtly different path in the end.
A sledge-hammer fix is quite simple, but I'm still thinking about how to get a
better fix which doesn't pessimize a bunch of cases.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1496 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
` (5 preceding siblings ...)
2017-11-27 20:42 ` bugzilla-daemon
@ 2017-11-28 12:27 ` bugzilla-daemon
2017-11-28 12:28 ` bugzilla-daemon
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2017-11-28 12:27 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 320 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #7 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Created attachment 135749
--> https://bugs.freedesktop.org/attachment.cgi?id=135749&action=edit
patch for related issue
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1409 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
` (6 preceding siblings ...)
2017-11-28 12:27 ` bugzilla-daemon
@ 2017-11-28 12:28 ` bugzilla-daemon
2017-11-28 17:31 ` bugzilla-daemon
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2017-11-28 12:28 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 380 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #8 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Created attachment 135750
--> https://bugs.freedesktop.org/attachment.cgi?id=135750&action=edit
patch to fix this issue
Two patches for LLVM attached that fix the issue for me.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1469 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
` (7 preceding siblings ...)
2017-11-28 12:28 ` bugzilla-daemon
@ 2017-11-28 17:31 ` bugzilla-daemon
2017-11-28 17:33 ` bugzilla-daemon
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2017-11-28 17:31 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 673 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #9 from Philip Rebohle <philip.rebohle@tu-dortmund.de> ---
Thanks for looking into this. While these two patches certainly improve the
situation significantly, they don't fix the issue entirely.
The remaining artifacts are hardly noticable in the original apitrace, so I
created another one (2.9G, bz2-compressed):
https://mega.nz/#!FHxSgZjL!0MzRQhI6W6Lk0beTv9LrPxDWjNTQveDuXVq3Mz2s7-M
Note that my original workaround still works with the LLVM patches applied.
Tested with updated LLVM-git, revision accb337c76e.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1633 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
` (8 preceding siblings ...)
2017-11-28 17:31 ` bugzilla-daemon
@ 2017-11-28 17:33 ` bugzilla-daemon
2017-11-28 17:34 ` bugzilla-daemon
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2017-11-28 17:33 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 336 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #10 from Philip Rebohle <philip.rebohle@tu-dortmund.de> ---
Created attachment 135780
--> https://bugs.freedesktop.org/attachment.cgi?id=135780&action=edit
Frame 2320 with patched LLVM
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1360 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
` (9 preceding siblings ...)
2017-11-28 17:33 ` bugzilla-daemon
@ 2017-11-28 17:34 ` bugzilla-daemon
2018-04-18 9:50 ` bugzilla-daemon
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2017-11-28 17:34 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 336 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #11 from Philip Rebohle <philip.rebohle@tu-dortmund.de> ---
Created attachment 135781
--> https://bugs.freedesktop.org/attachment.cgi?id=135781&action=edit
Frame 2800 with patched LLVM
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1360 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
` (10 preceding siblings ...)
2017-11-28 17:34 ` bugzilla-daemon
@ 2018-04-18 9:50 ` bugzilla-daemon
2018-04-28 14:09 ` bugzilla-daemon
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2018-04-18 9:50 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 318 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #12 from Samuel Pitoiset <samuel.pitoiset@gmail.com> ---
Any news on this? The two LLVM patches have been pushed ~2 weeks ago. Can you
still reproduce the issue? Thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1191 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
` (11 preceding siblings ...)
2018-04-18 9:50 ` bugzilla-daemon
@ 2018-04-28 14:09 ` bugzilla-daemon
2019-02-18 1:36 ` bugzilla-daemon
2019-09-17 2:49 ` bugzilla-daemon
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2018-04-28 14:09 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 589 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #13 from Fabian Maurer <dark.shadow4@web.de> ---
Created attachment 139196
--> https://bugs.freedesktop.org/attachment.cgi?id=139196&action=edit
Video showing minor artifacts
While it's a lot better, it's not fully fixed yet. I added a video to show a
few artifacts, just look at the top middle area where the lightning jumps
around.
Created from this apitrace:
http://www.mediafire.com/file/cch4roemrd2gi1f/AutomataArtifacts.7z
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1685 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
` (12 preceding siblings ...)
2018-04-28 14:09 ` bugzilla-daemon
@ 2019-02-18 1:36 ` bugzilla-daemon
2019-09-17 2:49 ` bugzilla-daemon
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2019-02-18 1:36 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 742 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
--- Comment #14 from Timothy Arceri <t_arceri@yahoo.com.au> ---
(In reply to Fabian Maurer from comment #13)
> Created attachment 139196 [details]
> Video showing minor artifacts
>
> While it's a lot better, it's not fully fixed yet. I added a video to show a
> few artifacts, just look at the top middle area where the lightning jumps
> around.
>
> Created from this apitrace:
> http://www.mediafire.com/file/cch4roemrd2gi1f/AutomataArtifacts.7z
Those artifacts from the video seem to be gone with recent Mesa (19.1-devel)
and LLVM (9.0-devel). Can you confirm if that this is indeed fixed?
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2000 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts
2017-11-14 18:09 [Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts bugzilla-daemon
` (13 preceding siblings ...)
2019-02-18 1:36 ` bugzilla-daemon
@ 2019-09-17 2:49 ` bugzilla-daemon
14 siblings, 0 replies; 16+ messages in thread
From: bugzilla-daemon @ 2019-09-17 2:49 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 433 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=103743
Timothy Arceri <t_arceri@yahoo.com.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1304 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread