[Bug 208353] New: Distorted Audio Output Through USB C Docking Station

[Bug 208353] New: Distorted Audio Output Through USB C Docking Station

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

            Bug ID: 208353
           Summary: Distorted Audio Output Through USB C Docking Station
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.4.49
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: USB
          Assignee: drivers_usb@kernel-bugs.kernel.org
          Reporter: pbui@kernel.bx612.space
        Regression: No

Created attachment 289909
  --> https://bugzilla.kernel.org/attachment.cgi?id=289909&action=edit
Output of alsa-info.sh

With kernel 5.4.49 the audio output through my Dell WD19 Docking station is now
laggy and distorted (sounds like only bass frequencies are emitted). 
Previously, audio output through the dock worked just fine with all versions of
4.19.x and 5.4.x.

After looking through the changelog for 5.4.49, I was able to locate the
offending patch:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/patch/?id=aba41867dd66939d336fdf604e4d73b805d8039f

Reverting this patch allows audio to play normally through my docking station.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

Re: [Bug 208353] New: Distorted Audio Output Through USB C Docking Station

[Alan Stern]

Bring this to the attention of the person who wrote the offending commit:

On Sun, Jun 28, 2020 at 03:19:06PM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=208353
> 
>             Bug ID: 208353
>            Summary: Distorted Audio Output Through USB C Docking Station
>            Product: Drivers
>            Version: 2.5
>     Kernel Version: 5.4.49
>           Hardware: All
>                 OS: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: USB
>           Assignee: drivers_usb@kernel-bugs.kernel.org
>           Reporter: pbui@kernel.bx612.space
>         Regression: No
> 
> Created attachment 289909
>   --> https://bugzilla.kernel.org/attachment.cgi?id=289909&action=edit
> Output of alsa-info.sh
> 
> With kernel 5.4.49 the audio output through my Dell WD19 Docking station is now
> laggy and distorted (sounds like only bass frequencies are emitted). 
> Previously, audio output through the dock worked just fine with all versions of
> 4.19.x and 5.4.x.
> 
> After looking through the changelog for 5.4.49, I was able to locate the
> offending patch:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/patch/?id=aba41867dd66939d336fdf604e4d73b805d8039f

This is upstream commit f0bd62b64016 ("ALSA: usb-audio: Improve frames 
size computation").

Alan Stern

> Reverting this patch allows audio to play normally through my docking station.

[Bug 208353] Distorted Audio Output Through USB C Docking Station

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

--- Comment #1 from Alan Stern (stern@rowland.harvard.edu) ---
Bring this to the attention of the person who wrote the offending commit:

On Sun, Jun 28, 2020 at 03:19:06PM +0000, bugzilla-daemon@bugzilla.kernel.org
wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=208353
> 
>             Bug ID: 208353
>            Summary: Distorted Audio Output Through USB C Docking Station
>            Product: Drivers
>            Version: 2.5
>     Kernel Version: 5.4.49
>           Hardware: All
>                 OS: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: USB
>           Assignee: drivers_usb@kernel-bugs.kernel.org
>           Reporter: pbui@kernel.bx612.space
>         Regression: No
> 
> Created attachment 289909
>   --> https://bugzilla.kernel.org/attachment.cgi?id=289909&action=edit
> Output of alsa-info.sh
> 
> With kernel 5.4.49 the audio output through my Dell WD19 Docking station is
> now
> laggy and distorted (sounds like only bass frequencies are emitted). 
> Previously, audio output through the dock worked just fine with all versions
> of
> 4.19.x and 5.4.x.
> 
> After looking through the changelog for 5.4.49, I was able to locate the
> offending patch:
> 
>
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/patch/?id=aba41867dd66939d336fdf604e4d73b805d8039f

This is upstream commit f0bd62b64016 ("ALSA: usb-audio: Improve frames 
size computation").

Alan Stern

> Reverting this patch allows audio to play normally through my docking
> station.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208353] Distorted Audio Output Through USB C Docking Station

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

--- Comment #2 from Alexander Tsoy (alexander@tsoy.me) ---
Please attach the output of "lsusb -v -d 0bda:402e" command.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208353] Distorted Audio Output Through USB C Docking Station

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

Alexander Tsoy (alexander@tsoy.me) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tiwai@suse.de

--- Comment #4 from Alexander Tsoy (alexander@tsoy.me) ---
Thanks! I think I've completely missed datainterval in my calculations. I'll
prepare a patch for you to test.

(Also CCing Takashi)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208353] Distorted Audio Output Through USB C Docking Station

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

--- Comment #5 from Alexander Tsoy (alexander@tsoy.me) ---
Created attachment 289917
  --> https://bugzilla.kernel.org/attachment.cgi?id=289917&action=edit
test.patch

Here is a quick patch to test my theory. Please give it a try.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208353] Distorted Audio Output Through USB C Docking Station

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

--- Comment #9 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
Fedora is shipping 5.7.z kernels in our updates repo and it is raining
bug-reports because of this issue.

Can we please get a non test-patch fix for this ASAP?

Or get a revert of the commit causing this regression queued up for all the
stable series where this got added and is causing regressions (also ASAP)?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208353] Distorted Audio Output Through USB C Docking Station

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

--- Comment #10 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
Also see: bug 208311, bug 208317 and:

https://bugzilla.redhat.com/show_bug.cgi?id=1852564
https://bugzilla.redhat.com/show_bug.cgi?id=1853707
https://bugzilla.redhat.com/show_bug.cgi?id=1854166

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208353] Distorted Audio Output Through USB C Docking Station

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

Florian Engelhardt (flo@dotbox.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |flo@dotbox.org

--- Comment #11 from Florian Engelhardt (flo@dotbox.org) ---
I too can confirm the patch works, applied it to the Fedora 32 5.7.7 kernel and
the problem is solved. Thanks for the fix!

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208353] Distorted Audio Output Through USB C Docking Station

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

pnqkernelbugzilla@inkvizice.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pnqkernelbugzilla@inkvizice
                   |                            |.org

--- Comment #12 from pnqkernelbugzilla@inkvizice.org ---
I have similar issue with audio output from Dell WD15 USB-C Dock. I decoded
notorious song "Never Gonna Give You Up" to raw audio and ran it throug aplay.
Before the commit it plays normally, since the commit it plays like this:
https://central.szn.cz/s/tr9otisNwiFEE2A

The first official release with the issue is 5.7.6, it is still present in
5.8-rc4. Bisecting found the following commit
d288dc74f8cf95cb7ae0aaf245b7128627a49bf3 (ALSA: usb-audio: Improve frames size
computation), which is based on upstream commit
f0bd62b64016508938df9babe47f65c2c727d25c.

Release 5.7.7 with the patch from comment #5 seems okay.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208353] Distorted Audio Output Through USB C Docking Station

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

Takashi Iwai (tiwai@suse.de) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #13 from Takashi Iwai (tiwai@suse.de) ---
The fix patch landed in Linus tree yesterday.  Sorry that it took long, as I've
been off.

FWIW, Greg already reverted the original commit that caused a problem on stable
trees.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208353] Distorted Audio Output Through USB C Docking Station

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

Takashi Iwai (tiwai@suse.de) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alxchk@gmail.com

--- Comment #14 from Takashi Iwai (tiwai@suse.de) ---
*** Bug 208403 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208353] Distorted Audio Output Through USB C Docking Station

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

Takashi Iwai (tiwai@suse.de) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |subjectdenied@gmail.com

--- Comment #15 from Takashi Iwai (tiwai@suse.de) ---
*** Bug 208317 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208353] Distorted Audio Output Through USB C Docking Station

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

Takashi Iwai (tiwai@suse.de) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david@ixit.cz

--- Comment #16 from Takashi Iwai (tiwai@suse.de) ---
*** Bug 208501 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching the assignee of the bug.