* Re: [Bug 208353] New: Distorted Audio Output Through USB C Docking Station
2020-06-28 15:19 [Bug 208353] New: Distorted Audio Output Through USB C Docking Station bugzilla-daemon
@ 2020-06-28 17:50 ` Alan Stern
2020-06-28 17:50 ` [Bug 208353] " bugzilla-daemon
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: Alan Stern @ 2020-06-28 17:50 UTC (permalink / raw)
To: bugzilla-daemon; +Cc: Alexander Tsoy, linux-usb
Bring this to the attention of the person who wrote the offending commit:
On Sun, Jun 28, 2020 at 03:19:06PM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=208353
>
> Bug ID: 208353
> Summary: Distorted Audio Output Through USB C Docking Station
> Product: Drivers
> Version: 2.5
> Kernel Version: 5.4.49
> Hardware: All
> OS: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: USB
> Assignee: drivers_usb@kernel-bugs.kernel.org
> Reporter: pbui@kernel.bx612.space
> Regression: No
>
> Created attachment 289909
> --> https://bugzilla.kernel.org/attachment.cgi?id=289909&action=edit
> Output of alsa-info.sh
>
> With kernel 5.4.49 the audio output through my Dell WD19 Docking station is now
> laggy and distorted (sounds like only bass frequencies are emitted).
> Previously, audio output through the dock worked just fine with all versions of
> 4.19.x and 5.4.x.
>
> After looking through the changelog for 5.4.49, I was able to locate the
> offending patch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/patch/?id=aba41867dd66939d336fdf604e4d73b805d8039f
This is upstream commit f0bd62b64016 ("ALSA: usb-audio: Improve frames
size computation").
Alan Stern
> Reverting this patch allows audio to play normally through my docking station.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 208353] Distorted Audio Output Through USB C Docking Station
2020-06-28 15:19 [Bug 208353] New: Distorted Audio Output Through USB C Docking Station bugzilla-daemon
2020-06-28 17:50 ` Alan Stern
@ 2020-06-28 17:50 ` bugzilla-daemon
2020-06-28 18:15 ` bugzilla-daemon
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2020-06-28 17:50 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=208353
--- Comment #1 from Alan Stern (stern@rowland.harvard.edu) ---
Bring this to the attention of the person who wrote the offending commit:
On Sun, Jun 28, 2020 at 03:19:06PM +0000, bugzilla-daemon@bugzilla.kernel.org
wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=208353
>
> Bug ID: 208353
> Summary: Distorted Audio Output Through USB C Docking Station
> Product: Drivers
> Version: 2.5
> Kernel Version: 5.4.49
> Hardware: All
> OS: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: USB
> Assignee: drivers_usb@kernel-bugs.kernel.org
> Reporter: pbui@kernel.bx612.space
> Regression: No
>
> Created attachment 289909
> --> https://bugzilla.kernel.org/attachment.cgi?id=289909&action=edit
> Output of alsa-info.sh
>
> With kernel 5.4.49 the audio output through my Dell WD19 Docking station is
> now
> laggy and distorted (sounds like only bass frequencies are emitted).
> Previously, audio output through the dock worked just fine with all versions
> of
> 4.19.x and 5.4.x.
>
> After looking through the changelog for 5.4.49, I was able to locate the
> offending patch:
>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/patch/?id=aba41867dd66939d336fdf604e4d73b805d8039f
This is upstream commit f0bd62b64016 ("ALSA: usb-audio: Improve frames
size computation").
Alan Stern
> Reverting this patch allows audio to play normally through my docking
> station.
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 208353] Distorted Audio Output Through USB C Docking Station
2020-06-28 15:19 [Bug 208353] New: Distorted Audio Output Through USB C Docking Station bugzilla-daemon
2020-06-28 17:50 ` Alan Stern
2020-06-28 17:50 ` [Bug 208353] " bugzilla-daemon
@ 2020-06-28 18:15 ` bugzilla-daemon
2020-06-28 19:09 ` bugzilla-daemon
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2020-06-28 18:15 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=208353
--- Comment #2 from Alexander Tsoy (alexander@tsoy.me) ---
Please attach the output of "lsusb -v -d 0bda:402e" command.
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 208353] Distorted Audio Output Through USB C Docking Station
2020-06-28 15:19 [Bug 208353] New: Distorted Audio Output Through USB C Docking Station bugzilla-daemon
` (2 preceding siblings ...)
2020-06-28 18:15 ` bugzilla-daemon
@ 2020-06-28 19:09 ` bugzilla-daemon
2020-06-28 20:24 ` bugzilla-daemon
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2020-06-28 19:09 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=208353
Alexander Tsoy (alexander@tsoy.me) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tiwai@suse.de
--- Comment #4 from Alexander Tsoy (alexander@tsoy.me) ---
Thanks! I think I've completely missed datainterval in my calculations. I'll
prepare a patch for you to test.
(Also CCing Takashi)
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 208353] Distorted Audio Output Through USB C Docking Station
2020-06-28 15:19 [Bug 208353] New: Distorted Audio Output Through USB C Docking Station bugzilla-daemon
` (3 preceding siblings ...)
2020-06-28 19:09 ` bugzilla-daemon
@ 2020-06-28 20:24 ` bugzilla-daemon
2020-07-07 8:34 ` bugzilla-daemon
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2020-06-28 20:24 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=208353
--- Comment #5 from Alexander Tsoy (alexander@tsoy.me) ---
Created attachment 289917
--> https://bugzilla.kernel.org/attachment.cgi?id=289917&action=edit
test.patch
Here is a quick patch to test my theory. Please give it a try.
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 208353] Distorted Audio Output Through USB C Docking Station
2020-06-28 15:19 [Bug 208353] New: Distorted Audio Output Through USB C Docking Station bugzilla-daemon
` (4 preceding siblings ...)
2020-06-28 20:24 ` bugzilla-daemon
@ 2020-07-07 8:34 ` bugzilla-daemon
2020-07-07 8:36 ` bugzilla-daemon
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2020-07-07 8:34 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=208353
--- Comment #9 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
Fedora is shipping 5.7.z kernels in our updates repo and it is raining
bug-reports because of this issue.
Can we please get a non test-patch fix for this ASAP?
Or get a revert of the commit causing this regression queued up for all the
stable series where this got added and is causing regressions (also ASAP)?
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 208353] Distorted Audio Output Through USB C Docking Station
2020-06-28 15:19 [Bug 208353] New: Distorted Audio Output Through USB C Docking Station bugzilla-daemon
` (5 preceding siblings ...)
2020-07-07 8:34 ` bugzilla-daemon
@ 2020-07-07 8:36 ` bugzilla-daemon
2020-07-07 13:45 ` bugzilla-daemon
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2020-07-07 8:36 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=208353
--- Comment #10 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
Also see: bug 208311, bug 208317 and:
https://bugzilla.redhat.com/show_bug.cgi?id=1852564
https://bugzilla.redhat.com/show_bug.cgi?id=1853707
https://bugzilla.redhat.com/show_bug.cgi?id=1854166
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 208353] Distorted Audio Output Through USB C Docking Station
2020-06-28 15:19 [Bug 208353] New: Distorted Audio Output Through USB C Docking Station bugzilla-daemon
` (6 preceding siblings ...)
2020-07-07 8:36 ` bugzilla-daemon
@ 2020-07-07 13:45 ` bugzilla-daemon
2020-07-08 15:39 ` bugzilla-daemon
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2020-07-07 13:45 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=208353
Florian Engelhardt (flo@dotbox.org) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |flo@dotbox.org
--- Comment #11 from Florian Engelhardt (flo@dotbox.org) ---
I too can confirm the patch works, applied it to the Fedora 32 5.7.7 kernel and
the problem is solved. Thanks for the fix!
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 208353] Distorted Audio Output Through USB C Docking Station
2020-06-28 15:19 [Bug 208353] New: Distorted Audio Output Through USB C Docking Station bugzilla-daemon
` (7 preceding siblings ...)
2020-07-07 13:45 ` bugzilla-daemon
@ 2020-07-08 15:39 ` bugzilla-daemon
2020-07-09 14:10 ` bugzilla-daemon
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2020-07-08 15:39 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=208353
pnqkernelbugzilla@inkvizice.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pnqkernelbugzilla@inkvizice
| |.org
--- Comment #12 from pnqkernelbugzilla@inkvizice.org ---
I have similar issue with audio output from Dell WD15 USB-C Dock. I decoded
notorious song "Never Gonna Give You Up" to raw audio and ran it throug aplay.
Before the commit it plays normally, since the commit it plays like this:
https://central.szn.cz/s/tr9otisNwiFEE2A
The first official release with the issue is 5.7.6, it is still present in
5.8-rc4. Bisecting found the following commit
d288dc74f8cf95cb7ae0aaf245b7128627a49bf3 (ALSA: usb-audio: Improve frames size
computation), which is based on upstream commit
f0bd62b64016508938df9babe47f65c2c727d25c.
Release 5.7.7 with the patch from comment #5 seems okay.
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 208353] Distorted Audio Output Through USB C Docking Station
2020-06-28 15:19 [Bug 208353] New: Distorted Audio Output Through USB C Docking Station bugzilla-daemon
` (8 preceding siblings ...)
2020-07-08 15:39 ` bugzilla-daemon
@ 2020-07-09 14:10 ` bugzilla-daemon
2020-07-09 14:12 ` bugzilla-daemon
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2020-07-09 14:10 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=208353
Takashi Iwai (tiwai@suse.de) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |CODE_FIX
--- Comment #13 from Takashi Iwai (tiwai@suse.de) ---
The fix patch landed in Linus tree yesterday. Sorry that it took long, as I've
been off.
FWIW, Greg already reverted the original commit that caused a problem on stable
trees.
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 208353] Distorted Audio Output Through USB C Docking Station
2020-06-28 15:19 [Bug 208353] New: Distorted Audio Output Through USB C Docking Station bugzilla-daemon
` (9 preceding siblings ...)
2020-07-09 14:10 ` bugzilla-daemon
@ 2020-07-09 14:12 ` bugzilla-daemon
2020-07-09 14:15 ` bugzilla-daemon
2020-07-09 14:19 ` bugzilla-daemon
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2020-07-09 14:12 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=208353
Takashi Iwai (tiwai@suse.de) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alxchk@gmail.com
--- Comment #14 from Takashi Iwai (tiwai@suse.de) ---
*** Bug 208403 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 208353] Distorted Audio Output Through USB C Docking Station
2020-06-28 15:19 [Bug 208353] New: Distorted Audio Output Through USB C Docking Station bugzilla-daemon
` (10 preceding siblings ...)
2020-07-09 14:12 ` bugzilla-daemon
@ 2020-07-09 14:15 ` bugzilla-daemon
2020-07-09 14:19 ` bugzilla-daemon
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2020-07-09 14:15 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=208353
Takashi Iwai (tiwai@suse.de) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |subjectdenied@gmail.com
--- Comment #15 from Takashi Iwai (tiwai@suse.de) ---
*** Bug 208317 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 208353] Distorted Audio Output Through USB C Docking Station
2020-06-28 15:19 [Bug 208353] New: Distorted Audio Output Through USB C Docking Station bugzilla-daemon
` (11 preceding siblings ...)
2020-07-09 14:15 ` bugzilla-daemon
@ 2020-07-09 14:19 ` bugzilla-daemon
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2020-07-09 14:19 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=208353
Takashi Iwai (tiwai@suse.de) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david@ixit.cz
--- Comment #16 from Takashi Iwai (tiwai@suse.de) ---
*** Bug 208501 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread