[Bug 28517] New: [r300g] Savage 2 : characters are not rendered + another corruptions

[Bug 28517] New: [r300g] Savage 2 : characters are not rendered + another corruptions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

           Summary: [r300g] Savage 2 : characters are not rendered +
                    another corruptions
           Product: Mesa
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/r300
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: drakkk@centrum.cz


Created an attachment (id=36242)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=36242)
full terminal output

While in menu or in-game, characters are not rendered and there are many other
problems (top half of the screen is almost white etc.).

Some selected terminal output:

r300 VP: Compiler error:
rc_dataflow_deadcode: Unexpected control flow instruction
Using a dummy shader instead.
If there's an 'unknown opcode' message, please file a bug report and attach
this log.
When I tried this some time ago there were missing opcodes (BGNLOOP, BRK,
ENDLOOP), it looks like they are implemented now however this error is new.
This may interest Tom Stellard. 

Another problem:
Failed to allocate :
   size      : 16777216 bytes
   alignment : 2048 bytes
   domains   : 2
r300: Failed to create a transfer object, praise.
This is bug 28443

And lot of those:
Out of hw temporaries

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] Savage 2 : characters are not rendered + another corruptions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

Pavel Ondračka <drakkk@centrum.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.savage2.com/en/d
                   |                            |ownload.php

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] Savage 2 : characters are not rendered + another corruptions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #1 from Pavel Ondračka <drakkk@centrum.cz> 2010-06-13 02:59:33 PDT ---
Created an attachment (id=36243)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=36243)
screenshot

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] Savage 2 : characters are not rendered + another corruptions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #2 from Pavel Ondračka <drakkk@centrum.cz> 2010-06-13 04:18:23 PDT ---
I forgot to mention, all game graphic settings are set to lowest possible.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] Savage 2 : characters are not rendered + another corruptions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #3 from Pavel Ondračka <drakkk@centrum.cz> 2010-06-24 01:38:30 PDT ---
With current mesa git compiler error looks different:

r300 VP: Compiler error:
Ran out of temporary registers
Using a dummy shader instead.
If there's an 'unknown opcode' message, please file a bug report and attach
this log.

However rendering problems still remain.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] Savage 2 : characters are not rendered + another corruptions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

Sven Arvidsson <sa@whiz.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sa@whiz.se

--- Comment #4 from Sven Arvidsson <sa@whiz.se> 2010-06-26 12:27:38 PDT ---
FWIW: the problem with the white top of the screen is the same on Intel with
the i965 driver, so it's probably a general problem with Mesa.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] Savage 2 : characters are not rendered + another corruptions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #5 from Pavel Ondračka <drakkk@centrum.cz> 2010-06-26 13:25:40 PDT ---
(In reply to comment #4)
> FWIW: the problem with the white top of the screen is the same on Intel with
> the i965 driver, so it's probably a general problem with Mesa.

Maybe this bug needs splitting, or is there already bug opened about this
problem with i965 driver?
However I'm not sure if this is the same issue, I think the DRI and gallium
drivers use different codepaths?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] Savage 2 : characters are not rendered + another corruptions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #6 from Sven Arvidsson <sa@whiz.se> 2010-06-26 14:12:54 PDT ---
(In reply to comment #5)
> Maybe this bug needs splitting, or is there already bug opened about this
> problem with i965 driver?
> However I'm not sure if this is the same issue, I think the DRI and gallium
> drivers use different codepaths?

Well, there's bug 27028, a general bug for getting Savage 2 running on Intel
(at the moment it's only possible by increasing the loop unrolling limits).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[r300g] Savage 2 :          |[r300g] loop unrolling
                   |characters are not rendered |fails (was: Savage 2 :
                   |+ another corruptions       |characters are not rendered
                   |                            |+ another corruptions)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #7 from Tom Stellard <tstellar@gmail.com> 2010-08-05 23:37:28 PDT ---
Can you try again with the latest git code and post the output with
RADEON_DEBUG=vp

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #8 from Sven Arvidsson <sa@whiz.se> 2010-08-06 03:33:54 PDT ---
Created an attachment (id=37624)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=37624)
RADEON_DEBUG=vp log

(In reply to comment #7)
> Can you try again with the latest git code and post the output with
> RADEON_DEBUG=vp

Sure! Attaching a gzipped log.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #9 from Tom Stellard <tstellar@gmail.com> 2010-08-06 11:27:49 PDT ---
This patch: https://bugs.freedesktop.org/attachment.cgi?id=37644 from bug 29363
should help with this bug too.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #10 from Sven Arvidsson <sa@whiz.se> 2010-08-06 11:42:49 PDT ---
Created an attachment (id=37647)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=37647)
RADEON_DEBUG=vp log with patch from 29363

(In reply to comment #9)
> This patch: https://bugs.freedesktop.org/attachment.cgi?id=37644 from bug 29363
> should help with this bug too.

There's not much of a difference visually, it might actually be a little worse
with this patch. Not sure if that's much to go on though.

I'm also getting a lot of "Out of hw temporaries" warnings.

Attaching a new log with RADEON_DEBUG=vp if that's of any use.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #11 from Tom Stellard <tstellar@gmail.com> 2010-08-09 22:48:42 PDT ---
Can you try this patch https://bugs.freedesktop.org/attachment.cgi?id=37755
from bug 29363 and post the output of RADEON_DEBUG=vp.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #12 from Pavel Ondračka <drakkk@centrum.cz> 2010-08-10 01:33:26 PDT ---
Created an attachment (id=37759)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=37759)
RADEON_DEBUG=vp log with vs-if-loop.patch

Characters are being rendered now with your patch, but they are completely
wrong, I would say they are too big and there are many another problems.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #13 from Sven Arvidsson <sa@whiz.se> 2010-08-10 07:51:36 PDT ---
Created an attachment (id=37768)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=37768)
Screenshot of oversized character

I added a screenshot of the character, if that's helpful.

The slowdown mentioned in bug 29363 is also present in this game, but I guess
that might be secondary issue.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #14 from Sven Arvidsson <sa@whiz.se> 2010-08-19 07:39:50 PDT ---
The bug with the character might be something general in Mesa, and not in r300g
since it's almost the same in i965.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #15 from Pavel Ondračka <drakkk@centrum.cz> 2010-08-25 01:49:54 PDT ---
With latest mesa git problem with top half of the screen being white is fixed,
however characters are still corrupted, this is even worse than before glsl2
merge. As Sven Arvidsson said this may be a more generic problem, see similar
problems described in bug 27028. However I suspect r300 compiler to also have
some troubles because of the big slowdown introduced with Tom Stellards vertex
shader loops patches.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #16 from Marek Olšák <maraeo@gmail.com> 2010-08-25 06:46:52 PDT ---
Can you point to the vertex shader loops patches which cause problems for you?
Does reverting them help?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #17 from Tom Stellard <tstellar@gmail.com> 2010-08-25 07:20:15 PDT ---
(In reply to comment #13)
> Created an attachment (id=37768)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=37768)
> Screenshot of oversized character
> 
> I added a screenshot of the character, if that's helpful.
> 
> The slowdown mentioned in bug 29363 is also present in this game, but I guess
> that might be secondary issue.

The performance decrease you are seeing is because the correct vertex shaders
are being used now instead of dummy shaders.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #18 from Tom Stellard <tstellar@gmail.com> 2010-08-25 07:32:59 PDT ---
(In reply to comment #17)
> The performance decrease you are seeing is because the correct vertex shaders
> are being used now instead of dummy shaders.

I should add that there are still some optimizations that can be done with
vertex shader loops, but I can't really predict how much these optimizations
will improve performance.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #19 from Pavel Ondračka <drakkk@centrum.cz> 2010-08-25 08:09:00 PDT ---
(In reply to comment #17)
> (In reply to comment #13)
> > Created an attachment (id=37768)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=37768)
> > Screenshot of oversized character
> > 
> > I added a screenshot of the character, if that's helpful.
> > 
> > The slowdown mentioned in bug 29363 is also present in this game, but I guess
> > that might be secondary issue.
> 
> The performance decrease you are seeing is because the correct vertex shaders
> are being used now instead of dummy shaders.

OK this explains everything, except that at this point the vertex shaders are
not correct... do you need any more logs? However there is probably no rush to
fix this, since the game wont be playable anyway, unless the possible
optimization  speedup is really huge :-(

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #20 from Sven Arvidsson <sa@whiz.se> 2010-08-25 13:55:55 PDT ---
With latest git master (commit b5c07b9226d8e7de78f6367b5799b39caf820ef3) I only
get a black background and a mouse cursor. 

As for performance, it is much much slower than on my Intel IGP, slow enough
that you need to wait for the mouse cursor to move, so something seems to be
wrong.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #21 from Marek Olšák <maraeo@gmail.com> 2010-08-25 18:20:27 PDT ---
That doesn't sound good. Is there anything in dmesg? Perhaps you are just being
successfully recovered from a hard lockup every frame.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #22 from Sven Arvidsson <sa@whiz.se> 2010-08-26 06:38:10 PDT ---
No, nothing in dmesg. And just to clarify, it's only the game that's black, X
is unaffected.

I'll see if I can figure out where it broke, as it was working at least a
little bit better before.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #23 from Sven Arvidsson <sa@whiz.se> 2010-08-26 14:09:58 PDT ---
Dunno why, but the black screen was caused by libtxc_dxtn, removing it made the
problem go away. Anyway, some more observations about the performance problem: 

* It's not CPU-related, the game is only using about 60-70% on my system, so
shouldn't be a problem. 

* If run the game in a window, all other graphics related operations (such as
moving windows) slows to a crawl. 

* There's no significant difference in performance if I set all video options
in the game to their lowest setting.


Another game (from the same developers) that's having the same problem, is
Heroes of Newerth.
http://www.heroesofnewerth.com/download.php

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #24 from Sven Arvidsson <sa@whiz.se> 2010-08-26 14:32:38 PDT ---
(Sorry for the bug spam)

The performance problem I'm having seems to be a result of the glsl2 merge, and
not from the vs loops. So I guess that's a different problem than what Pavel
have described.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #25 from Ian Romanick <idr@freedesktop.org> 2010-08-26 15:41:05 PDT ---
(In reply to comment #20)
> With latest git master (commit b5c07b9226d8e7de78f6367b5799b39caf820ef3) I only
> get a black background and a mouse cursor. 
> 
> As for performance, it is much much slower than on my Intel IGP, slow enough
> that you need to wait for the mouse cursor to move, so something seems to be
> wrong.

Is the rendering correct on Intel hardware?  If the rendering isn't correct
anywhere, then the performance issues are irrelevant.  The performance will
change, one way or the other, when the correctness is fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #26 from Sven Arvidsson <sa@whiz.se> 2010-08-26 16:09:38 PDT ---
(In reply to comment #25)
> Is the rendering correct on Intel hardware?  If the rendering isn't correct
> anywhere, then the performance issues are irrelevant.  The performance will
> change, one way or the other, when the correctness is fixed.

No, it isn't correct on i965 either. Last word was that it was a bug in the
preprocessor, see bug 27028.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #27 from Ian Romanick <idr@freedesktop.org> 2010-08-26 16:31:51 PDT ---
(In reply to comment #26)
> (In reply to comment #25)
> > Is the rendering correct on Intel hardware?  If the rendering isn't correct
> > anywhere, then the performance issues are irrelevant.  The performance will
> > change, one way or the other, when the correctness is fixed.
> 
> No, it isn't correct on i965 either. Last word was that it was a bug in the
> preprocessor, see bug 27028.

The preprocessor test mentioned in that bug seems to work correctly now.  I
believe that one is fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #28 from Pavel Ondračka <drakkk@centrum.cz> 2010-08-27 00:37:49 PDT ---
(In reply to comment #24)
> (Sorry for the bug spam)
> 
> The performance problem I'm having seems to be a result of the glsl2 merge, and
> not from the vs loops. So I guess that's a different problem than what Pavel
> have described.

Hm, I don't really get this, I thought you also suffered from the slowdown
problem with vs loops patches long before glsl2 was merged (as indicated in
comment 13)? Never mind, I'll repeat my bisecting later today, maybe I did
something wrong last time.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #29 from Tom Stellard <tstellar@gmail.com> 2010-08-30 09:08:21 PDT ---
Created an attachment (id=38306)
 View: https://bugs.freedesktop.org/attachment.cgi?id=38306
 Review: https://bugs.freedesktop.org/review?bug=28517&attachment=38306

Reduce the number of loop iterations

Does this patch impact performance at all?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #30 from Pavel Ondračka <drakkk@centrum.cz> 2010-08-30 12:01:04 PDT ---
(In reply to comment #29)
> Created an attachment (id=38306)
 View: https://bugs.freedesktop.org/attachment.cgi?id=38306
 Review: https://bugs.freedesktop.org/review?bug=28517&attachment=38306

> Reduce the number of loop iterations
> 
> Does this patch impact performance at all?

No noticeable difference with you patch. BTW I did repeat bisecting and it
again showed commit c298bab60ea63882f34825a35cbc60f662783e64 as the one
introducing this slowness. So indeed your analysis in comment 17 looks right. I
wasn't able to bisect any further slowdown with glsl2 merge which Sven
mentioned in comment 24. However we might have different setups because for
example I don't have any troubles with libtxc_dxtn.so

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #31 from Sven Arvidsson <sa@whiz.se> 2010-08-30 12:24:37 PDT ---
(In reply to comment #29)
> Created an attachment (id=38306)
 View: https://bugs.freedesktop.org/attachment.cgi?id=38306
 Review: https://bugs.freedesktop.org/review?bug=28517&attachment=38306

> Reduce the number of loop iterations
> 
> Does this patch impact performance at all?

No noticeable difference here either.

I did notice a few compile errors though:
 r300 FP: Compiler Error:
 Fragment program does not support relative addressing  of source operands. 
 Using a dummy shader instead

And I'm getting these errors:
 radeon: The kernel rejected CS, see dmesg for more information.

dmesg:
 [340535.918564] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
 [340536.199125] [drm:r100_cs_track_check] *ERROR* [drm] Buffer too small for
color buffer 0 (need 4194304 have 3145728) !
 [340536.199129] [drm:r100_cs_track_check] *ERROR* [drm] color buffer 0 (1024 4
0 1024)

This behaviour is the same with or without the patch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #32 from Sven Arvidsson <sa@whiz.se> 2010-09-01 14:21:15 PDT ---
Interesting, the game seems to be rendering fine when llvmpipe is used.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

Ian Romanick <idr@freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |NEEDINFO

--- Comment #33 from Ian Romanick <idr@freedesktop.org> 2010-09-03 12:19:34 PDT ---
(In reply to comment #31)
> (In reply to comment #29)
> > Created an attachment (id=38306)
 View: https://bugs.freedesktop.org/attachment.cgi?id=38306
 Review: https://bugs.freedesktop.org/review?bug=28517&attachment=38306

> > Reduce the number of loop iterations
> > 
> > Does this patch impact performance at all?
> 
> No noticeable difference here either.
> 
> I did notice a few compile errors though:
>  r300 FP: Compiler Error:
>  Fragment program does not support relative addressing  of source operands. 
>  Using a dummy shader instead

This may be fixed now that loop unrolling is merged.  Can you retest?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #34 from Sven Arvidsson <sa@whiz.se> 2010-09-03 13:48:30 PDT ---
Created an attachment (id=38409)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=38409)
Screenshot of smearing in menu

(In reply to comment #33)
> 
> This may be fixed now that loop unrolling is merged.  Can you retest?

It is if not fixed, at least a whole lot better now! :)

Fixed:
* The model in the menu and the player character is rendered correctly as far
as I can tell. 
* The horrible slowdown is gone.

Remaining problems are: 
* "Smearing" in the menu (see screenshot for a better explanation) probably
because I'm still getting "radeon: The kernel rejected CS, see dmesg for more
information." errors logged in the terminal.
* Ingame, all textures seems to be white, not sure if this is related to my
problems with S3TC or something else.

So the GLSL side of things seems to have been taken care of!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #35 from Tom Stellard <tstellar@gmail.com> 2010-09-03 23:14:37 PDT ---
Can you repost the output of RADEON_DEBUG=vp with the latest git version?  I
want to see what the shaders look like with loop unrolling.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

Pavel Ondračka <drakkk@centrum.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36242|0                           |1
        is obsolete|                            |
  Attachment #36243|0                           |1
        is obsolete|                            |
  Attachment #37624|0                           |1
        is obsolete|                            |
  Attachment #37647|0                           |1
        is obsolete|                            |
  Attachment #37759|0                           |1
        is obsolete|                            |
  Attachment #37768|0                           |1
        is obsolete|                            |

--- Comment #36 from Pavel Ondračka <drakkk@centrum.cz> 2010-09-04 02:49:20 PDT ---
Created an attachment (id=38421)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=38421)
RADEON_DEBUG=vp output with mesa 79088746a231d361232fc87ab4d578b08c7ce2a7

This is with latest mesa and graphic settings set to lowest possible (no
glitches with lowest settings).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #37 from Sven Arvidsson <sa@whiz.se> 2010-09-04 05:12:48 PDT ---
(In reply to comment #36)
> 
> This is with latest mesa and graphic settings set to lowest possible (no
> glitches with lowest settings).

Good catch, it's seems to be working well on lowest settings here too!

Maybe we should consider this bug done and file new reports for the remaining
issues?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

Pavel Ondračka <drakkk@centrum.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #38 from Pavel Ondračka <drakkk@centrum.cz> 2010-09-04 05:59:43 PDT ---
(In reply to comment #37)
> (In reply to comment #36)
> > 
> > This is with latest mesa and graphic settings set to lowest possible (no
> > glitches with lowest settings).
> 
> Good catch, it's seems to be working well on lowest settings here too!
> 
> Maybe we should consider this bug done and file new reports for the remaining
> issues?

OK, closing, we spammed this report too much already. File new bugs if you
want. I'm not interested in higher settings since the game isn't fast enough to
be playable even with lowest settings here with my RV530 :-(

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #39 from Sven Arvidsson <sa@whiz.se> 2010-09-05 13:02:28 PDT ---
Remaining issue filed as bug 30036.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.