* [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads.
2017-02-12 15:34 [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads bugzilla-daemon
@ 2017-02-12 15:38 ` bugzilla-daemon
2017-02-12 15:39 ` bugzilla-daemon
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2017-02-12 15:38 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 383 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #1 from Matias N. Goldberg <dark_sylinc@yahoo.com.ar> ---
Created attachment 129531
--> https://bugs.freedesktop.org/attachment.cgi?id=129531&action=edit
Pixel Shader used to receive these shadows (already stripped down & with tint)
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1475 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads.
2017-02-12 15:34 [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads bugzilla-daemon
2017-02-12 15:38 ` bugzilla-daemon
@ 2017-02-12 15:39 ` bugzilla-daemon
2017-02-12 16:19 ` bugzilla-daemon
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2017-02-12 15:39 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 384 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #2 from Matias N. Goldberg <dark_sylinc@yahoo.com.ar> ---
Created attachment 129532
--> https://bugs.freedesktop.org/attachment.cgi?id=129532&action=edit
Vertex Shader used to receive these shadows (already stripped down & with tint)
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1478 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads.
2017-02-12 15:34 [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads bugzilla-daemon
2017-02-12 15:38 ` bugzilla-daemon
2017-02-12 15:39 ` bugzilla-daemon
@ 2017-02-12 16:19 ` bugzilla-daemon
2017-02-12 16:20 ` bugzilla-daemon
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2017-02-12 16:19 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 648 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #3 from Matias N. Goldberg <dark_sylinc@yahoo.com.ar> ---
Created attachment 129533
--> https://bugs.freedesktop.org/attachment.cgi?id=129533&action=edit
IR Generated by LLVM 3.9.1
Took me a while to find the IR out of all the noise.
You should consider adding a Mesa extension to give human-readable names to
shaders. It would help everyone in debugging A LOT.
I don't mind having
glSetNameMESA( shaderId, "My Filename" );
and internally Mesa keeps a std::map<int, string> or similar.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1640 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads.
2017-02-12 15:34 [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads bugzilla-daemon
` (2 preceding siblings ...)
2017-02-12 16:19 ` bugzilla-daemon
@ 2017-02-12 16:20 ` bugzilla-daemon
2017-02-12 16:30 ` bugzilla-daemon
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2017-02-12 16:20 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 329 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #4 from Matias N. Goldberg <dark_sylinc@yahoo.com.ar> ---
Created attachment 129534
--> https://bugs.freedesktop.org/attachment.cgi?id=129534&action=edit
IR Generated by LLVM 4.0
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1301 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads.
2017-02-12 15:34 [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads bugzilla-daemon
` (3 preceding siblings ...)
2017-02-12 16:20 ` bugzilla-daemon
@ 2017-02-12 16:30 ` bugzilla-daemon
2017-02-12 16:31 ` bugzilla-daemon
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2017-02-12 16:30 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 374 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #5 from Matias N. Goldberg <dark_sylinc@yahoo.com.ar> ---
Created attachment 129535
--> https://bugs.freedesktop.org/attachment.cgi?id=129535&action=edit
ASM 4.0
Those readfirstlane instructions are incredibly suspicious
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1312 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads.
2017-02-12 15:34 [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads bugzilla-daemon
` (4 preceding siblings ...)
2017-02-12 16:30 ` bugzilla-daemon
@ 2017-02-12 16:31 ` bugzilla-daemon
2017-02-12 17:34 ` bugzilla-daemon
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2017-02-12 16:31 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 319 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #6 from Matias N. Goldberg <dark_sylinc@yahoo.com.ar> ---
Created attachment 129536
--> https://bugs.freedesktop.org/attachment.cgi?id=129536&action=edit
ASM from 3.9.1
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1271 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads.
2017-02-12 15:34 [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads bugzilla-daemon
` (5 preceding siblings ...)
2017-02-12 16:31 ` bugzilla-daemon
@ 2017-02-12 17:34 ` bugzilla-daemon
2017-02-12 17:54 ` bugzilla-daemon
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2017-02-12 17:34 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 420 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #7 from Matias N. Goldberg <dark_sylinc@yahoo.com.ar> ---
Analyzing the ASM it's clear what's happening: the 3.9.1 version branches
everything.
The 4.0 version branches the calculations, then at the end uses readfirstlane
(this is WRONG) and finally performs one sample.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1252 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads.
2017-02-12 15:34 [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads bugzilla-daemon
` (6 preceding siblings ...)
2017-02-12 17:34 ` bugzilla-daemon
@ 2017-02-12 17:54 ` bugzilla-daemon
2017-02-12 23:42 ` bugzilla-daemon
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2017-02-12 17:54 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 333 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #8 from Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> ---
I think this is the issue described in
https://reviews.llvm.org/D26348
Not idea when the fix is going to go through though.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1209 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads.
2017-02-12 15:34 [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads bugzilla-daemon
` (7 preceding siblings ...)
2017-02-12 17:54 ` bugzilla-daemon
@ 2017-02-12 23:42 ` bugzilla-daemon
2017-02-15 15:21 ` bugzilla-daemon
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2017-02-12 23:42 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 525 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #9 from Matias N. Goldberg <dark_sylinc@yahoo.com.ar> ---
Thanks for the referral.
I commented there, and they replied back with a potential fix:
> I believe it is very easy to fix, no need to change LLVM: marking the texture operation as having unknown side-effect should be enough.
Any comments? (perhaps you already know this but the performance hit could be
huge?)
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1388 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads.
2017-02-12 15:34 [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads bugzilla-daemon
` (8 preceding siblings ...)
2017-02-12 23:42 ` bugzilla-daemon
@ 2017-02-15 15:21 ` bugzilla-daemon
2017-02-16 16:24 ` bugzilla-daemon
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2017-02-15 15:21 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 428 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #10 from Matias N. Goldberg <dark_sylinc@yahoo.com.ar> ---
I've built LLVM 5.0 from latest SVN.
I've applied the patch from https://reviews.llvm.org/D26348
The issue still persists. I don't know if anything else was needed (e.g.
changes to radeonsi to make use of the patch?).
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1307 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads.
2017-02-12 15:34 [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads bugzilla-daemon
` (9 preceding siblings ...)
2017-02-15 15:21 ` bugzilla-daemon
@ 2017-02-16 16:24 ` bugzilla-daemon
2017-02-16 18:47 ` bugzilla-daemon
2017-03-15 13:46 ` bugzilla-daemon
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2017-02-16 16:24 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 418 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #11 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Created attachment 129675
--> https://bugs.freedesktop.org/attachment.cgi?id=129675&action=edit
Mesa patch
Yes, you need this patch for Mesa as well.
I'm going to pick up the LLVM patch again as well these days.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1439 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads.
2017-02-12 15:34 [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads bugzilla-daemon
` (10 preceding siblings ...)
2017-02-16 16:24 ` bugzilla-daemon
@ 2017-02-16 18:47 ` bugzilla-daemon
2017-03-15 13:46 ` bugzilla-daemon
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2017-02-16 18:47 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 315 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #12 from Matias N. Goldberg <dark_sylinc@yahoo.com.ar> ---
I can confirm applying the patch you uploaded (plus LLVM's patch of course)
fixes the problem.
Thank you.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1148 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads.
2017-02-12 15:34 [Bug 99780] Flickering artifacts in radeonsi driver with divergent texture reads bugzilla-daemon
` (11 preceding siblings ...)
2017-02-16 18:47 ` bugzilla-daemon
@ 2017-03-15 13:46 ` bugzilla-daemon
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2017-03-15 13:46 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 653 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=99780
Samuel Pitoiset <samuel.pitoiset@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #13 from Samuel Pitoiset <samuel.pitoiset@gmail.com> ---
Just pushed a workaround for this issue in Mesa.
https://cgit.freedesktop.org/mesa/mesa/commit/?id=7751ed39e40e08e5aa0633d018c9f25ad17f9bb0
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2333 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread