From: Sricharan R <sricharan@codeaurora.org> To: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: robh+dt@kernel.org, robh@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, andy.gross@linaro.org, david.brown@linaro.org, catalin.marinas@arm.com, will.deacon@arm.com, sboyd@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, absahu@codeaurora.org, marc.zyngier@arm.com, richardcochran@gmail.com Subject: Re: [PATCH v5 13/13] ARM: dts: ipq8074: Enable few peripherals for hk01 board Date: Mon, 2 Apr 2018 12:06:48 +0530 [thread overview] Message-ID: <c02ed3b7-30e6-29a0-a68d-fcb96ace2841@codeaurora.org> (raw) In-Reply-To: <20180327174913.GP1403@tuxbook-pro> Hi Bjorn, On 3/27/2018 11:19 PM, Bjorn Andersson wrote: > On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote: > >> Reviewed-by: Abhishek Sahu <absahu@codeaurora.org> >> Signed-off-by: Sricharan R <sricharan@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/ipq8074-hk01.dts | 103 ++++++++++++++++++++++++++++++ >> 1 file changed, 103 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts >> index 6a838b5..dbca7ec 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts >> +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts >> @@ -21,6 +21,7 @@ >> >> aliases { >> serial0 = &blsp1_uart5; >> + serial1 = &serial_blsp2; >> }; >> >> chosen { >> @@ -41,6 +42,47 @@ >> bias-disable; >> }; >> }; >> + >> + i2c_0_pins: i2c_0_pinmux { >> + mux { >> + pins = "gpio42", "gpio43"; >> + function = "blsp1_i2c"; >> + drive-strength = <8>; >> + bias-disable; >> + }; >> + }; >> + >> + spi_0_pins: spi_0_pins { >> + mux { >> + pins = "gpio38", "gpio39", "gpio40", "gpio41"; >> + function = "blsp0_spi"; >> + drive-strength = <8>; >> + bias-disable; >> + }; >> + }; >> + >> + hsuart_pins: hsuart_pins { >> + mux { >> + pins = "gpio46", "gpio47", "gpio48", "gpio49"; >> + function = "blsp2_uart"; >> + drive-strength = <8>; >> + bias-disable; >> + }; >> + }; >> + >> + qpic_pins: qpic_pins { >> + mux { >> + pins = "gpio1", "gpio3", "gpio4", >> + "gpio5", "gpio6", "gpio7", >> + "gpio8", "gpio10", "gpio11", >> + "gpio12", "gpio13", "gpio14", >> + "gpio15", "gpio16", "gpio17"; >> + function = "qpic"; > > I would prefer that you move the pinmux part to the same dtsi that > defines the nand and add the board specific pinconf (electrical > properties) here. That way we limit the repetition between the board > files. > sure. will do. >> + drive-strength = <8>; >> + bias-disable; >> + }; >> + }; >> + >> }; >> > > Other than that, > > Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Thanks. Again, thanks for your time and all the reviews. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sricharan@codeaurora.org (Sricharan R) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 13/13] ARM: dts: ipq8074: Enable few peripherals for hk01 board Date: Mon, 2 Apr 2018 12:06:48 +0530 [thread overview] Message-ID: <c02ed3b7-30e6-29a0-a68d-fcb96ace2841@codeaurora.org> (raw) In-Reply-To: <20180327174913.GP1403@tuxbook-pro> Hi Bjorn, On 3/27/2018 11:19 PM, Bjorn Andersson wrote: > On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote: > >> Reviewed-by: Abhishek Sahu <absahu@codeaurora.org> >> Signed-off-by: Sricharan R <sricharan@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/ipq8074-hk01.dts | 103 ++++++++++++++++++++++++++++++ >> 1 file changed, 103 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts >> index 6a838b5..dbca7ec 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts >> +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts >> @@ -21,6 +21,7 @@ >> >> aliases { >> serial0 = &blsp1_uart5; >> + serial1 = &serial_blsp2; >> }; >> >> chosen { >> @@ -41,6 +42,47 @@ >> bias-disable; >> }; >> }; >> + >> + i2c_0_pins: i2c_0_pinmux { >> + mux { >> + pins = "gpio42", "gpio43"; >> + function = "blsp1_i2c"; >> + drive-strength = <8>; >> + bias-disable; >> + }; >> + }; >> + >> + spi_0_pins: spi_0_pins { >> + mux { >> + pins = "gpio38", "gpio39", "gpio40", "gpio41"; >> + function = "blsp0_spi"; >> + drive-strength = <8>; >> + bias-disable; >> + }; >> + }; >> + >> + hsuart_pins: hsuart_pins { >> + mux { >> + pins = "gpio46", "gpio47", "gpio48", "gpio49"; >> + function = "blsp2_uart"; >> + drive-strength = <8>; >> + bias-disable; >> + }; >> + }; >> + >> + qpic_pins: qpic_pins { >> + mux { >> + pins = "gpio1", "gpio3", "gpio4", >> + "gpio5", "gpio6", "gpio7", >> + "gpio8", "gpio10", "gpio11", >> + "gpio12", "gpio13", "gpio14", >> + "gpio15", "gpio16", "gpio17"; >> + function = "qpic"; > > I would prefer that you move the pinmux part to the same dtsi that > defines the nand and add the board specific pinconf (electrical > properties) here. That way we limit the repetition between the board > files. > sure. will do. >> + drive-strength = <8>; >> + bias-disable; >> + }; >> + }; >> + >> }; >> > > Other than that, > > Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Thanks. Again, thanks for your time and all the reviews. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2018-04-02 6:36 UTC|newest] Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-23 10:18 [PATCH v5 00/13] ARM: dts: ipq: updates to enable a few peripherals Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-23 10:18 ` [PATCH v5 01/13] firmware: qcom: scm: Add ipq4019 soc compatible Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-27 16:56 ` Bjorn Andersson 2018-03-27 16:56 ` Bjorn Andersson 2018-03-23 10:18 ` [PATCH v5 02/13] ARM: dts: ipq4019: Add a default chosen node Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-27 16:56 ` Bjorn Andersson 2018-03-27 16:56 ` Bjorn Andersson 2018-03-27 16:56 ` Bjorn Andersson 2018-03-23 10:18 ` [PATCH v5 03/13] ARM: dts: ipq4019: Add a few peripheral nodes Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-27 16:50 ` Bjorn Andersson 2018-03-27 16:50 ` Bjorn Andersson 2018-04-02 5:27 ` Sricharan R 2018-04-02 5:27 ` Sricharan R 2018-03-23 10:18 ` [PATCH v5 04/13] ARM: dts: ipq4019: Change the max opp frequency Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-23 10:18 ` [PATCH v5 05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-27 17:04 ` Bjorn Andersson 2018-03-27 17:04 ` Bjorn Andersson 2018-04-02 5:28 ` Sricharan R 2018-04-02 5:28 ` Sricharan R 2018-04-18 6:59 ` [v5,05/13] " Sven Eckelmann 2018-04-18 6:59 ` Sven Eckelmann 2018-04-18 7:07 ` Sven Eckelmann 2018-04-18 7:07 ` Sven Eckelmann 2018-04-18 7:15 ` Sricharan R 2018-04-18 7:15 ` Sricharan R 2018-04-18 7:38 ` Sven Eckelmann 2018-04-18 7:38 ` Sven Eckelmann 2018-04-18 8:39 ` Sricharan R 2018-04-18 8:39 ` Sricharan R 2018-03-23 10:18 ` [PATCH v5 06/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.1-c1 board file Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-27 17:12 ` Bjorn Andersson 2018-03-27 17:12 ` Bjorn Andersson 2018-04-02 5:34 ` Sricharan R 2018-04-02 5:34 ` Sricharan R 2018-04-02 6:30 ` Varadarajan Narayanan 2018-04-02 6:30 ` Varadarajan Narayanan 2018-03-23 10:18 ` [PATCH v5 07/13] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk04.1-c3 " Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-27 17:14 ` Bjorn Andersson 2018-03-27 17:14 ` Bjorn Andersson 2018-04-02 6:07 ` Sricharan R 2018-04-02 6:07 ` Sricharan R 2018-03-23 10:18 ` [PATCH v5 08/13] ARM: dts: ipq4019: Add ipq4019-ap.dk07.1 common data Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-27 17:20 ` Bjorn Andersson 2018-03-27 17:20 ` Bjorn Andersson 2018-04-02 6:09 ` Sricharan R 2018-04-02 6:09 ` Sricharan R 2018-04-18 6:59 ` [v5,08/13] " Sven Eckelmann 2018-04-18 6:59 ` Sven Eckelmann 2018-04-18 7:12 ` Sricharan R 2018-04-18 7:12 ` Sricharan R 2018-03-23 10:18 ` [PATCH v5 09/13] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk07.1-c1 board file Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-27 17:22 ` Bjorn Andersson 2018-03-27 17:22 ` Bjorn Andersson 2018-04-02 6:10 ` Sricharan R 2018-04-02 6:10 ` Sricharan R 2018-03-23 10:18 ` [PATCH v5 10/13] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk07.1-c2 " Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-27 17:29 ` Bjorn Andersson 2018-03-27 17:29 ` Bjorn Andersson 2018-04-02 6:12 ` Sricharan R 2018-04-02 6:12 ` Sricharan R 2018-03-23 10:18 ` [PATCH v5 11/13] ARM: dts: ipq8074: Add peripheral nodes Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-27 17:45 ` Bjorn Andersson 2018-03-27 17:45 ` Bjorn Andersson 2018-04-02 6:34 ` Sricharan R 2018-04-02 6:34 ` Sricharan R 2018-03-23 10:18 ` [PATCH v5 12/13] ARM: dts: ipq8074: Add pcie nodes Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-27 17:46 ` Bjorn Andersson 2018-03-27 17:46 ` Bjorn Andersson 2018-04-02 6:35 ` Sricharan R 2018-04-02 6:35 ` Sricharan R 2018-03-23 10:18 ` [PATCH v5 13/13] ARM: dts: ipq8074: Enable few peripherals for hk01 board Sricharan R 2018-03-23 10:18 ` Sricharan R 2018-03-27 17:49 ` Bjorn Andersson 2018-03-27 17:49 ` Bjorn Andersson 2018-04-02 6:36 ` Sricharan R [this message] 2018-04-02 6:36 ` Sricharan R 2018-03-24 2:17 ` [PATCH v5 00/13] ARM: dts: ipq: updates to enable a few peripherals Richard Cochran 2018-03-24 2:17 ` Richard Cochran 2018-03-24 2:17 ` Richard Cochran 2018-03-24 6:12 ` sricharan 2018-03-24 6:12 ` sricharan at codeaurora.org 2018-03-24 17:16 ` Richard Cochran 2018-03-24 17:16 ` Richard Cochran
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c02ed3b7-30e6-29a0-a68d-fcb96ace2841@codeaurora.org \ --to=sricharan@codeaurora.org \ --cc=absahu@codeaurora.org \ --cc=andy.gross@linaro.org \ --cc=bjorn.andersson@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=david.brown@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=richardcochran@gmail.com \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ --cc=sboyd@codeaurora.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.