* [PATCH] cpu: microcode: remove redundant check on pointer entry
@ 2019-12-07 15:33 Colin King
2019-12-07 15:39 ` Colin Ian King
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-12-07 15:33 UTC (permalink / raw)
To: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
The check for a null entry is redundant as the while loop
also checks for this. Remove the redundant check. Cleans
up cppcheck style warning:
src/cpu/microcode/microcode.c:203:14: style: Condition 'entry' is
always true [knownConditionTrueFalse]
if (entry &&
src/cpu/microcode/microcode.c:202:32: note: Assuming that condition
'(entry=readdir(dir))!=NULL' is not redundant
while ((entry = readdir(dir)) != NULL) {
src/cpu/microcode/microcode.c:203:14: note: Condition 'entry' is
always true
if (entry &&
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
src/cpu/microcode/microcode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/cpu/microcode/microcode.c b/src/cpu/microcode/microcode.c
index 974fdec9..65abe50a 100644
--- a/src/cpu/microcode/microcode.c
+++ b/src/cpu/microcode/microcode.c
@@ -200,8 +200,7 @@ static int microcode_test1(fwts_framework *fw)
/* Scan and check */
while ((entry = readdir(dir)) != NULL) {
- if (entry &&
- (strlen(entry->d_name) > 3) &&
+ if ((strlen(entry->d_name) > 3) &&
(strncmp(entry->d_name,"cpu", 3) = 0) &&
(isdigit(entry->d_name[3]))) {
char path[PATH_MAX];
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cpu: microcode: remove redundant check on pointer entry
2019-12-07 15:33 [PATCH] cpu: microcode: remove redundant check on pointer entry Colin King
@ 2019-12-07 15:39 ` Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: Colin Ian King @ 2019-12-07 15:39 UTC (permalink / raw)
To: kernel-janitors
Sorry, I didn't mean to cc this to kernel-janitors. please ignore.
On 07/12/2019 15:33, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check for a null entry is redundant as the while loop
> also checks for this. Remove the redundant check. Cleans
> up cppcheck style warning:
>
> src/cpu/microcode/microcode.c:203:14: style: Condition 'entry' is
> always true [knownConditionTrueFalse]
> if (entry &&
>
> src/cpu/microcode/microcode.c:202:32: note: Assuming that condition
> '(entry=readdir(dir))!=NULL' is not redundant
>
> while ((entry = readdir(dir)) != NULL) {
>
> src/cpu/microcode/microcode.c:203:14: note: Condition 'entry' is
> always true
> if (entry &&
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> src/cpu/microcode/microcode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/cpu/microcode/microcode.c b/src/cpu/microcode/microcode.c
> index 974fdec9..65abe50a 100644
> --- a/src/cpu/microcode/microcode.c
> +++ b/src/cpu/microcode/microcode.c
> @@ -200,8 +200,7 @@ static int microcode_test1(fwts_framework *fw)
>
> /* Scan and check */
> while ((entry = readdir(dir)) != NULL) {
> - if (entry &&
> - (strlen(entry->d_name) > 3) &&
> + if ((strlen(entry->d_name) > 3) &&
> (strncmp(entry->d_name,"cpu", 3) = 0) &&
> (isdigit(entry->d_name[3]))) {
> char path[PATH_MAX];
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-07 15:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-07 15:33 [PATCH] cpu: microcode: remove redundant check on pointer entry Colin King
2019-12-07 15:39 ` Colin Ian King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.