From: kajoljain <kjain@linux.ibm.com> To: James Clark <james.clark@arm.com>, acme@kernel.org, john.garry@huawei.com, ak@linux.intel.com, linux-perf-users@vger.kernel.org Cc: Nick.Forrington@arm.com, Andrew.Kilroy@arm.com, Will Deacon <will@kernel.org>, Mathieu Poirier <mathieu.poirier@linaro.org>, Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] perf tools: Enable strict JSON parsing Date: Fri, 8 Oct 2021 13:13:52 +0530 [thread overview] Message-ID: <c15fd2bf-104e-6ab0-6496-7e5cf77a218f@linux.ibm.com> (raw) In-Reply-To: <20211007110543.564963-1-james.clark@arm.com> On 10/7/21 4:35 PM, James Clark wrote: > After a discussion on "[PATCH 1/4] perf vendor events: Syntax corrections in Neoverse N1 json", > John Garry suggested that we can just modify the parser to make it more strict. Hopefully this will > remove the need to apply any future JSON comma fixup commits. > > Applies on top of "[PATCH v2 1/3] perf vendor events: Syntax corrections in Neoverse N1 json" on > perf/core. > > Also available at: > git clone --branch james-json-parse-fix git@git.gitlab.arm.com:linux-arm/linux-jc.git Hi James, Do we have any dependency patches on top of this patch series. I am reviewing and testing it, but in both powerpc and x86 system I am getting build issue. Not sure if I am missing something. I am trying your changes on top of upstream perf. pmu-events/arch/test/test_soc/sys/uncore.json: json error Invalid character inside JSON string make[3]: *** [pmu-events/Build:18: pmu-events/pmu-events.c] Error 1 make[3]: *** Deleting file 'pmu-events/pmu-events.c' make[2]: *** [Makefile.perf:667: pmu-events/pmu-events-in.o] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Makefile.perf:238: sub-make] Error 2 make: *** [Makefile:70: all] Error 2 Also, Is it possible to add line number along with file name while showing this error `json error Invalid character inside JSON string`. It might make it easy to fix. Thanks, Kajol Jain > > James Clark (3): > perf vendor-events: Fix all remaining invalid JSON files > perf tools: Make the JSON parser more conformant when in strict mode > perf tools: Enable strict JSON parsing > > .../arch/arm64/ampere/emag/bus.json | 2 +- > .../arch/arm64/ampere/emag/cache.json | 20 ++++----- > .../arch/arm64/ampere/emag/clock.json | 2 +- > .../arch/arm64/ampere/emag/exception.json | 4 +- > .../arch/arm64/ampere/emag/instruction.json | 10 ++--- > .../arch/arm64/ampere/emag/memory.json | 4 +- > .../arch/arm64/hisilicon/hip08/metrics.json | 2 +- > .../pmu-events/arch/nds32/n13/atcpmu.json | 2 +- > .../pmu-events/arch/s390/cf_z10/basic.json | 2 +- > .../pmu-events/arch/s390/cf_z10/crypto.json | 2 +- > .../pmu-events/arch/s390/cf_z10/extended.json | 2 +- > .../pmu-events/arch/s390/cf_z13/basic.json | 2 +- > .../pmu-events/arch/s390/cf_z13/crypto.json | 2 +- > .../pmu-events/arch/s390/cf_z13/extended.json | 2 +- > .../pmu-events/arch/s390/cf_z14/basic.json | 2 +- > .../pmu-events/arch/s390/cf_z14/crypto.json | 2 +- > .../pmu-events/arch/s390/cf_z14/extended.json | 2 +- > .../pmu-events/arch/s390/cf_z15/basic.json | 2 +- > .../pmu-events/arch/s390/cf_z15/crypto.json | 2 +- > .../pmu-events/arch/s390/cf_z15/crypto6.json | 2 +- > .../pmu-events/arch/s390/cf_z15/extended.json | 2 +- > .../pmu-events/arch/s390/cf_z196/basic.json | 2 +- > .../pmu-events/arch/s390/cf_z196/crypto.json | 2 +- > .../arch/s390/cf_z196/extended.json | 2 +- > .../pmu-events/arch/s390/cf_zec12/basic.json | 2 +- > .../pmu-events/arch/s390/cf_zec12/crypto.json | 2 +- > .../arch/s390/cf_zec12/extended.json | 2 +- > .../arch/test/test_soc/cpu/uncore.json | 2 +- > .../arch/x86/icelakex/icx-metrics.json | 2 +- > tools/perf/pmu-events/jsmn.c | 43 ++++++++++++++++++- > 30 files changed, 85 insertions(+), 46 deletions(-) >
WARNING: multiple messages have this Message-ID (diff)
From: kajoljain <kjain@linux.ibm.com> To: James Clark <james.clark@arm.com>, acme@kernel.org, john.garry@huawei.com, ak@linux.intel.com, linux-perf-users@vger.kernel.org Cc: Nick.Forrington@arm.com, Andrew.Kilroy@arm.com, Will Deacon <will@kernel.org>, Mathieu Poirier <mathieu.poirier@linaro.org>, Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] perf tools: Enable strict JSON parsing Date: Fri, 8 Oct 2021 13:13:52 +0530 [thread overview] Message-ID: <c15fd2bf-104e-6ab0-6496-7e5cf77a218f@linux.ibm.com> (raw) In-Reply-To: <20211007110543.564963-1-james.clark@arm.com> On 10/7/21 4:35 PM, James Clark wrote: > After a discussion on "[PATCH 1/4] perf vendor events: Syntax corrections in Neoverse N1 json", > John Garry suggested that we can just modify the parser to make it more strict. Hopefully this will > remove the need to apply any future JSON comma fixup commits. > > Applies on top of "[PATCH v2 1/3] perf vendor events: Syntax corrections in Neoverse N1 json" on > perf/core. > > Also available at: > git clone --branch james-json-parse-fix git@git.gitlab.arm.com:linux-arm/linux-jc.git Hi James, Do we have any dependency patches on top of this patch series. I am reviewing and testing it, but in both powerpc and x86 system I am getting build issue. Not sure if I am missing something. I am trying your changes on top of upstream perf. pmu-events/arch/test/test_soc/sys/uncore.json: json error Invalid character inside JSON string make[3]: *** [pmu-events/Build:18: pmu-events/pmu-events.c] Error 1 make[3]: *** Deleting file 'pmu-events/pmu-events.c' make[2]: *** [Makefile.perf:667: pmu-events/pmu-events-in.o] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Makefile.perf:238: sub-make] Error 2 make: *** [Makefile:70: all] Error 2 Also, Is it possible to add line number along with file name while showing this error `json error Invalid character inside JSON string`. It might make it easy to fix. Thanks, Kajol Jain > > James Clark (3): > perf vendor-events: Fix all remaining invalid JSON files > perf tools: Make the JSON parser more conformant when in strict mode > perf tools: Enable strict JSON parsing > > .../arch/arm64/ampere/emag/bus.json | 2 +- > .../arch/arm64/ampere/emag/cache.json | 20 ++++----- > .../arch/arm64/ampere/emag/clock.json | 2 +- > .../arch/arm64/ampere/emag/exception.json | 4 +- > .../arch/arm64/ampere/emag/instruction.json | 10 ++--- > .../arch/arm64/ampere/emag/memory.json | 4 +- > .../arch/arm64/hisilicon/hip08/metrics.json | 2 +- > .../pmu-events/arch/nds32/n13/atcpmu.json | 2 +- > .../pmu-events/arch/s390/cf_z10/basic.json | 2 +- > .../pmu-events/arch/s390/cf_z10/crypto.json | 2 +- > .../pmu-events/arch/s390/cf_z10/extended.json | 2 +- > .../pmu-events/arch/s390/cf_z13/basic.json | 2 +- > .../pmu-events/arch/s390/cf_z13/crypto.json | 2 +- > .../pmu-events/arch/s390/cf_z13/extended.json | 2 +- > .../pmu-events/arch/s390/cf_z14/basic.json | 2 +- > .../pmu-events/arch/s390/cf_z14/crypto.json | 2 +- > .../pmu-events/arch/s390/cf_z14/extended.json | 2 +- > .../pmu-events/arch/s390/cf_z15/basic.json | 2 +- > .../pmu-events/arch/s390/cf_z15/crypto.json | 2 +- > .../pmu-events/arch/s390/cf_z15/crypto6.json | 2 +- > .../pmu-events/arch/s390/cf_z15/extended.json | 2 +- > .../pmu-events/arch/s390/cf_z196/basic.json | 2 +- > .../pmu-events/arch/s390/cf_z196/crypto.json | 2 +- > .../arch/s390/cf_z196/extended.json | 2 +- > .../pmu-events/arch/s390/cf_zec12/basic.json | 2 +- > .../pmu-events/arch/s390/cf_zec12/crypto.json | 2 +- > .../arch/s390/cf_zec12/extended.json | 2 +- > .../arch/test/test_soc/cpu/uncore.json | 2 +- > .../arch/x86/icelakex/icx-metrics.json | 2 +- > tools/perf/pmu-events/jsmn.c | 43 ++++++++++++++++++- > 30 files changed, 85 insertions(+), 46 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-08 7:44 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-07 11:05 [PATCH 0/3] perf tools: Enable strict JSON parsing James Clark 2021-10-07 11:05 ` James Clark 2021-10-07 11:05 ` [PATCH 1/3] perf vendor-events: Fix all remaining invalid JSON files James Clark 2021-10-07 11:05 ` James Clark 2021-10-07 17:22 ` John Garry 2021-10-07 17:22 ` John Garry 2021-10-07 11:05 ` [PATCH 2/3] perf tools: Make the JSON parser more conformant when in strict mode James Clark 2021-10-07 11:05 ` James Clark 2021-10-07 17:52 ` Jiri Olsa 2021-10-07 17:52 ` Jiri Olsa 2021-10-08 10:08 ` James Clark 2021-10-08 10:08 ` James Clark 2021-10-08 13:12 ` Jiri Olsa 2021-10-08 13:12 ` Jiri Olsa 2021-10-08 18:56 ` Arnaldo Carvalho de Melo 2021-10-08 18:56 ` Arnaldo Carvalho de Melo 2021-10-08 19:01 ` Arnaldo Carvalho de Melo 2021-10-08 19:01 ` Arnaldo Carvalho de Melo 2021-10-07 11:05 ` [PATCH 3/3] perf tools: Enable strict JSON parsing James Clark 2021-10-07 11:05 ` James Clark 2021-10-07 23:51 ` [PATCH 0/3] " Andi Kleen 2021-10-07 23:51 ` Andi Kleen 2021-10-08 7:43 ` kajoljain [this message] 2021-10-08 7:43 ` kajoljain 2021-10-08 10:02 ` James Clark 2021-10-08 10:02 ` James Clark 2021-10-08 11:26 ` kajoljain 2021-10-08 11:26 ` kajoljain 2021-10-08 19:00 ` Arnaldo Carvalho de Melo 2021-10-08 19:00 ` Arnaldo Carvalho de Melo 2021-10-12 13:30 ` James Clark 2021-10-12 13:30 ` James Clark 2021-10-12 20:15 ` Arnaldo Carvalho de Melo 2021-10-12 20:15 ` Arnaldo Carvalho de Melo 2021-10-13 16:57 ` Arnaldo Carvalho de Melo 2021-10-13 16:57 ` Arnaldo Carvalho de Melo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c15fd2bf-104e-6ab0-6496-7e5cf77a218f@linux.ibm.com \ --to=kjain@linux.ibm.com \ --cc=Andrew.Kilroy@arm.com \ --cc=Nick.Forrington@arm.com \ --cc=acme@kernel.org \ --cc=ak@linux.intel.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=james.clark@arm.com \ --cc=john.garry@huawei.com \ --cc=jolsa@redhat.com \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=namhyung@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.