All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: James Clark <james.clark@arm.com>, <acme@kernel.org>,
	<ak@linux.intel.com>, <linux-perf-users@vger.kernel.org>
Cc: <Nick.Forrington@arm.com>, <Andrew.Kilroy@arm.com>,
	Will Deacon <will@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	"Namhyung Kim" <namhyung@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] perf vendor-events: Fix all remaining invalid JSON files
Date: Thu, 7 Oct 2021 18:22:06 +0100	[thread overview]
Message-ID: <c73a8d30-a2ed-fec7-1537-c0ec79c1ad6f@huawei.com> (raw)
In-Reply-To: <20211007110543.564963-2-james.clark@arm.com>

On 07/10/2021 12:05, James Clark wrote:
> Remove trailing commas. A later commit will make the parser more strict
> and these will not be valid anymore.
> 
> Signed-off-by: James Clark<james.clark@arm.com>
> ---
>   .../arch/arm64/ampere/emag/bus.json           |  2 +-
>   .../arch/arm64/ampere/emag/cache.json         | 20 +++++++++----------
>   .../arch/arm64/ampere/emag/clock.json         |  2 +-
>   .../arch/arm64/ampere/emag/exception.json     |  4 ++--
>   .../arch/arm64/ampere/emag/instruction.json   | 10 +++++-----
>   .../arch/arm64/ampere/emag/memory.json        |  4 ++--
>   .../arch/arm64/hisilicon/hip08/metrics.json   |  2 +-
>   .../pmu-events/arch/nds32/n13/atcpmu.json     |  2 +-
>   .../pmu-events/arch/s390/cf_z10/basic.json    |  2 +-
>   .../pmu-events/arch/s390/cf_z10/crypto.json   |  2 +-
>   .../pmu-events/arch/s390/cf_z10/extended.json |  2 +-
>   .../pmu-events/arch/s390/cf_z13/basic.json    |  2 +-
>   .../pmu-events/arch/s390/cf_z13/crypto.json   |  2 +-
>   .../pmu-events/arch/s390/cf_z13/extended.json |  2 +-
>   .../pmu-events/arch/s390/cf_z14/basic.json    |  2 +-
>   .../pmu-events/arch/s390/cf_z14/crypto.json   |  2 +-
>   .../pmu-events/arch/s390/cf_z14/extended.json |  2 +-
>   .../pmu-events/arch/s390/cf_z15/basic.json    |  2 +-
>   .../pmu-events/arch/s390/cf_z15/crypto.json   |  2 +-
>   .../pmu-events/arch/s390/cf_z15/crypto6.json  |  2 +-
>   .../pmu-events/arch/s390/cf_z15/extended.json |  2 +-
>   .../pmu-events/arch/s390/cf_z196/basic.json   |  2 +-
>   .../pmu-events/arch/s390/cf_z196/crypto.json  |  2 +-
>   .../arch/s390/cf_z196/extended.json           |  2 +-
>   .../pmu-events/arch/s390/cf_zec12/basic.json  |  2 +-
>   .../pmu-events/arch/s390/cf_zec12/crypto.json |  2 +-
>   .../arch/s390/cf_zec12/extended.json          |  2 +-
>   .../arch/test/test_soc/cpu/uncore.json        |  2 +-
>   .../arch/x86/icelakex/icx-metrics.json        |  2 +-


This seems fine. But, as mentioned earlier, I do worry that some of 
these JSONs are copied from some downstream repositories, and now they 
will go out of sync. That could cause problems, so need to check with 
respective owners.

Apart from that caveat, it seems ok:

Reviewed-by: John Garry <john.garry@huawei.com>



WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: James Clark <james.clark@arm.com>, <acme@kernel.org>,
	<ak@linux.intel.com>, <linux-perf-users@vger.kernel.org>
Cc: <Nick.Forrington@arm.com>, <Andrew.Kilroy@arm.com>,
	Will Deacon <will@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	"Namhyung Kim" <namhyung@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] perf vendor-events: Fix all remaining invalid JSON files
Date: Thu, 7 Oct 2021 18:22:06 +0100	[thread overview]
Message-ID: <c73a8d30-a2ed-fec7-1537-c0ec79c1ad6f@huawei.com> (raw)
In-Reply-To: <20211007110543.564963-2-james.clark@arm.com>

On 07/10/2021 12:05, James Clark wrote:
> Remove trailing commas. A later commit will make the parser more strict
> and these will not be valid anymore.
> 
> Signed-off-by: James Clark<james.clark@arm.com>
> ---
>   .../arch/arm64/ampere/emag/bus.json           |  2 +-
>   .../arch/arm64/ampere/emag/cache.json         | 20 +++++++++----------
>   .../arch/arm64/ampere/emag/clock.json         |  2 +-
>   .../arch/arm64/ampere/emag/exception.json     |  4 ++--
>   .../arch/arm64/ampere/emag/instruction.json   | 10 +++++-----
>   .../arch/arm64/ampere/emag/memory.json        |  4 ++--
>   .../arch/arm64/hisilicon/hip08/metrics.json   |  2 +-
>   .../pmu-events/arch/nds32/n13/atcpmu.json     |  2 +-
>   .../pmu-events/arch/s390/cf_z10/basic.json    |  2 +-
>   .../pmu-events/arch/s390/cf_z10/crypto.json   |  2 +-
>   .../pmu-events/arch/s390/cf_z10/extended.json |  2 +-
>   .../pmu-events/arch/s390/cf_z13/basic.json    |  2 +-
>   .../pmu-events/arch/s390/cf_z13/crypto.json   |  2 +-
>   .../pmu-events/arch/s390/cf_z13/extended.json |  2 +-
>   .../pmu-events/arch/s390/cf_z14/basic.json    |  2 +-
>   .../pmu-events/arch/s390/cf_z14/crypto.json   |  2 +-
>   .../pmu-events/arch/s390/cf_z14/extended.json |  2 +-
>   .../pmu-events/arch/s390/cf_z15/basic.json    |  2 +-
>   .../pmu-events/arch/s390/cf_z15/crypto.json   |  2 +-
>   .../pmu-events/arch/s390/cf_z15/crypto6.json  |  2 +-
>   .../pmu-events/arch/s390/cf_z15/extended.json |  2 +-
>   .../pmu-events/arch/s390/cf_z196/basic.json   |  2 +-
>   .../pmu-events/arch/s390/cf_z196/crypto.json  |  2 +-
>   .../arch/s390/cf_z196/extended.json           |  2 +-
>   .../pmu-events/arch/s390/cf_zec12/basic.json  |  2 +-
>   .../pmu-events/arch/s390/cf_zec12/crypto.json |  2 +-
>   .../arch/s390/cf_zec12/extended.json          |  2 +-
>   .../arch/test/test_soc/cpu/uncore.json        |  2 +-
>   .../arch/x86/icelakex/icx-metrics.json        |  2 +-


This seems fine. But, as mentioned earlier, I do worry that some of 
these JSONs are copied from some downstream repositories, and now they 
will go out of sync. That could cause problems, so need to check with 
respective owners.

Apart from that caveat, it seems ok:

Reviewed-by: John Garry <john.garry@huawei.com>



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-07 17:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 11:05 [PATCH 0/3] perf tools: Enable strict JSON parsing James Clark
2021-10-07 11:05 ` James Clark
2021-10-07 11:05 ` [PATCH 1/3] perf vendor-events: Fix all remaining invalid JSON files James Clark
2021-10-07 11:05   ` James Clark
2021-10-07 17:22   ` John Garry [this message]
2021-10-07 17:22     ` John Garry
2021-10-07 11:05 ` [PATCH 2/3] perf tools: Make the JSON parser more conformant when in strict mode James Clark
2021-10-07 11:05   ` James Clark
2021-10-07 17:52   ` Jiri Olsa
2021-10-07 17:52     ` Jiri Olsa
2021-10-08 10:08     ` James Clark
2021-10-08 10:08       ` James Clark
2021-10-08 13:12       ` Jiri Olsa
2021-10-08 13:12         ` Jiri Olsa
2021-10-08 18:56         ` Arnaldo Carvalho de Melo
2021-10-08 18:56           ` Arnaldo Carvalho de Melo
2021-10-08 19:01           ` Arnaldo Carvalho de Melo
2021-10-08 19:01             ` Arnaldo Carvalho de Melo
2021-10-07 11:05 ` [PATCH 3/3] perf tools: Enable strict JSON parsing James Clark
2021-10-07 11:05   ` James Clark
2021-10-07 23:51 ` [PATCH 0/3] " Andi Kleen
2021-10-07 23:51   ` Andi Kleen
2021-10-08  7:43 ` kajoljain
2021-10-08  7:43   ` kajoljain
2021-10-08 10:02   ` James Clark
2021-10-08 10:02     ` James Clark
2021-10-08 11:26     ` kajoljain
2021-10-08 11:26       ` kajoljain
2021-10-08 19:00       ` Arnaldo Carvalho de Melo
2021-10-08 19:00         ` Arnaldo Carvalho de Melo
2021-10-12 13:30         ` James Clark
2021-10-12 13:30           ` James Clark
2021-10-12 20:15           ` Arnaldo Carvalho de Melo
2021-10-12 20:15             ` Arnaldo Carvalho de Melo
2021-10-13 16:57           ` Arnaldo Carvalho de Melo
2021-10-13 16:57             ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c73a8d30-a2ed-fec7-1537-c0ec79c1ad6f@huawei.com \
    --to=john.garry@huawei.com \
    --cc=Andrew.Kilroy@arm.com \
    --cc=Nick.Forrington@arm.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=namhyung@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.