[GIT PULL] fbdev fixes for 4.9

[GIT PULL] fbdev fixes for 4.9

[Tomi Valkeinen]

[-- Attachment #1.1: Type: text/plain, Size: 1029 bytes --]

Hi Linus,

Please pull two fbdev fixes for 4.9.

 Tomi

The following changes since commit a909d3e636995ba7c349e2ca5dbb528154d4ac30:

  Linux 4.9-rc3 (2016-10-29 13:52:02 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git tags/fbdev-fixes-4.9

for you to fetch changes up to 1746aff3dba0f7530688e405e7802eeca928665f:

  Fix loading of module radeonfb on PowerMac (2016-11-14 13:27:54 +0200)

----------------------------------------------------------------
fbdev fixes for 4.9

* Fix CLCD regression on Vexpress
* Fix loading of radeonfb on PowerMac

----------------------------------------------------------------
Linus Walleij (1):
      video: ARM CLCD: fix Vexpress regression

Mathieu Malaterre (1):
      Fix loading of module radeonfb on PowerMac

 drivers/video/fbdev/amba-clcd-versatile.c |  4 ++--
 drivers/video/fbdev/aty/radeon_base.c     | 22 ++++++++++++++++++++--
 2 files changed, 22 insertions(+), 4 deletions(-)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[GIT PULL] fbdev fixes for 4.9

[Tomi Valkeinen]

[-- Attachment #1.1: Type: text/plain, Size: 1029 bytes --]

Hi Linus,

Please pull two fbdev fixes for 4.9.

 Tomi

The following changes since commit a909d3e636995ba7c349e2ca5dbb528154d4ac30:

  Linux 4.9-rc3 (2016-10-29 13:52:02 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git tags/fbdev-fixes-4.9

for you to fetch changes up to 1746aff3dba0f7530688e405e7802eeca928665f:

  Fix loading of module radeonfb on PowerMac (2016-11-14 13:27:54 +0200)

----------------------------------------------------------------
fbdev fixes for 4.9

* Fix CLCD regression on Vexpress
* Fix loading of radeonfb on PowerMac

----------------------------------------------------------------
Linus Walleij (1):
      video: ARM CLCD: fix Vexpress regression

Mathieu Malaterre (1):
      Fix loading of module radeonfb on PowerMac

 drivers/video/fbdev/amba-clcd-versatile.c |  4 ++--
 drivers/video/fbdev/aty/radeon_base.c     | 22 ++++++++++++++++++++--
 2 files changed, 22 insertions(+), 4 deletions(-)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [GIT PULL] fbdev fixes for 4.9

[Linus Torvalds]

On Mon, Nov 14, 2016 at 3:44 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>
> Please pull two fbdev fixes for 4.9.

No.

This has obviously never even been test-compiled. It introduces two
new annoying warnings.

                 Linus

Re: [GIT PULL] fbdev fixes for 4.9

[Linus Torvalds]

On Mon, Nov 14, 2016 at 3:44 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>
> Please pull two fbdev fixes for 4.9.

No.

This has obviously never even been test-compiled. It introduces two
new annoying warnings.

                 Linus

Re: [GIT PULL] fbdev fixes for 4.9

[Mathieu Malaterre]

Tomi,

On Mon, Nov 14, 2016 at 5:25 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Mon, Nov 14, 2016 at 3:44 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>>
>> Please pull two fbdev fixes for 4.9.
>
> No.
>
> This has obviously never even been test-compiled. It introduces two
> new annoying warnings.

Sorry about that noob error. I've just send a v2 a minute ago.

Thanks

Re: [GIT PULL] fbdev fixes for 4.9

[Tomi Valkeinen]

[-- Attachment #1.1: Type: text/plain, Size: 1480 bytes --]

On 14/11/16 18:25, Linus Torvalds wrote:
> On Mon, Nov 14, 2016 at 3:44 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>>
>> Please pull two fbdev fixes for 4.9.
> 
> No.
> 
> This has obviously never even been test-compiled. It introduces two
> new annoying warnings.

Sorry about that. I dropped the patch for now and here's a new pull request.

I did test compile, and I would have noticed errors but I missed the warnings
(I blame the flu...). I need to improve my testing methods, but I couldn't find
a way to add -Werror to kernel builds. I guess I should just always capture the
warnings and errors to a file, and check that after the build.

How do you test build?

 Tomi

The following changes since commit a909d3e636995ba7c349e2ca5dbb528154d4ac30:

  Linux 4.9-rc3 (2016-10-29 13:52:02 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git tags/fbdev-fixes-4.9

for you to fetch changes up to cfbd950d5e6e649c6c1a88925feada64f890c894:

  video: ARM CLCD: fix Vexpress regression (2016-11-03 12:20:14 +0200)

----------------------------------------------------------------
fbdev fixes for 4.9

* Fix CLCD regression on Vexpress

----------------------------------------------------------------
Linus Walleij (1):
      video: ARM CLCD: fix Vexpress regression

 drivers/video/fbdev/amba-clcd-versatile.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [GIT PULL] fbdev fixes for 4.9

[Tomi Valkeinen]

[-- Attachment #1.1: Type: text/plain, Size: 1480 bytes --]

On 14/11/16 18:25, Linus Torvalds wrote:
> On Mon, Nov 14, 2016 at 3:44 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>>
>> Please pull two fbdev fixes for 4.9.
> 
> No.
> 
> This has obviously never even been test-compiled. It introduces two
> new annoying warnings.

Sorry about that. I dropped the patch for now and here's a new pull request.

I did test compile, and I would have noticed errors but I missed the warnings
(I blame the flu...). I need to improve my testing methods, but I couldn't find
a way to add -Werror to kernel builds. I guess I should just always capture the
warnings and errors to a file, and check that after the build.

How do you test build?

 Tomi

The following changes since commit a909d3e636995ba7c349e2ca5dbb528154d4ac30:

  Linux 4.9-rc3 (2016-10-29 13:52:02 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git tags/fbdev-fixes-4.9

for you to fetch changes up to cfbd950d5e6e649c6c1a88925feada64f890c894:

  video: ARM CLCD: fix Vexpress regression (2016-11-03 12:20:14 +0200)

----------------------------------------------------------------
fbdev fixes for 4.9

* Fix CLCD regression on Vexpress

----------------------------------------------------------------
Linus Walleij (1):
      video: ARM CLCD: fix Vexpress regression

 drivers/video/fbdev/amba-clcd-versatile.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [GIT PULL] fbdev fixes for 4.9

[Linus Torvalds]

On Tue, Nov 15, 2016 at 3:40 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>
> I did test compile, and I would have noticed errors but I missed the warnings
> (I blame the flu...). I need to improve my testing methods, but I couldn't find
> a way to add -Werror to kernel builds. I guess I should just always capture the
> warnings and errors to a file, and check that after the build.
>
> How do you test build?

I basically do just an allmodconfig build, but I do it with

    make -j16 > ../make-output

so that any warnings are very obvious (because stdout goes elsewhere).

              Linus

Re: [GIT PULL] fbdev fixes for 4.9

[Linus Torvalds]

On Tue, Nov 15, 2016 at 3:40 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>
> I did test compile, and I would have noticed errors but I missed the warnings
> (I blame the flu...). I need to improve my testing methods, but I couldn't find
> a way to add -Werror to kernel builds. I guess I should just always capture the
> warnings and errors to a file, and check that after the build.
>
> How do you test build?

I basically do just an allmodconfig build, but I do it with

    make -j16 > ../make-output

so that any warnings are very obvious (because stdout goes elsewhere).

              Linus

Re: [GIT PULL] fbdev fixes for 4.9

[Michael Ellerman]

Tomi Valkeinen <tomi.valkeinen@ti.com> writes:

> [ Unknown signature status ]
> On 14/11/16 18:25, Linus Torvalds wrote:
>> On Mon, Nov 14, 2016 at 3:44 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>>>
>>> Please pull two fbdev fixes for 4.9.
>> 
>> No.
>> 
>> This has obviously never even been test-compiled. It introduces two
>> new annoying warnings.
>
> Sorry about that. I dropped the patch for now and here's a new pull request.
>
> I did test compile, and I would have noticed errors but I missed the warnings
> (I blame the flu...). I need to improve my testing methods, but I couldn't find
> a way to add -Werror to kernel builds.

You can turn it on per-directory, eg:

diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile
index ee8c81405a7f..2ee96810d26d 100644
--- a/drivers/video/fbdev/Makefile
+++ b/drivers/video/fbdev/Makefile
@@ -4,6 +4,8 @@
 
 # Each configuration option enables a list of files.
 
+subdir-ccflags-y := -Werror
+
 obj-y				+= core/
 
 obj-$(CONFIG_FB_MACMODES)      += macmodes.o


cheers

Re: [GIT PULL] fbdev fixes for 4.9

[Michael Ellerman]

Tomi Valkeinen <tomi.valkeinen@ti.com> writes:

> [ Unknown signature status ]
> On 14/11/16 18:25, Linus Torvalds wrote:
>> On Mon, Nov 14, 2016 at 3:44 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>>>
>>> Please pull two fbdev fixes for 4.9.
>> 
>> No.
>> 
>> This has obviously never even been test-compiled. It introduces two
>> new annoying warnings.
>
> Sorry about that. I dropped the patch for now and here's a new pull request.
>
> I did test compile, and I would have noticed errors but I missed the warnings
> (I blame the flu...). I need to improve my testing methods, but I couldn't find
> a way to add -Werror to kernel builds.

You can turn it on per-directory, eg:

diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile
index ee8c81405a7f..2ee96810d26d 100644
--- a/drivers/video/fbdev/Makefile
+++ b/drivers/video/fbdev/Makefile
@@ -4,6 +4,8 @@
 
 # Each configuration option enables a list of files.
 
+subdir-ccflags-y := -Werror
+
 obj-y				+= core/
 
 obj-$(CONFIG_FB_MACMODES)      += macmodes.o


cheers