All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Mikko Perttunen <mperttunen@nvidia.com>,
	Sumit Gupta <sumitg@nvidia.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Hulk Robot <hulkci@huawei.com>,
	"linux-kernel@vger.kernel.org List"
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <hch@infradead.org>,
	"Anshuman Khandual" <anshuman.khandual@arm.com>
Subject: Re: [PATCH -next] arm64: Export __cpu_logical_map
Date: Sat, 25 Jul 2020 10:00:35 +0800	[thread overview]
Message-ID: <c24b88be-e711-66d8-796a-8964af1762de@huawei.com> (raw)
In-Reply-To: <20200724131059.GB6521@bogus>


On 2020/7/24 21:10, Sudeep Holla wrote:
> On Fri, Jul 24, 2020 at 11:08:03AM +0800, Kefeng Wang wrote:
>> +maillist
>>
>> On 2020/7/24 11:04, Kefeng Wang wrote:
>>> ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined!
>>>
>>> ARM64 tegra194-cpufreq driver use cpu_logical_map, export
>>> __cpu_logical_map to fix build issue.
>>>
> I wonder why like other instances in the drivers, the mpidr is not get
> directly from the cpu. The cpufreq_driver->init call happens when the cpu
> is being brought online and is executed on the required cpu IIUC.
>
> read_cpuid_mpidr() is inline and avoids having to export the logical_cpu_map.
> Though we may not add physical hotplug anytime soon, less dependency
> on this cpu_logical_map is better given that we can resolve this without
> the need to access the map.

Hi all,  thanks for all comments.

As Sudeep said, I will using read_cpuid_mpidr() directly in 
tegra194-cpufreq to

fix the build issue,  and later we also would turn cpu_logical_map() 
into a C wrapper.

If that's ok, I will send a new build-fix patch firstly, thanks.


>


WARNING: multiple messages have this Message-ID
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	"linux-kernel@vger.kernel.org List"
	<linux-kernel@vger.kernel.org>,
	Mikko Perttunen <mperttunen@nvidia.com>,
	hch@infradead.org, Hulk Robot <hulkci@huawei.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Sumit Gupta <sumitg@nvidia.com>, Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] arm64: Export __cpu_logical_map
Date: Sat, 25 Jul 2020 10:00:35 +0800	[thread overview]
Message-ID: <c24b88be-e711-66d8-796a-8964af1762de@huawei.com> (raw)
In-Reply-To: <20200724131059.GB6521@bogus>


On 2020/7/24 21:10, Sudeep Holla wrote:
> On Fri, Jul 24, 2020 at 11:08:03AM +0800, Kefeng Wang wrote:
>> +maillist
>>
>> On 2020/7/24 11:04, Kefeng Wang wrote:
>>> ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined!
>>>
>>> ARM64 tegra194-cpufreq driver use cpu_logical_map, export
>>> __cpu_logical_map to fix build issue.
>>>
> I wonder why like other instances in the drivers, the mpidr is not get
> directly from the cpu. The cpufreq_driver->init call happens when the cpu
> is being brought online and is executed on the required cpu IIUC.
>
> read_cpuid_mpidr() is inline and avoids having to export the logical_cpu_map.
> Though we may not add physical hotplug anytime soon, less dependency
> on this cpu_logical_map is better given that we can resolve this without
> the need to access the map.

Hi all,  thanks for all comments.

As Sudeep said, I will using read_cpuid_mpidr() directly in 
tegra194-cpufreq to

fix the build issue,  and later we also would turn cpu_logical_map() 
into a C wrapper.

If that's ok, I will send a new build-fix patch firstly, thanks.


>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-07-25  2:01 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200724030433.22287-1-wangkefeng.wang@huawei.com>
2020-07-24  3:08 ` Kefeng Wang
2020-07-24  3:08   ` Kefeng Wang
2020-07-24  8:16   ` Anshuman Khandual
2020-07-24  8:16     ` Anshuman Khandual
2020-07-24  9:13     ` Mark Rutland
2020-07-24  9:13       ` Mark Rutland
2020-07-24  9:35       ` Catalin Marinas
2020-07-24  9:35         ` Catalin Marinas
2020-07-24 10:33         ` Anshuman Khandual
2020-07-24 10:33           ` Anshuman Khandual
2020-07-24  9:16     ` Kefeng Wang
2020-07-24  9:16       ` Kefeng Wang
2020-07-24  9:30     ` Catalin Marinas
2020-07-24  9:30       ` Catalin Marinas
2020-07-24 10:36       ` Anshuman Khandual
2020-07-24 10:36         ` Anshuman Khandual
2020-07-24  9:43   ` Christoph Hellwig
2020-07-24  9:43     ` Christoph Hellwig
2020-07-24 13:10   ` Sudeep Holla
2020-07-24 13:10     ` Sudeep Holla
2020-07-25  2:00     ` Kefeng Wang [this message]
2020-07-25  2:00       ` Kefeng Wang
2020-07-26 11:46     ` Sumit Gupta
2020-07-26 11:46       ` Sumit Gupta
2020-07-27 16:05       ` Sudeep Holla
2020-07-27 16:05         ` Sudeep Holla
2020-08-01 12:16         ` Sumit Gupta
2020-08-01 12:16           ` Sumit Gupta
2020-08-10  7:49           ` Sudeep Holla
2020-08-10  7:49             ` Sudeep Holla
2020-08-10 10:19             ` Catalin Marinas
2020-08-10 10:19               ` Catalin Marinas
2020-08-10 12:11               ` Sudeep Holla
2020-08-10 12:11                 ` Sudeep Holla
2020-08-11 19:44               ` Sumit Gupta
2020-08-11 19:44                 ` Sumit Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c24b88be-e711-66d8-796a-8964af1762de@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=hch@infradead.org \
    --cc=hulkci@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mperttunen@nvidia.com \
    --cc=sudeep.holla@arm.com \
    --cc=sumitg@nvidia.com \
    --cc=viresh.kumar@linaro.org \
    --cc=will@kernel.org \
    --subject='Re: [PATCH -next] arm64: Export __cpu_logical_map' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.