[PATCH] arch: arm: uDPU: fix PHY mode definition to sgmii-2500

[PATCH] arch: arm: uDPU: fix PHY mode definition to sgmii-2500

[Jakov Petrina]

Commit f49ac7e1c4 switched the default PHY speed to 3.125Gbit to resolve
issues with SFP modules. However, U-Boot does not have a "2500base-x"
phy-mode.

Resolve this by using "sgmii-2500" instead.

Signed-off-by: Jakov Petrina <jakov.petrina@sartura.hr>
Signed-off-by: Vladimir Vid <vladimir.vid@sartura.hr>
Cc: Luka Perkov <luka.perkov@sartura.hr>
Cc: Stefan Roese <sr@denx.de>
---
 arch/arm/dts/armada-3720-uDPU.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/armada-3720-uDPU.dts b/arch/arm/dts/armada-3720-uDPU.dts
index 07c7b91175..7f4b8222f4 100644
--- a/arch/arm/dts/armada-3720-uDPU.dts
+++ b/arch/arm/dts/armada-3720-uDPU.dts
@@ -125,14 +125,14 @@
 &eth0 {
 	pinctrl-0 = <&pcie_pins>;
 	status = "okay";
-	phy-mode = "2500base-x";
+	phy-mode = "sgmii-2500";
 	managed = "in-band-status";
 	phy = <&ethphy0>;
 };
 
 &eth1 {
 	status = "okay";
-	phy-mode = "2500base-x";
+	phy-mode = "sgmii-2500";
 	managed = "in-band-status";
 	phy = <&ethphy1>;
 };
-- 
2.26.2

[PATCH] arch: arm: uDPU: fix PHY mode definition to sgmii-2500

[Jakov Petrina]

On 12/05/2020 12:02, Jakov Petrina wrote:
> Commit f49ac7e1c4 switched the default PHY speed to 3.125Gbit to resolve
> issues with SFP modules. However, U-Boot does not have a "2500base-x"
> phy-mode.
> 
> Resolve this by using "sgmii-2500" instead.
> 
> Signed-off-by: Jakov Petrina <jakov.petrina@sartura.hr>
> Signed-off-by: Vladimir Vid <vladimir.vid@sartura.hr>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> Cc: Stefan Roese <sr@denx.de>
> ---
>   arch/arm/dts/armada-3720-uDPU.dts | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

Hi Stefan,

I'm curious if there are any feedback or blockers on this patch?

Thanks,
Jakov

> diff --git a/arch/arm/dts/armada-3720-uDPU.dts b/arch/arm/dts/armada-3720-uDPU.dts
> index 07c7b91175..7f4b8222f4 100644
> --- a/arch/arm/dts/armada-3720-uDPU.dts
> +++ b/arch/arm/dts/armada-3720-uDPU.dts
> @@ -125,14 +125,14 @@
>   &eth0 {
>   	pinctrl-0 = <&pcie_pins>;
>   	status = "okay";
> -	phy-mode = "2500base-x";
> +	phy-mode = "sgmii-2500";
>   	managed = "in-band-status";
>   	phy = <&ethphy0>;
>   };
>   
>   &eth1 {
>   	status = "okay";
> -	phy-mode = "2500base-x";
> +	phy-mode = "sgmii-2500";
>   	managed = "in-band-status";
>   	phy = <&ethphy1>;
>   };
> 


-- 
Jakov Petrina

[PATCH] arch: arm: uDPU: fix PHY mode definition to sgmii-2500

[Stefan Roese]

Hi Jakov,

On 23.05.20 20:23, Jakov Petrina wrote:
> On 12/05/2020 12:02, Jakov Petrina wrote:
>> Commit f49ac7e1c4 switched the default PHY speed to 3.125Gbit to resolve
>> issues with SFP modules. However, U-Boot does not have a "2500base-x"
>> phy-mode.
>>
>> Resolve this by using "sgmii-2500" instead.
>>
>> Signed-off-by: Jakov Petrina <jakov.petrina@sartura.hr>
>> Signed-off-by: Vladimir Vid <vladimir.vid@sartura.hr>
>> Cc: Luka Perkov <luka.perkov@sartura.hr>
>> Cc: Stefan Roese <sr@denx.de>
>> ---
>> ? arch/arm/dts/armada-3720-uDPU.dts | 4 ++--
>> ? 1 file changed, 2 insertions(+), 2 deletions(-)
>>
> 
> Hi Stefan,
> 
> I'm curious if there are any feedback or blockers on this patch?

Sorry for the delay. I'll take care of it shortly.

Thanks,
Stefan

> 
> Thanks,
> Jakov
> 
>> diff --git a/arch/arm/dts/armada-3720-uDPU.dts 
>> b/arch/arm/dts/armada-3720-uDPU.dts
>> index 07c7b91175..7f4b8222f4 100644
>> --- a/arch/arm/dts/armada-3720-uDPU.dts
>> +++ b/arch/arm/dts/armada-3720-uDPU.dts
>> @@ -125,14 +125,14 @@
>> ? &eth0 {
>> ????? pinctrl-0 = <&pcie_pins>;
>> ????? status = "okay";
>> -??? phy-mode = "2500base-x";
>> +??? phy-mode = "sgmii-2500";
>> ????? managed = "in-band-status";
>> ????? phy = <&ethphy0>;
>> ? };
>> ? &eth1 {
>> ????? status = "okay";
>> -??? phy-mode = "2500base-x";
>> +??? phy-mode = "sgmii-2500";
>> ????? managed = "in-band-status";
>> ????? phy = <&ethphy1>;
>> ? };
>>
> 
> 


Viele Gr??e,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de

[PATCH] arch: arm: uDPU: fix PHY mode definition to sgmii-2500

[Stefan Roese]

On 12.05.20 12:02, Jakov Petrina wrote:
> Commit f49ac7e1c4 switched the default PHY speed to 3.125Gbit to resolve
> issues with SFP modules. However, U-Boot does not have a "2500base-x"
> phy-mode.
> 
> Resolve this by using "sgmii-2500" instead.
> 
> Signed-off-by: Jakov Petrina <jakov.petrina@sartura.hr>
> Signed-off-by: Vladimir Vid <vladimir.vid@sartura.hr>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> Cc: Stefan Roese <sr@denx.de>

Applied to u-boot-marvell/master

Thanks,
Stefan